|
From: <sv...@va...> - 2012-10-21 21:13:45
|
philippe 2012-10-21 22:13:39 +0100 (Sun, 21 Oct 2012)
New Revision: 13078
Log:
Follow-up to sys_ipc restructuration
Now that the PRE/POS(sys_ipc) code is not duplicated anymore,
fix two strange things in this code:
* PRE(sys_ipc) : add missing ; after the call PRE_REG_READ6
(strange that this was compiling without it ???)
* POST(sys_ipc) : it seems there was a copy/paste of
the PRE(sys_ipc) code for VKI_SEMCTL.
Cannot understand why we would need to call again
deref_Addr and ML_(generic_PRE_sys_semctl) in the POST(sys_ipc).
Modified files:
trunk/coregrind/m_syswrap/syswrap-linux.c
Modified: trunk/coregrind/m_syswrap/syswrap-linux.c (+1 -6)
===================================================================
--- trunk/coregrind/m_syswrap/syswrap-linux.c 2012-10-21 22:03:11 +01:00 (rev 13077)
+++ trunk/coregrind/m_syswrap/syswrap-linux.c 2012-10-21 22:13:39 +01:00 (rev 13078)
@@ -3307,7 +3307,7 @@
// XXX: this is simplistic -- some args are not used in all circumstances.
PRE_REG_READ6(int, "ipc",
vki_uint, call, int, first, int, second, int, third,
- void *, ptr, long, fifth)
+ void *, ptr, long, fifth);
switch (ARG1 /* call */) {
case VKI_SEMOP:
@@ -3387,13 +3387,8 @@
switch (ARG1 /* call */) {
case VKI_SEMOP:
case VKI_SEMGET:
- break;
case VKI_SEMCTL:
- {
- UWord arg = deref_Addr( tid, ARG5, "semctl(arg)" );
- ML_(generic_PRE_sys_semctl)( tid, ARG2, ARG3, ARG4, arg );
break;
- }
case VKI_SEMTIMEDOP:
case VKI_MSGSND:
break;
|