|
From: <sv...@va...> - 2012-03-20 19:04:52
|
philippe 2012-03-20 19:04:39 +0000 (Tue, 20 Mar 2012)
New Revision: 12453
Log:
fix 295799 Missing \n with get_vbits in gdbserver when line is % 80 and there are some unaddressable bytes
patch from Marc Bessi竪res
Thanks
Modified files:
trunk/NEWS
trunk/memcheck/mc_main.c
Modified: trunk/NEWS (+2 -1)
===================================================================
--- trunk/NEWS 2012-03-19 20:19:23 +00:00 (rev 12452)
+++ trunk/NEWS 2012-03-20 19:04:39 +00:00 (rev 12453)
@@ -56,7 +56,7 @@
where XXXXXX is the bug number as listed below.
247386 make perf does not run all performance tests
-270006 -Valgrind scheduler unfair
+270006 Valgrind scheduler unfair
270796 s390x: Removed broken support for the TS insn
271438 Fix configure for proper SSE4.2 detection
273114 s390x: Support TR, TRE, TROO, TROT, TRTO, and TRTT instructions
@@ -76,6 +76,7 @@
293088 Add some VEX sanity checks for ppc64 unhandled instructions
294055 regtest none/tests/shell fails when locale is not set to C
294190 --vgdb-error=xxx can be out of sync with errors shown to the user
+295799 Missing \n with get_vbits in gdbserver when line is % 80 and there are some unaddressable bytes
n-i-bz s390x: Shadow registers can now be examined using vgdb
Modified: trunk/memcheck/mc_main.c (+3 -2)
===================================================================
--- trunk/memcheck/mc_main.c 2012-03-19 20:19:23 +00:00 (rev 12452)
+++ trunk/memcheck/mc_main.c 2012-03-20 19:04:39 +00:00 (rev 12453)
@@ -5139,8 +5139,10 @@
(address+i, (Addr) &vbits, 1,
False, /* get them */
False /* is client request */ );
+ /* we are before the first character on next line, print a \n. */
if ((i % 32) == 0 && i != 0)
VG_(gdb_printf) ("\n");
+ /* we are before the next block of 4 starts, print a space. */
else if ((i % 4) == 0 && i != 0)
VG_(gdb_printf) (" ");
if (res == 1) {
@@ -5151,8 +5153,7 @@
VG_(gdb_printf) ("__");
}
}
- if ((i % 80) != 0)
- VG_(gdb_printf) ("\n");
+ VG_(gdb_printf) ("\n");
if (unaddressable) {
VG_(gdb_printf)
("Address %p len %ld has %d bytes unaddressable\n",
|