|
From: <sv...@va...> - 2011-05-11 22:55:06
|
Author: sewardj
Date: 2011-05-11 23:54:57 +0100 (Wed, 11 May 2011)
New Revision: 11748
Log:
* fixed two bugs reported by the IBM BEAM checker:
fd leak in vgdb.c
break missing in valgrind-low-s390x.c
* use option --vgdb=full for the tests mcsigpass.vgtest and mcsignopass.vgtest
This might improve these tests on ppc32/debian 6.0
* added a paragraph in gdbserver_tests/README_DEVELOPPERS to indicate
how to report problems about failing gdbserver tests.
(bug 214909 comment 71, Philippe Waroquiers, phi...@sk...)
Modified:
trunk/coregrind/m_gdbserver/valgrind-low-s390x.c
trunk/coregrind/vgdb.c
trunk/gdbserver_tests/README_DEVELOPPERS
trunk/gdbserver_tests/mcsignopass.vgtest
trunk/gdbserver_tests/mcsigpass.vgtest
Modified: trunk/coregrind/m_gdbserver/valgrind-low-s390x.c
===================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-s390x.c 2011-05-11 16:45:52 UTC (rev 11747)
+++ trunk/coregrind/m_gdbserver/valgrind-low-s390x.c 2011-05-11 22:54:57 UTC (rev 11748)
@@ -130,7 +130,7 @@
switch (regno) {
// numbers here have to match the order of regs above
// Attention: gdb order does not match valgrind order.
- case 0: *mod = False; //GDBTD??? { "pswm", 0, 64 },
+ case 0: *mod = False; break; //GDBTD??? { "pswm", 0, 64 },
case 1: VG_(transfer) (&s390x->guest_IA, buf, dir, size, mod); break;
case 2: VG_(transfer) (&s390x->guest_r0, buf, dir, size, mod); break;
case 3: VG_(transfer) (&s390x->guest_r1, buf, dir, size, mod); break;
Modified: trunk/coregrind/vgdb.c
===================================================================
--- trunk/coregrind/vgdb.c 2011-05-11 16:45:52 UTC (rev 11747)
+++ trunk/coregrind/vgdb.c 2011-05-11 22:54:57 UTC (rev 11748)
@@ -1822,6 +1822,7 @@
if (cmdline[i] == 0)
cmdline[i] = ' ';
cmdline[sz] = 0;
+ close (fd);
}
fprintf(stderr, "use --pid=%d for %s\n", pid, cmdline);
fflush(stderr);
Modified: trunk/gdbserver_tests/README_DEVELOPPERS
===================================================================
--- trunk/gdbserver_tests/README_DEVELOPPERS 2011-05-11 16:45:52 UTC (rev 11747)
+++ trunk/gdbserver_tests/README_DEVELOPPERS 2011-05-11 22:54:57 UTC (rev 11748)
@@ -34,7 +34,25 @@
The prerequisite are established during make regtest (using marker files).
Each test verifies the prerequisite using the prereq: line.
+In case of failing tests
+------------------------
+gdbserver tests are often failing due to (irrelevant) differences
+depending on the gdb version and/or the OS version.
+Such irrelevant differences have to be filtered by gdbserver_tests/filter_gdb.
+To report such problems, the best is to re-run the gdbserver tests
+the following way:
+ perl tests/vg_regtest --keep-unfiltered gdbserver_tests
+
+Then file a bug in bugzilla, giving the following information:
+ output of
+ gdbserver_tests/gdb --version
+ uname -a
+ cat /etc/issue
+ valgrind --version (and/or svn version)
+ and attach a tar file containing all the *.out files in gdbserver_tests
+ directory
+
Naming conventions:
-------------------
Modified: trunk/gdbserver_tests/mcsignopass.vgtest
===================================================================
--- trunk/gdbserver_tests/mcsignopass.vgtest 2011-05-11 16:45:52 UTC (rev 11747)
+++ trunk/gdbserver_tests/mcsignopass.vgtest 2011-05-11 22:54:57 UTC (rev 11748)
@@ -5,7 +5,7 @@
# (i.e. SIGBUG, Test 3). Other tests will be succesful, because signals
# are eventually passed.
prog: ../none/tests/faultstatus
-vgopts: --tool=memcheck --vgdb=yes --vgdb-error=0 --vgdb-prefix=./vgdb-prefix-mcsignopass
+vgopts: --tool=memcheck --vgdb=full --vgdb-error=0 --vgdb-prefix=./vgdb-prefix-mcsignopass
stderr_filter: filter_memcheck_monitor
progB: gdb
argsB: --quiet -l 60 --nx ../none/tests/faultstatus
Modified: trunk/gdbserver_tests/mcsigpass.vgtest
===================================================================
--- trunk/gdbserver_tests/mcsigpass.vgtest 2011-05-11 16:45:52 UTC (rev 11747)
+++ trunk/gdbserver_tests/mcsigpass.vgtest 2011-05-11 22:54:57 UTC (rev 11748)
@@ -1,6 +1,6 @@
# test the signal handling, when signals are passed to the Valgrind guest.
prog: ../none/tests/faultstatus
-vgopts: --tool=memcheck --vgdb=yes --vgdb-error=0 --vgdb-prefix=./vgdb-prefix-mcsigpass
+vgopts: --tool=memcheck --vgdb=full --vgdb-error=0 --vgdb-prefix=./vgdb-prefix-mcsigpass
stderr_filter: filter_memcheck_monitor
progB: gdb
argsB: --quiet -l 60 --nx ../none/tests/faultstatus
|