|
From: Дмитрий Д. <di...@gm...> - 2011-04-29 10:20:55
|
>From exp-ptrcheck/h_intercepts.c
/* The following intercepts are copied verbatim from
memcheck/mc_replace_strmem.c. If you copy more in, please keep
them in the same order as in mc_replace_strmem.c. */
Trivial change in Makefile.am allows to use all intercepts and not to
duplicate code.
So, why not use one file instead of two?
Dmitry
valgrind$ svn diff exp-ptrcheck/Makefile.am
Index: exp-ptrcheck/Makefile.am
===================================================================
--- exp-ptrcheck/Makefile.am (revision 11718)
+++ exp-ptrcheck/Makefile.am (working copy)
@@ -79,7 +79,7 @@
noinst_DSYMS = $(noinst_PROGRAMS)
endif
-VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON = h_intercepts.c
+VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON = ../memcheck/mc_replace_strmem.c
vgpreload_exp_ptrcheck_@VGCONF_ARCH_PRI@_@VGCONF_OS@_so_SOURCES = \
$(VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON)
|
|
From: Julian S. <js...@ac...> - 2011-05-04 07:55:38
|
For 3.7.0 I plan to remove the heap checking components of exp-ptrcheck since Memcheck does a better job 99% of the time, and is faster. That change would make the need for intercepts in exp-ptrcheck unnecessary afaiks. The overall would be a simpler tool that only does stack and global array checking. J On Friday, April 29, 2011, Дмитрий Дьяченко wrote: > >From exp-ptrcheck/h_intercepts.c > > /* The following intercepts are copied verbatim from > memcheck/mc_replace_strmem.c. If you copy more in, please keep > them in the same order as in mc_replace_strmem.c. */ > > Trivial change in Makefile.am allows to use all intercepts and not to > duplicate code. > > So, why not use one file instead of two? > > Dmitry > > > > valgrind$ svn diff exp-ptrcheck/Makefile.am > Index: exp-ptrcheck/Makefile.am > =================================================================== > --- exp-ptrcheck/Makefile.am (revision 11718) > +++ exp-ptrcheck/Makefile.am (working copy) > @@ -79,7 +79,7 @@ > noinst_DSYMS = $(noinst_PROGRAMS) > endif > > -VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON = h_intercepts.c > +VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON = ../memcheck/mc_replace_strmem.c > > vgpreload_exp_ptrcheck_@VGCONF_ARCH_PRI@_@VGCONF_OS@_so_SOURCES = \ > $(VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON) |
|
From: Дмитрий Д. <di...@gm...> - 2011-05-04 08:42:54
|
Thank You for explanation Dm. 2011/5/4 Julian Seward <js...@ac...> > > For 3.7.0 I plan to remove the heap checking components of exp-ptrcheck > since Memcheck does a better job 99% of the time, and is faster. That > change would make the need for intercepts in exp-ptrcheck unnecessary > afaiks. The overall would be a simpler tool that only does stack and > global array checking. > > J > > On Friday, April 29, 2011, Дмитрий Дьяченко wrote: > > >From exp-ptrcheck/h_intercepts.c > > > > /* The following intercepts are copied verbatim from > > memcheck/mc_replace_strmem.c. If you copy more in, please keep > > them in the same order as in mc_replace_strmem.c. */ > > > > Trivial change in Makefile.am allows to use all intercepts and not to > > duplicate code. > > > > So, why not use one file instead of two? > > > > Dmitry > > > > > > > > valgrind$ svn diff exp-ptrcheck/Makefile.am > > Index: exp-ptrcheck/Makefile.am > > =================================================================== > > --- exp-ptrcheck/Makefile.am (revision 11718) > > +++ exp-ptrcheck/Makefile.am (working copy) > > @@ -79,7 +79,7 @@ > > noinst_DSYMS = $(noinst_PROGRAMS) > > endif > > > > -VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON = h_intercepts.c > > +VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON = ../memcheck/mc_replace_strmem.c > > > > vgpreload_exp_ptrcheck_@VGCONF_ARCH_PRI@_@VGCONF_OS@_so_SOURCES = > \ > > $(VGPRELOAD_EXP_PTRCHECK_SOURCES_COMMON) > > |