|
From: Brad H. <br...@fr...> - 2011-04-10 08:07:43
|
This is a pretty simple ioctl, which shows up running qemu
under valgrind with host USB device pass-through.
Please review and apply.
Brad
Index: include/vki/vki-linux.h
===================================================================
--- include/vki/vki-linux.h (revision 11686)
+++ include/vki/vki-linux.h (working copy)
@@ -2394,6 +2394,7 @@
#define VKI_USBDEVFS_REAPURBNDELAY _VKI_IOW('U', 13, void *)
#define VKI_USBDEVFS_CONNECTINFO _VKI_IOW('U', 17, struct vki_usbdevfs_connectinfo)
#define VKI_USBDEVFS_IOCTL _VKI_IOWR('U', 18, struct vki_usbdevfs_ioctl)
+#define VKI_USBDEVFS_RESET _VKI_IO('U', 20)
#define VKI_USBDEVFS_URB_TYPE_ISO 0
#define VKI_USBDEVFS_URB_TYPE_INTERRUPT 1
Index: coregrind/m_syswrap/syswrap-linux.c
===================================================================
--- coregrind/m_syswrap/syswrap-linux.c (revision 11686)
+++ coregrind/m_syswrap/syswrap-linux.c (working copy)
@@ -4777,6 +4777,8 @@
}
}
break;
+ case VKI_USBDEVFS_RESET:
+ break;
/* I2C (/dev/i2c-*) ioctls */
case VKI_I2C_SLAVE:
|
|
From: Brad H. <br...@fr...> - 2011-04-18 09:53:41
|
On Sun, 10 Apr 2011 06:07:32 pm Brad Hards wrote:
> Index: include/vki/vki-linux.h
> ===================================================================
> --- include/vki/vki-linux.h (revision 11686)
> +++ include/vki/vki-linux.h (working copy)
> @@ -2394,6 +2394,7 @@
> #define VKI_USBDEVFS_REAPURBNDELAY _VKI_IOW('U', 13, void *)
> #define VKI_USBDEVFS_CONNECTINFO _VKI_IOW('U', 17, struct
> vki_usbdevfs_connectinfo) #define VKI_USBDEVFS_IOCTL
> _VKI_IOWR('U', 18, struct vki_usbdevfs_ioctl) +#define VKI_USBDEVFS_RESET
> _VKI_IO('U', 20)
>
> #define VKI_USBDEVFS_URB_TYPE_ISO 0
> #define VKI_USBDEVFS_URB_TYPE_INTERRUPT 1
> Index: coregrind/m_syswrap/syswrap-linux.c
> ===================================================================
> --- coregrind/m_syswrap/syswrap-linux.c (revision 11686)
> +++ coregrind/m_syswrap/syswrap-linux.c (working copy)
> @@ -4777,6 +4777,8 @@
> }
> }
> break;
> + case VKI_USBDEVFS_RESET:
> + break;
>
> /* I2C (/dev/i2c-*) ioctls */
> case VKI_I2C_SLAVE:
Hi. I wondered if there was anything required on this patch? Any questions or
concerns?
Brad
|
|
From: Bart V. A. <bva...@ac...> - 2011-04-18 10:40:35
|
On Sun, Apr 10, 2011 at 10:07 AM, Brad Hards <br...@fr...> wrote:
>
> This is a pretty simple ioctl, which shows up running qemu
> under valgrind with host USB device pass-through.
>
> Please review and apply.
>
> Brad
>
> Index: include/vki/vki-linux.h
> ===================================================================
> --- include/vki/vki-linux.h (revision 11686)
> +++ include/vki/vki-linux.h (working copy)
> @@ -2394,6 +2394,7 @@
> #define VKI_USBDEVFS_REAPURBNDELAY _VKI_IOW('U', 13, void *)
> #define VKI_USBDEVFS_CONNECTINFO _VKI_IOW('U', 17, struct vki_usbdevfs_connectinfo)
> #define VKI_USBDEVFS_IOCTL _VKI_IOWR('U', 18, struct vki_usbdevfs_ioctl)
> +#define VKI_USBDEVFS_RESET _VKI_IO('U', 20)
>
> #define VKI_USBDEVFS_URB_TYPE_ISO 0
> #define VKI_USBDEVFS_URB_TYPE_INTERRUPT 1
> Index: coregrind/m_syswrap/syswrap-linux.c
> ===================================================================
> --- coregrind/m_syswrap/syswrap-linux.c (revision 11686)
> +++ coregrind/m_syswrap/syswrap-linux.c (working copy)
> @@ -4777,6 +4777,8 @@
> }
> }
> break;
> + case VKI_USBDEVFS_RESET:
> + break;
>
> /* I2C (/dev/i2c-*) ioctls */
> case VKI_I2C_SLAVE:
Applied as r11702 on the trunk - please retest.
Note: the preferred way for contributing patches to the Valgrind
project is by creating a bugzilla entry and to attach the patch to it.
Bart.
|