|
From: <sv...@va...> - 2010-07-21 16:00:16
|
Author: sewardj
Date: 2010-07-21 17:00:08 +0100 (Wed, 21 Jul 2010)
New Revision: 11219
Log:
Put quotes around the argument to /usr/bin/dsymutil, so it doesn't
screw up on filenames with spaces. Fixes (part of) #205093.
Modified:
trunk/coregrind/m_debuginfo/readmacho.c
Modified: trunk/coregrind/m_debuginfo/readmacho.c
===================================================================
--- trunk/coregrind/m_debuginfo/readmacho.c 2010-07-21 15:28:34 UTC (rev 11218)
+++ trunk/coregrind/m_debuginfo/readmacho.c 2010-07-21 16:00:08 UTC (rev 11219)
@@ -948,10 +948,12 @@
HChar* cmd = ML_(dinfo_zalloc)( "di.readmacho.tmp1",
VG_(strlen)(dsymutil)
+ VG_(strlen)(di->filename)
- + 30 /* misc */ );
+ + 32 /* misc */ );
VG_(strcpy)(cmd, dsymutil);
if (0) VG_(strcat)(cmd, "--verbose ");
+ VG_(strcat)(cmd, "\"");
VG_(strcat)(cmd, di->filename);
+ VG_(strcat)(cmd, "\"");
VG_(message)(Vg_DebugMsg, "run: %s\n", cmd);
r = VG_(system)( cmd );
if (r)
|