|
From: <sv...@va...> - 2010-02-10 13:55:42
|
Author: sewardj
Date: 2010-02-10 13:37:37 +0000 (Wed, 10 Feb 2010)
New Revision: 11038
Log:
Fix bogus comparisons of PDB vs PE timestamps, so as to avoid
signed vs unsigned confusion.
Modified:
trunk/coregrind/m_debuginfo/debuginfo.c
Modified: trunk/coregrind/m_debuginfo/debuginfo.c
===================================================================
--- trunk/coregrind/m_debuginfo/debuginfo.c 2010-02-04 12:04:14 UTC (rev 11037)
+++ trunk/coregrind/m_debuginfo/debuginfo.c 2010-02-10 13:37:37 UTC (rev 11038)
@@ -972,7 +972,7 @@
}
pdb_mtime = stat_buf.mtime;
- if (obj_mtime - pdb_mtime > 60ULL) {
+ if (obj_mtime > pdb_mtime + 60ULL) {
/* PDB file is older than PE file. Really, the PDB should be
newer than the PE, but that doesn't always seem to be the
case. Allow the PDB to be up to one minute older.
@@ -981,9 +981,9 @@
(b) crash.
*/
VG_(message)(Vg_UserMsg,
- "Warning: Ignoring %s since it is older than %s\n",
- pdbname, exename);
- goto out;
+ "Warning: %s (mtime = %llu)\n"
+ " is older than %s (mtime = %llu)\n",
+ pdbname, pdb_mtime, exename, obj_mtime);
}
sres = VG_(open)(pdbname, VKI_O_RDONLY, 0);
|