|
From: <sv...@va...> - 2010-01-04 12:10:32
|
Author: sewardj
Date: 2010-01-04 12:10:24 +0000 (Mon, 04 Jan 2010)
New Revision: 11014
Log:
Analysis/make-it-work for arm-linux.
Modified:
trunk/memcheck/tests/partiallydefinedeq.c
trunk/memcheck/tests/partiallydefinedeq.stderr.exp2
Modified: trunk/memcheck/tests/partiallydefinedeq.c
===================================================================
--- trunk/memcheck/tests/partiallydefinedeq.c 2010-01-04 12:04:38 UTC (rev 11013)
+++ trunk/memcheck/tests/partiallydefinedeq.c 2010-01-04 12:10:24 UTC (rev 11014)
@@ -57,9 +57,16 @@
// Note: on ppc32/64 the second call to foo() does give an error,
// since the expensive EQ/NE scheme does not apply to the CmpORD
// primops used by ppc.
-static void bar ( void )
+//
+// On arm, the "normal" (x86-like) comparison primops are used, so
+// the expensive EQ/NE scheme could apply. However, it doesn't,
+// because the constant 0x80808080 is placed in a constant pool
+// and so never appears as a literal, and so the instrumenter
+// never spots it and so doesn't use the expensive scheme (for foo).
+// Hence also on ARM we get 3 errors, not 2.
+static __attribute__((noinline)) void bar ( void )
{
-#if defined(__powerpc__) || defined(__powerpc64__)
- fprintf(stderr, "Currently running on ppc32/64: this test should give 3 errors, not 2.\n");
+#if defined(__powerpc__) || defined(__powerpc64__) || defined(__arm__)
+ fprintf(stderr, "Currently running on ppc32/64/arm: this test should give 3 errors, not 2.\n");
#endif
}
Modified: trunk/memcheck/tests/partiallydefinedeq.stderr.exp2
===================================================================
--- trunk/memcheck/tests/partiallydefinedeq.stderr.exp2 2010-01-04 12:04:38 UTC (rev 11013)
+++ trunk/memcheck/tests/partiallydefinedeq.stderr.exp2 2010-01-04 12:10:24 UTC (rev 11014)
@@ -1,5 +1,5 @@
-Currently running on ppc32/64: this test should give 3 errors, not 2.
+Currently running on ppc32/64/arm: this test should give 3 errors, not 2.
Conditional jump or move depends on uninitialised value(s)
at 0x........: foo (partiallydefinedeq.c:15)
by 0x........: main (partiallydefinedeq.c:37)
@@ -22,4 +22,3 @@
For counts of detected and suppressed errors, rerun with: -v
Use --track-origins=yes to see where uninitialised values come from
ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0)
-
|