|
From: Bart V. A. <bar...@gm...> - 2009-05-19 18:21:57
|
Hello, Regarding the issue I reported earlier today with "make dist": by this time I found out that in the file auxprogs/Makefile.am refers to the symbol @VGCONF_ARCH_SEC@, a symbol that is never expanded by configure. Running make dist generates a.o. the following files: auxprogs/libmpiwrap-@VGCONF_ARCH_SEC@-linux.c auxprogs/libmpiwrap-amd64-linux.c This doesn't look right to me. Bart. |
|
From: Julian S. <js...@ac...> - 2009-05-19 18:59:31
|
On Tuesday 19 May 2009, Bart Van Assche wrote: > Hello, > > Regarding the issue I reported earlier today with "make dist": by this > time I found out that in the file auxprogs/Makefile.am refers to the > symbol @VGCONF_ARCH_SEC@, a symbol that is never expanded by > configure. Running make dist generates a.o. the following files: > > auxprogs/libmpiwrap-@VGCONF_ARCH_SEC@-linux.c > auxprogs/libmpiwrap-amd64-linux.c > > This doesn't look right to me. I agree. My mistake; this was caused by r9899. We should back it out. J |
|
From: Nicholas N. <n.n...@gm...> - 2009-05-20 02:36:28
|
On Wed, May 20, 2009 at 5:02 AM, Julian Seward <js...@ac...> wrote: >> >> Regarding the issue I reported earlier today with "make dist": by this >> time I found out that in the file auxprogs/Makefile.am refers to the >> symbol @VGCONF_ARCH_SEC@, a symbol that is never expanded by >> configure. Running make dist generates a.o. the following files: >> >> auxprogs/libmpiwrap-@VGCONF_ARCH_SEC@-linux.c >> auxprogs/libmpiwrap-amd64-linux.c >> >> This doesn't look right to me. > > I agree. My mistake; this was caused by r9899. We should back it > out. But that's only on the MESSAGING_TIDYUP branch, right? r9899 hasn't been merged with the trunk AFAICT. Nick |
|
From: Bart V. A. <bar...@gm...> - 2009-05-20 06:51:48
|
On Tue, May 19, 2009 at 8:21 PM, Bart Van Assche
<bar...@gm...> wrote:
> Regarding the issue I reported earlier today with "make dist": by this
> time I found out that in the file auxprogs/Makefile.am refers to the
> symbol @VGCONF_ARCH_SEC@, a symbol that is never expanded by
> configure. Running make dist generates a.o. the following files:
>
> auxprogs/libmpiwrap-@VGCONF_ARCH_SEC@-linux.c
> auxprogs/libmpiwrap-amd64-linux.c
>
> This doesn't look right to me.
Some more information: the above comments apply to the trunk.
According to the information in Subversion a.o. the following changes
were introduced via r9121:
$ svn diff -r9114:9121 auxprogs/Makefile.am
[ ... ]
## cleanery
clean-local:
rm -f libmpiwrap-.c \
- libmpiwrap-@VGCONF_PLATFORM_PRI_CAPS@.c \
- libmpiwrap-@VGCONF_PLATFORM_SEC_CAPS@.c
+ libmpiwrap-@VGCONF_ARCH_PRI@-@VGCONF_OS@.c \
+ libmpiwrap-@VGCONF_ARCH_SEC@-@VGCONF_OS@.c
#
#----------------------------------------------------------
Bart.
|
|
From: Nicholas N. <n.n...@gm...> - 2009-05-20 07:31:36
|
On Wed, May 20, 2009 at 4:51 PM, Bart Van Assche <bar...@gm...> wrote: > Some more information: the above comments apply to the trunk. > According to the information in Subversion a.o. the following changes > were introduced via r9121: > > $ svn diff -r9114:9121 auxprogs/Makefile.am > [ ... ] > ## cleanery > clean-local: > rm -f libmpiwrap-.c \ > - libmpiwrap-@VGCONF_PLATFORM_PRI_CAPS@.c \ > - libmpiwrap-@VGCONF_PLATFORM_SEC_CAPS@.c > + libmpiwrap-@VGCONF_ARCH_PRI@-@VGCONF_OS@.c \ > + libmpiwrap-@VGCONF_ARCH_SEC@-@VGCONF_OS@.c So to summarise in a comprehensible fashion: on the trunk, auxprogs/Makefile.am refers to VGCONF_ARCH_SEC, a configure variable that doesn't exist. It seems that Julian tried to fix this on the MESSAGING_TIDYUP branch, but his fix was bogus. That bogus fix needs to be undone on the branch, and a correct fix is required for the trunk (that correct fix could optionally be merged onto the branch if desired). N |
|
From: Julian S. <js...@ac...> - 2009-05-20 08:15:12
|
> > $ svn diff -r9114:9121 auxprogs/Makefile.am > > [ ... ] > > ## cleanery > > clean-local: > > rm -f libmpiwrap-.c \ > > - libmpiwrap-@VGCONF_PLATFORM_PRI_CAPS@.c \ > > - libmpiwrap-@VGCONF_PLATFORM_SEC_CAPS@.c > > + libmpiwrap-@VGCONF_ARCH_PRI@-@VGCONF_OS@.c \ > > + libmpiwrap-@VGCONF_ARCH_SEC@-@VGCONF_OS@.c > > So to summarise in a comprehensible fashion: on the trunk, > auxprogs/Makefile.am refers to VGCONF_ARCH_SEC, a configure variable > that doesn't exist. It seems that Julian tried to fix this on the > MESSAGING_TIDYUP branch, but his fix was bogus. That bogus fix needs > to be undone on the branch, and a correct fix is required for the > trunk (that correct fix could optionally be merged onto the branch if > desired). Yes. That syncs with my understanding. J |
|
From: Nicholas N. <n.n...@gm...> - 2009-06-02 00:55:52
|
On Wed, May 20, 2009 at 6:02 PM, Julian Seward <js...@ac...> wrote: > >> So to summarise in a comprehensible fashion: on the trunk, >> auxprogs/Makefile.am refers to VGCONF_ARCH_SEC, a configure variable >> that doesn't exist. It seems that Julian tried to fix this on the >> MESSAGING_TIDYUP branch, but his fix was bogus. That bogus fix needs >> to be undone on the branch, and a correct fix is required for the >> trunk (that correct fix could optionally be merged onto the branch if >> desired). > > Yes. That syncs with my understanding. I just added VGCONF_ARCH_SEC in r10195, so this should work now; it seems to get it right on my Mac when doing a dual-build. N |