|
From: <sv...@va...> - 2008-10-30 13:26:41
|
Author: sewardj
Date: 2008-10-30 13:26:29 +0000 (Thu, 30 Oct 2008)
New Revision: 8722
Log:
Get rid of longstanding and now pointless restriction that disallowed
using --db-attach=yes and --trace-children=yes together.
Modified:
trunk/coregrind/m_main.c
trunk/docs/xml/manual-core.xml
Modified: trunk/coregrind/m_main.c
===================================================================
--- trunk/coregrind/m_main.c 2008-10-30 13:17:35 UTC (rev 8721)
+++ trunk/coregrind/m_main.c 2008-10-30 13:26:29 UTC (rev 8722)
@@ -563,15 +563,6 @@
if (VG_(clo_verbosity) < 0)
VG_(clo_verbosity) = 0;
- if (VG_(clo_db_attach) && VG_(clo_trace_children)) {
- VG_(message)(Vg_UserMsg, "");
- VG_(message)(Vg_UserMsg,
- "--db-attach=yes conflicts with --trace-children=yes");
- VG_(message)(Vg_UserMsg,
- "Please choose one or the other, but not both.");
- VG_(err_bad_option)("--db-attach=yes and --trace-children=yes");
- }
-
if (VG_(clo_gen_suppressions) > 0 &&
!VG_(needs).core_errors && !VG_(needs).tool_errors) {
VG_(message)(Vg_UserMsg,
Modified: trunk/docs/xml/manual-core.xml
===================================================================
--- trunk/docs/xml/manual-core.xml 2008-10-30 13:17:35 UTC (rev 8721)
+++ trunk/docs/xml/manual-core.xml 2008-10-30 13:26:29 UTC (rev 8722)
@@ -950,18 +950,6 @@
<para><varname>C Ret</varname> or <varname>c Ret</varname> causes
Valgrind not to start a debugger, and not to ask again.</para>
-
- <para><command>Note:</command> <option>--db-attach=yes</option>
- conflicts with <option>--trace-children=yes</option>. You can't
- use them together. Valgrind refuses to start up in this
- situation.</para>
-
- <para>May 2002: this is a historical relic which could be easily
- fixed if it gets in your way. Mail us and complain if this is a
- problem for you.</para>
- <para>Nov 2002: if you're sending output to a logfile or to a
- network socket, I guess this option doesn't make any sense.
- Caveat emptor.</para>
</listitem>
</varlistentry>
|
|
From: Nicholas N. <nj...@cs...> - 2008-10-30 19:34:57
|
On Thu, 30 Oct 2008 sv...@va... wrote:
> Author: sewardj
> Date: 2008-10-30 13:26:29 +0000 (Thu, 30 Oct 2008)
> New Revision: 8722
>
> Log:
> Get rid of longstanding and now pointless restriction that disallowed
> using --db-attach=yes and --trace-children=yes together.
>
> Modified:
> trunk/coregrind/m_main.c
> trunk/docs/xml/manual-core.xml
>
>
> Modified: trunk/coregrind/m_main.c
> ===================================================================
> --- trunk/coregrind/m_main.c 2008-10-30 13:17:35 UTC (rev 8721)
> +++ trunk/coregrind/m_main.c 2008-10-30 13:26:29 UTC (rev 8722)
> @@ -563,15 +563,6 @@
> if (VG_(clo_verbosity) < 0)
> VG_(clo_verbosity) = 0;
>
> - if (VG_(clo_db_attach) && VG_(clo_trace_children)) {
> - VG_(message)(Vg_UserMsg, "");
> - VG_(message)(Vg_UserMsg,
> - "--db-attach=yes conflicts with --trace-children=yes");
> - VG_(message)(Vg_UserMsg,
> - "Please choose one or the other, but not both.");
> - VG_(err_bad_option)("--db-attach=yes and --trace-children=yes");
> - }
> -
> if (VG_(clo_gen_suppressions) > 0 &&
> !VG_(needs).core_errors && !VG_(needs).tool_errors) {
> VG_(message)(Vg_UserMsg,
You mean, all those years, that change was all that was required? ;)
N
|