|
From: <sv...@va...> - 2007-11-26 21:34:27
|
Author: sewardj
Date: 2007-11-26 21:34:30 +0000 (Mon, 26 Nov 2007)
New Revision: 7228
Log:
drd: make the build silent regardless of platform, and abort at
startup with a message if a not supported platform, like
Omega.
omega: make the platform-not-supported-message a bit nicer.
Modified:
trunk/exp-drd/drd_main.c
trunk/exp-drd/pthread_object_size.h
trunk/exp-omega/o_main.c
Modified: trunk/exp-drd/drd_main.c
===================================================================
--- trunk/exp-drd/drd_main.c 2007-11-26 15:15:40 UTC (rev 7227)
+++ trunk/exp-drd/drd_main.c 2007-11-26 21:34:30 UTC (rev 7228)
@@ -553,7 +553,16 @@
static
void drd_post_clo_init(void)
-{ }
+{
+# if defined(VGP_x86_linux) || defined(VGP_amd64_linux)
+ /* fine */
+# else
+ VG_(printf)("\nDRD currently only works on x86-linux and amd64-linux.\n");
+ VG_(printf)("At the very least you need to set PTHREAD_{MUTEX,COND}_SIZE\n");
+ VG_(printf)("in pthread_object_size.h to correct values. Sorry.\n\n");
+ VG_(exit)(0);
+# endif
+}
static
IRSB* drd_instrument(VgCallbackClosure* const closure,
Modified: trunk/exp-drd/pthread_object_size.h
===================================================================
--- trunk/exp-drd/pthread_object_size.h 2007-11-26 15:15:40 UTC (rev 7227)
+++ trunk/exp-drd/pthread_object_size.h 2007-11-26 21:34:30 UTC (rev 7228)
@@ -8,7 +8,7 @@
# define PTHREAD_MUTEX_SIZE 40
# define PTHREAD_COND_SIZE 48
#else
-# warning "Unknown platform for PTHREAD_{MUTEX,COND}_SIZE"
+ /* FIXME: fill these fields in correctly. 32 is arbitrary. */
# define PTHREAD_MUTEX_SIZE 32
# define PTHREAD_COND_SIZE 32
#endif
Modified: trunk/exp-omega/o_main.c
===================================================================
--- trunk/exp-omega/o_main.c 2007-11-26 15:15:40 UTC (rev 7227)
+++ trunk/exp-omega/o_main.c 2007-11-26 21:34:30 UTC (rev 7228)
@@ -196,7 +196,7 @@
return 0;
}
#elif defined(VGA_ppc32) || defined(VGA_ppc64)
- VG_(printf)("\n\nOmega does not currently work on ppc platforms."
+ VG_(printf)("\nOmega does not currently work on PowerPC/POWER platforms."
" Sorry.\n\n");
VG_(exit)(0);
#else
@@ -2820,7 +2820,7 @@
#elif defined(VGA_ppc32) || defined(VGA_ppc64)
default:
- VG_(printf)("\n\nOmega does not currently work on ppc platforms."
+ VG_(printf)("\nOmega does not currently work on PowerPC/POWER platforms."
" Sorry.\n\n");
VG_(exit)(0);
#else
|
|
From: Oswald B. <os...@kd...> - 2007-11-26 22:45:36
|
On Mon, Nov 26, 2007 at 09:34:32PM +0000, sv...@va... wrote: > Author: sewardj > Date: 2007-11-26 21:34:30 +0000 (Mon, 26 Nov 2007) > New Revision: 7228 > > Log: > drd: make the build silent regardless of platform, and abort at > startup with a message if a not supported platform, like > Omega. > that's sort of unclean. the build should be disabled in configure and makefile.am via an automake conditional. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. |