|
From: Julian S. <js...@ac...> - 2006-03-19 00:50:37
|
syswrap-generic.c, function PRE(sys_setrlimit), has these:
((struct vki_rlimit *)ARG2)->rlim_max > ((struct vki_rlimit
*)ARG2)->rlim_max)
((struct vki_rlimit *)ARG2)->rlim_max > ((struct vki_rlimit
*)ARG2)->rlim_max)
(lines 5074/5084 respectively). x > x is always False.
Anybody have any idea why there are here / what they should be?
'svn ann' says I was the last person to edit them, but I have
no memory of messing with this code :-)
It looks like it might be some kind of typo, but I'm not
sure what.
J
|
|
From: Tom H. <to...@co...> - 2006-03-19 08:37:15
|
In message <200...@ac...>
Julian Seward <js...@ac...> wrote:
> syswrap-generic.c, function PRE(sys_setrlimit), has these:
>
> ((struct vki_rlimit *)ARG2)->rlim_max > ((struct vki_rlimit *)ARG2)->rlim_max)
>
> ((struct vki_rlimit *)ARG2)->rlim_max > ((struct vki_rlimit *)ARG2)->rlim_max)
>
> (lines 5074/5084 respectively). x > x is always False.
>
> Anybody have any idea why there are here / what they should be?
> 'svn ann' says I was the last person to edit them, but I have
> no memory of messing with this code :-)
It was actually me that put that in (revision 345677 in the old
repository) and it does look wrong.
> It looks like it might be some kind of typo, but I'm not
> sure what.
I think it should be comparing against VG_(client_rlimit_data).rlim_max
to make sure you aren't trying to raise either limit above the current
hard limit.
The stack limit code below it has the same problem.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|
|
From: Julian S. <js...@ac...> - 2006-03-19 11:14:39
|
> I think it should be comparing against VG_(client_rlimit_data).rlim_max > to make sure you aren't trying to raise either limit above the current > hard limit. I'm not quite clear what should be compared against what. Perhaps better if you fix it. J |