|
From: <sv...@va...> - 2005-11-07 04:52:45
|
Author: njn
Date: 2005-11-07 04:52:41 +0000 (Mon, 07 Nov 2005)
New Revision: 5025
Log:
Improve factoring in m_coredump a little.
Modified:
trunk/coregrind/m_coredump/coredump-amd64-linux.c
trunk/coregrind/m_coredump/coredump-elf.c
trunk/coregrind/m_coredump/coredump-ppc32-linux.c
trunk/coregrind/m_coredump/coredump-x86-linux.c
trunk/coregrind/m_coredump/priv_elf.h
Modified: trunk/coregrind/m_coredump/coredump-amd64-linux.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_coredump/coredump-amd64-linux.c 2005-11-06 12:29:50=
UTC (rev 5024)
+++ trunk/coregrind/m_coredump/coredump-amd64-linux.c 2005-11-07 04:52:41=
UTC (rev 5025)
@@ -84,7 +84,6 @@
VG_(memset)(fpu->padding, 0, sizeof(fpu->padding));
}
=20
-void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt max_=
size)
-{
- ML_(make_elf_coredump)(tid, si, max_size);
-}
+/*--------------------------------------------------------------------*/
+/*--- end ---*/
+/*--------------------------------------------------------------------*/
Modified: trunk/coregrind/m_coredump/coredump-elf.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_coredump/coredump-elf.c 2005-11-06 12:29:50 UTC (re=
v 5024)
+++ trunk/coregrind/m_coredump/coredump-elf.c 2005-11-07 04:52:41 UTC (re=
v 5025)
@@ -281,7 +281,8 @@
}
#endif
=20
-void ML_(make_elf_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt =
max_size)
+static
+void make_elf_coredump(ThreadId tid, const vki_siginfo_t *si, UInt max_s=
ize)
{
Char buf[1000];
Char *basename =3D "vgcore";
@@ -434,6 +435,11 @@
VG_(close)(core_fd);
}
=20
+void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt max_=
size)
+{
+ make_elf_coredump(tid, si, max_size);
+}
+
/*--------------------------------------------------------------------*/
/*--- end ---*/
/*--------------------------------------------------------------------*/
Modified: trunk/coregrind/m_coredump/coredump-ppc32-linux.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_coredump/coredump-ppc32-linux.c 2005-11-06 12:29:50=
UTC (rev 5024)
+++ trunk/coregrind/m_coredump/coredump-ppc32-linux.c 2005-11-07 04:52:41=
UTC (rev 5025)
@@ -71,7 +71,6 @@
# undef DO
}
=20
-void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt max_=
size)
-{
- ML_(make_elf_coredump)(tid, si, max_size);
-}
+/*--------------------------------------------------------------------*/
+/*--- end ---*/
+/*--------------------------------------------------------------------*/
Modified: trunk/coregrind/m_coredump/coredump-x86-linux.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_coredump/coredump-x86-linux.c 2005-11-06 12:29:50 U=
TC (rev 5024)
+++ trunk/coregrind/m_coredump/coredump-x86-linux.c 2005-11-07 04:52:41 U=
TC (rev 5025)
@@ -104,7 +104,6 @@
VG_(memset)(xfpu->padding, 0, sizeof(xfpu->padding));
}
=20
-void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt max_=
size)
-{
- ML_(make_elf_coredump)(tid, si, max_size);
-}
+/*--------------------------------------------------------------------*/
+/*--- end ---*/
+/*--------------------------------------------------------------------*/
Modified: trunk/coregrind/m_coredump/priv_elf.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/m_coredump/priv_elf.h 2005-11-06 12:29:50 UTC (rev 50=
24)
+++ trunk/coregrind/m_coredump/priv_elf.h 2005-11-07 04:52:41 UTC (rev 50=
25)
@@ -31,8 +31,6 @@
#ifndef __PRIV_SYMTAB_H
#define __PRIV_SYMTAB_H
=20
-void ML_(make_elf_coredump)(ThreadId tid, const vki_siginfo_t *si, UInt =
max_size);
-
void ML_(fill_elfregs_from_tst)(struct vki_user_regs_struct* regs,=20
const ThreadArchState* arch);
=20
|
|
From: Tom H. <to...@co...> - 2005-11-07 07:12:32
|
In message <200...@ja...>
sv...@va... wrote:
> Author: njn
> Date: 2005-11-07 04:52:41 +0000 (Mon, 07 Nov 2005)
> New Revision: 5025
>
> Log:
> Improve factoring in m_coredump a little.
It was entirely deliberate that I did it the way I did - my original
code did have it the way you now have it and I changed it before it
was committed.
The theory is that if we get a non-ELF platform then we won't want
the generic make_coredump call going into the ELF code - if each
platform has to provide that and send it to the right place then
things will work.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|
|
From: Nicholas N. <nj...@cs...> - 2005-11-07 14:47:24
|
On Mon, 7 Nov 2005, Tom Hughes wrote: >> Log: >> Improve factoring in m_coredump a little. > > It was entirely deliberate that I did it the way I did - my original > code did have it the way you now have it and I changed it before it > was committed. > > The theory is that if we get a non-ELF platform then we won't want > the generic make_coredump call going into the ELF code - if each > platform has to provide that and send it to the right place then > things will work. I see. Change it back if you want... or we can wait until it's needed. Doesn't worry me. Nick |
|
From: Tom H. <to...@co...> - 2005-11-07 14:51:29
|
In message <Pin...@ch...>
Nicholas Nethercote <nj...@cs...> wrote:
> On Mon, 7 Nov 2005, Tom Hughes wrote:
>
>> The theory is that if we get a non-ELF platform then we won't want
>> the generic make_coredump call going into the ELF code - if each
>> platform has to provide that and send it to the right place then
>> things will work.
>
> I see. Change it back if you want... or we can wait until it's
> needed. Doesn't worry me.
Leave it for now I think - aside from anything else with the biarch
patch we could actually leave it as it is now and just not compile
in coredump-elf.c on non-ELF platforms.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|