|
From: Tom H. <to...@co...> - 2005-11-02 09:31:27
|
Does anybody know what memcheck/tests/weirdioctl is trying to accomplish? It looks like whatever it was trying to test is now defunct anyway and the test itself is nonsense. It fetches the terminal attributes for standard input, modifies them and does some stuff and then restores them. The problem is that standard input is not a terminal as the vgtest file provides a file as standard input, so none of the terminal ioctls actually does anything (they all fail) and you just get warnings from memcheck about passing uninitialised data to TCSETA. For some reason the results only have one warning but all my machines seem to print two as expected (there are two calls to TCSETA and both have undefined arguments because the TCGETA failed). Tom -- Tom Hughes (to...@co...) http://www.compton.nu/ |
|
From: Julian S. <js...@ac...> - 2005-11-02 13:20:55
|
I think it harks back to the 1.0.X days where some kind of strange hang happened due to the poor threading support back then. I agree (1) it's nonsensical and (2) it fails on N different machines here too. I think we should remove it. J On Wednesday 02 November 2005 09:31, Tom Hughes wrote: > Does anybody know what memcheck/tests/weirdioctl is trying to > accomplish? It looks like whatever it was trying to test is now > defunct anyway and the test itself is nonsense. > > It fetches the terminal attributes for standard input, modifies > them and does some stuff and then restores them. > > The problem is that standard input is not a terminal as the vgtest > file provides a file as standard input, so none of the terminal ioctls > actually does anything (they all fail) and you just get warnings from > memcheck about passing uninitialised data to TCSETA. > > For some reason the results only have one warning but all my machines > seem to print two as expected (there are two calls to TCSETA and both > have undefined arguments because the TCGETA failed). > > Tom |