|
From: <sv...@va...> - 2005-08-30 12:54:40
|
Author: sewardj
Date: 2005-08-30 13:54:36 +0100 (Tue, 30 Aug 2005)
New Revision: 4587
Log:
Fix suspicious code in the memcheck instrumenter which probably
rendered many of the assertions in this file ineffective. Spotted by
Tom Truscott.
Modified:
trunk/memcheck/mc_translate.c
Modified: trunk/memcheck/mc_translate.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/memcheck/mc_translate.c 2005-08-30 12:35:36 UTC (rev 4586)
+++ trunk/memcheck/mc_translate.c 2005-08-30 12:54:36 UTC (rev 4587)
@@ -174,9 +174,9 @@
are identically-kinded. */
static Bool sameKindedAtoms ( IRAtom* a1, IRAtom* a2 )
{
- if (a1->tag =3D=3D Iex_Tmp && a1->tag =3D=3D Iex_Tmp)
+ if (a1->tag =3D=3D Iex_Tmp && a2->tag =3D=3D Iex_Tmp)
return True;
- if (a1->tag =3D=3D Iex_Const && a1->tag =3D=3D Iex_Const)
+ if (a1->tag =3D=3D Iex_Const && a2->tag =3D=3D Iex_Const)
return True;
return False;
}
|
|
From: Dirk M. <dm...@gm...> - 2005-08-31 10:37:25
|
On Tuesday 30 August 2005 14:54, sv...@va... wrote: > Fix suspicious code in the memcheck instrumenter which probably > rendered many of the assertions in this file ineffective. Spotted by > Tom Truscott. Worth backporting, right? Dirk |
|
From: Julian S. <js...@ac...> - 2005-08-31 13:08:22
|
On Wednesday 31 August 2005 11:36, Dirk Mueller wrote: > On Tuesday 30 August 2005 14:54, sv...@va... wrote: > > Fix suspicious code in the memcheck instrumenter which probably > > rendered many of the assertions in this file ineffective. Spotted by > > Tom Truscott. > > Worth backporting, right? No, imo. I thought about it, but the only effect it can have is to cause assertions to fail when they didn't fail before, which isn't good. If this change in the trunk reveals other problems in memcheck then we can backport the fixes for those problems. But I prefer not to backport this. J |