|
From: <sv...@va...> - 2005-07-26 10:10:35
|
Author: sewardj Date: 2005-07-26 11:10:25 +0100 (Tue, 26 Jul 2005) New Revision: 1300 Log: Don't delete vex_svnversion.h during 'make clean'. This causes breakage if someone builds from the final V tarball, then does 'make clean', then re-runs make -- because creating this file requires (1) svnversion to be present on the end-user system, which it probably isn't, and (2) the metadata which svnversion consults also to be present here, which it certainly isn't [in the cut-down VEX image in the distro tarball.] Modified: trunk/Makefile Modified: trunk/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/Makefile 2005-07-25 11:58:34 UTC (rev 1299) +++ trunk/Makefile 2005-07-26 10:10:25 UTC (rev 1300) @@ -94,9 +94,11 @@ =20 clean: rm -f $(LIB_OBJS) libvex.a vex test_main.o \ - priv/main/vex_svnversion.h \ pub/libvex_guest_offsets.h =20 +distclean: clean + rm -f priv/main/vex_svnversion.h + version: rm -f priv/main/vex_svnversion.h echo -n "\"" > priv/main/vex_svnversion.h |
|
From: Tom H. <to...@co...> - 2005-07-26 11:46:26
|
In message <200...@op...>
sv...@va... wrote:
> Don't delete vex_svnversion.h during 'make clean'. This causes
> breakage if someone builds from the final V tarball, then does 'make
> clean', then re-runs make -- because creating this file requires (1)
> svnversion to be present on the end-user system, which it probably
> isn't, and (2) the metadata which svnversion consults also to be
> present here, which it certainly isn't [in the cut-down VEX image in
> the distro tarball.]
I don't think deleting it on "make distclean" is right either - that
is only supposed to delete things that weren't in the distribution tar
ball. The idea is that you can build then distclean and be back where
you started.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|
|
From: Dirk M. <dm...@gm...> - 2005-07-26 19:28:31
|
On Tuesday 26 July 2005 12:10, sv...@va... wrote: > +distclean: clean > + rm -f priv/main/vex_svnversion.h you actually want "maintainerclean" (why is vex not autotooled btw?) Dirk |