|
From: <sv...@va...> - 2005-05-21 19:49:11
|
Author: njn Date: 2005-05-21 20:49:09 +0100 (Sat, 21 May 2005) New Revision: 3782 Modified: trunk/NOTES.txt trunk/coregrind/m_dispatch/dispatch-amd64.S trunk/coregrind/m_dispatch/dispatch-x86.S Log: Address item in NOTES.txt. Modified: trunk/NOTES.txt =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/NOTES.txt 2005-05-21 19:36:45 UTC (rev 3781) +++ trunk/NOTES.txt 2005-05-21 19:49:09 UTC (rev 3782) @@ -1,11 +1,3 @@ -13 May 05 -~~~~~~~~~ -ToDo: (arch)/dispatch.S: In dispatch_exceptional, there's no point -testing the guest code return value against VG_TRC_INNER_COUNTERZERO, -as vex never sets this flag. Need to check to see if it's possible to -completely get rid of VG_TRC_INNER_COUNTERZERO. - - 11 May 05 ~~~~~~~~~ ToDo: vex-amd64: check above/below the line for reg-alloc Modified: trunk/coregrind/m_dispatch/dispatch-amd64.S =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/coregrind/m_dispatch/dispatch-amd64.S 2005-05-21 19:36:45 UTC (= rev 3781) +++ trunk/coregrind/m_dispatch/dispatch-amd64.S 2005-05-21 19:49:09 UTC (= rev 3782) @@ -189,8 +189,6 @@ */ dispatch_exceptional: /* this is jumped to only, not fallen-through from above */ - cmpq $VG_TRC_INNER_COUNTERZERO, %rbp - jz counter_is_zero =20 /* save %rax in %RIP and defer to sched */ movq 8(%rsp), %rdi Modified: trunk/coregrind/m_dispatch/dispatch-x86.S =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- trunk/coregrind/m_dispatch/dispatch-x86.S 2005-05-21 19:36:45 UTC (re= v 3781) +++ trunk/coregrind/m_dispatch/dispatch-x86.S 2005-05-21 19:49:09 UTC (re= v 3782) @@ -165,8 +165,6 @@ */ dispatch_exceptional: /* this is jumped to only, not fallen-through from above */ - cmpl $VG_TRC_INNER_COUNTERZERO, %ebp - jz counter_is_zero =20 /* save %eax in %EIP and defer to sched */ movl 28(%esp), %edi |