|
From: <sv...@va...> - 2005-05-14 17:00:32
|
Author: njn
Date: 2005-05-14 18:00:25 +0100 (Sat, 14 May 2005)
New Revision: 3706
Modified:
trunk/coregrind/vg_signals.c
Log:
Remove a short sequence of code that was:
(a) overly complex (the parens could be added by the sprintf);
(b) buggy (buf is used uninitialised if VG_(get_fnname) fails);
(c) redundant (the VG_(core_panic_at) prints the stack trace anyway).
Modified: trunk/coregrind/vg_signals.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- trunk/coregrind/vg_signals.c 2005-05-14 11:18:31 UTC (rev 3705)
+++ trunk/coregrind/vg_signals.c 2005-05-14 17:00:25 UTC (rev 3706)
@@ -1887,8 +1887,6 @@
and have it delivered. Otherwise it's a Valgrind bug. */
{ =20
Addr ips[ VG_(clo_backtrace_size) ];
- Addr context_ip;
- Char buf[1024];
ThreadState *tst =3D VG_(get_ThreadState)(VG_(get_lwp_tid)(VG_(get=
tid)()));
=20
if (VG_(sigismember)(&tst->sig_mask, sigNo)) {
@@ -1920,23 +1918,10 @@
"INTERNAL ERROR: Valgrind received a signal %d (%s) - exiting",
sigNo, signame(sigNo));
=20
- buf[0] =3D 0;
- context_ip =3D VGP_UCONTEXT_INSTR_PTR(uc);
- if (1 && !VG_(get_fnname)(context_ip, buf+2, sizeof(buf)-5)) {
- Int len;
-
- buf[0] =3D ' ';
- buf[1] =3D '(';
- len =3D VG_(strlen)(buf);
- buf[len] =3D ')';
- buf[len+1] =3D '\0';
- }
-
VG_(message)(Vg_DebugMsg,=20
- "si_code=3D%x Fault EIP: %p%s; Faulting address: %p",
- info->si_code, context_ip, buf, info->_sifields._sigfault._addr);
- VG_(message)(Vg_DebugMsg,=20
- " sp=3D%p\n", VGP_UCONTEXT_STACK_PTR(uc));
+ "si_code=3D%x; Faulting address: %p; sp: %p",
+ info->si_code, info->_sifields._sigfault._addr,
+ VGP_UCONTEXT_STACK_PTR(uc));
=20
if (0)
VG_(kill_self)(sigNo); /* generate a core dump */
|