|
From: Bart V. A. <bar...@gm...> - 2009-02-26 08:33:58
|
Hello Nicholas, Building the regression tests failed. I found the following error message in the logs: unit_libcbase.o:(.toc+0x78): undefined reference to `VKI_PAGE_SIZE' Can you please have a look at this ? Thanks, Bart. |
|
From: Julian S. <js...@ac...> - 2009-02-26 17:26:16
|
> unit_libcbase.o:(.toc+0x78): undefined reference to `VKI_PAGE_SIZE'
Not sure exactly what happened here, but ..
VKI_PAGE_SIZE isn't a #defined constant on ppc{32,64}-linux -- it's a
variable which is set at startup (of V). This is because on ppc64-linux
there was a movement at one time to also support page sizes of 64k,
although I think that has now been abandoned.
One easy fix is just to do the test with VKI_MAX_PAGE_SIZE, which
afaict is a constant on all platforms.
J
|
|
From: Bart V. A. <bar...@gm...> - 2009-02-26 13:06:48
|
On Thu, Feb 26, 2009 at 1:37 PM, Julian Seward <js...@ac...> wrote:
>
> > unit_libcbase.o:(.toc+0x78): undefined reference to `VKI_PAGE_SIZE'
>
> Not sure exactly what happened here, but ..
>
> VKI_PAGE_SIZE isn't a #defined constant on ppc{32,64}-linux -- it's a
> variable which is set at startup (of V). This is because on ppc64-linux
> there was a movement at one time to also support page sizes of 64k,
> although I think that has now been abandoned.
>
> One easy fix is just to do the test with VKI_MAX_PAGE_SIZE, which
> afaict is a constant on all platforms.
AFAIK the source file memcheck/tests/unit_libcbase.c includes the
source file coregrind/m_libcbase.c. And in the header file
include/vki/vki-ppc64-linux.h I found the following:
extern unsigned long VKI_PAGE_SIZE;
So adding the following line to unit_libcbase.c will probably solve this issue:
unsigned long VKI_PAGE_SIZE = VKI_MAX_PAGE_SIZE;
Bart.
|
|
From: Paul M. <pa...@sa...> - 2009-02-26 21:45:09
|
Julian Seward writes:
> VKI_PAGE_SIZE isn't a #defined constant on ppc{32,64}-linux -- it's a
> variable which is set at startup (of V). This is because on ppc64-linux
> there was a movement at one time to also support page sizes of 64k,
> although I think that has now been abandoned.
Not abandoned at all - 64k pages are fully supported upstream, and
RHEL5 uses 64k pages on ppc64.
Paul.
|