|
From: Carl E. L. <ce...@us...> - 2015-08-10 16:46:44
|
Florian:
> I've fixed what gcc -Wformat-signedness pointed out on amd64, x86, and
> s390. On the ppc machine I have access to there was no suitable gcc and
> attempting to build 5.1 failed with some strange error message I don't
> recall. Carl, perhaps you have a suitable machine + compiler handy?
I pulled down the latest code in svn. I enabled the checking in the configure.ac
file:
# Disabled for now until all platforms are clean
# carll enabled
format_checking_enabled=yes
if test "$format_checking_enabled" = "yes"; then
AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS])
else
dumy_assignment_to_avoid_syntax_errors=1
AC_SUBST([FLAG_W_FORMAT_SIGNEDNESS], [])
fi
I ran .configure and make. I captured the output from make and looked through it but
didn't find any errors related to the checking. The system I ran on was:
Power 8 Little Endian
Linux 3.13.0-35-generic #62-Ubuntu SMP Fri Aug 15 01:57:29 UTC 2014 ppc64le GNU/Linux
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
I tried again with the latest GCC I can find which is available via the IBM advanced
tool chain.
gcc (GCC) 5.1.1 20150512
Again, I didn't find any error messages in the output from make.
Let me know if I am looking in the right place or didn't set things up correctly.
Carl Love
|
|
From: Florian K. <fl...@ei...> - 2015-08-10 17:41:50
|
On 10.08.2015 18:46, Carl E. Love wrote:
>
> I ran .configure and make. I captured the output from make and looked through it but
> didn't find any errors related to the checking. The system I ran on was:
>
> Power 8 Little Endian
> Linux 3.13.0-35-generic #62-Ubuntu SMP Fri Aug 15 01:57:29 UTC 2014 ppc64le GNU/Linux
>
> gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
>
> I tried again with the latest GCC I can find which is available via the IBM advanced
> tool chain.
>
> gcc (GCC) 5.1.1 20150512
>
> Again, I didn't find any error messages in the output from make.
>
> Let me know if I am looking in the right place or didn't set things up correctly.
Carl,
thanks for testing! I think you did it just right. make -s is what I
usually do when I'm looking for warnings or errors. But you probably did
that anyways.. One thing: these inconsistencies would be reported as
warning not as error.
I was wondering whether we should also test on ppc64be? You have a
better feeling as to whether that wold be worth it. I have bo sense for
how much code is in common between big endian and little endian. So I'll
leave it to you to decide.
Thanks again
Florian
|
|
From: Carl E. L. <ce...@us...> - 2015-08-10 21:33:40
|
On Mon, 2015-08-10 at 19:41 +0200, Florian Krohm wrote:
> On 10.08.2015 18:46, Carl E. Love wrote:
> >
> > I ran .configure and make. I captured the output from make and looked through it but
> > didn't find any errors related to the checking. The system I ran on was:
> >
> > Power 8 Little Endian
> > Linux 3.13.0-35-generic #62-Ubuntu SMP Fri Aug 15 01:57:29 UTC 2014 ppc64le GNU/Linux
> >
> > gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
> >
> > I tried again with the latest GCC I can find which is available via the IBM advanced
> > tool chain.
> >
> > gcc (GCC) 5.1.1 20150512
> >
> > Again, I didn't find any error messages in the output from make.
> >
> > Let me know if I am looking in the right place or didn't set things up correctly.
>
> Carl,
>
> thanks for testing! I think you did it just right. make -s is what I
> usually do when I'm looking for warnings or errors. But you probably did
> that anyways.. One thing: these inconsistencies would be reported as
> warning not as error.
> I was wondering whether we should also test on ppc64be? You have a
> better feeling as to whether that wold be worth it. I have bo sense for
> how much code is in common between big endian and little endian. So I'll
> leave it to you to decide.
>
> Thanks again
>
> Florian
>
Florian:
I went back an rechecked for warnings as well as errors. I didn't find
any warnings. I retested with make -s and checked for warnings and
errors and didn't see anything.
I then did the same on a Power 7 big endian machine. Again no warnings
or errors were found.
Carl Love
|