|
From: Uttam P. <ut...@us...> - 2006-01-20 01:09:21
|
Hi All,
Here is 2nd cleanup patch. Variable 'human_readable' is always true, so
the following conditional assignment is really not necessary.
Any feedback is appreciated.
Thanks,
Uttam
--- valgrind-3.1.0.orig/coregrind/m_debuginfo/symtab.c 2006-01-20 07:58:07.211145392 -0800
+++ valgrind-3.1.0/coregrind/m_debuginfo/symtab.c 2006-01-20 08:15:41.429058232 -0800
@@ -2498,9 +2498,8 @@ Char* VG_(describe_IP)(Addr eip, Char* b
);
if (VG_(clo_xml)) {
- Bool human_readable = True;
- HChar* maybe_newline = human_readable ? "\n " : "";
- HChar* maybe_newline2 = human_readable ? "\n " : "";
+ HChar* maybe_newline = "\n ";
+ HChar* maybe_newline2 = "\n ";
/* Print in XML format, dumping in as much info as we know. */
APPEND("<frame>");
|
|
From: Julian S. <js...@ac...> - 2006-01-21 03:11:07
|
On Friday 20 January 2006 01:12, Uttam Pawar wrote: > Hi All, > > Here is 2nd cleanup patch. Variable 'human_readable' is always true, so > the following conditional assignment is really not necessary. True, but it's not harmful either as the compiler will fold away the unused side. It's probably there to make debugging easier. J |