|
From: <ppl...@go...> - 2011-11-29 05:49:34
|
Greetings,
Attached patch makes VG builtin gdbserver respect value of VALGRIND_LIB
in the help message it prints, rather than using compiled-in value.
Thanks,
Index: coregrind/m_gdbserver/remote-utils.c
===================================================================
--- coregrind/m_gdbserver/remote-utils.c (revision 12277)
+++ coregrind/m_gdbserver/remote-utils.c (working copy)
@@ -269,7 +269,7 @@
"don't want to do, unless you know exactly what you're doing,\n"
"or are doing some strange experiment):\n"
" %s/../../bin/vgdb --pid=%d%s%s ...command...\n",
- VG_LIBDIR,
+ VG_(libdir),
pid, (name_default ? "" : " --vgdb-prefix="),
(name_default ? "" : name));
}
@@ -282,7 +282,7 @@
"and then give GDB the following command\n"
" target remote | %s/../../bin/vgdb --pid=%d%s%s\n",
VG_(args_the_exename),
- VG_LIBDIR,
+ VG_(libdir),
pid, (name_default ? "" : " --vgdb-prefix="),
(name_default ? "" : name)
);
|
|
From: Philippe W. <phi...@sk...> - 2011-11-29 20:21:42
|
> Greetings, > > Attached patch makes VG builtin gdbserver respect value of VALGRIND_LIB > in the help message it prints, rather than using compiled-in value. I have applied the patch, and then tested it by doing make (so *not* make install), then running vg-in-place. The help message is changed to reference the .in_place directory : ==11372== target remote | /home/pubuntu/valgrind/invoker_param/./.in_place/../../bin/vgdb --pid=11372 but the provided vgdb path does not point to the compiled (not installed) vgdb : ls /home/pubuntu/valgrind/invoker_param/./.in_place/../../bin/vgdb ls: cannot access /home/pubuntu/valgrind/invoker_param/./.in_place/../../bin/vgdb: No such file or directory ls /home/pubuntu/valgrind/invoker_param/coregrind/vgdb /home/pubuntu/valgrind/invoker_param/coregrind/vgdb So, the above does not work for a 'make' without install. Is there another situation in which using the VG_(libdir) would improve ? Note that the vg-in-place script has "hard-coded" the knowledge that the valgrind executable is found in the coregrind directory. Philippe |
|
From: Paul P. <ppl...@go...> - 2011-11-29 21:38:15
|
On Tue, Nov 29, 2011 at 12:21 PM, Philippe Waroquiers <phi...@sk...> wrote: > So, the above does not work for a 'make' without install. > Is there another situation in which using the VG_(libdir) would improve ? We have environment here in which the compiled-in VG_LIBDIR has nothing at all to do with where valgrind ends up being installed, and here the situation is improved by using VG_(libdir). Besides, it's more uniform with the rest of the code. Uniformity is good ;-) Thanks, -- Paul Pluzhnikov |