You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
1
(1) |
2
(1) |
3
|
|
4
|
5
(3) |
6
|
7
(2) |
8
(1) |
9
(1) |
10
|
|
11
|
12
(2) |
13
|
14
(1) |
15
(2) |
16
|
17
|
|
18
|
19
|
20
|
21
|
22
|
23
|
24
|
|
25
|
26
|
27
|
28
(1) |
29
|
30
(1) |
|
|
From: Paul F. <pa...@so...> - 2023-06-07 20:55:00
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=8bc3a55d50570ef3e3077a7bdfb6354895a56878 commit 8bc3a55d50570ef3e3077a7bdfb6354895a56878 Author: Paul Floyd <pj...@wa...> Date: Wed Jun 7 22:54:22 2023 +0200 Merge error, missing continuation in Makefile.am Diff: --- memcheck/tests/freebsd/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memcheck/tests/freebsd/Makefile.am b/memcheck/tests/freebsd/Makefile.am index f515a684ec..722cc5d51e 100644 --- a/memcheck/tests/freebsd/Makefile.am +++ b/memcheck/tests/freebsd/Makefile.am @@ -100,7 +100,7 @@ EXTRA_DIST = \ bug464476_rel_symlink.vgtest \ bug464476_rel_symlink.stderr.exp \ bug464476_rel_symlink.stdout.exp \ - memalign.vgtest memalign.stderr.exp + memalign.vgtest memalign.stderr.exp \ bug470713.vgtest bug470713.stderr.exp \ bug470713.stdout.exp |
|
From: Paul F. <pa...@so...> - 2023-06-07 20:29:52
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=840ccb9915c675fd7db527107e6b38343fafdf86 commit 840ccb9915c675fd7db527107e6b38343fafdf86 Author: Paul Floyd <pj...@wa...> Date: Wed Jun 7 22:27:08 2023 +0200 Bug 470713 - Failure on the Yosys project: valgrind: m_libcfile.c:1802 (Bool vgPlain_realpath(const HChar *, HChar *)): Assertion 'resolved' failed When using sysctl kern proc pathname with the pid of the guest or -1 we need to intercept the call otherwise the syscall will return the path of the memcheck tool and not the path of the guest. This uses VG_(realpath), which asserts if it doesn't get valid input pointers. sysctl kern proc pathname can use a NULL pointer in order to determine the length of the path (so users can allocate the minumum necessary). The NULL pointer was being passed on to VG_(realpath) without being checked, resulting in an assert. Diff: --- .gitignore | 1 + NEWS | 2 ++ coregrind/m_syswrap/syswrap-freebsd.c | 13 +++++++++ memcheck/tests/freebsd/Makefile.am | 5 +++- memcheck/tests/freebsd/bug470713.cpp | 44 +++++++++++++++++++++++++++++ memcheck/tests/freebsd/bug470713.stderr.exp | 0 memcheck/tests/freebsd/bug470713.stdout.exp | 2 ++ memcheck/tests/freebsd/bug470713.vgtest | 3 ++ 8 files changed, 69 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 6d73324cea..9e16ac126d 100644 --- a/.gitignore +++ b/.gitignore @@ -1341,6 +1341,7 @@ /memcheck/tests/freebsd/452275 /memcheck/tests/freebsd/access /memcheck/tests/freebsd/bug464476 +/memcheck/tests/freebsd/bug470713 /memcheck/tests/freebsd/capsicum /memcheck/tests/freebsd/chflags /memcheck/tests/freebsd/chmod_chown diff --git a/NEWS b/NEWS index 09f8c71370..4c5635dde1 100644 --- a/NEWS +++ b/NEWS @@ -38,6 +38,8 @@ are not entered into bugzilla tend to get forgotten about or ignored. 469146 massif --ignore-fn does not ignore inlined functions 469768 Make it possible to install gdb scripts in a different location 470520 Multiple realloc zero errors crash in MC_(eq_Error) +470713 Failure on the Yosys project: valgrind: m_libcfile.c:1802 + (Bool vgPlain_realpath(const HChar *, HChar *)): Assertion 'resolved' failed To see details of a given bug, visit https://bugs.kde.org/show_bug.cgi?id=XXXXXX diff --git a/coregrind/m_syswrap/syswrap-freebsd.c b/coregrind/m_syswrap/syswrap-freebsd.c index fd4dff4da4..6b9f3d2109 100644 --- a/coregrind/m_syswrap/syswrap-freebsd.c +++ b/coregrind/m_syswrap/syswrap-freebsd.c @@ -1987,6 +1987,19 @@ static Bool sysctl_kern_proc_pathname(HChar *out, SizeT *len) { const HChar *exe_name = VG_(resolved_exename); + if (!len) { + return False; + } + + if (!out) { + HChar tmp[VKI_PATH_MAX]; + if (!VG_(realpath)(exe_name, tmp)) { + return False; + } + *len = VG_(strlen)(tmp)+1; + return True; + } + if (!VG_(realpath)(exe_name, out)) { return False; } diff --git a/memcheck/tests/freebsd/Makefile.am b/memcheck/tests/freebsd/Makefile.am index 2259e1efb8..f515a684ec 100644 --- a/memcheck/tests/freebsd/Makefile.am +++ b/memcheck/tests/freebsd/Makefile.am @@ -101,6 +101,8 @@ EXTRA_DIST = \ bug464476_rel_symlink.stderr.exp \ bug464476_rel_symlink.stdout.exp \ memalign.vgtest memalign.stderr.exp + bug470713.vgtest bug470713.stderr.exp \ + bug470713.stdout.exp check_PROGRAMS = \ statfs pdfork_pdkill getfsstat inlinfo inlinfo_nested.so extattr \ @@ -108,7 +110,7 @@ check_PROGRAMS = \ linkat scalar_fork scalar_thr_exit scalar_abort2 scalar_pdfork \ scalar_vfork stat file_locking_wait6 utimens access chmod_chown \ misc get_set_context utimes static_allocs fexecve errno_aligned_allocs \ - setproctitle sctp sctp2 bug464476 memalign + setproctitle sctp sctp2 bug464476 memalign bug470713 AM_CFLAGS += $(AM_FLAG_M3264_PRI) AM_CXXFLAGS += $(AM_FLAG_M3264_PRI) @@ -122,6 +124,7 @@ inlinfo_nested_so_CFLAGS = $(AM_CFLAGS) -fPIC @FLAG_W_NO_UNINITIALIZED@ inlinfo_nested_so_LDFLAGS = -Wl,-rpath,$(top_builddir)/memcheck/tests/freebsd -shared -fPIC bug464476_SOURCES = bug464476.cpp +bug470713_SOURCES = bug470713.cpp if FREEBSD_VERS_13_PLUS check_PROGRAMS += realpathat scalar_13_plus eventfd1 eventfd2 diff --git a/memcheck/tests/freebsd/bug470713.cpp b/memcheck/tests/freebsd/bug470713.cpp new file mode 100644 index 0000000000..67a544926a --- /dev/null +++ b/memcheck/tests/freebsd/bug470713.cpp @@ -0,0 +1,44 @@ +// roughly based on the code for Firefox class BinaryPath +// https://searchfox.org/mozilla-central/source/xpcom/build/BinaryPath.h#185 + +#include <iostream> +#include <sys/types.h> +#include <sys/sysctl.h> +#include <limits.h> +#include <string> +#include <memory> + +using std::cerr; +using std::cout; +using std::string; + +int main(int argc, char **argv) +{ + int mib[] = { CTL_KERN, KERN_PROC, KERN_PROC_PATHNAME, -1}; + size_t len; + + if (sysctl(mib, 4, NULL, &len, NULL, 0) != 0) { + cout << "sysctl failed to get path length: " << strerror(errno) << '\n'; + return -1; + } + + std::unique_ptr<char[]> aResult(new char[len]); + + if (sysctl(mib, 4, aResult.get(), &len, NULL, 0) != 0) { + cout << "sysctl failed to get path: " << strerror(errno) << '\n'; + return -1; + } + + if (string(aResult.get()) == argv[1]) { + cout << "OK\n"; + } else { + cout << "Not OK aResult " << aResult << " argv[1] " << argv[1] << '\n'; + } + + if (sysctl(mib, 4, NULL, NULL, NULL, 0) != -1) { + cout << "OK syscall failed\n"; + return -1; + } else { + cout << "sysctl succeeded when it should have failed\n"; + } +} diff --git a/memcheck/tests/freebsd/bug470713.stderr.exp b/memcheck/tests/freebsd/bug470713.stderr.exp new file mode 100644 index 0000000000..e69de29bb2 diff --git a/memcheck/tests/freebsd/bug470713.stdout.exp b/memcheck/tests/freebsd/bug470713.stdout.exp new file mode 100644 index 0000000000..2ba70ed13d --- /dev/null +++ b/memcheck/tests/freebsd/bug470713.stdout.exp @@ -0,0 +1,2 @@ +OK +OK syscall failed diff --git a/memcheck/tests/freebsd/bug470713.vgtest b/memcheck/tests/freebsd/bug470713.vgtest new file mode 100644 index 0000000000..b85043a5ab --- /dev/null +++ b/memcheck/tests/freebsd/bug470713.vgtest @@ -0,0 +1,3 @@ +prog: bug470713 +vgopts: -q +args: `pwd`/bug470713 |