You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
|
1
(6) |
|
2
(6) |
3
(9) |
4
(4) |
5
(1) |
6
|
7
|
8
|
|
9
|
10
(2) |
11
(1) |
12
(2) |
13
(4) |
14
(6) |
15
(8) |
|
16
(9) |
17
(5) |
18
(13) |
19
(6) |
20
(15) |
21
(17) |
22
(19) |
|
23
(2) |
24
(4) |
25
(2) |
26
(10) |
27
(6) |
28
(9) |
29
(3) |
|
30
|
|
|
|
|
|
|
|
From: Nicholas N. <n.n...@gm...> - 2023-04-23 22:39:50
|
On Sun, 23 Apr 2023 at 03:25, Mark Wielaard <ma...@kl...> wrote: > > > > You can send up a .gitconfig for the project, so it'll work automatically > > for everyone. > > How? > We would have a file, called `.git-blame-ignore-revs` by convention. Here's an example that hides the auto-formatting/unformatting that Paul accidentally committed recently: # Accidental clang-format on a few files, 2023-04-22. > bf347551c99313a4af9c38bdeda9b946c9795945 > > # Undo the previous commit, 2023-04-22. > 76d6b4591a5a05e43e1a819bf630c0d8ee857a7e > I tested this out, it works well. Here is the vanilla blame for a couple of lines in `memcheck/mc_main.c` that were affected: 76d6b4591a (Paul Floyd 2023-04-22 16:29:27 +0200 60) static void > ocache_sarp_Set_Origins ( Addr, UWord, UInt ); /* fwds */ > 76d6b4591a (Paul Floyd 2023-04-22 16:29:27 +0200 61) static > void ocache_sarp_Clear_Origins ( Addr, UWord ); /* fwds */ > and here is the blame using the `.git-blame-ignore-revs` file: afebe61b37 (Nicholas Nethercote 2002-09-23 09:36:25 +0000 60) static void > ocache_sarp_Set_Origins ( Addr, UWord, UInt ); /* fwds */ > 4cae5c3ed5 (Julian Seward 2008-05-01 20:24:26 +0000 61) static > void ocache_sarp_Clear_Origins ( Addr, UWord ); /* fwds */ > To make that work seamlessly with `git blame` requires running `git config blame.ignoreRevsFile .git-blame-ignore-revs` once per cloned repository. That command could easily be put somewhere that will always run while building. Somewhere in `configure.ac` seems like a logical place though I'd be happy to hear suggestions otherwise. Firefox's `.git-blame-ignore-revs` file is here: https://searchfox.org/mozilla-central/source/.git-blame-ignore-revs. It has hundreds of entries! I expect/hope we wouldn't need anything like that many, but it shows that the solution scales nicely to very large codebases. The end result is that the effect of auto-formatting on history can be worked around in a straightforward manner. (BTW, we could take advantage of `configure.ac` to set up other git aliases. E.g. we could have one for pushing to a try branch, so you just have to run `git vgtry $BRANCH` instead of `git push origin $BRANCH:users/$USERNAME/try-$BRANCH`.) I can see how it would work nicely for new python code. gdb also uses > python black (plus a buildbot checker) to auto-format their python > code. If you like we could add the same to the buildbot for valgrind. > Sounds great. I am all for automating this kind of thing, making it impossible to forget to do it or do it incorrectly. How exactly would it work? Would it be a post-commit check? Could we get the same check to run locally, to run pre-commit? > BTW. Trying the various formatters listed in auxprogs/pybuild.sh gives > me (pylint suggests to use a range generator instead of an array, then > black reformates the file to get everything on one line: > > - min_ofl_st_mtime_ns = min( > - [os.stat(ofl).st_mtime_ns for ofl in ofls] > - ) > + min_ofl_st_mtime_ns = min(os.stat(ofl).st_mtime_ns > for ofl in ofls) Interesting. I have black 22.6.0, what version do you have? Nick |
|
From: Paul F. <pa...@so...> - 2023-04-23 11:52:39
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=a821780d8ccbf4a1ade369d838d52486ec1571a2 commit a821780d8ccbf4a1ade369d838d52486ec1571a2 Author: Paul Floyd <pj...@wa...> Date: Sun Apr 23 13:51:37 2023 +0200 solaris: aligned allocation issues Solaris 11.3 doesn't have aligned_alloc - add a configure time test memalign does not accept either a size or an alignment of zero Diff: --- configure.ac | 1 + coregrind/m_replacemalloc/vg_replace_malloc.c | 5 +++- memcheck/tests/Makefile.am | 2 ++ .../tests/cxx17_aligned_new.stderr.exp-solaris | 30 ++++++++++++++++++++++ memcheck/tests/memalign_args.c | 2 +- memcheck/tests/memalign_args.stderr.exp-darwin | 11 ++++++++ memcheck/tests/solaris/aligned_alloc.c | 5 ++-- 7 files changed, 52 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 8470daebd1..d1af9de0d3 100755 --- a/configure.ac +++ b/configure.ac @@ -4803,6 +4803,7 @@ AC_CHECK_LIB([pthread], [pthread_create]) AC_CHECK_LIB([rt], [clock_gettime]) AC_CHECK_FUNCS([ \ + aligned_alloc \ clock_gettime\ copy_file_range \ epoll_create \ diff --git a/coregrind/m_replacemalloc/vg_replace_malloc.c b/coregrind/m_replacemalloc/vg_replace_malloc.c index 78d0b33104..a71aa4b5b2 100644 --- a/coregrind/m_replacemalloc/vg_replace_malloc.c +++ b/coregrind/m_replacemalloc/vg_replace_malloc.c @@ -1742,8 +1742,10 @@ extern int * __error(void) __attribute__((weak)); #if defined(VGO_solaris) #define VG_MEMALIGN_ALIGN_POWER_TWO 0 +#define VG_MEMALIGN_NO_ALIGN_ZERO 1 #else #define VG_MEMALIGN_ALIGN_POWER_TWO 1 +#define VG_MEMALIGN_NO_ALIGN_ZERO 0 #endif #if defined(VGO_solaris) @@ -1802,7 +1804,8 @@ extern int * __error(void) __attribute__((weak)); DO_INIT; \ MALLOC_TRACE("memalign(alignment %llu, size %llu)", \ (ULong)alignment, (ULong)size ); \ - if ((VG_MEMALIGN_NO_SIZE_ZERO && (alignment == 0)) \ + if ((VG_MEMALIGN_NO_SIZE_ZERO && (size == 0)) \ + || (VG_MEMALIGN_NO_ALIGN_ZERO && (alignment == 0)) \ || (VG_MEMALIGN_ALIGN_POWER_TWO && (alignment & (alignment - 1)) != 0) \ || (VG_MEMALIGN_ALIGN_FACTOR_FOUR && (alignment % 4 != 0))) { \ SET_ERRNO_EINVAL; \ diff --git a/memcheck/tests/Makefile.am b/memcheck/tests/Makefile.am index faf9130bcd..9bbbe7bec5 100644 --- a/memcheck/tests/Makefile.am +++ b/memcheck/tests/Makefile.am @@ -141,6 +141,7 @@ EXTRA_DIST = \ custom-overlap.stderr.exp custom-overlap.vgtest \ cxx17_aligned_new.stderr.exp cxx17_aligned_new.vgtest \ cxx17_aligned_new.stderr.exp_32 \ + cxx17_aligned_new.stderr.exp-solaris \ cxx17_aligned_new.stdout.exp \ sized_aligned_new_delete_args.stderr.exp \ sized_aligned_new_delete_args.vgtest \ @@ -226,6 +227,7 @@ EXTRA_DIST = \ memalign_test.stderr.exp-freebsd-clang \ memalign_args.vgtest memalign_args.stderr.exp \ memalign_args.stderr.exp-glibc \ + memalign_args.stderr.exp-darwin \ memcmptest.stderr.exp memcmptest.stderr.exp2 \ memcmptest.stdout.exp memcmptest.vgtest \ memmem.stderr.exp memmem.vgtest \ diff --git a/memcheck/tests/cxx17_aligned_new.stderr.exp-solaris b/memcheck/tests/cxx17_aligned_new.stderr.exp-solaris new file mode 100644 index 0000000000..54659a4dba --- /dev/null +++ b/memcheck/tests/cxx17_aligned_new.stderr.exp-solaris @@ -0,0 +1,30 @@ + +_ZnwmSt11align_val_t(size 64, al 64) = 0x........ +_ZdlPvSt11align_val_t(0x........) +_ZnamSt11align_val_t(size 320, al 64) = 0x........ +_ZdaPvSt11align_val_t(0x........) +_ZnwmSt11align_val_t(size 64, al 64) = 0x........ +_ZdlPvmSt11align_val_t(0x........) +_ZnamSt11align_val_t(size 320, al 64) = 0x........ +_ZdaPvmSt11align_val_t(0x........) +_ZnwmSt11align_val_tRKSt9nothrow_t(size 64, al 64) = 0x........ +_ZdlPvSt11align_val_tRKSt9nothrow_t(0x........) +_ZnamSt11align_val_tRKSt9nothrow_t(size 320, al 64) = 0x........ +_ZdaPvSt11align_val_tRKSt9nothrow_t(0x........) +_Znwm(4) = 0x........ +_ZdlPvSt11align_val_t(0x........) +_ZnwmRKSt9nothrow_t(4) = 0x........ +_ZdlPvm(0x........) +_Znam(20) = 0x........ +_ZdaPv(0x........) +_ZnamRKSt9nothrow_t(20) = 0x........ +_ZdaPv(0x........) + +HEAP SUMMARY: + in use at exit: ... bytes in ... blocks + total heap usage: ... allocs, ... frees, ... bytes allocated + +For a detailed leak analysis, rerun with: --leak-check=full + +For lists of detected and suppressed errors, rerun with: -s +ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0) diff --git a/memcheck/tests/memalign_args.c b/memcheck/tests/memalign_args.c index de765bcc2b..6946ae3a32 100644 --- a/memcheck/tests/memalign_args.c +++ b/memcheck/tests/memalign_args.c @@ -23,7 +23,7 @@ int main(void) (void)posix_memalign((void **)&mem,align,size); free(mem); -#if !defined(VGO_darwin) +#if defined(HAVE_ALIGNED_ALLOC) p = aligned_alloc(align, size); free(p); #endif diff --git a/memcheck/tests/memalign_args.stderr.exp-darwin b/memcheck/tests/memalign_args.stderr.exp-darwin new file mode 100644 index 0000000000..c255e02f1c --- /dev/null +++ b/memcheck/tests/memalign_args.stderr.exp-darwin @@ -0,0 +1,11 @@ +Conditional jump or move depends on uninitialised value(s) + at 0x........: memalign (vg_replace_malloc.c:...) + by 0x........: main (memalign_args.c:19) + +Conditional jump or move depends on uninitialised value(s) + at 0x........: posix_memalign (vg_replace_malloc.c:...) + by 0x........: main (memalign_args.c:23) + +Conditional jump or move depends on uninitialised value(s) + at 0x........: valloc (vg_replace_malloc.c:...) + by 0x........: main (memalign_args.c:31) diff --git a/memcheck/tests/solaris/aligned_alloc.c b/memcheck/tests/solaris/aligned_alloc.c index c8e82e276f..346595f29e 100644 --- a/memcheck/tests/solaris/aligned_alloc.c +++ b/memcheck/tests/solaris/aligned_alloc.c @@ -1,12 +1,13 @@ #include <stdlib.h> #include <assert.h> #include <errno.h> +#include "../../config.h" int main(void) { +#if defined(HAVE_ALIGNED_ALLOC) char* p = NULL; - // zero size p = aligned_alloc(0, 8); assert(p == NULL && errno == EINVAL); @@ -33,6 +34,6 @@ int main(void) } assert(p == NULL && errno == ENOMEM); - +#endif } |