You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
1
(3) |
2
|
3
|
4
|
|
5
(13) |
6
(2) |
7
(5) |
8
(4) |
9
(3) |
10
(4) |
11
(4) |
|
12
(7) |
13
|
14
(1) |
15
|
16
|
17
(2) |
18
|
|
19
|
20
|
21
(3) |
22
(8) |
23
(7) |
24
(5) |
25
(4) |
|
26
(6) |
27
|
28
(9) |
29
|
30
(4) |
31
(5) |
|
|
From: Paul F. <pa...@so...> - 2023-03-06 20:52:25
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=e8d4d64e46cde7507c3716ad8094d886e8824fa4 commit e8d4d64e46cde7507c3716ad8094d886e8824fa4 Author: Paul Floyd <pj...@wa...> Date: Mon Mar 6 21:50:01 2023 +0100 Bug 466104 - aligned_alloc problems, part 1 I think that these are all now done. This commit refactors memalign and updates manual-core.xml to say some behaviour of Valgrind depends on the build time OS and libraries. Diff: --- NEWS | 1 + coregrind/m_replacemalloc/vg_replace_malloc.c | 124 +++++++++----------------- docs/xml/manual-core.xml | 5 ++ 3 files changed, 50 insertions(+), 80 deletions(-) diff --git a/NEWS b/NEWS index 61c4e03053..bc3f4a363b 100644 --- a/NEWS +++ b/NEWS @@ -98,6 +98,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. 464859 Build failures with GCC-13 (drd tsan_unittest) 464969 D language demangling 465435 m_libcfile.c:66 (vgPlain_safe_fd): Assertion 'newfd >= VG_(fd_hard_limit)' failed. +466104 aligned_alloc problems, part 1 n-i-bz FreeBSD rfork syscall fail with EINVAL or ENOSYS rather than VG_(unimplemented) To see details of a given bug, visit diff --git a/coregrind/m_replacemalloc/vg_replace_malloc.c b/coregrind/m_replacemalloc/vg_replace_malloc.c index 18cbb7f88e..6addfe80f9 100644 --- a/coregrind/m_replacemalloc/vg_replace_malloc.c +++ b/coregrind/m_replacemalloc/vg_replace_malloc.c @@ -1506,6 +1506,7 @@ extern int *___errno (void) __attribute__((weak)); * */ + /* @todo PJF exactly what is the behaviour if this? */ #define ZONEMEMALIGN(soname, fnname) \ \ void* VG_REPLACE_FUNCTION_EZU(10100,soname,fnname) \ @@ -1534,8 +1535,34 @@ extern int *___errno (void) __attribute__((weak)); return v; \ } -#if defined(VGO_linux) -#if !defined(MUSL_LIBC) +#if defined(VGO_freebsd) +#define VG_MEMALIGN_MAKE_SIZE_MULTIPLE_ALIGN 1 +#else +#define VG_MEMALIG_MAKE_SIZE_MULTIPLE_ALIGN 0 +#endif + +#if defined(VGO_solaris) +#define VG_MEMALIGN_ALIGN_POWER_TWO 0 +#else +#define VG_MEMALIGN_ALIGN_POWER_TWO 1 +#endif + +#if defined(VGO_solaris) +#define VG_MEMALIGD_ALIGN_FACTOR_FOUR 1 +#else +#define VG_MEMALIGN_ALIGN_FACTOR_FOUR 0 +#endif + +#if defined(MUSL_LIBC) +#define VG_MEMALIGN_NO_SIZE_ZERO 0 +#else +#define VG_MEMALIGN_NO_SIZE_ZERO 1 +#endif + + + +#if defined(VGO_linux) && !defined(MUSL_LIBC) + #define MEMALIGN(soname, fnname) \ \ void* VG_REPLACE_FUNCTION_EZU(10110,soname,fnname) \ @@ -1562,34 +1589,8 @@ extern int *___errno (void) __attribute__((weak)); if (!v) SET_ERRNO_ENOMEM; \ return v; \ } -#else /* MUSL_LIBC */ -#define MEMALIGN(soname, fnname) \ - \ - void* VG_REPLACE_FUNCTION_EZU(10110,soname,fnname) \ - ( SizeT alignment, SizeT size ); \ - void* VG_REPLACE_FUNCTION_EZU(10110,soname,fnname) \ - ( SizeT alignment, SizeT size ) \ - { \ - void *mem; \ - \ - DO_INIT; \ - if ((alignment & (alignment - 1)) != 0) { \ - SET_ERRNO_EINVAL; \ - return 0; \ - } \ - /* Round up to minimum alignment if necessary. */ \ - if (alignment < VG_MIN_MALLOC_SZB) \ - alignment = VG_MIN_MALLOC_SZB; \ - \ - mem = (void*)VALGRIND_NON_SIMD_CALL2( info.tl_memalign, alignment, size ); \ - \ - if (!mem) SET_ERRNO_ENOMEM; \ - \ - return mem; \ - } -#endif -#elif defined(VGO_freebsd) +#else #define MEMALIGN(soname, fnname) \ \ @@ -1601,70 +1602,31 @@ extern int *___errno (void) __attribute__((weak)); void *mem; \ \ DO_INIT; \ - TRIGGER_MEMCHECK_ERROR_IF_UNDEFINED(size); \ - MALLOC_TRACE("memalign(al %llu, size %llu)\n", \ - (ULong)alignment, (ULong)size ); \ - if ((alignment & (alignment - 1)) != 0) { \ + MALLOC_TRACE("memalign(alignment %llu, size %llu)", \ + (ULong)alignment, (ULong)size ); \ + if ((VG_MEMALIGN_NO_SIZE_ZERO && (alignment == 0)) \ + || (VG_MEMALIGN_ALIGN_POWER_TWO && (alignment & (alignment - 1)) != 0) \ + || (VG_MEMALIGN_ALIGN_FACTOR_FOUR && (alignment % 4 != 0))) { \ SET_ERRNO_EINVAL; \ return 0; \ } \ /* Round up to minimum alignment if necessary. */ \ - if (alignment < VG_MIN_MALLOC_SZB) \ - alignment = VG_MIN_MALLOC_SZB; \ - \ - mem = (void*)VALGRIND_NON_SIMD_CALL2( info.tl_memalign, \ - alignment, VG_ALIGN_ROUNDUP(size, alignment) ); \ - \ - if (!mem) SET_ERRNO_ENOMEM; \ - \ - return mem; \ - } - -#elif defined(VGO_solaris) - -// In the Illumos source there is a macro MINSIZE -// which is sizeof (TREE) - sizeof (WORD) -// struct TREE contains 6 WORDS -// so MINSIZE is 5 words -// -// In gdb I get the impression that sizeof (WORD) is 16 -#define VG_MEMALIGN_MINSIZE (5*VG_WORDSIZE) - -#define MEMALIGN(soname, fnname) \ - \ - void* VG_REPLACE_FUNCTION_EZU(10110,soname,fnname) \ - ( SizeT alignment, SizeT size ); \ - void* VG_REPLACE_FUNCTION_EZU(10110,soname,fnname) \ - ( SizeT alignment, SizeT size ) \ - { \ - void *mem; \ + if (alignment < VG_MIN_MALLOC_SZB) \ + alignment = VG_MIN_MALLOC_SZB; \ + /* Solaris allows non-power of 2 alignment but not Valgrind. */ \ + while (0 != (alignment & (alignment - 1))) alignment++; \ \ - DO_INIT; \ - MALLOC_TRACE("memalign(al %llu, size %llu)\n", \ - (ULong)alignment, (ULong)size ); \ - if (alignment == 0 \ - || (size == 0) \ - || (alignment & 3)) { \ - SET_ERRNO_EINVAL; \ - return 0; \ + if (VG_MEMALIGN_MAKE_SIZE_MULTIPLE_ALIGN) { \ + size = ((size + alignment - 1)/alignment)*alignment; \ } \ - size = VG_ALIGN_ROUNDUP(size, VG_WORDSIZE); \ - if (size < VG_MEMALIGN_MINSIZE) \ - size = VG_MEMALIGN_MINSIZE; \ - alignment = VG_ALIGN_ROUNDUP(alignment, VG_WORDSIZE); \ - while (alignment < VG_MEMALIGN_MINSIZE + VG_WORDSIZE) \ - alignment <<= 1U; \ \ - mem = (void*)VALGRIND_NON_SIMD_CALL2( info.tl_memalign, \ - alignment, VG_ALIGN_ROUNDUP(size, alignment) ); \ + mem = (void*)VALGRIND_NON_SIMD_CALL2( info.tl_memalign, alignment, size ); \ \ if (!mem) SET_ERRNO_ENOMEM; \ \ return mem; \ } -// no Darwin - #endif #if defined(VGO_linux) @@ -1955,6 +1917,7 @@ extern int *___errno (void) __attribute__((weak)); { \ void *mem; \ \ + DO_INIT; \ TRIGGER_MEMCHECK_ERROR_IF_UNDEFINED(size); \ MALLOC_TRACE("aligned_alloc(al %llu, size %llu)", \ (ULong)alignment, (ULong)size ); \ @@ -1982,6 +1945,7 @@ extern int *___errno (void) __attribute__((weak)); { \ void *mem; \ \ + DO_INIT; \ MALLOC_TRACE("aligned_alloc(al %llu, size %llu)", \ (ULong)alignment, (ULong)size ); \ if ((VG_ALIGNED_ALLOC_NO_SIZE_ZERO && (alignment == 0)) \ diff --git a/docs/xml/manual-core.xml b/docs/xml/manual-core.xml index 558d1f62df..3a91c930fa 100644 --- a/docs/xml/manual-core.xml +++ b/docs/xml/manual-core.xml @@ -82,6 +82,11 @@ To make it easier to write suppressions, you can use the print out a suppression for each reported error, which you can then copy into a suppressions file.</para> +<para>Valgrind will try to match the behaviour of applications +compiled to run on the same OS and libraries that Valgrind was +built with. If you use different libraries or a different +OS version there may be some small differences in behaviour.</para> + <para>Different error-checking tools report different kinds of errors. The suppression mechanism therefore allows you to say which tool or tool(s) each suppression applies to.</para> |
|
From: Nicholas N. <n.n...@gm...> - 2023-03-06 11:03:32
|
Hi, Perl was a reasonable choice for `cg_annotate` when I first wrote it 20+ years ago. But it's unfortunate now, with Perl being (a) a pretty weird and horrible language, and (b) moribund. I'd like to rewrite it (and `cg_diff`) in Python, which will make maintenance easier. I see that we already have some Python in Valgrind: `coregrind/m_gdbserver/valgrind-monitor.py` and `coregrind/m_gdbserver/valgrind-monitor-def.py`. Therefore I don't think this should be controversial. But I might as well ask, just in case: any objections or advice? Because these are single file scripts, we avoid all the usual problems of Python packaging, and just use `cp` as the package manager :) On a related note, the `cg_annotate.in`/`cg_annotate` split is annoying. The only reason for it now is to auto-embed the version number into the script, via the configure `@VERSION@` variable, for `cg_annotate --version` output. Does anyone know of a way to achieve that without requiring configure? Thanks. Nick |