You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
1
(3) |
2
|
3
|
4
|
|
5
(13) |
6
(2) |
7
(5) |
8
(4) |
9
(3) |
10
(4) |
11
(4) |
|
12
(7) |
13
|
14
(1) |
15
|
16
|
17
(2) |
18
|
|
19
|
20
|
21
(3) |
22
(8) |
23
(7) |
24
(5) |
25
(4) |
|
26
(6) |
27
|
28
(9) |
29
|
30
(4) |
31
(5) |
|
|
From: Nicholas N. <n.n...@gm...> - 2023-03-22 23:09:11
|
All the Rust projects I work on use GitHub, and in terms of usability and productivity it's miles ahead of how Valgrind development works. If I were king of the world here's how I would drag Valgrind's development practices forward by 10-20 years. - Move the repository to GitHub. Require all changes to be done via pull requests, with no direct pushing. - Set up some CI testing via GitHub Actions. Require that all pull requests pass these tests before merging. - Lots of projects require a review approval before a pull request can be merged. But that might be too hard for Valgrind to start with, given the small number of active contributors. - Switch from KDE bugzilla to GitHub issues for bug reporting. Not sure what I'd do with existing open bug reports, whether it would be worth importing them to GitHub issues somehow or not. - Use auto-formatting tools, such as clang-format. (Possibly even moving from 3 space indents in C code to 2 or 4!) - Change the docs from that XML-based thing we use (groan) to something nicer, probably involving Markdown. - Website: not sure... a lot of it could be naturally hosted on the main GitHub page. It might be nice to still have valgrind.org, though, but perhaps greatly stripped back. I understand the concerns about GitHub and commercialization, but I also worry about Valgrind's future viability if it doesn't attract some level of new contributors. The Linux kernel will never have that problem, but I suspect lots of GNU projects also face that risk. Nick On Thu, 23 Mar 2023 at 08:19, Paul Floyd <pj...@wa...> wrote: > > > On 22-03-23 21:31, Nicholas Nethercote wrote: > > Thanks to Paul and Mark for a couple of small fixes to my commit. > > > > Yesterday I was idly dreaming about the quality-of-life improvements > > that would be available if Valgrind was hosted on GitHub: > > - ability to upload commits ahead of time, in a fashion nicer than > > "attach patch to bugzilla" > > - ability to do reviews > > - CI support for pre-merge testing runs > > - easier entry for newcomers > > > > Does sourceware.org <http://sourceware.org> have support for any of > > these things? > > Hi > > GH does have a lot going for it, and when they add code browsing it will > be even better. One concern though is their owner and creeping > commercialization. > > As far as I know, a lot of GNU projects and Linux still work mostly by > by patches sent to mailing lists. > > One other fairly common system is phabricator (used by LLVM and FreeBSD > amonst others). However, the company that developed phabricator closed > down so I don't know where that is going (there is a fork). FWIW FreeBSD > is increasingly using GH. > > A+ > Paul > > > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |
|
From: Nicholas N. <n.n...@gm...> - 2023-03-22 22:52:55
|
Thanks for the suggestion. I have removed the use of `TypeAlias` like you suggested, and documented version expectations. Nick On Thu, 23 Mar 2023 at 08:03, Paul Floyd <pj...@wa...> wrote: > > > On 22-03-23 00:22, Nicholas Nethercote wrote: > > I have merged the new version of `cg_annotate`: > > > https://sourceware.org/git/?p=valgrind.git;a=commit;h=4650b7949ae3a41326e52ae454a9202493c41444 > < > https://sourceware.org/git/?p=valgrind.git;a=commit;h=4650b7949ae3a41326e52ae454a9202493c41444 > > > > Hi Nick > > I've seen two problems. The first I've already fixed with "env". > > The other is with typing / TypeAlias. This was added in Python 3.10. On > my FreeBSD system "python3" defaults to Python 3.9, so I get > > ImportError: cannot import name 'TypeAlias' from 'typing' > (/usr/local/lib/python3.9/typing.py) > > That will probably also cause problems on old Linux systems as well. > > I don't know much Python, but would it be OK to use non-explicit > (implicit?) type aliases like in the diff below: > > The alternative would be to add python3.10 detection, something like > > AC_CHECK_PROGS([PYTHON3],[python3.10 python3] > > and then to use @PYTHON3@ in cg_annotate.in and the 3 ann[123]/vgtest > files. > > A+ > Paul > > > > diff --git a/cachegrind/cg_annotate.in b/cachegrind/cg_annotate.in > index 91d75aecd..c3d5f71d4 100755 > --- a/cachegrind/cg_annotate.in > +++ b/cachegrind/cg_annotate.in > @@ -73,7 +73,7 @@ import re > import sys > from argparse import ArgumentParser, BooleanOptionalAction, Namespace > from collections import defaultdict > -from typing import Callable, DefaultDict, NewType, NoReturn, TextIO, > TypeAlias > +from typing import Callable, DefaultDict, NewType, NoReturn, TextIO > > > class Args(Namespace): > @@ -323,11 +323,11 @@ class Cc: > Flfn = NewType("Flfn", tuple[str, str]) > > # Per-function CCs. > -DictFlfnCc: TypeAlias = DefaultDict[Flfn, Cc] > +DictFlfnCc = DefaultDict[Flfn, Cc] > > # Per-line CCs, organised by filename and line number. > -DictLineCc: TypeAlias = DefaultDict[int, Cc] > -DictFlDictLineCc: TypeAlias = DefaultDict[str, DictLineCc] > +DictLineCc = DefaultDict[int, Cc] > +DictFlDictLineCc = DefaultDict[str, DictLineCc] > > > def die(msg: str) -> NoReturn: > > > > A+ > Paul > > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > |
|
From: Nicholas N. <nj...@so...> - 2023-03-22 22:51:47
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=e9e7b663fb69075a110963d85726389f469fcf5b commit e9e7b663fb69075a110963d85726389f469fcf5b Author: Nicholas Nethercote <n.n...@gm...> Date: Thu Mar 23 09:50:21 2023 +1100 Make `cg_annotate` work with Python 3.9, by avoiding `TypeAlias`. Diff: --- cachegrind/cg_annotate.in | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/cachegrind/cg_annotate.in b/cachegrind/cg_annotate.in index 91d75aecdf..20969f0f92 100755 --- a/cachegrind/cg_annotate.in +++ b/cachegrind/cg_annotate.in @@ -34,6 +34,10 @@ This script reads Cachegrind output files and produces human-readable reports. # formatters, type-checkers, and linters on `cg_annotate.in` and then generates # `cg_annotate`. # +# Python versions: Currently this script targets Python 3.9 and later versions. +# Consequences of this: +# - No use of `TypeAlias` for explicit type aliases, which requires 3.10. +# # The following Python tools are used. All can be installed with `pip3 install # $NAME`, except `cProfile` which is built into Python. # @@ -73,7 +77,7 @@ import re import sys from argparse import ArgumentParser, BooleanOptionalAction, Namespace from collections import defaultdict -from typing import Callable, DefaultDict, NewType, NoReturn, TextIO, TypeAlias +from typing import Callable, DefaultDict, NewType, NoReturn, TextIO class Args(Namespace): @@ -323,11 +327,13 @@ class Cc: Flfn = NewType("Flfn", tuple[str, str]) # Per-function CCs. -DictFlfnCc: TypeAlias = DefaultDict[Flfn, Cc] +# Note: not using `TypeAlias`. See "Python versions" comment above. +DictFlfnCc = DefaultDict[Flfn, Cc] # Per-line CCs, organised by filename and line number. -DictLineCc: TypeAlias = DefaultDict[int, Cc] -DictFlDictLineCc: TypeAlias = DefaultDict[str, DictLineCc] +# Note: not using `TypeAlias`. See "Python versions" comment above. +DictLineCc = DefaultDict[int, Cc] +DictFlDictLineCc = DefaultDict[str, DictLineCc] def die(msg: str) -> NoReturn: |
|
From: Paul F. <pj...@wa...> - 2023-03-22 21:18:25
|
On 22-03-23 21:31, Nicholas Nethercote wrote: > Thanks to Paul and Mark for a couple of small fixes to my commit. > > Yesterday I was idly dreaming about the quality-of-life improvements > that would be available if Valgrind was hosted on GitHub: > - ability to upload commits ahead of time, in a fashion nicer than > "attach patch to bugzilla" > - ability to do reviews > - CI support for pre-merge testing runs > - easier entry for newcomers > > Does sourceware.org <http://sourceware.org> have support for any of > these things? Hi GH does have a lot going for it, and when they add code browsing it will be even better. One concern though is their owner and creeping commercialization. As far as I know, a lot of GNU projects and Linux still work mostly by by patches sent to mailing lists. One other fairly common system is phabricator (used by LLVM and FreeBSD amonst others). However, the company that developed phabricator closed down so I don't know where that is going (there is a fork). FWIW FreeBSD is increasingly using GH. A+ Paul |
|
From: Paul F. <pj...@wa...> - 2023-03-22 21:02:53
|
On 22-03-23 00:22, Nicholas Nethercote wrote: > I have merged the new version of `cg_annotate`: > https://sourceware.org/git/?p=valgrind.git;a=commit;h=4650b7949ae3a41326e52ae454a9202493c41444 <https://sourceware.org/git/?p=valgrind.git;a=commit;h=4650b7949ae3a41326e52ae454a9202493c41444> Hi Nick I've seen two problems. The first I've already fixed with "env". The other is with typing / TypeAlias. This was added in Python 3.10. On my FreeBSD system "python3" defaults to Python 3.9, so I get ImportError: cannot import name 'TypeAlias' from 'typing' (/usr/local/lib/python3.9/typing.py) That will probably also cause problems on old Linux systems as well. I don't know much Python, but would it be OK to use non-explicit (implicit?) type aliases like in the diff below: The alternative would be to add python3.10 detection, something like AC_CHECK_PROGS([PYTHON3],[python3.10 python3] and then to use @PYTHON3@ in cg_annotate.in and the 3 ann[123]/vgtest files. A+ Paul diff --git a/cachegrind/cg_annotate.in b/cachegrind/cg_annotate.in index 91d75aecd..c3d5f71d4 100755 --- a/cachegrind/cg_annotate.in +++ b/cachegrind/cg_annotate.in @@ -73,7 +73,7 @@ import re import sys from argparse import ArgumentParser, BooleanOptionalAction, Namespace from collections import defaultdict -from typing import Callable, DefaultDict, NewType, NoReturn, TextIO, TypeAlias +from typing import Callable, DefaultDict, NewType, NoReturn, TextIO class Args(Namespace): @@ -323,11 +323,11 @@ class Cc: Flfn = NewType("Flfn", tuple[str, str]) # Per-function CCs. -DictFlfnCc: TypeAlias = DefaultDict[Flfn, Cc] +DictFlfnCc = DefaultDict[Flfn, Cc] # Per-line CCs, organised by filename and line number. -DictLineCc: TypeAlias = DefaultDict[int, Cc] -DictFlDictLineCc: TypeAlias = DefaultDict[str, DictLineCc] +DictLineCc = DefaultDict[int, Cc] +DictFlDictLineCc = DefaultDict[str, DictLineCc] def die(msg: str) -> NoReturn: A+ Paul |
|
From: Nicholas N. <n.n...@gm...> - 2023-03-22 20:32:11
|
Thanks to Paul and Mark for a couple of small fixes to my commit. Yesterday I was idly dreaming about the quality-of-life improvements that would be available if Valgrind was hosted on GitHub: - ability to upload commits ahead of time, in a fashion nicer than "attach patch to bugzilla" - ability to do reviews - CI support for pre-merge testing runs - easier entry for newcomers Does sourceware.org have support for any of these things? Nick On Wed, 22 Mar 2023 at 10:22, Nicholas Nethercote <n.n...@gm...> wrote: > I have merged the new version of `cg_annotate`: > > https://sourceware.org/git/?p=valgrind.git;a=commit;h=4650b7949ae3a41326e52ae454a9202493c41444 > > Nick > > On Fri, 17 Mar 2023 at 16:24, Nicholas Nethercote <n.n...@gm...> > wrote: > >> I have finished the rewrite. I am happy with the new code, it is much >> better than the old code. You can see it at >> https://bugs.kde.org/show_bug.cgi?id=467472. I plan to merge it by the >> end of next week, and I am happy to hear any suggestions. >> >> I also have some good news about the `cg_annotate.in`/`cg_annotate` >> split. I learned that you can generate the latter from the former very >> quickly with `config.status cachegrind/cg_annotate.in`. Also, this can >> be done automatically from some make targets. So I ended up creating a new >> make target `make ann` that can be run within the `cachegrind` directory. >> It runs the various Python formatters, type-checkers, and linters I am >> using on `cg_annotate.in` and then generates `cg_annotate`. It's a >> one-step "build" command that runs quickly, which is great. >> >> Nick >> >> On Wed, 15 Mar 2023 at 06:15, Nicholas Nethercote <n.n...@gm...> >> wrote: >> >>> On Sun, 12 Mar 2023 at 23:01, Paul Floyd <pj...@wa...> wrote: >>> >>>> >>>> The only think I can think of to get the version is to use something >>>> like >>>> >>>> pkg-config --modversion valgrind >>>> >>> >>> Thanks for the suggestion. Unfortunately this could cause misleading >>> results. E.g. if I have Valgrind installed on my system but I also have a >>> development version, when I run the development version of `cg_annotate >>> --version` it will claim to be the installed version. I think the `@VERSION@` >>> junk is unavoidable. >>> >>> Nick >>> >> |
|
From: Paul F. <pa...@so...> - 2023-03-22 19:44:49
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=bb35cd572f7f805eb55160ad13e5bf8f1c174499 commit bb35cd572f7f805eb55160ad13e5bf8f1c174499 Author: Paul Floyd <pj...@wa...> Date: Wed Mar 22 20:43:30 2023 +0100 Make cg_annotate independent of python3 install location Diff: --- cachegrind/cg_annotate.in | 2 +- cachegrind/tests/ann1.vgtest | 2 +- cachegrind/tests/ann2.vgtest | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cachegrind/cg_annotate.in b/cachegrind/cg_annotate.in index 247026f1fa..91d75aecdf 100755 --- a/cachegrind/cg_annotate.in +++ b/cachegrind/cg_annotate.in @@ -1,4 +1,4 @@ -#! /usr/bin/python3 +#! /usr/bin/env python3 # pyright: strict # -------------------------------------------------------------------- diff --git a/cachegrind/tests/ann1.vgtest b/cachegrind/tests/ann1.vgtest index e3e574276a..660f524f09 100644 --- a/cachegrind/tests/ann1.vgtest +++ b/cachegrind/tests/ann1.vgtest @@ -2,5 +2,5 @@ # the post-processing of the cgout-test file. prog: ../../tests/true vgopts: --cachegrind-out-file=cachegrind.out -post: touch cgout-test && perl ../../cachegrind/cg_annotate --show=Ir,I1mr,ILmr --show-percs=no cgout-test +post: touch cgout-test && python3 ../../cachegrind/cg_annotate --show=Ir,I1mr,ILmr --show-percs=no cgout-test cleanup: rm cachegrind.out diff --git a/cachegrind/tests/ann2.vgtest b/cachegrind/tests/ann2.vgtest index 7cf1b7fcd3..9ef76e38e9 100644 --- a/cachegrind/tests/ann2.vgtest +++ b/cachegrind/tests/ann2.vgtest @@ -2,5 +2,5 @@ # the post-processing of the cgout-test file. prog: ../../tests/true vgopts: --cachegrind-out-file=cachegrind.out -post: touch cgout-test && perl ../../cachegrind/cg_annotate --sort=Dr --show=Dw,Dr,Ir --auto=no cgout-test a.c +post: touch cgout-test && python3 ../../cachegrind/cg_annotate --sort=Dr --show=Dw,Dr,Ir --auto=no cgout-test a.c cleanup: rm cachegrind.out |
|
From: Mark W. <ma...@so...> - 2023-03-22 10:42:36
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=3bb907290aa97ba6b5d776844444c04fcb3a71aa commit 3bb907290aa97ba6b5d776844444c04fcb3a71aa Author: Mark Wielaard <ma...@kl...> Date: Wed Mar 22 11:41:53 2023 +0100 cachegrind/tests/Makefile.am EXTRA_DIST add ann3.{{post,stderr}.exp,vgtest} Diff: --- cachegrind/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/cachegrind/tests/Makefile.am b/cachegrind/tests/Makefile.am index 2ce7426677..ded05c8fdb 100644 --- a/cachegrind/tests/Makefile.am +++ b/cachegrind/tests/Makefile.am @@ -16,6 +16,7 @@ EXTRA_DIST = \ cgout-test \ ann1.post.exp ann1.stderr.exp ann1.vgtest \ ann2.post.exp ann2.stderr.exp ann2.vgtest \ + ann3.post.exp ann3.stderr.exp ann3.vgtest \ chdir.vgtest chdir.stderr.exp \ clreq.vgtest clreq.stderr.exp \ diff.post.exp diff.stderr.exp diff.vgtest \ |