You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(32) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
|
1
(6) |
|
2
(4) |
3
(9) |
4
(11) |
5
(16) |
6
(6) |
7
(1) |
8
(11) |
|
9
(11) |
10
(6) |
11
(10) |
12
(23) |
13
(23) |
14
(6) |
15
(10) |
|
16
(5) |
17
(13) |
18
(9) |
19
(4) |
20
(6) |
21
(16) |
22
(3) |
|
23
(5) |
24
(7) |
25
(6) |
26
(4) |
27
(8) |
28
|
29
(3) |
|
30
(2) |
31
(17) |
|
|
|
|
|
|
From: <sv...@va...> - 2015-08-11 20:37:36
|
Author: florian
Date: Tue Aug 11 21:37:28 2015
New Revision: 15519
Log:
In filter_stderr_basic do not remove lines beginning with
--pid:
i.e. debug output. Asserts originating from the address space
manager look exactly like that and we do not want to filter those
out by default.
Remove some specialised filter scripts that are no longer needed
and update a few .vgtest files accordingly.
Removed:
trunk/none/tests/amd64-linux/filter_minimal
trunk/none/tests/x86-linux/filter_minimal
Modified:
trunk/massif/tests/filter_verbose
trunk/none/tests/amd64-linux/Makefile.am
trunk/none/tests/amd64-linux/bug345887.vgtest
trunk/none/tests/amd64-linux/filter_stderr
trunk/none/tests/amd64-linux/map_32bits.vgtest
trunk/none/tests/x86-linux/Makefile.am
trunk/none/tests/x86-linux/bug345887.vgtest
trunk/tests/filter_stderr_basic
Modified: trunk/massif/tests/filter_verbose
==============================================================================
--- trunk/massif/tests/filter_verbose (original)
+++ trunk/massif/tests/filter_verbose Tue Aug 11 21:37:28 2015
@@ -7,6 +7,9 @@
$dir/filter_stderr |
+# Remove any --pid:0: strings (debuglog level zero output)
+sed "/^--[0-9]\{1,7\}:0:*/d" |
+
# Only print lines that contain "Massif:". The -n means don't print any
# lines by default, and the 'p' means do print those that match the pattern.
sed -n "/Massif:/p" |
Modified: trunk/none/tests/amd64-linux/Makefile.am
==============================================================================
--- trunk/none/tests/amd64-linux/Makefile.am (original)
+++ trunk/none/tests/amd64-linux/Makefile.am Tue Aug 11 21:37:28 2015
@@ -2,7 +2,7 @@
include $(top_srcdir)/Makefile.tool-tests.am
dist_noinst_SCRIPTS = \
- filter_stderr filter_minimal
+ filter_stderr
EXTRA_DIST = \
bug345887.stderr.exp bug345887.vgtest \
Modified: trunk/none/tests/amd64-linux/bug345887.vgtest
==============================================================================
--- trunk/none/tests/amd64-linux/bug345887.vgtest (original)
+++ trunk/none/tests/amd64-linux/bug345887.vgtest Tue Aug 11 21:37:28 2015
@@ -1,4 +1,4 @@
prog: bug345887
vgopts: -q
-stderr_filter: filter_minimal
+stderr_filter: filter_stderr
cleanup: rm -f vgcore.*
Removed: trunk/none/tests/amd64-linux/filter_minimal
==============================================================================
--- trunk/none/tests/amd64-linux/filter_minimal (original)
+++ trunk/none/tests/amd64-linux/filter_minimal (removed)
@@ -1,20 +0,0 @@
-#! /bin/sh
-
-dir=`dirname $0`
-
-# Remove ==pid== and **pid** strings
-perl -p -e 's/(==|\*\*)[0-9]{1,7}\1 //' |
-
-perl -p -e 's/0x[0-9A-Fa-f]+/0x......../g' |
-
-# Older bash versions print abnormal termination messages on the stderr
-# of the bash process. Newer bash versions redirect such messages properly.
-# Suppress any redirected abnormal termination messages. You can find the
-# complete list of messages in the bash source file siglist.c.
-perl -n -e 'print if !/^(Segmentation fault|Alarm clock|Aborted|Bus error)( \(core dumped\))?$/' |
-
-# Remove the size in "The main thread stack size..." message.
-sed "s/The main thread stack size used in this run was [0-9]*/The main thread stack size used in this run was .../"
-
-# NOTE: it is essential for the bug345887 testcase that the stderr
-# filtering does *not* remove lines beginning with --
Modified: trunk/none/tests/amd64-linux/filter_stderr
==============================================================================
--- trunk/none/tests/amd64-linux/filter_stderr (original)
+++ trunk/none/tests/amd64-linux/filter_stderr Tue Aug 11 21:37:28 2015
@@ -2,10 +2,5 @@
dir=`dirname $0`
-# Remove ==pid== and --pid-- and **pid** strings
-perl -p -e 's/(==|--|\*\*)[0-9]{1,7}\1 //' |
-
-perl -p -e 's/0x[0-9A-Fa-f]+/0x......../g'
-
-# NOTE: it is essential for the bug345887 testcase that the stderr
-# filtering does *not* remove lines beginning with --
+$dir/../../../tests/filter_stderr_basic |
+$dir/../../../tests/filter_addresses
Modified: trunk/none/tests/amd64-linux/map_32bits.vgtest
==============================================================================
--- trunk/none/tests/amd64-linux/map_32bits.vgtest (original)
+++ trunk/none/tests/amd64-linux/map_32bits.vgtest Tue Aug 11 21:37:28 2015
@@ -1,5 +1,5 @@
prog: map_32bits
# take a big aspacemgr minaddr, to quickly reach the 2GB limit
vgopts: -q --aspace-minaddr=0x7ff60000
-stderr_filter: filter_minimal
+stderr_filter: filter_stderr
Modified: trunk/none/tests/x86-linux/Makefile.am
==============================================================================
--- trunk/none/tests/x86-linux/Makefile.am (original)
+++ trunk/none/tests/x86-linux/Makefile.am Tue Aug 11 21:37:28 2015
@@ -2,7 +2,7 @@
include $(top_srcdir)/Makefile.tool-tests.am
dist_noinst_SCRIPTS = \
- filter_stderr filter_minimal
+ filter_stderr
EXTRA_DIST = \
bug345887.stderr.exp bug345887.vgtest \
Modified: trunk/none/tests/x86-linux/bug345887.vgtest
==============================================================================
--- trunk/none/tests/x86-linux/bug345887.vgtest (original)
+++ trunk/none/tests/x86-linux/bug345887.vgtest Tue Aug 11 21:37:28 2015
@@ -1,4 +1,4 @@
prog: bug345887
vgopts: -q
-stderr_filter: filter_minimal
+stderr_filter: filter_stderr
cleanup: rm -f vgcore.*
Removed: trunk/none/tests/x86-linux/filter_minimal
==============================================================================
--- trunk/none/tests/x86-linux/filter_minimal (original)
+++ trunk/none/tests/x86-linux/filter_minimal (removed)
@@ -1,20 +0,0 @@
-#! /bin/sh
-
-dir=`dirname $0`
-
-# Remove ==pid== and **pid** strings
-perl -p -e 's/(==|\*\*)[0-9]{1,7}\1 //' |
-
-perl -p -e 's/0x[0-9A-Fa-f]+/0x......../g' |
-
-# Older bash versions print abnormal termination messages on the stderr
-# of the bash process. Newer bash versions redirect such messages properly.
-# Suppress any redirected abnormal termination messages. You can find the
-# complete list of messages in the bash source file siglist.c.
-perl -n -e 'print if !/^(Segmentation fault|Alarm clock|Aborted|Bus error)( \(core dumped\))?$/' |
-
-# Remove the size in "The main thread stack size..." message.
-sed "s/The main thread stack size used in this run was [0-9]*/The main thread stack size used in this run was .../"
-
-# NOTE: it is essential for the bug345887 testcase that the stderr
-# filtering does *not* remove lines beginning with --
Modified: trunk/tests/filter_stderr_basic
==============================================================================
--- trunk/tests/filter_stderr_basic (original)
+++ trunk/tests/filter_stderr_basic Tue Aug 11 21:37:28 2015
@@ -12,8 +12,9 @@
# Remove ==pid== and --pid-- and **pid** strings
perl -p -e 's/(==|--|\*\*)[0-9]{1,7}\1 //' |
-# Remove any --pid:0: strings (debuglog level zero output)
-sed "/^--[0-9]\{1,7\}:0:*/d" |
+# Do NOT remove debug level output, i.e. lines beginning with --pid:
+# Doing so would also remove asserts from the address space manager
+# and we always to see those.
# Remove "Command: line". (If wrapping occurs, it won't remove the
# subsequent lines...)
|
|
From: Matthias S. <zz...@ge...> - 2015-08-11 18:10:23
|
Am 11.08.2015 um 04:07 schrieb Bart Van Assche: > On 08/10/15 11:52, Matthias Schwarzott wrote: >> Hi! >> >> I have seen that valgrind.h will missdetect x32 as amd64. >> >> So I wonder if this can cause any bad effects. >> >> If so, the header needs to be protected so it does not emit client >> requests on x32. >> It could be done like this, because the x32 ABI says that __ILP32__ must >> be defined (and it is not defined on amd64). >> See abi.pdf in https://sites.google.com/site/x32abi/documents >> >> Regards >> Matthias >> >> >> --- a/include/valgrind.h >> +++ b/include/valgrind.h >> @@ -140,7 +140,7 @@ >> # define PLAT_amd64_win64 1 >> #elif defined(__linux__) && defined(__i386__) >> # define PLAT_x86_linux 1 >> -#elif defined(__linux__) && defined(__x86_64__) >> +#elif defined(__linux__) && defined(__x86_64__) && !defined(__ILP32__) >> # define PLAT_amd64_linux 1 >> #elif defined(__linux__) && defined(__powerpc__) && >> !defined(__powerpc64__) >> # define PLAT_ppc32_linux 1 > > Hello Matthias, > > Has this patch been tested ? I think if you want the above to work > correctly that you need to swap the x86 and amd64 detection code. > > Bart. > Hello Bart, yes, I did a compile check with a very simple c file calling VALGRIND_PRINTF. Then I compiled this with -m32, -m64 and -mx32. With my modified valgrind.h and using -mx32 the VALGRIND_PRINTF did not leave traces in the executabe. Why should it be necessary to swap amd64 and x86 - it worked already before I touched it and stays like this. And x32 does not define __i386__. But I still don't know if it is necessary to exclude x32 or if it just does not matter. Regards Matthias |
|
From: Yan <ya...@ya...> - 2015-08-11 10:15:28
|
Hi guys, About two years ago, I sent along a link to a project called PyVEX (now here: https://github.com/angr/pyvex), which exposed libVEX in Python for static binary analysis, and talked to some of you about it at FOSDEM 2014. Since then, we (the Computer Security Lab at UC Santa Barbara) have been hard at work building a full-fledged binary analysis framework around VEX. We've used it in a few academic works (for example, to detect backdoors in firmware [1] [2]) and to qualify for the DARPA Cyber Grand Challenge [3]. Last Saturday, at Defcon, we open sourced the whole thing! Here it is: http://angr.io. angr is mostly targeted at static analysis and concolic execution, using VEX as the binary translation layer. For now, we're still hacking up our own branch of VEX to make things work well statically, but it's still on our todo list (manpower is an issue) to propose and implement a nice refactor of VEX so that it's as nice to use statically as it is dynamically. I wanted to let you guys know, in case anyone is interested in playing around with it and using it. We'd love to hear what you think of it and always appreciate issues and pull requests. Thank you for building such a useful library! - Yan [1] http://www.internetsociety.org/doc/firmalice-automatic-detection-authentication-bypass-vulnerabilities-binary-firmware [2] https://www.blackhat.com/us-15/briefings.html#using-static-binary-analysis-to-find-vulnerabilities-and-backdoors-in-firmware [3] http://www.independent.com/news/2015/jul/14/ucsb-hackers-win-750000/ |
|
From: <sv...@va...> - 2015-08-11 09:12:50
|
Author: iraisr
Date: Tue Aug 11 10:12:40 2015
New Revision: 15518
Log:
Add support for repository cache protocol version 26.
Patch contributed by Tomas Jedlicka <jed...@gm...>.
n-i-bz
Modified:
trunk/coregrind/m_syswrap/syswrap-solaris.c
trunk/include/vki/vki-solaris-repcache.h
Modified: trunk/coregrind/m_syswrap/syswrap-solaris.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-solaris.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-solaris.c Tue Aug 11 10:12:40 2015
@@ -28,6 +28,8 @@
The GNU General Public License is contained in the file COPYING.
*/
+/* Copyright 2015-2015, Tomas Jedlicka <jed...@gm...>. */
+
/* Copyright 2013-2015, Ivo Raisr <iv...@iv...>. */
/* Copyright 2013, OmniTI Computer Consulting, Inc. All rights reserved. */
@@ -7818,6 +7820,16 @@
"entity_name->rpr_answertype)", r->rpr_answertype);
}
break;
+ case VKI_REP_PROTOCOL_ENTITY_GET_ROOT:
+ {
+ struct vki_rep_protocol_entity_root *r =
+ (struct vki_rep_protocol_entity_root *) p;
+ PRE_FIELD_READ("door_call(\"" VKI_REPOSITORY_DOOR_NAME "\", "
+ "entity_root->rpr_entityid)", r->rpr_entityid);
+ PRE_FIELD_READ("door_call(\"" VKI_REPOSITORY_DOOR_NAME "\", "
+ "entity_root->rpr_outid)", r->rpr_outid);
+ }
+ break;
case VKI_REP_PROTOCOL_ENTITY_GET:
{
struct vki_rep_protocol_entity_get *r =
Modified: trunk/include/vki/vki-solaris-repcache.h
==============================================================================
--- trunk/include/vki/vki-solaris-repcache.h (original)
+++ trunk/include/vki/vki-solaris-repcache.h Tue Aug 11 10:12:40 2015
@@ -28,6 +28,8 @@
The GNU General Public License is contained in the file COPYING.
*/
+/* Copyright 2015-2015, Tomas Jedlicka <jed...@gm...>. */
+
#ifndef __VKI_SOLARIS_REPCACHE_H
#define __VKI_SOLARIS_REPCACHE_H
@@ -175,6 +177,60 @@
VKI_REP_PROTOCOL_ENTITY_IS_MASKED,
VKI_REP_PROTOCOL_CLIENT_REMOVE_NOTIFY,
};
+#elif (SOLARIS_REPCACHE_PROTOCOL_VERSION == 26)
+#define VKI_REPOSITORY_DOOR_VERSION (26 + VKI_REPOSITORY_DOOR_BASEVER)
+enum vki_rep_protocol_requestid {
+ VKI_REP_PROTOCOL_CLOSE = ('C' << 8),
+ VKI_REP_PROTOCOL_ENTITY_SETUP,
+ VKI_REP_PROTOCOL_ENTITY_NAME,
+ VKI_REP_PROTOCOL_ENTITY_FMRI,
+ VKI_REP_PROTOCOL_ENTITY_PARENT_TYPE,
+ VKI_REP_PROTOCOL_ENTITY_GET_CHILD,
+ VKI_REP_PROTOCOL_ENTITY_GET_PARENT,
+ VKI_REP_PROTOCOL_ENTITY_GET_ROOT,
+ VKI_REP_PROTOCOL_ENTITY_GET,
+ VKI_REP_PROTOCOL_ENTITY_UPDATE,
+ VKI_REP_PROTOCOL_ENTITY_CREATE_CHILD,
+ VKI_REP_PROTOCOL_ENTITY_CREATE_PG,
+ VKI_REP_PROTOCOL_ENTITY_DELETE,
+ VKI_REP_PROTOCOL_ENTITY_UNDELETE,
+ VKI_REP_PROTOCOL_ENTITY_REMOVE,
+ VKI_REP_PROTOCOL_ENTITY_DELCUST,
+ VKI_REP_PROTOCOL_BUNDLE_REMOVE,
+ VKI_REP_PROTOCOL_ENTITY_RESET,
+ VKI_REP_PROTOCOL_ENTITY_TEARDOWN,
+ VKI_REP_PROTOCOL_ITER_SETUP,
+ VKI_REP_PROTOCOL_ITER_START,
+ VKI_REP_PROTOCOL_ITER_READ,
+ VKI_REP_PROTOCOL_ITER_READ_VALUE,
+ VKI_REP_PROTOCOL_ITER_RESET,
+ VKI_REP_PROTOCOL_ITER_TEARDOWN,
+ VKI_REP_PROTOCOL_NEXT_SNAPLEVEL,
+ VKI_REP_PROTOCOL_SNAPSHOT_TAKE,
+ VKI_REP_PROTOCOL_SNAPSHOT_TAKE_NAMED,
+ VKI_REP_PROTOCOL_SNAPSHOT_ATTACH,
+ VKI_REP_PROTOCOL_PROPERTY_GET_TYPE,
+ VKI_REP_PROTOCOL_PROPERTY_GET_VALUE,
+ VKI_REP_PROTOCOL_PG_SETUP_WAIT,
+ VKI_REP_PROTOCOL_PG_TX_START,
+ VKI_REP_PROTOCOL_PG_TX_COMMIT,
+ VKI_REP_PROTOCOL_PROP_BUNDLE_REMOVE,
+ VKI_REP_PROTOCOL_CLIENT_ADD_NOTIFY,
+ VKI_REP_PROTOCOL_CLIENT_WAIT,
+ VKI_REP_PROTOCOL_BACKUP,
+ VKI_REP_PROTOCOL_SET_AUDIT_ANNOTATION,
+ VKI_REP_PROTOCOL_UNSET_AUDIT_ANNOTATION,
+ VKI_REP_PROTOCOL_SET_TX_DECORATION,
+ VKI_REP_PROTOCOL_SWITCH,
+ VKI_REP_PROTOCOL_DECORATION_GET_LAYER,
+ VKI_REP_PROTOCOL_DECORATION_GET_TYPE,
+ VKI_REP_PROTOCOL_DECORATION_GET_VALUE,
+ VKI_REP_PROTOCOL_DECORATION_GET_BUNDLE,
+ VKI_REP_PROTOCOL_ENTITY_INCONFLICT,
+ VKI_REP_PROTOCOL_ENTITY_IS_MASKED,
+ VKI_REP_PROTOCOL_CLIENT_REMOVE_NOTIFY,
+ VKI_REP_PROTOCOL_MAX_REQUEST
+};
#else
#error Unsupported repcache protocol version
#endif
@@ -230,6 +286,11 @@
vki_uint32_t rpr_entityid;
vki_uint32_t rpr_outid;
};
+struct vki_rep_protocol_entity_root {
+ enum vki_rep_protocol_requestid rpr_request;
+ vki_uint32_t rpr_entityid;
+ vki_uint32_t rpr_outid;
+};
struct vki_rep_protocol_entity_reset {
enum vki_rep_protocol_requestid rpr_request;
vki_uint32_t rpr_entityid;
|
|
From: Bart V. A. <bva...@ac...> - 2015-08-11 02:08:13
|
On 08/10/15 11:52, Matthias Schwarzott wrote: > Hi! > > I have seen that valgrind.h will missdetect x32 as amd64. > > So I wonder if this can cause any bad effects. > > If so, the header needs to be protected so it does not emit client > requests on x32. > It could be done like this, because the x32 ABI says that __ILP32__ must > be defined (and it is not defined on amd64). > See abi.pdf in https://sites.google.com/site/x32abi/documents > > Regards > Matthias > > > --- a/include/valgrind.h > +++ b/include/valgrind.h > @@ -140,7 +140,7 @@ > # define PLAT_amd64_win64 1 > #elif defined(__linux__) && defined(__i386__) > # define PLAT_x86_linux 1 > -#elif defined(__linux__) && defined(__x86_64__) > +#elif defined(__linux__) && defined(__x86_64__) && !defined(__ILP32__) > # define PLAT_amd64_linux 1 > #elif defined(__linux__) && defined(__powerpc__) && !defined(__powerpc64__) > # define PLAT_ppc32_linux 1 Hello Matthias, Has this patch been tested ? I think if you want the above to work correctly that you need to swap the x86 and amd64 detection code. Bart. |
|
From: Carl E. L. <ce...@us...> - 2015-08-10 21:33:40
|
On Mon, 2015-08-10 at 19:41 +0200, Florian Krohm wrote:
> On 10.08.2015 18:46, Carl E. Love wrote:
> >
> > I ran .configure and make. I captured the output from make and looked through it but
> > didn't find any errors related to the checking. The system I ran on was:
> >
> > Power 8 Little Endian
> > Linux 3.13.0-35-generic #62-Ubuntu SMP Fri Aug 15 01:57:29 UTC 2014 ppc64le GNU/Linux
> >
> > gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
> >
> > I tried again with the latest GCC I can find which is available via the IBM advanced
> > tool chain.
> >
> > gcc (GCC) 5.1.1 20150512
> >
> > Again, I didn't find any error messages in the output from make.
> >
> > Let me know if I am looking in the right place or didn't set things up correctly.
>
> Carl,
>
> thanks for testing! I think you did it just right. make -s is what I
> usually do when I'm looking for warnings or errors. But you probably did
> that anyways.. One thing: these inconsistencies would be reported as
> warning not as error.
> I was wondering whether we should also test on ppc64be? You have a
> better feeling as to whether that wold be worth it. I have bo sense for
> how much code is in common between big endian and little endian. So I'll
> leave it to you to decide.
>
> Thanks again
>
> Florian
>
Florian:
I went back an rechecked for warnings as well as errors. I didn't find
any warnings. I retested with make -s and checked for warnings and
errors and didn't see anything.
I then did the same on a Power 7 big endian machine. Again no warnings
or errors were found.
Carl Love
|
|
From: Matthias S. <zz...@ge...> - 2015-08-10 19:54:10
|
Copy a block from tests/filter_stderr_basic --- none/tests/amd64-linux/filter_minimal | 4 ++++ none/tests/x86-linux/filter_minimal | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/none/tests/amd64-linux/filter_minimal b/none/tests/amd64-linux/filter_minimal index e69398c..e09882c 100755 --- a/none/tests/amd64-linux/filter_minimal +++ b/none/tests/amd64-linux/filter_minimal @@ -13,6 +13,10 @@ perl -p -e 's/0x[0-9A-Fa-f]+/0x......../g' | # complete list of messages in the bash source file siglist.c. perl -n -e 'print if !/^(Segmentation fault|Alarm clock|Aborted|Bus error)( \(core dumped\))?$/' | +# Remove any ": dumping core" message as the user might have a +# limit set that prevents the core dump +sed "s/\(signal [0-9]* (SIG[A-Z]*)\): dumping core/\1/" | + # Remove the size in "The main thread stack size..." message. sed "s/The main thread stack size used in this run was [0-9]*/The main thread stack size used in this run was .../" diff --git a/none/tests/x86-linux/filter_minimal b/none/tests/x86-linux/filter_minimal index e69398c..e09882c 100755 --- a/none/tests/x86-linux/filter_minimal +++ b/none/tests/x86-linux/filter_minimal @@ -13,6 +13,10 @@ perl -p -e 's/0x[0-9A-Fa-f]+/0x......../g' | # complete list of messages in the bash source file siglist.c. perl -n -e 'print if !/^(Segmentation fault|Alarm clock|Aborted|Bus error)( \(core dumped\))?$/' | +# Remove any ": dumping core" message as the user might have a +# limit set that prevents the core dump +sed "s/\(signal [0-9]* (SIG[A-Z]*)\): dumping core/\1/" | + # Remove the size in "The main thread stack size..." message. sed "s/The main thread stack size used in this run was [0-9]*/The main thread stack size used in this run was .../" -- 2.5.0 |
|
From: Matthias S. <zz...@ge...> - 2015-08-10 19:44:01
|
Each testcase that crashes should delete vgcore files --- gdbserver_tests/nlgone_abrt.vgtest | 1 + memcheck/tests/deep-backtrace.vgtest | 1 + none/tests/linux/blockfault.vgtest | 1 + none/tests/linux/stack-overflow.vgtest | 1 + none/tests/x86-linux/hang.vgtest | 1 + 5 files changed, 5 insertions(+) diff --git a/gdbserver_tests/nlgone_abrt.vgtest b/gdbserver_tests/nlgone_abrt.vgtest index 86aecfd..e1e9f24 100644 --- a/gdbserver_tests/nlgone_abrt.vgtest +++ b/gdbserver_tests/nlgone_abrt.vgtest @@ -10,3 +10,4 @@ argsB: --quiet -l 60 --nx ./gone stdinB: nlgone_abrt.stdinB.gdb stdoutB_filter: filter_gdb stderrB_filter: filter_gdb +cleanup: rm -f vgcore.* diff --git a/memcheck/tests/deep-backtrace.vgtest b/memcheck/tests/deep-backtrace.vgtest index ebeccf9..a3fd1df 100644 --- a/memcheck/tests/deep-backtrace.vgtest +++ b/memcheck/tests/deep-backtrace.vgtest @@ -1,2 +1,3 @@ prog: deep-backtrace vgopts: -q --num-callers=500 +cleanup: rm -f vgcore.* diff --git a/none/tests/linux/blockfault.vgtest b/none/tests/linux/blockfault.vgtest index 88e3255..8d10f1a 100644 --- a/none/tests/linux/blockfault.vgtest +++ b/none/tests/linux/blockfault.vgtest @@ -1 +1,2 @@ prog: blockfault +cleanup: rm -f vgcore.* diff --git a/none/tests/linux/stack-overflow.vgtest b/none/tests/linux/stack-overflow.vgtest index 3b9ffd4..e7b4f29 100644 --- a/none/tests/linux/stack-overflow.vgtest +++ b/none/tests/linux/stack-overflow.vgtest @@ -1 +1,2 @@ prog: stack-overflow +cleanup: rm -f vgcore.* diff --git a/none/tests/x86-linux/hang.vgtest b/none/tests/x86-linux/hang.vgtest index c3678bb..9b17ae0 100644 --- a/none/tests/x86-linux/hang.vgtest +++ b/none/tests/x86-linux/hang.vgtest @@ -3,3 +3,4 @@ # Can only be reproduced on an x86 box running a 32-bit kernel. prog: hang vgopts: -q +cleanup: rm -f vgcore.* -- 2.5.0 |
|
From: Matthias S. <zz...@ge...> - 2015-08-10 18:52:52
|
Hi! I have seen that valgrind.h will missdetect x32 as amd64. So I wonder if this can cause any bad effects. If so, the header needs to be protected so it does not emit client requests on x32. It could be done like this, because the x32 ABI says that __ILP32__ must be defined (and it is not defined on amd64). See abi.pdf in https://sites.google.com/site/x32abi/documents Regards Matthias --- a/include/valgrind.h +++ b/include/valgrind.h @@ -140,7 +140,7 @@ # define PLAT_amd64_win64 1 #elif defined(__linux__) && defined(__i386__) # define PLAT_x86_linux 1 -#elif defined(__linux__) && defined(__x86_64__) +#elif defined(__linux__) && defined(__x86_64__) && !defined(__ILP32__) # define PLAT_amd64_linux 1 #elif defined(__linux__) && defined(__powerpc__) && !defined(__powerpc64__) # define PLAT_ppc32_linux 1 |
|
From: Florian K. <fl...@ei...> - 2015-08-10 17:41:50
|
On 10.08.2015 18:46, Carl E. Love wrote:
>
> I ran .configure and make. I captured the output from make and looked through it but
> didn't find any errors related to the checking. The system I ran on was:
>
> Power 8 Little Endian
> Linux 3.13.0-35-generic #62-Ubuntu SMP Fri Aug 15 01:57:29 UTC 2014 ppc64le GNU/Linux
>
> gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
>
> I tried again with the latest GCC I can find which is available via the IBM advanced
> tool chain.
>
> gcc (GCC) 5.1.1 20150512
>
> Again, I didn't find any error messages in the output from make.
>
> Let me know if I am looking in the right place or didn't set things up correctly.
Carl,
thanks for testing! I think you did it just right. make -s is what I
usually do when I'm looking for warnings or errors. But you probably did
that anyways.. One thing: these inconsistencies would be reported as
warning not as error.
I was wondering whether we should also test on ppc64be? You have a
better feeling as to whether that wold be worth it. I have bo sense for
how much code is in common between big endian and little endian. So I'll
leave it to you to decide.
Thanks again
Florian
|
|
From: Carl E. L. <ce...@us...> - 2015-08-10 16:46:44
|
Florian:
> I've fixed what gcc -Wformat-signedness pointed out on amd64, x86, and
> s390. On the ppc machine I have access to there was no suitable gcc and
> attempting to build 5.1 failed with some strange error message I don't
> recall. Carl, perhaps you have a suitable machine + compiler handy?
I pulled down the latest code in svn. I enabled the checking in the configure.ac
file:
# Disabled for now until all platforms are clean
# carll enabled
format_checking_enabled=yes
if test "$format_checking_enabled" = "yes"; then
AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS])
else
dumy_assignment_to_avoid_syntax_errors=1
AC_SUBST([FLAG_W_FORMAT_SIGNEDNESS], [])
fi
I ran .configure and make. I captured the output from make and looked through it but
didn't find any errors related to the checking. The system I ran on was:
Power 8 Little Endian
Linux 3.13.0-35-generic #62-Ubuntu SMP Fri Aug 15 01:57:29 UTC 2014 ppc64le GNU/Linux
gcc (Ubuntu 4.8.4-2ubuntu1~14.04) 4.8.4
I tried again with the latest GCC I can find which is available via the IBM advanced
tool chain.
gcc (GCC) 5.1.1 20150512
Again, I didn't find any error messages in the output from make.
Let me know if I am looking in the right place or didn't set things up correctly.
Carl Love
|
|
From: <sv...@va...> - 2015-08-09 22:38:00
|
Author: mjw
Date: Sun Aug 9 23:37:52 2015
New Revision: 15517
Log:
Bug #351140 arm64 syscalls setuid (146) and setresgid (149) not implemented.
Modified:
trunk/NEWS
trunk/coregrind/m_syswrap/syswrap-arm64-linux.c
Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS (original)
+++ trunk/NEWS Sun Aug 9 23:37:52 2015
@@ -279,6 +279,7 @@
350811 Remove reference to --db-attach which has been removed.
350813 Use handwritten memcheck assembly helpers on x86/Solaris in addition to {arm,x86}-linux
350854 hard-to-understand code in VG_(load_ELF)()
+351140 arm64 syscalls setuid (146) and setresgid (149) not implemented
n-i-bz Provide implementations of certain compiler builtins to support
compilers who may not provide those
n-i-bz Old STABS code is still being compiled, but never used. Remove it.
Modified: trunk/coregrind/m_syswrap/syswrap-arm64-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-arm64-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-arm64-linux.c Sun Aug 9 23:37:52 2015
@@ -957,8 +957,10 @@
GENX_(__NR_setregid, sys_setregid), // 143
GENX_(__NR_setgid, sys_setgid), // 144
GENX_(__NR_setreuid, sys_setreuid), // 145
+ GENX_(__NR_setuid, sys_setuid), // 146
LINX_(__NR_setresuid, sys_setresuid), // 147
LINXY(__NR_getresuid, sys_getresuid), // 148
+ LINX_(__NR_setresgid, sys_setresgid), // 149
LINXY(__NR_getresgid, sys_getresgid), // 150
GENXY(__NR_times, sys_times), // 153
GENX_(__NR_setpgid, sys_setpgid), // 154
|
|
From: Florian K. <fl...@ei...> - 2015-08-09 20:57:34
|
On 23.07.2015 19:36, Matthias Schwarzott wrote: > An additional comment to memcheck profiling. > > The counter values should be printed unsigned. For same cases it might > even be useful to have 64bit counters instead. Event counters are now 64-bit wide entities (r15516) and are printed as unsigned numbers. Florian |
|
From: <sv...@va...> - 2015-08-09 20:55:46
|
Author: florian
Date: Sun Aug 9 21:55:39 2015
New Revision: 15516
Log:
When profiling memory events in memcheck, event counts larget
than INT_MAX have been observed in practice. Make counters
64 bit entities.
Modified:
trunk/memcheck/mc_include.h
trunk/memcheck/mc_main.c
Modified: trunk/memcheck/mc_include.h
==============================================================================
--- trunk/memcheck/mc_include.h (original)
+++ trunk/memcheck/mc_include.h Sun Aug 9 21:55:39 2015
@@ -320,7 +320,7 @@
MCPE_LAST
};
-extern UInt MC_(event_ctr)[MCPE_LAST];
+extern ULong MC_(event_ctr)[MCPE_LAST];
# define PROF_EVENT(ev) \
do { tl_assert((ev) >= 0 && (ev) < MCPE_LAST); \
Modified: trunk/memcheck/mc_main.c
==============================================================================
--- trunk/memcheck/mc_main.c (original)
+++ trunk/memcheck/mc_main.c Sun Aug 9 21:55:39 2015
@@ -6746,7 +6746,7 @@
#ifdef MC_PROFILE_MEMORY
-UInt MC_(event_ctr)[MCPE_LAST];
+ULong MC_(event_ctr)[MCPE_LAST];
/* Event counter names. Use the name of the function that increases the
event counter. Drop any MC_() and mc_ prefices. */
@@ -6896,7 +6896,7 @@
if (MC_(event_ctr)[i] > 0) {
spaced = False;
++n;
- VG_(printf)( "prof mem event %3d: %9u %s\n",
+ VG_(printf)( "prof mem event %3d: %11llu %s\n",
i, MC_(event_ctr)[i],
MC_(event_ctr_name)[i]);
}
|
|
From: Florian K. <fl...@ei...> - 2015-08-09 20:37:06
|
On 30.07.2015 22:49, Matthias Schwarzott wrote:
> Hi!
>
> I think the error reporting out of replaced functions is a bit inconsistent.
>
> 1. They use different exit-codes in fatal cases:
> * vg_replace_malloc.c: malloc dies with exitcode of 1.
> * vg_replace_malloc.c: panic dies with exitcode of 99.
> * vg_replace_strmem.c: dies with an exitcode of 127.
>
Fixed in r15515.
> 2. Only VALGRIND_PRINTF_BACKTRACE is used so in xml <clientmsg> will
> appear instead of <error>.
>
Parse error.. Perhaps file a bug report with an example. Otherwise, this
will fall through the cracks.
> Is it possible to create an <error> via client requests?
>
I don't think this is possible today but would not rule it out in
general (in the future).
Florian
|
|
From: <sv...@va...> - 2015-08-09 20:29:26
|
Author: florian
Date: Sun Aug 9 21:29:18 2015
New Revision: 15515
Log:
Consistently use exit code 1 (== POSIX's EXIT_FAILURE) if things
go wrong. As we can tell from the error messages what whent wrong
there is no need to have different exit codes to distinguish.
Spotted by Matthias Schwarzott.
Modified:
trunk/coregrind/m_replacemalloc/vg_replace_malloc.c
trunk/shared/vg_replace_strmem.c
Modified: trunk/coregrind/m_replacemalloc/vg_replace_malloc.c
==============================================================================
--- trunk/coregrind/m_replacemalloc/vg_replace_malloc.c (original)
+++ trunk/coregrind/m_replacemalloc/vg_replace_malloc.c Sun Aug 9 21:29:18 2015
@@ -1078,8 +1078,7 @@
static void panic(const char *str)
{
VALGRIND_PRINTF_BACKTRACE("Program aborting because of call to %s\n", str);
- my_exit(99);
- *(volatile int *)0 = 'x';
+ my_exit(1);
}
#define PANIC(soname, fnname) \
Modified: trunk/shared/vg_replace_strmem.c
==============================================================================
--- trunk/shared/vg_replace_strmem.c (original)
+++ trunk/shared/vg_replace_strmem.c Sun Aug 9 21:29:18 2015
@@ -1325,7 +1325,7 @@
VALGRIND_PRINTF_BACKTRACE( \
"*** memmove_chk: buffer overflow detected ***: " \
"program terminated\n"); \
- my_exit(127); \
+ my_exit(1); \
/*NOTREACHED*/ \
return NULL; \
}
@@ -1417,7 +1417,7 @@
VALGRIND_PRINTF_BACKTRACE( \
"*** strcpy_chk: buffer overflow detected ***: " \
"program terminated\n"); \
- my_exit(127); \
+ my_exit(1); \
/*NOTREACHED*/ \
return NULL; \
}
@@ -1452,7 +1452,7 @@
VALGRIND_PRINTF_BACKTRACE( \
"*** stpcpy_chk: buffer overflow detected ***: " \
"program terminated\n"); \
- my_exit(127); \
+ my_exit(1); \
/*NOTREACHED*/ \
return NULL; \
}
@@ -1552,7 +1552,7 @@
VALGRIND_PRINTF_BACKTRACE( \
"*** memcpy_chk: buffer overflow detected ***: " \
"program terminated\n"); \
- my_exit(127); \
+ my_exit(1); \
/*NOTREACHED*/ \
return NULL; \
}
|
|
From: <sv...@va...> - 2015-08-09 16:27:52
|
Author: florian
Date: Sun Aug 9 17:27:44 2015
New Revision: 15514
Log:
Fix a few function declarations.
Modified:
trunk/coregrind/m_debuginfo/debuginfo.c
trunk/include/pub_tool_debuginfo.h
Modified: trunk/coregrind/m_debuginfo/debuginfo.c
==============================================================================
--- trunk/coregrind/m_debuginfo/debuginfo.c (original)
+++ trunk/coregrind/m_debuginfo/debuginfo.c Sun Aug 9 17:27:44 2015
@@ -3666,8 +3666,8 @@
XArray itself.
*/
Bool VG_(get_data_description)(
- /*MOD*/ void* /* really, XArray* of HChar */ dname1v,
- /*MOD*/ void* /* really, XArray* of HChar */ dname2v,
+ /*MOD*/ XArray* /* of HChar */ dname1,
+ /*MOD*/ XArray* /* of HChar */ dname2,
Addr data_addr
)
{
@@ -3681,9 +3681,6 @@
DebugInfo* di;
Word j;
- XArray* dname1 = (XArray*)dname1v;
- XArray* dname2 = (XArray*)dname2v;
-
if (0) VG_(printf)("get_data_description: dataaddr %#lx\n", data_addr);
/* First, see if data_addr is (or is part of) a global variable.
Loop over the DebugInfos we have. Check data_addr against the
@@ -3978,8 +3975,8 @@
point. If 'arrays_only' is True, only array-typed blocks are
returned; otherwise blocks of all types are returned. */
-void* /* really, XArray* of StackBlock */
- VG_(di_get_stack_blocks_at_ip)( Addr ip, Bool arrays_only )
+XArray* /* of StackBlock */
+VG_(di_get_stack_blocks_at_ip)( Addr ip, Bool arrays_only )
{
/* This is a derivation of consider_vars_in_frame() above. */
Word i;
@@ -4092,9 +4089,8 @@
array-typed blocks are returned; otherwise blocks of all types are
returned. */
-void* /* really, XArray* of GlobalBlock */
- VG_(di_get_global_blocks_from_dihandle) ( ULong di_handle,
- Bool arrays_only )
+XArray* /* of GlobalBlock */
+VG_(di_get_global_blocks_from_dihandle) ( ULong di_handle, Bool arrays_only )
{
/* This is a derivation of consider_vars_in_frame() above. */
Modified: trunk/include/pub_tool_debuginfo.h
==============================================================================
--- trunk/include/pub_tool_debuginfo.h (original)
+++ trunk/include/pub_tool_debuginfo.h Sun Aug 9 17:27:44 2015
@@ -32,6 +32,7 @@
#define __PUB_TOOL_DEBUGINFO_H
#include "pub_tool_basics.h" // VG_ macro
+#include "pub_tool_xarray.h" // XArray
/*====================================================================*/
/*=== Obtaining debug information ===*/
@@ -113,8 +114,8 @@
XArray itself.
*/
Bool VG_(get_data_description)(
- /*MOD*/ void* /* really, XArray* of HChar */ dname1v,
- /*MOD*/ void* /* really, XArray* of HChar */ dname2v,
+ /*MOD*/ XArray* /* of HChar */ dname1v,
+ /*MOD*/ XArray* /* of HChar */ dname2v,
Addr data_addr
);
@@ -178,8 +179,8 @@
}
StackBlock;
-extern void* /* really, XArray* of StackBlock */
- VG_(di_get_stack_blocks_at_ip)( Addr ip, Bool arrays_only );
+extern XArray* /* of StackBlock */
+VG_(di_get_stack_blocks_at_ip)( Addr ip, Bool arrays_only );
/* Get an array of GlobalBlock which describe the global blocks owned
@@ -199,7 +200,7 @@
}
GlobalBlock;
-extern void* /* really, XArray* of GlobalBlock */
+extern XArray* /* of GlobalBlock */
VG_(di_get_global_blocks_from_dihandle) ( ULong di_handle,
Bool arrays_only );
|
|
From: <sv...@va...> - 2015-08-09 14:43:41
|
Author: philippe
Date: Sun Aug 9 15:43:33 2015
New Revision: 15513
Log:
Remove duplicate definition ofVALGRIND_HG_ENABLE_CHECKING , wrongly introduced in rev 15207
Modified:
trunk/helgrind/helgrind.h
Modified: trunk/helgrind/helgrind.h
==============================================================================
--- trunk/helgrind/helgrind.h (original)
+++ trunk/helgrind/helgrind.h Sun Aug 9 15:43:33 2015
@@ -398,12 +398,6 @@
unsigned long,(_qzz_len))
-#define VALGRIND_HG_ENABLE_CHECKING(_qzz_start, _qzz_len) \
- DO_CREQ_v_WW(_VG_USERREQ__HG_ARANGE_MAKE_TRACKED, \
- void*,(_qzz_start), \
- unsigned long,(_qzz_len))
-
-
/* Checks the accessibility bits for addresses [zza..zza+zznbytes-1].
If zzabits array is provided, copy the accessibility bits in zzabits.
Return values:
|
|
From: <sv...@va...> - 2015-08-09 08:54:35
|
Author: florian
Date: Sun Aug 9 09:54:27 2015
New Revision: 15512
Log:
Fix another GCC 5.1 warning.
Modified:
trunk/none/tests/linux/Makefile.am
Modified: trunk/none/tests/linux/Makefile.am
==============================================================================
--- trunk/none/tests/linux/Makefile.am (original)
+++ trunk/none/tests/linux/Makefile.am Sun Aug 9 09:54:27 2015
@@ -36,3 +36,5 @@
# Special needs
pthread_stack_LDADD = -lpthread
+
+stack_overflow_CFLAGS = $(AM_CFLAGS) @FLAG_W_NO_UNINITIALIZED@
|
|
From: Florian K. <fl...@ei...> - 2015-08-09 08:26:55
|
Hi Rhys On 09.08.2015 00:22, Rhys Kidd wrote: > > Uncommenting the below line in configure.ac did not lead to a snowstorm of > compiler warnings, so for Darwin I'd be happy to see it enabled (per what > is the the proper fix here). Careful.... Are you sure that your compiler understands -Wformat-signedness ? Because, if it does not, -Wformat-signedness will not be used when compiling (obviously). Hence, you don't see any warnings :) clang-3.6.0 and earlier do not support -Wformat-signedness... Not sure about newer releases. Florian |
|
From: Florian K. <fl...@ei...> - 2015-08-09 08:19:07
|
On 09.08.2015 00:10, Ivo Raisr wrote: > > However with the latest greatest changes, the compilation fails with: > gcc: error: @FLAG_W_FORMAT_SIGNEDNESS@: No such file or directory > Sorry for the breakage. I fixed it in r15511. Florian |
|
From: <sv...@va...> - 2015-08-09 08:17:06
|
Author: florian
Date: Sun Aug 9 09:16:54 2015
New Revision: 15511
Log:
Fix build breakage introduced in r15510.
Modified:
trunk/configure.ac
Modified: trunk/configure.ac
==============================================================================
--- trunk/configure.ac (original)
+++ trunk/configure.ac Sun Aug 9 09:16:54 2015
@@ -1891,7 +1891,14 @@
AC_GCC_WARNING_SUBST([empty-body], [FLAG_W_EMPTY_BODY])
AC_GCC_WARNING_SUBST([format], [FLAG_W_FORMAT])
# Disabled for now until all platforms are clean
-# AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS])
+format_checking_enabled=no
+#format_checking_enabled=yes
+if test "$format_checking_enabled" = "yes"; then
+ AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS])
+else
+ dumy_assignment_to_avoid_syntax_errors=1
+ AC_SUBST([FLAG_W_FORMAT_SIGNEDNESS], [])
+fi
AC_GCC_WARNING_SUBST([cast-qual], [FLAG_W_CAST_QUAL])
AC_GCC_WARNING_SUBST([old-style-declaration], [FLAG_W_OLD_STYLE_DECLARATION])
AC_GCC_WARNING_SUBST([ignored-qualifiers], [FLAG_W_IGNORED_QUALIFIERS])
|
|
From: Rhys K. <rhy...@gm...> - 2015-08-08 22:23:01
|
Hello Florian, Thank you for all these signedness fixes. I know how unfun it is to find and resolve them, so thank you. Darwin does also experience the new compile error at present: clang: error: no such file or directory: '@FLAG_W_FORMAT_SIGNEDNESS@' Uncommenting the below line in configure.ac did not lead to a snowstorm of compiler warnings, so for Darwin I'd be happy to see it enabled (per what is the the proper fix here). # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) Regards, Rhys On 9 August 2015 at 08:10, Ivo Raisr <ivo...@gm...> wrote: > > > 2015-08-08 23:47 GMT+02:00 Florian Krohm <fl...@ei...>: > >> Hopefully, I did not introduce syntax errors. Apologies in advance. >> configure.ac was changed to detect whether the compiler supports >> -Wformat-signedness but the test is disabled, because it is not clear >> that we get the code cleaned up for all platforms in time for the release. >> So... if you want to play with this you need to enable this line >> >> # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) >> > > > Thank you for all the formatting fixes! > These were numerous to find and fix. Good work here. > > However with the latest greatest changes, the compilation fails with: > gcc: error: @FLAG_W_FORMAT_SIGNEDNESS@: No such file or directory > > I believe this is because expansion of @FLAG_W_FORMAT_SIGNEDNESS@ > is commented out in configure.ac but @FLAG_W_FORMAT_SIGNEDNESS@ > is still present in Makefile.all.am. Either it needs to unconditionally > expand > to something empty or it needs to be deleted from Makefile.all.am. > > I. > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Valgrind-developers mailing list > Val...@li... > https://lists.sourceforge.net/lists/listinfo/valgrind-developers > > |
|
From: Ivo R. <ivo...@gm...> - 2015-08-08 22:10:24
|
2015-08-08 23:47 GMT+02:00 Florian Krohm <fl...@ei...>: > Hopefully, I did not introduce syntax errors. Apologies in advance. > configure.ac was changed to detect whether the compiler supports > -Wformat-signedness but the test is disabled, because it is not clear > that we get the code cleaned up for all platforms in time for the release. > So... if you want to play with this you need to enable this line > > # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) > Thank you for all the formatting fixes! These were numerous to find and fix. Good work here. However with the latest greatest changes, the compilation fails with: gcc: error: @FLAG_W_FORMAT_SIGNEDNESS@: No such file or directory I believe this is because expansion of @FLAG_W_FORMAT_SIGNEDNESS@ is commented out in configure.ac but @FLAG_W_FORMAT_SIGNEDNESS@ is still present in Makefile.all.am. Either it needs to unconditionally expand to something empty or it needs to be deleted from Makefile.all.am. I. |
|
From: Florian K. <fl...@ei...> - 2015-08-08 21:47:15
|
I've fixed what gcc -Wformat-signedness pointed out on amd64, x86, and s390. On the ppc machine I have access to there was no suitable gcc and attempting to build 5.1 failed with some strange error message I don't recall. Carl, perhaps you have a suitable machine + compiler handy? I made obvious fixes in platform-specific code which I could not compile, but no guarantees that everything is fixed. This holds in particular for Darwin and Solaris. Hopefully, I did not introduce syntax errors. Apologies in advance. configure.ac was changed to detect whether the compiler supports -Wformat-signedness but the test is disabled, because it is not clear that we get the code cleaned up for all platforms in time for the release. So... if you want to play with this you need to enable this line # AC_GCC_WARNING_SUBST([format-signedness], [FLAG_W_FORMAT_SIGNEDNESS]) Cheers, Florian |