You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
1
(16) |
2
(22) |
3
(23) |
4
(12) |
5
(24) |
6
(28) |
7
(16) |
|
8
(3) |
9
(2) |
10
(9) |
11
(22) |
12
(19) |
13
(19) |
14
(15) |
|
15
(10) |
16
(23) |
17
(27) |
18
(31) |
19
(26) |
20
(19) |
21
(17) |
|
22
(6) |
23
(4) |
24
(3) |
25
(14) |
26
(1) |
27
(20) |
28
(14) |
|
29
(10) |
30
(26) |
|
|
|
|
|
|
From: <sv...@va...> - 2013-09-15 23:38:55
|
Author: petarj
Date: Sun Sep 15 23:38:39 2013
New Revision: 2763
Log:
mips32: small cleanup in show_hwcaps_mips32
Small cleanup in show_hwcaps_mips32(). More will follow as we need to add
support for Cavium boards too.
Modified:
trunk/priv/main_main.c
Modified: trunk/priv/main_main.c
==============================================================================
--- trunk/priv/main_main.c (original)
+++ trunk/priv/main_main.c Sun Sep 15 23:38:39 2013
@@ -1428,41 +1428,25 @@
static const HChar* show_hwcaps_mips32 ( UInt hwcaps )
{
/* MIPS baseline. */
- if (hwcaps && VEX_PRID_COMP_MIPS == VEX_PRID_COMP_MIPS) {
+ if (hwcaps & VEX_PRID_COMP_MIPS == VEX_PRID_COMP_MIPS) {
/* MIPS baseline with dspr2. */
- if (hwcaps && VEX_MIPS_ASE_DSP2P == VEX_MIPS_ASE_DSP2P) {
+ if (hwcaps & VEX_MIPS_ASE_DSP2P == VEX_MIPS_ASE_DSP2P) {
return "MIPS-baseline-dspr2";
}
/* MIPS baseline with dsp. */
- if (hwcaps && VEX_MIPS_ASE_DSP == VEX_MIPS_ASE_DSP) {
+ if (hwcaps & VEX_MIPS_ASE_DSP == VEX_MIPS_ASE_DSP) {
return "MIPS-baseline-dsp";
}
return "MIPS-baseline";
}
/* Broadcom baseline. */
- if (hwcaps && VEX_PRID_COMP_BROADCOM == VEX_PRID_COMP_BROADCOM) {
- /* Broadcom baseline with dspr2. */
- if (hwcaps && VEX_MIPS_ASE_DSP2P == VEX_MIPS_ASE_DSP2P) {
- return "Broadcom-baseline-dspr2";
- }
- /* Broadcom baseline with dsp. */
- if (hwcaps && VEX_MIPS_ASE_DSP == VEX_MIPS_ASE_DSP) {
- return "Broadcom-baseline-dsp";
- }
+ if (hwcaps & VEX_PRID_COMP_BROADCOM == VEX_PRID_COMP_BROADCOM) {
return "Broadcom-baseline";
}
/* Netlogic baseline. */
- if (hwcaps && VEX_PRID_COMP_NETLOGIC == VEX_PRID_COMP_NETLOGIC) {
- /* Netlogic baseline with dspr2. */
- if (hwcaps && VEX_MIPS_ASE_DSP2P == VEX_MIPS_ASE_DSP2P) {
- return "Netlogic-baseline-dspr2";
- }
- /* Netlogic baseline with dsp. */
- if (hwcaps && VEX_MIPS_ASE_DSP == VEX_MIPS_ASE_DSP) {
- return "Netlogic-baseline-dsp";
- }
+ if (hwcaps & VEX_PRID_COMP_NETLOGIC == VEX_PRID_COMP_NETLOGIC) {
return "Netlogic-baseline";
}
|
|
From: Petar J. <mip...@gm...> - 2013-09-15 22:50:42
|
ARM version likely needs something similar.
Regards,
Petar
On Mon, Sep 16, 2013 at 12:16 AM, <sv...@va...> wrote:
> Author: petarj
> Date: Sun Sep 15 22:16:38 2013
> New Revision: 13550
>
> Log:
> mips: flush the cache in perf/bigcode.c
>
> MIPS needs to flush the cache after memcpy in perf/bigcode.c.
> Otherwise, the executed code will likely be wrong.
>
> This fixes issues with bigcode test on some MIPS platforms.
>
> Modified:
> trunk/perf/bigcode.c
>
> Modified: trunk/perf/bigcode.c
>
> ==============================================================================
> --- trunk/perf/bigcode.c (original)
> +++ trunk/perf/bigcode.c Sun Sep 15 22:16:38 2013
> @@ -10,6 +10,10 @@
> #include <stdio.h>
> #include <string.h>
> #include <assert.h>
> +#if defined(__mips__)
> +#include <asm/cachectl.h>
> +#include <sys/syscall.h>
> +#endif
> #include "tests/sys_mman.h"
>
> #define FN_SIZE 996 // Must be big enough to hold the compiled f()
> @@ -58,7 +62,11 @@
> for (i = 0; i < n_fns; i++) {
> memcpy(&a[FN_SIZE*i], f, FN_SIZE);
> }
> -
> +
> +#if defined(__mips__)
> + syscall(__NR_cacheflush, a, FN_SIZE * n_fns, ICACHE);
> +#endif
> +
> for (h = 0; h < n_reps; h += 1) {
> for (i = 0; i < n_fns; i += 4) {
> int(*f1)(int,int) = (void*)&a[FN_SIZE*(i+0)];
>
>
>
> ------------------------------------------------------------------------------
> LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
> 1,500+ hours of tutorials including VisualStudio 2012, Windows 8,
> SharePoint
> 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack
> includes
> Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13.
> http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>
|
Author: petarj
Date: Sun Sep 15 22:49:01 2013
New Revision: 13551
Log:
mips32/mips64: rename mips32_features to mips_features
As this file is now detecting mips64/Cavium boards, we are renaming it to
reflect that. The functional change is that mips_features now can detect
Cavium board and allow Cavium-specific tests to be run.
Added:
trunk/tests/mips_features.c
Modified:
trunk/none/tests/mips32/mips32_dsp.vgtest
trunk/none/tests/mips32/mips32_dspr2.vgtest
trunk/tests/ (props changed)
trunk/tests/Makefile.am
trunk/tests/mips32_features.c
Modified: trunk/none/tests/mips32/mips32_dsp.vgtest
==============================================================================
--- trunk/none/tests/mips32/mips32_dsp.vgtest (original)
+++ trunk/none/tests/mips32/mips32_dsp.vgtest Sun Sep 15 22:49:01 2013
@@ -1,3 +1,3 @@
prog: mips32_dsp
-prereq: ../../../tests/mips32_features mips32-dsp
+prereq: ../../../tests/mips_features mips32-dsp
vgopts: -q
Modified: trunk/none/tests/mips32/mips32_dspr2.vgtest
==============================================================================
--- trunk/none/tests/mips32/mips32_dspr2.vgtest (original)
+++ trunk/none/tests/mips32/mips32_dspr2.vgtest Sun Sep 15 22:49:01 2013
@@ -1,3 +1,3 @@
prog: mips32_dspr2
-prereq: ../../../tests/mips32_features mips32-dspr2
+prereq: ../../../tests/mips_features mips32-dspr2
vgopts: -q
Modified: trunk/tests/Makefile.am
==============================================================================
--- trunk/tests/Makefile.am (original)
+++ trunk/tests/Makefile.am Sun Sep 15 22:49:01 2013
@@ -26,7 +26,7 @@
true \
x86_amd64_features \
s390x_features \
- mips32_features
+ mips_features
AM_CFLAGS += $(AM_FLAG_M3264_PRI)
AM_CXXFLAGS += $(AM_FLAG_M3264_PRI)
Added: trunk/tests/mips_features.c
==============================================================================
--- trunk/tests/mips_features.c (added)
+++ trunk/tests/mips_features.c Sun Sep 15 22:49:01 2013
@@ -0,0 +1,101 @@
+// This file determines MIPS features a processor supports.
+//
+// We return:
+// - 0 if the machine matches the asked-for feature.
+// - 1 if the machine does not.
+// - 2 if the asked-for feature isn't recognised (this will be the case for
+// any feature if run on a non-MIPS machine).
+// - 3 if there was a usage error (it also prints an error message).
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <assert.h>
+
+#define FEATURE_PRESENT 0
+#define FEATURE_NOT_PRESENT 1
+#define UNRECOGNISED_FEATURE 2
+#define USAGE_ERROR 3
+
+#if defined(VGA_mips32) || defined(VGA_mips64)
+static int mipsCPUInfo(const char *search_string) {
+ const char *file_name = "/proc/cpuinfo";
+ /* Simple detection of MIPS DSP ASE at runtime for Linux.
+ * It is based on /proc/cpuinfo, which reveals hardware configuration
+ * to user-space applications. */
+
+ char cpuinfo_line[256];
+
+ FILE *f = NULL;
+ if ((f = fopen (file_name, "r")) == NULL)
+ return 0;
+
+ while (fgets (cpuinfo_line, sizeof (cpuinfo_line), f) != NULL)
+ {
+ if (strstr (cpuinfo_line, search_string) != NULL)
+ {
+ fclose (f);
+ return 1;
+ }
+ }
+
+ fclose (f);
+
+ /* Did not find string in the /proc/cpuinfo file. */
+ return 0;
+}
+
+static int go(char *feature)
+{
+ int cpuinfo;
+ if ( (strcmp(feature, "mips32-dsp") == 0)) {
+ const char *dsp = "dsp";
+ cpuinfo = mipsCPUInfo(dsp);
+ if (cpuinfo == 1) {
+ return FEATURE_PRESENT;
+ } else{
+ return FEATURE_NOT_PRESENT;
+ }
+ } else if ((strcmp(feature, "mips32-dspr2") == 0)) {
+ const char *dsp2 = "dsp2";
+ cpuinfo = mipsCPUInfo(dsp2);
+ if (cpuinfo == 1) {
+ return FEATURE_PRESENT;
+ } else{
+ return FEATURE_NOT_PRESENT;
+ }
+ } else if ((strcmp(feature, "cavium-octeon") == 0)) {
+ const char *cavium = "Cavium Octeon";
+ cpuinfo = mipsCPUInfo(cavium);
+ if (cpuinfo == 1) {
+ return FEATURE_PRESENT;
+ } else{
+ return FEATURE_NOT_PRESENT;
+ }
+ } else {
+ return UNRECOGNISED_FEATURE;
+ }
+
+}
+
+#else
+
+static int go(char *feature)
+{
+ /* Feature is not recognised. (non-MIPS machine!) */
+ return UNRECOGNISED_FEATURE;
+}
+
+#endif
+
+
+//---------------------------------------------------------------------------
+// main
+//---------------------------------------------------------------------------
+int main(int argc, char **argv)
+{
+ if (argc != 2) {
+ fprintf( stderr, "usage: mips_features <feature>\n" );
+ exit(USAGE_ERROR);
+ }
+ return go(argv[1]);
+}
|
|
From: <sv...@va...> - 2013-09-15 22:17:03
|
Author: petarj
Date: Sun Sep 15 22:16:38 2013
New Revision: 13550
Log:
mips: flush the cache in perf/bigcode.c
MIPS needs to flush the cache after memcpy in perf/bigcode.c.
Otherwise, the executed code will likely be wrong.
This fixes issues with bigcode test on some MIPS platforms.
Modified:
trunk/perf/bigcode.c
Modified: trunk/perf/bigcode.c
==============================================================================
--- trunk/perf/bigcode.c (original)
+++ trunk/perf/bigcode.c Sun Sep 15 22:16:38 2013
@@ -10,6 +10,10 @@
#include <stdio.h>
#include <string.h>
#include <assert.h>
+#if defined(__mips__)
+#include <asm/cachectl.h>
+#include <sys/syscall.h>
+#endif
#include "tests/sys_mman.h"
#define FN_SIZE 996 // Must be big enough to hold the compiled f()
@@ -58,7 +62,11 @@
for (i = 0; i < n_fns; i++) {
memcpy(&a[FN_SIZE*i], f, FN_SIZE);
}
-
+
+#if defined(__mips__)
+ syscall(__NR_cacheflush, a, FN_SIZE * n_fns, ICACHE);
+#endif
+
for (h = 0; h < n_reps; h += 1) {
for (i = 0; i < n_fns; i += 4) {
int(*f1)(int,int) = (void*)&a[FN_SIZE*(i+0)];
|
|
From: Florian K. <fl...@ei...> - 2013-09-15 20:05:55
|
On 09/13/2013 12:10 AM, Philippe Waroquiers wrote: > Find below a patch to have nightly producing perf tests results. > At the end, you find an example mail sent on gcc110. > > If no comments, I will commit in a few days. > I wonder about the reproducability of the results: > we might need bigger --reps value (but that will take a lot of cpu) > or we might rather just run perf tests with the new > (and let the html page make the delta) > or we might increase --reps but also decrease the nr of tools > or .... > I'd say, let Marc's script take care of producing the delta to previous night and perhaps also the delta to some baseline result. That way we can increase the reps value without taking longer to run. One suggestion I'd have would be to output the --reps value at the beginning of the perf results. That way it can be extracted and shown on the webpage. Florian |
|
From: marc b. <mar...@gm...> - 2013-09-15 19:21:18
|
Hi Philippe,
Yes this should be easily parsable.
We have to discuss what we want the html generator to compare/generate.
Cheers,
Marc
2013/9/13 Philippe Waroquiers <phi...@sk...>
> Find below a patch to have nightly producing perf tests results.
> At the end, you find an example mail sent on gcc110.
>
> If no comments, I will commit in a few days.
> I wonder about the reproducability of the results:
> we might need bigger --reps value (but that will take a lot of cpu)
> or we might rather just run perf tests with the new
> (and let the html page make the delta)
> or we might increase --reps but also decrease the nr of tools
> or ....
>
> Marc, I guess the perf output is parsable without too much difficulties,
> but of course each "nightly regression owner" might change the setup,
> e.g. to run with more (or less) tools, only with valgrind-new, or ...
>
> Note that the patch is such that by default, no perf test are run.
> We might decide to instead run the perf tests by default,
> and have "nightly regression owner" opt out using the configuration.
>
> Philippe
>
> Index: nightly/bin/nightly
> ===================================================================
> --- nightly/bin/nightly (revision 13542)
> +++ nightly/bin/nightly (working copy)
> @@ -116,7 +116,14 @@ if [ "${ABT_RUN_REGTEST}" = "" ]; then
> ABT_RUN_REGTEST="make regtest"
> fi
>
> +if [ "${ABT_PERF_TOOLS}" = "" ]; then
> +
> ABT_PERF_TOOLS="--tools=none,memcheck,callgrind,helgrind,cachegrind,drd,massif"
> +fi
> +if [ "${ABT_PERF_REPS}" = "" ]; then
> + ABT_PERF_REPS="--reps=3"
> +fi
>
> +
>
> #----------------------------------------------------------------------------
> # Check out, build, test
>
> #----------------------------------------------------------------------------
> @@ -184,6 +191,14 @@ for logfile in old new ; do
> )
> done
>
> +# if requested, run regression tests and produce results in
> perflogfile.out
> +if [ "${ABT_PERF}" != "" ]; then
> + cd valgrind-new
> + perl perf/vg_perf ${ABT_PERF_TOOLS} ${ABT_PERF_REPS} ${ABT_PERF} perf
> > ../perflogfile 2>&1
> + cd ..
> +fi
> +
> +
>
> #----------------------------------------------------------------------------
> # Prepare results and send
>
> #----------------------------------------------------------------------------
> @@ -257,6 +272,11 @@ if [ $changed != 0 ] ; then
> echo >> final
> fi
>
> +# add perf results if requested
> +if [ "${ABT_PERF}" != "" ]; then
> + cat perflogfile >> final
> +fi
> +
> # Gather up the diffs (at most the first 100 lines for each one) into a
> # single file.
> MAX_LINES=100
> Index: nightly/README.txt
> ===================================================================
> --- nightly/README.txt (revision 13542)
> +++ nightly/README.txt (working copy)
> @@ -86,6 +86,18 @@ To set up nightly testing for a machine, do the fo
> - ABT_JOBS: allows parallel builds -- it's passed as the argument to
> "make -j" when building Valgrind and the tests. The default is 1.
>
> + - ABT_PERF: unset or set to "" mean 'do not run perf tests' (default
> value)
> + set to "--vg=../valgrind-new" (run perf tests for new
> tree)
> + set to "--vg=../valgrind-new --vg=../valgrind-old"
> + (run perf tests for "new" and for "24 hours ago",
> + to compare the performances between the 2 trees).
> +
> + - ABT_PERF_TOOLS: --tools=.... option of perf/vg_perf.
> + (default value: all non experimental tools)
> +
> + - ABT_PERF_REPS: --reps=... option of perf/vg_perf
> + (default value: --reps=3)
> +
> Note that the appropriate syntax to use in this file will depend on
> the
> shell from which the $DIR/bin/nightly script is run (which in turn may
> depend on what shell is used by cron or any similar program).
>
>
>
>
> -------- Forwarded Message --------
> From: Philippe Waroquiers <phi...@sk...>
> To: phi...@sk...
> Subject: (unchanged) 2013-09-12 12:15:48 PDT nightly build (gcc110,
> Fedora release 18 (Spherical Cow), ppc64)
> Date: Thu, 12 Sep 2013 13:54:22 -0700
>
> valgrind revision: 13544
> VEX revision: 2760
> C compiler: gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)
> GDB: GNU gdb (GDB) Fedora (7.5.1-37.fc18)
> Assembler: GNU assembler version 2.23.51.0.1-7.fc18 20120806
> C library: GNU C Library stable release version 2.16
> uname -mrs: Linux 3.7.2-204.fc18.ppc64 ppc64
> Vendor version: Fedora release 18 (Spherical Cow)
>
> Nightly build on gcc110 ( Fedora release 18 (Spherical Cow), ppc64 )
> Started at 2013-09-12 12:15:48 PDT
> Ended at 2013-09-12 13:54:21 PDT
> Results unchanged from 24 hours ago
>
> Checking out valgrind source tree ... done
> Configuring valgrind ... done
> Building valgrind ... done
> Running regression tests ... failed
>
> Regression test results follow
>
> == 563 tests, 33 stderr failures, 5 stdout failures, 0 stderrB failures, 0
> stdoutB failures, 2 post failures ==
> memcheck/tests/linux/getregset (stdout)
> memcheck/tests/linux/getregset (stderr)
> memcheck/tests/ppc64/power_ISA2_05 (stdout)
> memcheck/tests/supp_unknown (stderr)
> memcheck/tests/varinfo6 (stderr)
> memcheck/tests/wrap8 (stdout)
> memcheck/tests/wrap8 (stderr)
> massif/tests/big-alloc (post)
> massif/tests/deep-D (post)
> none/tests/ppc32/jm-misc (stdout)
> none/tests/ppc32/jm-misc (stderr)
> none/tests/ppc64/jm-misc (stdout)
> none/tests/ppc64/jm-misc (stderr)
> helgrind/tests/annotate_rwlock (stderr)
> helgrind/tests/free_is_write (stderr)
> helgrind/tests/hg02_deadlock (stderr)
> helgrind/tests/hg03_inherit (stderr)
> helgrind/tests/hg04_race (stderr)
> helgrind/tests/hg05_race2 (stderr)
> helgrind/tests/locked_vs_unlocked1_fwd (stderr)
> helgrind/tests/locked_vs_unlocked1_rev (stderr)
> helgrind/tests/locked_vs_unlocked2 (stderr)
> helgrind/tests/locked_vs_unlocked3 (stderr)
> helgrind/tests/pth_barrier1 (stderr)
> helgrind/tests/pth_barrier2 (stderr)
> helgrind/tests/pth_barrier3 (stderr)
> helgrind/tests/pth_destroy_cond (stderr)
> helgrind/tests/rwlock_race (stderr)
> helgrind/tests/tc01_simple_race (stderr)
> helgrind/tests/tc05_simple_race (stderr)
> helgrind/tests/tc06_two_races (stderr)
> helgrind/tests/tc06_two_races_xml (stderr)
> helgrind/tests/tc09_bad_unlock (stderr)
> helgrind/tests/tc14_laog_dinphils (stderr)
> helgrind/tests/tc16_byterace (stderr)
> helgrind/tests/tc18_semabuse (stderr)
> helgrind/tests/tc19_shadowmem (stderr)
> helgrind/tests/tc20_verifywrap (stderr)
> helgrind/tests/tc21_pthonce (stderr)
> helgrind/tests/tc22_exit_w_lock (stderr)
>
> -- Running tests in perf ----------------------------------------------
> -- bigcode1 --
> bigcode1 valgrind-new:0.22s no: 1.6s ( 7.1x, -----) me: 2.8s (12.9x,
> -----) ca:18.1s (82.1x, -----) he: 1.7s ( 7.7x, -----) ca: 5.3s (24.3x,
> -----) dr: 1.6s ( 7.4x, -----) ma: 2.1s ( 9.6x, -----)
> bigcode1 valgrind-old:0.22s no: 1.7s ( 7.7x, -8.3%) me: 3.1s (14.2x,
> -9.9%) ca:17.7s (80.4x, 2.0%) he: 1.7s ( 7.9x, -1.8%) ca: 5.3s (24.1x,
> 0.7%) dr: 1.6s ( 7.4x, 0.0%) ma: 2.1s ( 9.6x, 0.0%)
> -- bigcode2 --
> bigcode2 valgrind-new:0.21s no: 1.7s ( 8.2x, -----) me: 3.0s (14.5x,
> -----) ca:18.4s (87.5x, -----) he: 2.1s ( 9.9x, -----) ca: 5.5s (26.0x,
> -----) dr: 1.7s ( 8.0x, -----) ma: 2.3s (10.8x, -----)
> bigcode2 valgrind-old:0.21s no: 1.7s ( 8.0x, 2.3%) me: 2.9s (14.0x,
> 3.6%) ca:17.8s (85.0x, 2.9%) he: 2.1s ( 9.9x, 0.0%) ca: 5.5s (26.0x,
> -0.2%) dr: 1.7s ( 8.1x, -1.2%) ma: 2.3s (10.8x, 0.0%)
> -- bz2 --
> bz2 valgrind-new:0.75s no: 4.8s ( 6.4x, -----) me:13.1s (17.4x,
> -----) ca:26.0s (34.7x, -----) he:15.0s (20.0x, -----) ca:24.8s (33.0x,
> -----) dr:20.1s (26.9x, -----) ma: 5.0s ( 6.6x, -----)
> bz2 valgrind-old:0.75s no: 4.8s ( 6.4x, 0.6%) me:11.8s (15.7x,
> 9.5%) ca:25.6s (34.1x, 1.8%) he:14.7s (19.5x, 2.3%) ca:24.6s (32.8x,
> 0.6%) dr:20.0s (26.7x, 0.6%) ma: 4.6s ( 6.2x, 6.5%)
> -- fbench --
> fbench valgrind-new:0.34s no: 2.1s ( 6.2x, -----) me: 5.2s (15.4x,
> -----) ca: 8.4s (24.9x, -----) he: 5.2s (15.2x, -----) ca: 7.6s (22.4x,
> -----) dr: 4.8s (14.2x, -----) ma: 2.1s ( 6.2x, -----)
> fbench valgrind-old:0.34s no: 2.1s ( 6.2x, -0.5%) me: 5.3s (15.5x,
> -0.6%) ca: 8.3s (24.6x, 1.2%) he: 5.2s (15.2x, 0.2%) ca: 7.5s (22.0x,
> 2.0%) dr: 4.9s (14.5x, -2.3%) ma: 2.1s ( 6.3x, -1.4%)
> -- ffbench --
> ffbench valgrind-new:0.45s no: 1.0s ( 2.3x, -----) me: 2.5s ( 5.6x,
> -----) ca: 2.5s ( 5.6x, -----) he: 6.9s (15.3x, -----) ca: 7.0s (15.6x,
> -----) dr: 5.2s (11.6x, -----) ma: 1.0s ( 2.3x, -----)
> ffbench valgrind-old:0.45s no: 1.0s ( 2.3x, 1.0%) me: 2.6s ( 5.7x,
> -1.6%) ca: 2.5s ( 5.6x, 0.8%) he: 6.8s (15.1x, 1.5%) ca: 7.2s (16.0x,
> -3.0%) dr: 5.3s (11.9x, -2.1%) ma: 1.0s ( 2.3x, 1.0%)
> -- heap --
> heap valgrind-new:0.41s no: 2.4s ( 5.9x, -----) me: 9.9s (24.2x,
> -----) ca:13.3s (32.4x, -----) he:12.8s (31.3x, -----) ca:12.2s (29.7x,
> -----) dr: 7.9s (19.3x, -----) ma: 8.5s (20.7x, -----)
> heap valgrind-old:0.41s no: 2.5s ( 6.0x, -3.3%) me:10.0s (24.4x,
> -0.6%) ca:13.3s (32.4x, 0.1%) he:13.0s (31.8x, -1.4%) ca:12.1s (29.4x,
> 1.1%) dr: 7.8s (19.1x, 1.0%) ma: 8.7s (21.1x, -2.1%)
> -- heap_pdb4 --
> heap_pdb4 valgrind-new:0.43s no: 2.5s ( 5.9x, -----) me:13.8s (32.2x,
> -----) ca:14.2s (33.0x, -----) he:14.6s (34.0x, -----) ca:13.3s (31.0x,
> -----) dr: 9.1s (21.1x, -----) ma: 8.7s (20.2x, -----)
> heap_pdb4 valgrind-old:0.43s no: 2.5s ( 5.9x, -1.2%) me:14.1s (32.8x,
> -1.9%) ca:14.2s (33.0x, -0.1%) he:14.5s (33.7x, 1.1%) ca:13.3s (31.0x,
> 0.3%) dr: 8.8s (20.5x, 3.0%) ma: 8.6s (20.0x, 0.6%)
> -- many-loss-records --
> many-loss-records valgrind-new:0.03s no: 0.5s (17.7x, -----) me: 2.2s
> (72.3x, -----) ca: 1.9s (62.7x, -----) he: 2.0s (66.3x, -----) ca: 1.9s
> (62.0x, -----) dr: 1.5s (50.0x, -----) ma: 1.6s (52.0x, -----)
> many-loss-records valgrind-old:0.03s no: 0.5s (17.3x, 1.9%) me: 2.2s
> (72.7x, -0.5%) ca: 1.9s (62.0x, 1.1%) he: 2.0s (66.7x, -0.5%) ca: 1.9s
> (62.7x, -1.1%) dr: 1.5s (49.3x, 1.3%) ma: 1.6s (53.7x, -3.2%)
> -- many-xpts --
> many-xpts valgrind-new:0.06s no: 0.7s (12.3x, -----) me: 3.4s (56.5x,
> -----) ca: 4.7s (78.3x, -----) he: 5.0s (83.2x, -----) ca: 2.9s (48.2x,
> -----) dr: 2.2s (37.3x, -----) ma: 2.3s (37.8x, -----)
> many-xpts valgrind-old:0.06s no: 0.7s (12.2x, 1.4%) me: 3.4s (57.0x,
> -0.9%) ca: 4.7s (77.5x, 1.1%) he: 5.1s (84.3x, -1.4%) ca: 2.9s (48.0x,
> 0.3%) dr: 2.2s (37.3x, 0.0%) ma: 2.4s (39.5x, -4.4%)
> -- sarp --
> sarp valgrind-new:0.02s no: 0.4s (20.0x, -----) me: 3.6s (179.5x,
> -----) ca: 2.9s (146.5x, -----) he:10.8s (537.5x, -----) ca: 1.6s
> (82.0x, -----) dr: 1.0s (49.5x, -----) ma: 0.4s (21.0x, -----)
> sarp valgrind-old:0.02s no: 0.4s (19.5x, 2.5%) me: 3.6s (179.0x,
> 0.3%) ca: 2.9s (146.5x, 0.0%) he:10.9s (546.0x, -1.6%) ca: 1.7s
> (85.5x, -4.3%) dr: 1.0s (51.0x, -3.0%) ma: 0.4s (21.0x, 0.0%)
> -- tinycc --
> tinycc valgrind-new:0.27s no: 3.0s (11.0x, -----) me:14.2s (52.6x,
> -----) ca:17.2s (63.7x, -----) he:18.8s (69.6x, -----) ca:15.6s (57.6x,
> -----) dr:12.1s (44.8x, -----) ma: 3.8s (14.1x, -----)
> tinycc valgrind-old:0.27s no: 3.0s (11.0x, -0.3%) me:14.5s (53.7x,
> -2.1%) ca:27.6s (102.4x,-60.8%) he:28.2s (104.3x,-50.0%) ca:20.1s
> (74.6x,-29.4%) dr:14.4s (53.4x,-19.2%) ma: 4.2s (15.7x,-11.5%)
> -- Finished tests in perf ----------------------------------------------
>
> == 11 programs, 154 timings =================
>
>
>
>
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. Consolidate legacy IT systems to a single system of record for IT
> 2. Standardize and globalize service processes across IT
> 3. Implement zero-touch automation to replace manual, redundant tasks
> http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>
>
|
Author: florian
Date: Sun Sep 15 13:54:34 2013
New Revision: 13549
Log:
Fix coregrind header files such that they can be included without
having to worry what other header files may have to be included
beforehand.
Modified:
trunk/coregrind/m_debuginfo/priv_d3basics.h
trunk/coregrind/m_debuginfo/priv_image.h
trunk/coregrind/m_debuginfo/priv_misc.h
trunk/coregrind/m_debuginfo/priv_readdwarf.h
trunk/coregrind/m_debuginfo/priv_readdwarf3.h
trunk/coregrind/m_debuginfo/priv_readelf.h
trunk/coregrind/m_debuginfo/priv_readmacho.h
trunk/coregrind/m_debuginfo/priv_readpdb.h
trunk/coregrind/m_debuginfo/priv_readstabs.h
trunk/coregrind/m_debuginfo/priv_storage.h
trunk/coregrind/m_debuginfo/priv_tytypes.h
trunk/coregrind/m_gdbserver/regcache.h
trunk/coregrind/m_gdbserver/target.h
trunk/coregrind/m_gdbserver/valgrind_low.h
trunk/coregrind/m_initimg/priv_initimg_pathscan.h
trunk/coregrind/m_scheduler/priv_sched-lock-impl.h
trunk/coregrind/m_scheduler/priv_sched-lock.h
trunk/coregrind/m_scheduler/priv_sema.h
trunk/coregrind/m_syswrap/priv_syswrap-darwin.h
trunk/coregrind/m_syswrap/priv_syswrap-generic.h
trunk/coregrind/m_syswrap/priv_syswrap-linux-variants.h
trunk/coregrind/m_syswrap/priv_syswrap-linux.h
trunk/coregrind/m_syswrap/priv_syswrap-main.h
trunk/coregrind/m_syswrap/priv_syswrap-xen.h
trunk/coregrind/m_syswrap/priv_types_n_macros.h
trunk/coregrind/m_ume/priv_ume.h
trunk/coregrind/pub_core_commandline.h
trunk/coregrind/pub_core_coredump.h
trunk/coregrind/pub_core_cpuid.h
trunk/coregrind/pub_core_debugger.h
trunk/coregrind/pub_core_demangle.h
trunk/coregrind/pub_core_dispatch.h
trunk/coregrind/pub_core_initimg.h
trunk/coregrind/pub_core_libcassert.h
trunk/coregrind/pub_core_machine.h
trunk/coregrind/pub_core_redir.h
trunk/coregrind/pub_core_replacemalloc.h
trunk/coregrind/pub_core_sbprofile.h
trunk/coregrind/pub_core_scheduler.h
trunk/coregrind/pub_core_sigframe.h
trunk/coregrind/pub_core_signals.h
trunk/coregrind/pub_core_stacks.h
trunk/coregrind/pub_core_stacktrace.h
trunk/coregrind/pub_core_syscall.h
trunk/coregrind/pub_core_syswrap.h
trunk/coregrind/pub_core_threadstate.h
trunk/coregrind/pub_core_trampoline.h
trunk/coregrind/pub_core_translate.h
trunk/coregrind/pub_core_ume.h
trunk/coregrind/pub_core_vki.h
trunk/include/pub_tool_aspacehl.h
trunk/include/pub_tool_aspacemgr.h
trunk/include/pub_tool_clientstate.h
trunk/include/pub_tool_debuginfo.h
trunk/include/pub_tool_execontext.h
trunk/include/pub_tool_gdbserver.h
trunk/include/pub_tool_hashtable.h
trunk/include/pub_tool_libcassert.h
trunk/include/pub_tool_libcbase.h
trunk/include/pub_tool_libcfile.h
trunk/include/pub_tool_libcprint.h
trunk/include/pub_tool_libcproc.h
trunk/include/pub_tool_libcsetjmp.h
trunk/include/pub_tool_libcsignal.h
trunk/include/pub_tool_machine.h
trunk/include/pub_tool_mallocfree.h
trunk/include/pub_tool_options.h
trunk/include/pub_tool_oset.h
trunk/include/pub_tool_poolalloc.h
trunk/include/pub_tool_replacemalloc.h
trunk/include/pub_tool_seqmatch.h
trunk/include/pub_tool_signals.h
trunk/include/pub_tool_sparsewa.h
trunk/include/pub_tool_stacktrace.h
trunk/include/pub_tool_threadstate.h
trunk/include/pub_tool_vkiscnums.h
trunk/include/pub_tool_wordfm.h
trunk/include/pub_tool_xarray.h
Modified: trunk/coregrind/m_debuginfo/priv_d3basics.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_d3basics.h (original)
+++ trunk/coregrind/m_debuginfo/priv_d3basics.h Sun Sep 15 13:54:34 2013
@@ -38,6 +38,8 @@
#ifndef __PRIV_D3BASICS_H
#define __PRIV_D3BASICS_H
+#include "pub_core_basics.h" // Addr
+#include "pub_core_debuginfo.h" // DebugInfo
/* This stuff is taken from gdb-6.6/include/elf/dwarf2.h, which is
GPL2+.
Modified: trunk/coregrind/m_debuginfo/priv_image.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_image.h (original)
+++ trunk/coregrind/m_debuginfo/priv_image.h Sun Sep 15 13:54:34 2013
@@ -30,6 +30,11 @@
/* Contributed by Julian Seward <js...@ac...> */
+#ifndef __PRIV_IMAGE_H
+#define __PRIV_IMAGE_H
+
+#include "pub_core_basics.h" // ULong
+#include "priv_misc.h" // ML_(dinfo_zalloc)
/*------------------------------------------------------------*/
/*--- DiImage -- abstract images ---*/
@@ -339,7 +344,7 @@
}
}
-
+#endif /* ndef __PRIV_IMAGE_H */
/*--------------------------------------------------------------------*/
/*--- end priv_image.h ---*/
Modified: trunk/coregrind/m_debuginfo/priv_misc.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_misc.h (original)
+++ trunk/coregrind/m_debuginfo/priv_misc.h Sun Sep 15 13:54:34 2013
@@ -36,6 +36,7 @@
#ifndef __PRIV_MISC_H
#define __PRIV_MISC_H
+#include "pub_core_basics.h" // SizeT
/* Allocate(zeroed), free, strdup, memdup, all in VG_AR_DINFO. */
void* ML_(dinfo_zalloc)( const HChar* cc, SizeT szB );
Modified: trunk/coregrind/m_debuginfo/priv_readdwarf.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_readdwarf.h (original)
+++ trunk/coregrind/m_debuginfo/priv_readdwarf.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PRIV_READDWARF_H
#define __PRIV_READDWARF_H
+#include "pub_core_debuginfo.h" // DebugInfo
+#include "priv_image.h" // DiSlice
+
/*
Stabs reader greatly improved by Nick Nethercote, Apr 02.
This module was also extensively hacked on by Jeremy Fitzhardinge
@@ -43,7 +46,7 @@
-------------------- */
extern
void ML_(read_debuginfo_dwarf3)
- ( struct _DebugInfo* di,
+ ( DebugInfo* di,
DiSlice escn_debug_info, /* .debug_info */
DiSlice escn_debug_types, /* .debug_types */
DiSlice escn_debug_abbv, /* .debug_abbrev */
@@ -55,7 +58,7 @@
DWARF1 reader
-------------------- */
extern
-void ML_(read_debuginfo_dwarf1) ( struct _DebugInfo* di,
+void ML_(read_debuginfo_dwarf1) ( DebugInfo* di,
UChar* dwarf1d, Int dwarf1d_sz,
UChar* dwarf1l, Int dwarf1l_sz );
@@ -64,7 +67,7 @@
-------------------- */
extern
void ML_(read_callframe_info_dwarf3)
- ( /*OUT*/struct _DebugInfo* di,
+ ( /*OUT*/ DebugInfo* di,
DiSlice escn_frame, Addr frame_avma, Bool is_ehframe );
Modified: trunk/coregrind/m_debuginfo/priv_readdwarf3.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_readdwarf3.h (original)
+++ trunk/coregrind/m_debuginfo/priv_readdwarf3.h Sun Sep 15 13:54:34 2013
@@ -37,11 +37,13 @@
#ifndef __PRIV_READDWARF3_H
#define __PRIV_READDWARF3_H
+#include "pub_core_debuginfo.h" // DebugInfo
+#include "priv_image.h" // DiSlice
/* Read variables and types from DWARF3 ".debug_info" sections. */
void
ML_(new_dwarf3_reader) (
- struct _DebugInfo* di,
+ DebugInfo* di,
DiSlice escn_debug_info, DiSlice escn_debug_types,
DiSlice escn_debug_abbv, DiSlice escn_debug_line,
DiSlice escn_debug_str, DiSlice escn_debug_ranges,
Modified: trunk/coregrind/m_debuginfo/priv_readelf.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_readelf.h (original)
+++ trunk/coregrind/m_debuginfo/priv_readelf.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,9 @@
#ifndef __PRIV_READELF_H
#define __PRIV_READELF_H
+#include "pub_core_basics.h" // SizeT
+#include "pub_core_debuginfo.h" // DebugInfo
+
/*
Stabs reader greatly improved by Nick Nethercote, Apr 02.
This module was also extensively hacked on by Jeremy Fitzhardinge
@@ -48,7 +51,7 @@
info) and anything else we want, into the tables within the
supplied SegInfo.
*/
-extern Bool ML_(read_elf_debug_info) ( struct _DebugInfo* di );
+extern Bool ML_(read_elf_debug_info) ( DebugInfo* di );
#endif /* ndef __PRIV_READELF_H */
Modified: trunk/coregrind/m_debuginfo/priv_readmacho.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_readmacho.h (original)
+++ trunk/coregrind/m_debuginfo/priv_readmacho.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,9 @@
#ifndef __PRIV_READMACHO_H
#define __PRIV_READMACHO_H
+#include "pub_core_basics.h" // SizeT
+#include "pub_core_debuginfo.h" // DebugInfo
+
/* Identify a Mach-O object file by peering at the first few bytes of
it. */
extern Bool ML_(is_macho_object_file)( const void* buf, SizeT size );
@@ -42,7 +45,7 @@
info) and anything else we want, into the tables within the
supplied DebugInfo.
*/
-extern Bool ML_(read_macho_debug_info) ( struct _DebugInfo* si );
+extern Bool ML_(read_macho_debug_info) ( DebugInfo* si );
#endif /* ndef __PRIV_READMACHO_H */
Modified: trunk/coregrind/m_debuginfo/priv_readpdb.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_readpdb.h (original)
+++ trunk/coregrind/m_debuginfo/priv_readpdb.h Sun Sep 15 13:54:34 2013
@@ -37,6 +37,9 @@
#ifndef __PRIV_READPDB_H
#define __PRIV_READPDB_H
+#include "pub_core_basics.h" // Addr
+#include "pub_core_debuginfo.h" // DebugInfo
+
/* Returns True if OK, False for any kind of failure. */
extern Bool ML_(read_pdb_debug_info)(
DebugInfo* di,
Modified: trunk/coregrind/m_debuginfo/priv_readstabs.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_readstabs.h (original)
+++ trunk/coregrind/m_debuginfo/priv_readstabs.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PRIV_READSTABS_H
#define __PRIV_READSTABS_H
+#include "pub_core_basics.h" // UChar
+#include "pub_core_debuginfo.h" // DebugInfo
+
/*
Stabs reader greatly improved by Nick Nethercote, Apr 02.
This module was also extensively hacked on by Jeremy Fitzhardinge
@@ -41,7 +44,7 @@
Stabs reader
-------------------- */
extern
-void ML_(read_debuginfo_stabs) ( struct _DebugInfo* di,
+void ML_(read_debuginfo_stabs) ( DebugInfo* di,
UChar* stabC, Int stab_sz,
HChar* stabstr, Int stabstr_sz );
Modified: trunk/coregrind/m_debuginfo/priv_storage.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_storage.h (original)
+++ trunk/coregrind/m_debuginfo/priv_storage.h Sun Sep 15 13:54:34 2013
@@ -43,6 +43,11 @@
#ifndef __PRIV_STORAGE_H
#define __PRIV_STORAGE_H
+#include "pub_core_basics.h" // Addr
+#include "pub_core_xarray.h" // XArray
+#include "priv_d3basics.h" // GExpr et al.
+#include "priv_image.h" // DiCursor
+
/* --------------------- SYMBOLS --------------------- */
/* A structure to hold an ELF/MachO symbol (very crudely). Usually
Modified: trunk/coregrind/m_debuginfo/priv_tytypes.h
==============================================================================
--- trunk/coregrind/m_debuginfo/priv_tytypes.h (original)
+++ trunk/coregrind/m_debuginfo/priv_tytypes.h Sun Sep 15 13:54:34 2013
@@ -36,6 +36,10 @@
#ifndef __PRIV_TYTYPES_H
#define __PRIV_TYTYPES_H
+#include "pub_core_basics.h" // UWord
+#include "pub_core_xarray.h" // XArray
+#include "priv_misc.h" // MaybeULong
+
typedef
enum {
Te_EMPTY=10, /* empty (contains no info) */
Modified: trunk/coregrind/m_gdbserver/regcache.h
==============================================================================
--- trunk/coregrind/m_gdbserver/regcache.h (original)
+++ trunk/coregrind/m_gdbserver/regcache.h Sun Sep 15 13:54:34 2013
@@ -22,6 +22,8 @@
#ifndef REGCACHE_H
#define REGCACHE_H
+#include "pub_core_basics.h" // Bool
+
struct inferior_list_entry;
/* Create a new register cache for INFERIOR. */
Modified: trunk/coregrind/m_gdbserver/target.h
==============================================================================
--- trunk/coregrind/m_gdbserver/target.h (original)
+++ trunk/coregrind/m_gdbserver/target.h Sun Sep 15 13:54:34 2013
@@ -26,6 +26,9 @@
#ifndef TARGET_H
#define TARGET_H
+#include "pub_core_basics.h" // Addr
+#include "server.h" // CORE_ADDR
+
/* This file defines the architecture independent Valgrind gdbserver
high level operations such as read memory, get/set registers, ...
Modified: trunk/coregrind/m_gdbserver/valgrind_low.h
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind_low.h (original)
+++ trunk/coregrind/m_gdbserver/valgrind_low.h Sun Sep 15 13:54:34 2013
@@ -26,6 +26,9 @@
#ifndef VALGRIND_LOW_H
#define VALGRIND_LOW_H
+#include "pub_core_basics.h" // ThreadId
+#include "server.h" // CORE_ADDR
+
/* defines the characteristics of the "low" valgrind target architecture.
In other words, struct valgrind_target_ops defines the functions and
data which are specific to the architecture (x86 or amd64 or
Modified: trunk/coregrind/m_initimg/priv_initimg_pathscan.h
==============================================================================
--- trunk/coregrind/m_initimg/priv_initimg_pathscan.h (original)
+++ trunk/coregrind/m_initimg/priv_initimg_pathscan.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PRIV_INITIMG_PATHSCAN_H
#define __PRIV_INITIMG_PATHSCAN_
+#include "pub_core_basics.h" // HChar
+
extern const HChar* ML_(find_executable) ( const HChar* exec );
#endif
Modified: trunk/coregrind/m_scheduler/priv_sched-lock-impl.h
==============================================================================
--- trunk/coregrind/m_scheduler/priv_sched-lock-impl.h (original)
+++ trunk/coregrind/m_scheduler/priv_sched-lock-impl.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PRIV_SCHED_LOCK_IMPL_H
#define __PRIV_SCHED_LOCK_IMPL_H
+#include "pub_core_basics.h" // HChar
+
struct sched_lock_ops {
const HChar *(*get_sched_lock_name)(void);
struct sched_lock *(*create_sched_lock)(void);
Modified: trunk/coregrind/m_scheduler/priv_sched-lock.h
==============================================================================
--- trunk/coregrind/m_scheduler/priv_sched-lock.h (original)
+++ trunk/coregrind/m_scheduler/priv_sched-lock.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PRIV_SCHED_LOCK_H
#define __PRIV_SCHED_LOCK_H
+#include "pub_core_basics.h" // Bool
+
struct sched_lock;
enum SchedLockType { sched_lock_generic, sched_lock_ticket };
Modified: trunk/coregrind/m_scheduler/priv_sema.h
==============================================================================
--- trunk/coregrind/m_scheduler/priv_sema.h (original)
+++ trunk/coregrind/m_scheduler/priv_sema.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PRIV_SEMA_H
#define __PRIV_SEMA_H
+#include "pub_core_basics.h" // Bool
+
/* Not really a semaphore, but use a pipe for a token-passing scheme */
typedef struct {
Int pipe[2];
Modified: trunk/coregrind/m_syswrap/priv_syswrap-darwin.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-darwin.h (original)
+++ trunk/coregrind/m_syswrap/priv_syswrap-darwin.h Sun Sep 15 13:54:34 2013
@@ -31,7 +31,8 @@
#ifndef __PRIV_SYSWRAP_DARWIN_H
#define __PRIV_SYSWRAP_DARWIN_H
-/* requires #include "priv_types_n_macros.h" */
+#include "pub_core_basics.h" // ThreadId
+#include "priv_types_n_macros.h" // DECL_TEMPLATE
// syswrap-darwin.c
Addr allocstack ( ThreadId tid );
Modified: trunk/coregrind/m_syswrap/priv_syswrap-generic.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-generic.h (original)
+++ trunk/coregrind/m_syswrap/priv_syswrap-generic.h Sun Sep 15 13:54:34 2013
@@ -31,7 +31,9 @@
#ifndef __PRIV_SYSWRAP_GENERIC_H
#define __PRIV_SYSWRAP_GENERIC_H
-/* requires #include "priv_types_n_macros.h" */
+#include "pub_core_basics.h" // ThreadId
+#include "pub_core_vki.h" // vki_msghdr
+#include "priv_types_n_macros.h" // DECL_TEMPLATE
// Return true if address range entirely contained within client
Modified: trunk/coregrind/m_syswrap/priv_syswrap-linux-variants.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-linux-variants.h (original)
+++ trunk/coregrind/m_syswrap/priv_syswrap-linux-variants.h Sun Sep 15 13:54:34 2013
@@ -32,8 +32,7 @@
#ifndef __PRIV_SYSWRAP_LINUX_VARIANTS_H
#define __PRIV_SYSWRAP_LINUX_VARIANTS_H
-/* requires #include "priv_types_n_macros.h" */
-
+#include "pub_core_basics.h" // ThreadId
/* ---------------------------------------------------------------
BProc wrappers
Modified: trunk/coregrind/m_syswrap/priv_syswrap-linux.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-linux.h (original)
+++ trunk/coregrind/m_syswrap/priv_syswrap-linux.h Sun Sep 15 13:54:34 2013
@@ -31,7 +31,8 @@
#ifndef __PRIV_SYSWRAP_LINUX_H
#define __PRIV_SYSWRAP_LINUX_H
-/* requires #include "priv_types_n_macros.h" */
+#include "pub_core_basics.h" // ThreadId
+#include "priv_types_n_macros.h" // DECL_TEMPLATE
// Clone-related functions
extern Word ML_(start_thread_NORETURN) ( void* arg );
Modified: trunk/coregrind/m_syswrap/priv_syswrap-main.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-main.h (original)
+++ trunk/coregrind/m_syswrap/priv_syswrap-main.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PRIV_SYSWRAP_MAIN_H
#define __PRIV_SYSWRAP_MAIN_H
+#include "pub_core_basics.h" // ThreadID
+#include "pub_core_threadstate.h" // ThreadArchState
+
/* Back up a thread so as to restart a system call. */
extern
void ML_(fixup_guest_state_to_restart_syscall) ( ThreadArchState* arch );
Modified: trunk/coregrind/m_syswrap/priv_syswrap-xen.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_syswrap-xen.h (original)
+++ trunk/coregrind/m_syswrap/priv_syswrap-xen.h Sun Sep 15 13:54:34 2013
@@ -1,6 +1,8 @@
#ifndef __PRIV_SYSWRAP_XEN_H
#define __PRIV_SYSWRAP_XEN_H
+#include "priv_types_n_macros.h" // DECL_TEMPLATE
+
DECL_TEMPLATE(xen, hypercall);
#endif // __PRIV_SYSWRAP_XEN_H
Modified: trunk/coregrind/m_syswrap/priv_types_n_macros.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_types_n_macros.h (original)
+++ trunk/coregrind/m_syswrap/priv_types_n_macros.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PRIV_TYPES_N_MACROS_H
#define __PRIV_TYPES_N_MACROS_H
+#include "pub_core_basics.h" // Addr
+
/* requires #include "pub_core_options.h" */
/* requires #include "pub_core_signals.h" */
Modified: trunk/coregrind/m_ume/priv_ume.h
==============================================================================
--- trunk/coregrind/m_ume/priv_ume.h (original)
+++ trunk/coregrind/m_ume/priv_ume.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PRIV_UME_H
#define __PRIV_UME_H
+#include "pub_core_ume.h" // ExeInfo
+
extern int VG_(do_exec_inner)(const HChar *exe, ExeInfo *info);
#if defined(VGO_linux)
Modified: trunk/coregrind/pub_core_commandline.h
==============================================================================
--- trunk/coregrind/pub_core_commandline.h (original)
+++ trunk/coregrind/pub_core_commandline.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,7 @@
#ifndef __PUB_CORE_COMMANDLINE_H
#define __PUB_CORE_COMMANDLINE_H
+#include "pub_core_basics.h" // VG_ macro
/* Split up the args presented by the launcher to m_main.main(), and
park them in VG_(args_for_client), VG_(args_for_valgrind) and
Modified: trunk/coregrind/pub_core_coredump.h
==============================================================================
--- trunk/coregrind/pub_core_coredump.h (original)
+++ trunk/coregrind/pub_core_coredump.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_CORE_COREDUMP_H
#define __PUB_CORE_COREDUMP_H
+#include "pub_core_basics.h" // ThreadId
+#include "pub_core_vki.h" // vki_siginfo_t
+
//--------------------------------------------------------------------
// PURPOSE: This module produces a core dump when asked.
//--------------------------------------------------------------------
Modified: trunk/coregrind/pub_core_cpuid.h
==============================================================================
--- trunk/coregrind/pub_core_cpuid.h (original)
+++ trunk/coregrind/pub_core_cpuid.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_CPUID_H
#define __PUB_CORE_CPUID_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module provides Valgrind's interface to the x86/amd64
// CPUID instruction.
Modified: trunk/coregrind/pub_core_debugger.h
==============================================================================
--- trunk/coregrind/pub_core_debugger.h (original)
+++ trunk/coregrind/pub_core_debugger.h Sun Sep 15 13:54:34 2013
@@ -36,6 +36,8 @@
// running program.
//--------------------------------------------------------------------
+#include "pub_core_basics.h" // ThreadId
+
extern void VG_(start_debugger) ( ThreadId tid );
#endif // __PUB_CORE_DEBUGGER_H
Modified: trunk/coregrind/pub_core_demangle.h
==============================================================================
--- trunk/coregrind/pub_core_demangle.h (original)
+++ trunk/coregrind/pub_core_demangle.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_DEMANGLE_H
#define __PUB_CORE_DEMANGLE_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module exports functions for demangling C++ and
// Z-encoded names.
Modified: trunk/coregrind/pub_core_dispatch.h
==============================================================================
--- trunk/coregrind/pub_core_dispatch.h (original)
+++ trunk/coregrind/pub_core_dispatch.h Sun Sep 15 13:54:34 2013
@@ -40,6 +40,7 @@
//--------------------------------------------------------------------
#include "pub_core_dispatch_asm.h"
+#include "pub_core_basics.h" // Addr
/* Run translations, with the given guest state, and starting by
running the host code at 'host_addr'. It is almost always the case
Modified: trunk/coregrind/pub_core_initimg.h
==============================================================================
--- trunk/coregrind/pub_core_initimg.h (original)
+++ trunk/coregrind/pub_core_initimg.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,7 @@
#ifndef __PUB_CORE_INITIMG_H
#define __PUB_CORE_INITIMG_H
+#include "pub_core_basics.h" // Addr
//--------------------------------------------------------------------
// PURPOSE: Map the client executable into memory, then set up its
Modified: trunk/coregrind/pub_core_libcassert.h
==============================================================================
--- trunk/coregrind/pub_core_libcassert.h (original)
+++ trunk/coregrind/pub_core_libcassert.h Sun Sep 15 13:54:34 2013
@@ -37,6 +37,7 @@
//--------------------------------------------------------------------
#include "pub_tool_libcassert.h"
+#include "pub_core_basics.h" // UnwindStartRegs
// Useful for making failing stubs, when certain things haven't yet been
// implemented.
Modified: trunk/coregrind/pub_core_machine.h
==============================================================================
--- trunk/coregrind/pub_core_machine.h (original)
+++ trunk/coregrind/pub_core_machine.h Sun Sep 15 13:54:34 2013
@@ -38,6 +38,7 @@
//--------------------------------------------------------------------
#include "pub_tool_machine.h"
+#include "pub_core_basics.h" // UnwindStartRegs
// XXX: this is *really* the wrong spot for these things
#if defined(VGP_x86_linux)
Modified: trunk/coregrind/pub_core_redir.h
==============================================================================
--- trunk/coregrind/pub_core_redir.h (original)
+++ trunk/coregrind/pub_core_redir.h Sun Sep 15 13:54:34 2013
@@ -55,7 +55,8 @@
//--------------------------------------------------------------------
#include "pub_tool_redir.h"
-
+#include "pub_core_basics.h" // Addr
+#include "pub_core_debuginfo.h" // DebugInfo
//--------------------------------------------------------------------
// Notifications - by which we are told of state changes
Modified: trunk/coregrind/pub_core_replacemalloc.h
==============================================================================
--- trunk/coregrind/pub_core_replacemalloc.h (original)
+++ trunk/coregrind/pub_core_replacemalloc.h Sun Sep 15 13:54:34 2013
@@ -37,6 +37,7 @@
//--------------------------------------------------------------------
#include "pub_tool_replacemalloc.h"
+#include "pub_core_mallocfree.h" // vg_mallinfo
// things vg_replace_malloc.o needs to know about
struct vg_mallocfunc_info {
Modified: trunk/coregrind/pub_core_sbprofile.h
==============================================================================
--- trunk/coregrind/pub_core_sbprofile.h (original)
+++ trunk/coregrind/pub_core_sbprofile.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PUB_CORE_SBPROFILE_H
#define __PUB_CORE_SBPROFILE_H
+#include "pub_core_basics.h" // VG_ macro
+
/* Get and print a profile. Also, zero out the counters so that if we
call it again later, the second call will only show new work done
since the first call. ecs_done == 0 is taken to mean this is a
Modified: trunk/coregrind/pub_core_scheduler.h
==============================================================================
--- trunk/coregrind/pub_core_scheduler.h (original)
+++ trunk/coregrind/pub_core_scheduler.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_CORE_SCHEDULER_H
#define __PUB_CORE_SCHEDULER_H
+#include "pub_core_basics.h" // VG_ macro
+#include "pub_core_threadstate.h" // VgSchedReturnCode
+
//--------------------------------------------------------------------
// PURPOSE: This module is the scheduler, which is the main loop
// controlling the running of all the program's threads.
Modified: trunk/coregrind/pub_core_sigframe.h
==============================================================================
--- trunk/coregrind/pub_core_sigframe.h (original)
+++ trunk/coregrind/pub_core_sigframe.h Sun Sep 15 13:54:34 2013
@@ -32,16 +32,15 @@
#ifndef __PUB_CORE_SIGFRAME_H
#define __PUB_CORE_SIGFRAME_H
+#include "pub_core_basics.h" // VG_ macro
+#include "pub_tool_vki.h" // vki_sigset_t et al.
+
//--------------------------------------------------------------------
// PURPOSE: This module creates and destroys signal delivery frames
// for client threads, saving/restoring the thread CPU state in the
// frame appropriately.
//--------------------------------------------------------------------
-/* There are no tool-visible exports from m_sigframe, hence no header
- file for it. */
-/* #include "pub_tool_sigframe.h" */
-
/* Create a signal frame for thread 'tid'. */
extern
void VG_(sigframe_create) ( ThreadId tid,
Modified: trunk/coregrind/pub_core_signals.h
==============================================================================
--- trunk/coregrind/pub_core_signals.h (original)
+++ trunk/coregrind/pub_core_signals.h Sun Sep 15 13:54:34 2013
@@ -36,6 +36,7 @@
//--------------------------------------------------------------------
#include "pub_tool_signals.h" // I want to get rid of this header...
+#include "pub_tool_vki.h" // vki_sigset_t et al.
/* Highest signal the kernel will let us use */
extern Int VG_(max_signal);
Modified: trunk/coregrind/pub_core_stacks.h
==============================================================================
--- trunk/coregrind/pub_core_stacks.h (original)
+++ trunk/coregrind/pub_core_stacks.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_STACKS_H
#define __PUB_CORE_STACKS_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module deals with the registration of stacks for the
// purposes of detecting stack switches.
Modified: trunk/coregrind/pub_core_stacktrace.h
==============================================================================
--- trunk/coregrind/pub_core_stacktrace.h (original)
+++ trunk/coregrind/pub_core_stacktrace.h Sun Sep 15 13:54:34 2013
@@ -37,6 +37,7 @@
//--------------------------------------------------------------------
#include "pub_tool_stacktrace.h"
+#include "pub_core_basics.h" // UnwindStartRegs
// Variant that gives a little more control over the stack-walking
// (this is the "worker" function that actually does the walking).
Modified: trunk/coregrind/pub_core_syscall.h
==============================================================================
--- trunk/coregrind/pub_core_syscall.h (original)
+++ trunk/coregrind/pub_core_syscall.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_SYSCALL_H
#define __PUB_CORE_SYSCALL_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module contains the code for actually executing syscalls.
//--------------------------------------------------------------------
Modified: trunk/coregrind/pub_core_syswrap.h
==============================================================================
--- trunk/coregrind/pub_core_syswrap.h (original)
+++ trunk/coregrind/pub_core_syswrap.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_CORE_SYSWRAP_H
#define __PUB_CORE_SYSWRAP_H
+#include "pub_core_basics.h" // VG_ macro
+#include "pub_core_threadstate.h" // ThreadArchState
+
//--------------------------------------------------------------------
// PURPOSE: This module contains all the syscall junk: mostly PRE/POST
// wrappers, but also the main syscall jacketing code.
Modified: trunk/coregrind/pub_core_threadstate.h
==============================================================================
--- trunk/coregrind/pub_core_threadstate.h (original)
+++ trunk/coregrind/pub_core_threadstate.h Sun Sep 15 13:54:34 2013
@@ -41,6 +41,7 @@
#include "pub_tool_threadstate.h"
#include "pub_core_libcsetjmp.h" // VG_MINIMAL_JMP_BUF
+#include "pub_core_vki.h" // vki_sigset_t
/*------------------------------------------------------------*/
/*--- Types ---*/
Modified: trunk/coregrind/pub_core_trampoline.h
==============================================================================
--- trunk/coregrind/pub_core_trampoline.h (original)
+++ trunk/coregrind/pub_core_trampoline.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_TRAMPOLINE_H
#define __PUB_CORE_TRAMPOLINE_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module defines a few replacement functions for Linux
// vsyscalls, which we can't implement directly. It also contains
Modified: trunk/coregrind/pub_core_translate.h
==============================================================================
--- trunk/coregrind/pub_core_translate.h (original)
+++ trunk/coregrind/pub_core_translate.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_TRANSLATE_H
#define __PUB_CORE_TRANSLATE_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module is Valgrind's interface to the JITter. It's
// basically a wrapper around Vex.
Modified: trunk/coregrind/pub_core_ume.h
==============================================================================
--- trunk/coregrind/pub_core_ume.h (original)
+++ trunk/coregrind/pub_core_ume.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_CORE_UME_H
#define __PUB_CORE_UME_H
+#include "pub_core_basics.h" // VG_ macro
+
//--------------------------------------------------------------------
// PURPOSE: This module implements user-mode execve, ie. program loading
// and exec'ing.
Modified: trunk/coregrind/pub_core_vki.h
==============================================================================
--- trunk/coregrind/pub_core_vki.h (original)
+++ trunk/coregrind/pub_core_vki.h Sun Sep 15 13:54:34 2013
@@ -42,6 +42,7 @@
that means the only thing to be done here is ... */
#include "pub_tool_vki.h"
+#include "pub_core_basics.h" // VG_ macro
/* Do initial consistency checks on some of the definitions to do with
signals (vki_sigset_t and vki_sigaction_{toK,fromK}_t). This stuff
Modified: trunk/include/pub_tool_aspacehl.h
==============================================================================
--- trunk/include/pub_tool_aspacehl.h (original)
+++ trunk/include/pub_tool_aspacehl.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_ASPACEHL_H
#define __PUB_TOOL_ASPACEHL_H
+#include "pub_tool_basics.h" // VG_ macro
+
// Extract from aspacem a vector of the current segment start
// addresses. The vector is dynamically allocated and should be freed
// by the caller when done. REQUIRES m_mallocfree to be running.
Modified: trunk/include/pub_tool_aspacemgr.h
==============================================================================
--- trunk/include/pub_tool_aspacemgr.h (original)
+++ trunk/include/pub_tool_aspacemgr.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,7 @@
#ifndef __PUB_TOOL_ASPACEMGR_H
#define __PUB_TOOL_ASPACEMGR_H
+#include "pub_tool_basics.h" // VG_ macro
//--------------------------------------------------------------
// Definition of address-space segments
Modified: trunk/include/pub_tool_clientstate.h
==============================================================================
--- trunk/include/pub_tool_clientstate.h (original)
+++ trunk/include/pub_tool_clientstate.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_TOOL_CLIENTSTATE_H
#define __PUB_TOOL_CLIENTSTATE_H
+#include "pub_tool_basics.h" // VG_ macro
+#include "pub_tool_xarray.h" // XArray
+
/* Note, this header requires pub_{core,tool}_xarray.h to be
included ahead of it. */
Modified: trunk/include/pub_tool_debuginfo.h
==============================================================================
--- trunk/include/pub_tool_debuginfo.h (original)
+++ trunk/include/pub_tool_debuginfo.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_DEBUGINFO_H
#define __PUB_TOOL_DEBUGINFO_H
+#include "pub_tool_basics.h" // VG_ macro
+
/*====================================================================*/
/*=== Obtaining debug information ===*/
/*====================================================================*/
Modified: trunk/include/pub_tool_execontext.h
==============================================================================
--- trunk/include/pub_tool_execontext.h (original)
+++ trunk/include/pub_tool_execontext.h Sun Sep 15 13:54:34 2013
@@ -30,6 +30,8 @@
#ifndef __PUB_TOOL_EXECONTEXT_H
#define __PUB_TOOL_EXECONTEXT_H
+#include "pub_tool_basics.h" // ThreadID
+
// It's an abstract type.
typedef
struct _ExeContext
Modified: trunk/include/pub_tool_gdbserver.h
==============================================================================
--- trunk/include/pub_tool_gdbserver.h (original)
+++ trunk/include/pub_tool_gdbserver.h Sun Sep 15 13:54:34 2013
@@ -30,6 +30,7 @@
#ifndef __PUB_TOOL_GDBSERVER_H
#define __PUB_TOOL_GDBSERVER_H
+#include "pub_tool_basics.h" // VG_ macro
#include "libvex.h"
#include "libvex_ir.h"
Modified: trunk/include/pub_tool_hashtable.h
==============================================================================
--- trunk/include/pub_tool_hashtable.h (original)
+++ trunk/include/pub_tool_hashtable.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_HASHTABLE_H
#define __PUB_TOOL_HASHTABLE_H
+#include "pub_tool_basics.h" // VG_ macro
+
/* Generic type for a separately-chained hash table. Via a kind of dodgy
C-as-C++ style inheritance, tools can extend the VgHashNode type, so long
as the first two fields match the sizes of these two fields. Requires
Modified: trunk/include/pub_tool_libcassert.h
==============================================================================
--- trunk/include/pub_tool_libcassert.h (original)
+++ trunk/include/pub_tool_libcassert.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_LIBCBASSERT_H
#define __PUB_TOOL_LIBCBASSERT_H
+#include "pub_tool_basics.h" // VG_ macro
+
#define tl_assert(expr) \
((void) (LIKELY(expr) ? 0 : \
(VG_(assert_fail) (/*isCore?*/False, #expr, \
Modified: trunk/include/pub_tool_libcbase.h
==============================================================================
--- trunk/include/pub_tool_libcbase.h (original)
+++ trunk/include/pub_tool_libcbase.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_LIBCBASE_H
#define __PUB_TOOL_LIBCBASE_H
+#include "pub_tool_basics.h" // VG_ macro
+
/* ---------------------------------------------------------------------
Char functions.
------------------------------------------------------------------ */
Modified: trunk/include/pub_tool_libcfile.h
==============================================================================
--- trunk/include/pub_tool_libcfile.h (original)
+++ trunk/include/pub_tool_libcfile.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_TOOL_LIBCFILE_H
#define __PUB_TOOL_LIBCFILE_H
+#include "pub_tool_basics.h" // VG_ macro
+#include "pub_tool_vki.h" // vki_dirent et al.
+
/* ---------------------------------------------------------------------
File-related functions.
------------------------------------------------------------------ */
Modified: trunk/include/pub_tool_libcprint.h
==============================================================================
--- trunk/include/pub_tool_libcprint.h (original)
+++ trunk/include/pub_tool_libcprint.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_LIBCPRINT_H
#define __PUB_TOOL_LIBCPRINT_H
+#include "pub_tool_basics.h" // VG_ macro
+
/* ---------------------------------------------------------------------
Formatting functions
------------------------------------------------------------------ */
Modified: trunk/include/pub_tool_libcproc.h
==============================================================================
--- trunk/include/pub_tool_libcproc.h (original)
+++ trunk/include/pub_tool_libcproc.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_TOOL_LIBCPROC_H
#define __PUB_TOOL_LIBCPROC_H
+#include "pub_tool_basics.h" // VG_ macro
+#include "pub_tool_vki.h" // vki_rlimit
+
/* ---------------------------------------------------------------------
Command-line and environment stuff
------------------------------------------------------------------ */
Modified: trunk/include/pub_tool_libcsetjmp.h
==============================================================================
--- trunk/include/pub_tool_libcsetjmp.h (original)
+++ trunk/include/pub_tool_libcsetjmp.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PUB_TOOL_LIBCSETJMP_H
#define __PUB_TOOL_LIBCSETJMP_H
+#include "pub_tool_basics.h" // UWord
+
//--------------------------------------------------------------------
// PURPOSE: Provides a minimal setjmp/longjmp facility, that saves/
// restores integer registers, but not necessarily anything more.
Modified: trunk/include/pub_tool_libcsignal.h
==============================================================================
--- trunk/include/pub_tool_libcsignal.h (original)
+++ trunk/include/pub_tool_libcsignal.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,9 @@
#ifndef __PUB_TOOL_LIBCBSIGNAL_H
#define __PUB_TOOL_LIBCBSIGNAL_H
+#include "pub_tool_basics.h" // VG_ macro
+#include "pub_tool_vki.h" // vki_sigset
+
/* Note that these use the vki_ (kernel) structure
definitions, which are different in places from those that glibc
defines. Since we're operating right at the kernel interface, glibc's view
Modified: trunk/include/pub_tool_machine.h
==============================================================================
--- trunk/include/pub_tool_machine.h (original)
+++ trunk/include/pub_tool_machine.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,7 @@
#ifndef __PUB_TOOL_MACHINE_H
#define __PUB_TOOL_MACHINE_H
+#include "pub_tool_basics.h" // ThreadID
#include "libvex.h" // VexArchInfo
#if defined(VGP_x86_linux)
Modified: trunk/include/pub_tool_mallocfree.h
==============================================================================
--- trunk/include/pub_tool_mallocfree.h (original)
+++ trunk/include/pub_tool_mallocfree.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PUB_TOOL_MALLOCFREE_H
#define __PUB_TOOL_MALLOCFREE_H
+#include "pub_tool_basics.h" // SizeT
+
// These can be for allocating memory used by tools.
// Nb: the allocators *always succeed* -- they never return NULL (Valgrind
// will abort if they can't allocate the memory).
Modified: trunk/include/pub_tool_options.h
==============================================================================
--- trunk/include/pub_tool_options.h (original)
+++ trunk/include/pub_tool_options.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,7 @@
#ifndef __PUB_TOOL_OPTIONS_H
#define __PUB_TOOL_OPTIONS_H
+#include "pub_tool_basics.h" // for VG_ macro
#include "libvex.h" // for VexControl
Modified: trunk/include/pub_tool_oset.h
==============================================================================
--- trunk/include/pub_tool_oset.h (original)
+++ trunk/include/pub_tool_oset.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_OSET_H
#define __PUB_TOOL_OSET_H
+#include "pub_tool_basics.h" // Word
+
// This module implements an ordered set, a data structure with fast
// (eg. amortised log(n) or better) insertion, lookup and deletion of
// elements. It does not allow duplicates, and will assert if you insert a
Modified: trunk/include/pub_tool_poolalloc.h
==============================================================================
--- trunk/include/pub_tool_poolalloc.h (original)
+++ trunk/include/pub_tool_poolalloc.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_POOLALLOC_H
#define __PUB_TOOL_POOLALLOC_H
+#include "pub_tool_basics.h" // UWord
+
//--------------------------------------------------------------------
// PURPOSE: Provides efficient allocation and free of elements of
// the same size.
Modified: trunk/include/pub_tool_replacemalloc.h
==============================================================================
--- trunk/include/pub_tool_replacemalloc.h (original)
+++ trunk/include/pub_tool_replacemalloc.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_REPLACEMALLOC_H
#define __PUB_TOOL_REPLACEMALLOC_H
+#include "pub_tool_basics.h" // Addr
+
/* If a tool replaces malloc() et al, the easiest way to do so is to
link libreplacemalloc_toolpreload.o into its vgpreload_*.so file, and
use the functions declared below. You can do it from scratch,
Modified: trunk/include/pub_tool_seqmatch.h
==============================================================================
--- trunk/include/pub_tool_seqmatch.h (original)
+++ trunk/include/pub_tool_seqmatch.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PUB_TOOL_SEQMATCH_H
#define __PUB_TOOL_SEQMATCH_H
+#include "pub_tool_basics.h" // UWord
+
/* Perform totally abstractified sequence matching, of an input
sequence against a pattern sequence. The pattern sequence may
include '*' elements (matches any number of anything) and '?'
Modified: trunk/include/pub_tool_signals.h
==============================================================================
--- trunk/include/pub_tool_signals.h (original)
+++ trunk/include/pub_tool_signals.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_SIGNALS_H
#define __PUB_TOOL_SIGNALS_H
+#include "pub_tool_basics.h" // Addr
+
// Register an interest in apparently internal faults; used code which
// wanders around dangerous memory (ie, leakcheck). The catcher is
// not expected to return.
Modified: trunk/include/pub_tool_sparsewa.h
==============================================================================
--- trunk/include/pub_tool_sparsewa.h (original)
+++ trunk/include/pub_tool_sparsewa.h Sun Sep 15 13:54:34 2013
@@ -32,6 +32,8 @@
#ifndef __PUB_TOOL_SPARSEWA_H
#define __PUB_TOOL_SPARSEWA_H
+#include "pub_tool_basics.h" // UWord
+
//--------------------------------------------------------------------
// PURPOSE: (see coregrind/pub_core_sparsewa.h for details)
//--------------------------------------------------------------------
Modified: trunk/include/pub_tool_stacktrace.h
==============================================================================
--- trunk/include/pub_tool_stacktrace.h (original)
+++ trunk/include/pub_tool_stacktrace.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_STACKTRACE_H
#define __PUB_TOOL_STACKTRACE_H
+#include "pub_tool_basics.h" // Addr
+
// The basic stack trace type: just an array of code addresses.
typedef Addr* StackTrace;
Modified: trunk/include/pub_tool_threadstate.h
==============================================================================
--- trunk/include/pub_tool_threadstate.h (original)
+++ trunk/include/pub_tool_threadstate.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_THREADSTATE_H
#define __PUB_TOOL_THREADSTATE_H
+#include "pub_tool_basics.h" // ThreadID
+
/* The maximum number of pthreads that we support. This is
deliberately not very high since our implementation of some of the
scheduler algorithms is surely O(N) in the number of threads, since
Modified: trunk/include/pub_tool_vkiscnums.h
==============================================================================
--- trunk/include/pub_tool_vkiscnums.h (original)
+++ trunk/include/pub_tool_vkiscnums.h Sun Sep 15 13:54:34 2013
@@ -34,6 +34,7 @@
#define __PUB_TOOL_VKISCNUMS_H
#include "pub_tool_vkiscnums_asm.h"
+#include "pub_tool_basics.h" // Word
// This converts a syscall number into a string, suitable for printing. It is
Modified: trunk/include/pub_tool_wordfm.h
==============================================================================
--- trunk/include/pub_tool_wordfm.h (original)
+++ trunk/include/pub_tool_wordfm.h Sun Sep 15 13:54:34 2013
@@ -52,6 +52,8 @@
#ifndef __PUB_TOOL_WORDFM_H
#define __PUB_TOOL_WORDFM_H
+#include "pub_tool_basics.h" // Word
+
//------------------------------------------------------------------//
//--- WordFM ---//
//--- Public interface ---//
Modified: trunk/include/pub_tool_xarray.h
==============================================================================
--- trunk/include/pub_tool_xarray.h (original)
+++ trunk/include/pub_tool_xarray.h Sun Sep 15 13:54:34 2013
@@ -31,6 +31,8 @@
#ifndef __PUB_TOOL_XARRAY_H
#define __PUB_TOOL_XARRAY_H
+#include "pub_tool_basics.h" // Word
+
//--------------------------------------------------------------------
// PURPOSE: Provides a simple but useful structure, which is an array
// in which elements can be added at the end. The array is expanded
|
|
From: <sv...@va...> - 2013-09-15 10:42:40
|
Author: florian
Date: Sun Sep 15 10:42:26 2013
New Revision: 13548
Log:
Fix inclusion of header files in coregrind. No pub_tool_*.h should be
included here.
Added pub_core_poolalloc.h and renamed pub_tool_inner.h to pub_core_inner.h.
Added:
trunk/coregrind/pub_core_inner.h
- copied, changed from r13537, trunk/include/pub_tool_inner.h
trunk/coregrind/pub_core_poolalloc.h
Modified:
trunk/coregrind/Makefile.am
trunk/coregrind/m_debuginfo/image.c
trunk/coregrind/m_gdbserver/m_gdbserver.c
trunk/coregrind/m_gdbserver/server.h
trunk/coregrind/m_gdbserver/target.c
trunk/coregrind/m_gdbserver/valgrind-low-arm.c
trunk/coregrind/m_gdbserver/valgrind-low-mips32.c
trunk/coregrind/m_gdbserver/valgrind-low-mips64.c
trunk/coregrind/m_gdbserver/valgrind-low-ppc32.c
trunk/coregrind/m_gdbserver/valgrind-low-ppc64.c
trunk/coregrind/m_gdbserver/valgrind-low-s390x.c
trunk/coregrind/m_gdbserver/valgrind-low-x86.c
trunk/coregrind/m_libcprint.c
trunk/coregrind/m_machine.c
trunk/coregrind/m_main.c
trunk/coregrind/m_mallocfree.c
trunk/coregrind/m_oset.c
trunk/coregrind/m_poolalloc.c
trunk/coregrind/m_scheduler/sched-lock-generic.c
trunk/coregrind/m_scheduler/sched-lock.c
trunk/coregrind/m_scheduler/sema.c
trunk/coregrind/m_scheduler/ticket-lock-linux.c
trunk/coregrind/m_syswrap/syswrap-generic.c
trunk/coregrind/m_syswrap/syswrap-linux.c
trunk/coregrind/m_syswrap/syswrap-mips32-linux.c
trunk/coregrind/m_syswrap/syswrap-mips64-linux.c
trunk/coregrind/m_threadstate.c
trunk/coregrind/pub_core_debuglog.h
trunk/coregrind/pub_core_gdbserver.h
trunk/coregrind/pub_core_threadstate.h
trunk/include/Makefile.am
trunk/include/pub_tool_inner.h
Modified: trunk/coregrind/Makefile.am
==============================================================================
--- trunk/coregrind/Makefile.am (original)
+++ trunk/coregrind/Makefile.am Sun Sep 15 10:42:26 2013
@@ -156,6 +156,7 @@
pub_core_gdbserver.h \
pub_core_hashtable.h \
pub_core_initimg.h \
+ pub_core_inner.h \
pub_core_libcbase.h \
pub_core_libcassert.h \
pub_core_libcfile.h \
@@ -169,6 +170,7 @@
pub_core_options.h \
pub_core_oset.h \
pub_core_redir.h \
+ pub_core_poolalloc.h \
pub_core_replacemalloc.h\
pub_core_sbprofile.h \
pub_core_scheduler.h \
Modified: trunk/coregrind/m_debuginfo/image.c
==============================================================================
--- trunk/coregrind/m_debuginfo/image.c (original)
+++ trunk/coregrind/m_debuginfo/image.c Sun Sep 15 10:42:26 2013
@@ -39,11 +39,11 @@
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
#include "pub_core_libcprint.h"
+#include "pub_core_libcproc.h" /* VG_(read_millisecond_timer) */
#include "pub_core_libcfile.h"
#include "priv_misc.h" /* dinfo_zalloc/free/strdup */
#include "priv_image.h" /* self */
-#include "pub_tool_libcproc.h" // RMME
#include "minilzo.h"
#define CACHE_ENTRY_SIZE_BITS (12+1)
Modified: trunk/coregrind/m_gdbserver/m_gdbserver.c
==============================================================================
--- trunk/coregrind/m_gdbserver/m_gdbserver.c (original)
+++ trunk/coregrind/m_gdbserver/m_gdbserver.c Sun Sep 15 10:42:26 2013
@@ -33,21 +33,21 @@
#include "pub_core_libcproc.h"
#include "pub_core_libcprint.h"
#include "pub_core_mallocfree.h"
-#include "pub_tool_libcsetjmp.h"
+#include "pub_core_libcsetjmp.h"
#include "pub_core_threadstate.h"
#include "pub_core_gdbserver.h"
#include "pub_core_options.h"
#include "pub_core_libcsetjmp.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
-#include "pub_tool_hashtable.h"
-#include "pub_tool_xarray.h"
+#include "pub_core_hashtable.h"
+#include "pub_core_xarray.h"
#include "pub_core_libcassert.h"
-#include "pub_tool_libcbase.h"
+#include "pub_core_libcbase.h"
#include "pub_core_libcsignal.h"
#include "pub_core_signals.h"
-#include "pub_tool_machine.h" // VG_(fnptr_to_fnentry)
-#include "pub_tool_debuginfo.h"
+#include "pub_core_machine.h" // VG_(fnptr_to_fnentry)
+#include "pub_core_debuginfo.h"
#include "pub_core_scheduler.h"
#include "pub_core_syswrap.h"
Modified: trunk/coregrind/m_gdbserver/server.h
==============================================================================
--- trunk/coregrind/m_gdbserver/server.h (original)
+++ trunk/coregrind/m_gdbserver/server.h Sun Sep 15 10:42:26 2013
@@ -35,16 +35,16 @@
#include "pub_core_libcprint.h"
#include "pub_core_mallocfree.h"
#include "pub_core_syscall.h"
-#include "pub_tool_libcproc.h"
+#include "pub_core_libcproc.h"
#include "pub_core_tooliface.h"
-#include "pub_tool_libcassert.h"
-#include "pub_tool_libcbase.h"
-#include "pub_tool_options.h"
-#include "pub_tool_libcsetjmp.h"
+#include "pub_core_libcassert.h"
+#include "pub_core_libcbase.h"
+#include "pub_core_options.h"
+#include "pub_core_libcsetjmp.h"
#include "pub_core_threadstate.h"
#include "pub_core_gdbserver.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_vki.h"
+#include "pub_core_vki.h"
#include "valgrind.h"
/*------------- interface m_gdbserver <=> low level gdbserver */
Modified: trunk/coregrind/m_gdbserver/target.c
==============================================================================
--- trunk/coregrind/m_gdbserver/target.c (original)
+++ trunk/coregrind/m_gdbserver/target.c Sun Sep 15 10:42:26 2013
@@ -29,11 +29,11 @@
#include "valgrind_low.h"
#include "gdb/signals.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
#include "pub_core_gdbserver.h"
-#include "pub_tool_debuginfo.h"
+#include "pub_core_debuginfo.h"
/* the_low_target defines the architecture specific aspects depending
Modified: trunk/coregrind/m_gdbserver/valgrind-low-arm.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-arm.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-arm.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
#include "pub_core_gdbserver.h"
Modified: trunk/coregrind/m_gdbserver/valgrind-low-mips32.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-mips32.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-mips32.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_debuginfo.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
Modified: trunk/coregrind/m_gdbserver/valgrind-low-mips64.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-mips64.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-mips64.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_debuginfo.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
Modified: trunk/coregrind/m_gdbserver/valgrind-low-ppc32.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-ppc32.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-ppc32.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
#include "pub_core_gdbserver.h"
Modified: trunk/coregrind/m_gdbserver/valgrind-low-ppc64.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-ppc64.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-ppc64.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
#include "pub_core_gdbserver.h"
Modified: trunk/coregrind/m_gdbserver/valgrind-low-s390x.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-s390x.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-s390x.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
#include "pub_core_gdbserver.h"
Modified: trunk/coregrind/m_gdbserver/valgrind-low-x86.c
==============================================================================
--- trunk/coregrind/m_gdbserver/valgrind-low-x86.c (original)
+++ trunk/coregrind/m_gdbserver/valgrind-low-x86.c Sun Sep 15 10:42:26 2013
@@ -27,7 +27,7 @@
#include "regcache.h"
#include "pub_core_aspacemgr.h"
-#include "pub_tool_machine.h"
+#include "pub_core_machine.h"
#include "pub_core_threadstate.h"
#include "pub_core_transtab.h"
#include "pub_core_gdbserver.h"
Modified: trunk/coregrind/m_libcprint.c
==============================================================================
--- trunk/coregrind/m_libcprint.c (original)
+++ trunk/coregrind/m_libcprint.c Sun Sep 15 10:42:26 2013
@@ -31,7 +31,7 @@
#include "pub_core_basics.h"
#include "pub_core_vki.h"
#include "pub_core_debuglog.h"
-#include "pub_tool_gdbserver.h" // VG_(gdb_printf)
+#include "pub_core_gdbserver.h" // VG_(gdb_printf)
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
#include "pub_core_libcfile.h" // VG_(write)(), VG_(write_socket)()
Modified: trunk/coregrind/m_machine.c
==============================================================================
--- trunk/coregrind/m_machine.c (original)
+++ trunk/coregrind/m_machine.c Sun Sep 15 10:42:26 2013
@@ -445,7 +445,7 @@
testing, so we need a VG_MINIMAL_JMP_BUF. */
#if defined(VGA_ppc32) || defined(VGA_ppc64) \
|| defined(VGA_arm) || defined(VGA_s390x) || defined(VGA_mips32)
-#include "pub_tool_libcsetjmp.h"
+#include "pub_core_libcsetjmp.h"
static VG_MINIMAL_JMP_BUF(env_unsup_insn);
static void handler_unsup_insn ( Int x ) {
VG_MINIMAL_LONGJMP(env_unsup_insn);
Modified: trunk/coregrind/m_main.c
==============================================================================
--- trunk/coregrind/m_main.c (original)
+++ trunk/coregrind/m_main.c Sun Sep 15 10:42:26 2013
@@ -66,7 +66,7 @@
#include "pub_core_translate.h" // For VG_(translate)
#include "pub_core_trampoline.h"
#include "pub_core_transtab.h"
-#include "pub_tool_inner.h"
+#include "pub_core_inner.h"
#if defined(ENABLE_INNER_CLIENT_REQUEST)
#include "valgrind.h"
#endif
Modified: trunk/coregrind/m_mallocfree.c
==============================================================================
--- trunk/coregrind/m_mallocfree.c (original)
+++ trunk/coregrind/m_mallocfree.c Sun Sep 15 10:42:26 2013
@@ -43,7 +43,7 @@
#include "pub_core_transtab.h"
#include "pub_core_tooliface.h"
-#include "pub_tool_inner.h"
+#include "pub_core_inner.h"
#if defined(ENABLE_INNER_CLIENT_REQUEST)
#include "memcheck/memcheck.h"
#endif
Modified: trunk/coregrind/m_oset.c
==============================================================================
--- trunk/coregrind/m_oset.c (original)
+++ trunk/coregrind/m_oset.c Sun Sep 15 10:42:26 2013
@@ -80,7 +80,7 @@
#include "pub_core_libcassert.h"
#include "pub_core_libcprint.h"
#include "pub_core_oset.h"
-#include "pub_tool_poolalloc.h"
+#include "pub_core_poolalloc.h"
/*--------------------------------------------------------------------*/
/*--- Types and constants ---*/
Modified: trunk/coregrind/m_poolalloc.c
==============================================================================
--- trunk/coregrind/m_poolalloc.c (original)
+++ trunk/coregrind/m_poolalloc.c Sun Sep 15 10:42:26 2013
@@ -29,8 +29,8 @@
#include "pub_core_basics.h"
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
-#include "pub_tool_xarray.h"
-#include "pub_tool_poolalloc.h" /* self */
+#include "pub_core_xarray.h"
+#include "pub_core_poolalloc.h" /* self */
struct _PoolAlloc {
UWord nrRef; /* nr reference to this pool allocator */
Modified: trunk/coregrind/m_scheduler/sched-lock-generic.c
==============================================================================
--- trunk/coregrind/m_scheduler/sched-lock-generic.c (original)
+++ trunk/coregrind/m_scheduler/sched-lock-generic.c Sun Sep 15 10:42:26 2013
@@ -32,7 +32,7 @@
*/
#include "pub_core_basics.h"
-#include "pub_tool_mallocfree.h"
+#include "pub_core_mallocfree.h"
#include "priv_sema.h"
#include "priv_sched-lock.h"
#include "priv_sched-lock-impl.h"
Modified: trunk/coregrind/m_scheduler/sched-lock.c
==============================================================================
--- trunk/coregrind/m_scheduler/sched-lock.c (original)
+++ trunk/coregrind/m_scheduler/sched-lock.c Sun Sep 15 10:42:26 2013
@@ -29,8 +29,8 @@
#include "config.h"
#include "pub_core_basics.h"
-#include "pub_tool_libcbase.h"
-#include "pub_tool_mallocfree.h"
+#include "pub_core_libcbase.h"
+#include "pub_core_mallocfree.h"
#include "priv_sema.h"
#include "priv_sched-lock.h"
#include "priv_sched-lock-impl.h"
Modified: trunk/coregrind/m_scheduler/sema.c
==============================================================================
--- trunk/coregrind/m_scheduler/sema.c (original)
+++ trunk/coregrind/m_scheduler/sema.c Sun Sep 15 10:42:26 2013
@@ -34,7 +34,7 @@
#include "pub_core_libcassert.h"
#include "pub_core_libcfile.h"
#include "pub_core_libcproc.h" // For VG_(gettid)()
-#include "pub_tool_inner.h"
+#include "pub_core_inner.h"
#if defined(ENABLE_INNER_CLIENT_REQUEST)
#include "helgrind/helgrind.h"
#endif
Modified: trunk/coregrind/m_scheduler/ticket-lock-linux.c
==============================================================================
--- trunk/coregrind/m_scheduler/ticket-lock-linux.c (original)
+++ trunk/coregrind/m_scheduler/ticket-lock-linux.c Sun Sep 15 10:42:26 2013
@@ -41,10 +41,10 @@
#include "pub_core_syscall.h"
#include "pub_core_vki.h"
#include "pub_core_vkiscnums.h" // __NR_futex
-#include "pub_tool_libcproc.h"
-#include "pub_tool_mallocfree.h"
-#include "pub_tool_threadstate.h"
-#include "pub_tool_inner.h"
+#include "pub_core_libcproc.h"
+#include "pub_core_mallocfree.h"
+#include "pub_core_threadstate.h"
+#include "pub_core_inner.h"
#if defined(ENABLE_INNER_CLIENT_REQUEST)
#include "helgrind/helgrind.h"
#endif
Modified: trunk/coregrind/m_syswrap/syswrap-generic.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-generic.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-generic.c Sun Sep 15 10:42:26 2013
@@ -43,7 +43,7 @@
#include "pub_core_clientstate.h" // VG_(brk_base), VG_(brk_limit)
#include "pub_core_debuglog.h"
#include "pub_core_errormgr.h"
-#include "pub_tool_gdbserver.h" // VG_(gdbserver)
+#include "pub_core_gdbserver.h" // VG_(gdbserver)
#include "pub_core_libcbase.h"
#include "pub_core_libcassert.h"
#include "pub_core_libcfile.h"
Modified: trunk/coregrind/m_syswrap/syswrap-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-linux.c Sun Sep 15 10:42:26 2013
@@ -55,7 +55,7 @@
#include "pub_core_signals.h"
#include "pub_core_syscall.h"
#include "pub_core_syswrap.h"
-#include "pub_tool_inner.h"
+#include "pub_core_inner.h"
#if defined(ENABLE_INNER_CLIENT_REQUEST)
#include "valgrind.h"
#endif
Modified: trunk/coregrind/m_syswrap/syswrap-mips32-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-mips32-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-mips32-linux.c Sun Sep 15 10:42:26 2013
@@ -59,7 +59,7 @@
#include "pub_core_xarray.h"
#include "pub_core_clientstate.h" // VG_(brk_base), VG_(brk_limit)
#include "pub_core_errormgr.h"
-#include "pub_tool_gdbserver.h" // VG_(gdbserver)
+#include "pub_coretool_gdbserver.h" // VG_(gdbserver)
#include "pub_core_libcfile.h"
#include "pub_core_machine.h" // VG_(get_SP)
#include "pub_core_mallocfree.h"
Modified: trunk/coregrind/m_syswrap/syswrap-mips64-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-mips64-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-mips64-linux.c Sun Sep 15 10:42:26 2013
@@ -59,7 +59,7 @@
#include "pub_core_xarray.h"
#include "pub_core_clientstate.h" /* VG_(brk_base), VG_(brk_limit) */
#include "pub_core_errormgr.h"
-#include "pub_tool_gdbserver.h" /* VG_(gdbserver) */
+#include "pub_core_gdbserver.h" /* VG_(gdbserver) */
#include "pub_core_libcfile.h"
#include "pub_core_machine.h" /* VG_(get_SP) */
#include "pub_core_mallocfree.h"
Modified: trunk/coregrind/m_threadstate.c
==============================================================================
--- trunk/coregrind/m_threadstate.c (original)
+++ trunk/coregrind/m_threadstate.c Sun Sep 15 10:42:26 2013
@@ -33,7 +33,7 @@
#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy
#include "pub_core_threadstate.h"
#include "pub_core_libcassert.h"
-#include "pub_tool_inner.h"
+#include "pub_core_inner.h"
#if defined(ENABLE_INNER_CLIENT_REQUEST)
#include "helgrind/helgrind.h"
#endif
Modified: trunk/coregrind/pub_core_debuglog.h
==============================================================================
--- trunk/coregrind/pub_core_debuglog.h (original)
+++ trunk/coregrind/pub_core_debuglog.h Sun Sep 15 10:42:26 2013
@@ -47,7 +47,7 @@
portable way to avoid using stdarg.h. */
#include <stdarg.h>
-#include "pub_tool_basics.h" /* For definition of VG_ macro */
+#include "pub_core_basics.h" /* For definition of VG_ macro */
/* There are no tool-visible exports from m_debuglog, hence no header
file for it. */
Modified: trunk/coregrind/pub_core_gdbserver.h
==============================================================================
--- trunk/coregrind/pub_core_gdbserver.h (original)
+++ trunk/coregrind/pub_core_gdbserver.h Sun Sep 15 10:42:26 2013
@@ -31,6 +31,7 @@
#define __PUB_CORE_GDBSERVER_H
#include "pub_tool_gdbserver.h"
+#include "pub_core_threadstate.h" // VgSchedReturnCode
/* Return the path prefix for the named pipes (FIFOs) used by vgdb/gdb
to communicate with valgrind */
Copied: trunk/coregrind/pub_core_inner.h (from r13537, trunk/include/pub_tool_inner.h)
==============================================================================
--- trunk/include/pub_tool_inner.h (original)
+++ trunk/coregrind/pub_core_inner.h Sun Sep 15 10:42:26 2013
@@ -1,6 +1,6 @@
/*--------------------------------------------------------------------*/
-/*--- Utilities for inner Valgrind pub_tool_inner.h ---*/
+/*--- Utilities for inner Valgrind pub_core_inner.h ---*/
/*--------------------------------------------------------------------*/
/*
@@ -28,8 +28,8 @@
The GNU General Public License is contained in the file COPYING.
*/
-#ifndef __PUB_TOOL_INNER_H
-#define __PUB_TOOL_INNER_H
+#ifndef __PUB_CORE_INNER_H
+#define __PUB_CORE_INNER_H
//--------------------------------------------------------------------
// PURPOSE: This header should be imported by every file in Valgrind
@@ -65,7 +65,7 @@
#endif
-#endif // __PUB_TOOL_INNER_H
+#endif // __PUB_CORE_INNER_H
/*--------------------------------------------------------------------*/
/*--- end ---*/
Added: trunk/coregrind/pub_core_poolalloc.h
==============================================================================
--- trunk/coregrind/pub_core_poolalloc.h (added)
+++ trunk/coregrind/pub_core_poolalloc.h Sun Sep 15 10:42:26 2013
@@ -0,0 +1,42 @@
+
+/*--------------------------------------------------------------------*/
+/*--- A simple pool (memory) allocator. pub_core_poolalloc.h ---*/
+/*--------------------------------------------------------------------*/
+
+/*
+ This file is part of Valgrind, a dynamic binary instrumentation
+ framework.
+
+ Copyright (C) 2013-2013 Florian Krohm fl...@ei...
+
+ This program is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public License as
+ published by the Free Software Foundation; either version 2 of the
+ License, or (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+ 02111-1307, USA.
+
+ The GNU General Public License is contained in the file COPYING.
+*/
+
+#ifndef __PUB_CORE_POOLALLOC_H
+#define __PUB_CORE_POOLALLOC_H
+
+#include "pub_tool_poolalloc.h"
+
+// No core-only exports; everything in this module is visible to both
+// the core and tools.
+
+#endif // __PUB_CORE_POOLALLOC_H
+
+/*--------------------------------------------------------------------*/
+/*--- end ---*/
+/*--------------------------------------------------------------------*/
Modified: trunk/coregrind/pub_core_threadstate.h
==============================================================================
--- trunk/coregrind/pub_core_threadstate.h (original)
+++ trunk/coregrind/pub_core_threadstate.h Sun Sep 15 10:42:26 2013
@@ -40,6 +40,7 @@
//--------------------------------------------------------------------
#include "pub_tool_threadstate.h"
+#include "pub_core_libcsetjmp.h" // VG_MINIMAL_JMP_BUF
/*------------------------------------------------------------*/
/*--- Types ---*/
Modified: trunk/include/Makefile.am
==============================================================================
--- trunk/include/Makefile.am (original)
+++ trunk/include/Makefile.am Sun Sep 15 10:42:26 2013
@@ -14,7 +14,6 @@
pub_tool_gdbserver.h \
pub_tool_poolalloc.h \
pub_tool_hashtable.h \
- pub_tool_inner.h \
pub_tool_libcbase.h \
pub_tool_libcassert.h \
pub_tool_libcfile.h \
|
|
From: <sv...@va...> - 2013-09-15 09:56:25
|
Author: florian
Date: Sun Sep 15 09:56:18 2013
New Revision: 13547
Log:
Fix include guard.
Modified:
trunk/include/pub_tool_poolalloc.h
Modified: trunk/include/pub_tool_poolalloc.h
==============================================================================
--- trunk/include/pub_tool_poolalloc.h (original)
+++ trunk/include/pub_tool_poolalloc.h Sun Sep 15 09:56:18 2013
@@ -1,6 +1,6 @@
/*--------------------------------------------------------------------*/
-/*--- A simple pool (memory) allocator. pub_tool_poolalloc.h ---*/
+/*--- A simple pool (memory) allocator. pub_tool_poolalloc.h ---*/
/*--------------------------------------------------------------------*/
/*
@@ -28,8 +28,8 @@
The GNU General Public License is contained in the file COPYING.
*/
-#ifndef __PUB_TOOL_GROUPALLOC_H
-#define __PUB_TOOL_GROUPALLOC_H
+#ifndef __PUB_TOOL_POOLALLOC_H
+#define __PUB_TOOL_POOLALLOC_H
//--------------------------------------------------------------------
// PURPOSE: Provides efficient allocation and free of elements of
|
Author: florian
Date: Sun Sep 15 09:18:03 2013
New Revision: 13546
Log:
Move a function and its prototype VG_(malloc_effective_client_redzone_size)
to a conceptually better place.
Modified:
trunk/coregrind/m_mallocfree.c
trunk/coregrind/m_replacemalloc/replacemalloc_core.c
trunk/coregrind/pub_core_mallocfree.h
trunk/include/pub_tool_mallocfree.h
trunk/include/pub_tool_replacemalloc.h
Modified: trunk/coregrind/m_mallocfree.c
==============================================================================
--- trunk/coregrind/m_mallocfree.c (original)
+++ trunk/coregrind/m_mallocfree.c Sun Sep 15 09:18:03 2013
@@ -511,16 +511,6 @@
return arena;
}
-SizeT VG_(malloc_effective_client_redzone_size)(void)
-{
- vg_assert(VG_(needs).malloc_replacement);
- ensure_mm_init (VG_AR_CLIENT);
- /* ensure_mm_init will call arena_init if not yet done.
- This then ensures that the arena redzone size is properly
- initialised. */
- return arenaId_to_ArenaP(VG_AR_CLIENT)->rz_szB;
-}
-
// Initialise an arena. rz_szB is the (default) minimum redzone size;
// It might be overriden by VG_(clo_redzone_size) or VG_(clo_core_redzone_size).
// it might be made bigger to ensure that VG_MIN_MALLOC_SZB is observed.
@@ -2186,6 +2176,14 @@
mi->keepcost = 0; // may want some value in here
}
+SizeT VG_(arena_redzone_size) ( ArenaId aid )
+{
+ ensure_mm_init (VG_AR_CLIENT);
+ /* ensure_mm_init will call arena_init if not yet done.
+ This then ensures that the arena redzone size is properly
+ initialised. */
+ return arenaId_to_ArenaP(aid)->rz_szB;
+}
/*------------------------------------------------------------*/
/*--- Services layered on top of malloc/free. ---*/
Modified: trunk/coregrind/m_replacemalloc/replacemalloc_core.c
==============================================================================
--- trunk/coregrind/m_replacemalloc/replacemalloc_core.c (original)
+++ trunk/coregrind/m_replacemalloc/replacemalloc_core.c Sun Sep 15 09:18:03 2013
@@ -31,6 +31,8 @@
#include "pub_core_basics.h"
#include "pub_core_libcbase.h"
#include "pub_core_libcprint.h"
+#include "pub_core_libcassert.h"
+#include "pub_core_tooliface.h" // VG_(needs)
#include "pub_core_mallocfree.h"
#include "pub_core_options.h"
#include "pub_core_replacemalloc.h"
@@ -71,6 +73,13 @@
return True;
}
+SizeT VG_(malloc_effective_client_redzone_size)(void)
+{
+ vg_assert(VG_(needs).malloc_replacement);
+
+ return VG_(arena_redzone_size)(VG_AR_CLIENT);
+}
+
/*------------------------------------------------------------*/
/*--- Useful functions ---*/
/*------------------------------------------------------------*/
Modified: trunk/coregrind/pub_core_mallocfree.h
==============================================================================
--- trunk/coregrind/pub_core_mallocfree.h (original)
+++ trunk/coregrind/pub_core_mallocfree.h Sun Sep 15 09:18:03 2013
@@ -117,6 +117,8 @@
extern SizeT VG_(arena_malloc_usable_size) ( ArenaId aid, void* payload );
+extern SizeT VG_(arena_redzone_size) ( ArenaId aid );
+
extern void VG_(mallinfo) ( ThreadId tid, struct vg_mallinfo* mi );
// VG_(arena_perm_malloc) is for permanent allocation of small blocks.
Modified: trunk/include/pub_tool_mallocfree.h
==============================================================================
--- trunk/include/pub_tool_mallocfree.h (original)
+++ trunk/include/pub_tool_mallocfree.h Sun Sep 15 09:18:03 2013
@@ -47,15 +47,6 @@
// possibly some more due to rounding up.
extern SizeT VG_(malloc_usable_size)( void* p );
-
-// If tool is replacing malloc for the client, the below returns
-// the effective client redzone as derived from the default
-// provided by the tool, VG_(clo_redzone_size) and the minimum
-// redzone required by m_mallocfree.c.
-// It is an error to call this before VG_(needs_malloc_replacement) has
-// been called.
-extern SizeT VG_(malloc_effective_client_redzone_size)(void);
-
// TODO: move somewhere else
// Call here to bomb the system when out of memory (mmap anon fails)
__attribute__((noreturn))
Modified: trunk/include/pub_tool_replacemalloc.h
==============================================================================
--- trunk/include/pub_tool_replacemalloc.h (original)
+++ trunk/include/pub_tool_replacemalloc.h Sun Sep 15 09:18:03 2013
@@ -65,6 +65,14 @@
extern Bool VG_(replacement_malloc_process_cmd_line_option) ( const HChar* arg );
+// If tool is replacing malloc for the client, the below returns
+// the effective client redzone as derived from the default
+// provided by the tool, VG_(clo_redzone_size) and the minimum
+// redzone required by m_mallocfree.c.
+// It is an error to call this before VG_(needs_malloc_replacement) has
+// been called.
+extern SizeT VG_(malloc_effective_client_redzone_size)(void);
+
#endif // __PUB_TOOL_REPLACEMALLOC_H
/*--------------------------------------------------------------------*/
|