You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
|
1
(6) |
|
2
(6) |
3
(9) |
4
(4) |
5
(1) |
6
|
7
|
8
|
|
9
|
10
(2) |
11
(1) |
12
(2) |
13
(4) |
14
(6) |
15
(8) |
|
16
(9) |
17
(5) |
18
(13) |
19
(6) |
20
(15) |
21
(17) |
22
(19) |
|
23
(2) |
24
(4) |
25
(2) |
26
(10) |
27
(6) |
28
(9) |
29
(3) |
|
30
|
|
|
|
|
|
|
|
From: Carl L. <ce...@us...> - 2023-04-28 19:57:10
|
On Fri, 2023-04-28 at 20:30 +0200, Paul Floyd wrote:
>
> On 28-04-23 18:04, Carl Love wrote:
>
> > I don't see any explicit "post" errors printed? So I am clearly
> > missing something. :-)
> >
>
< snip >
> Unfortunately the pesky libc and libstdc++ can get in the way and do
> other, system dependent allocations. These allocations are for stuff
> like exception handlers and dynamic loading.
>
> The --ignore-fn options are supposed to filter out all those extras,
> leaving us with only the calls to operator new and delete.
>
> I thought that you might have a different function on power 10. But
> looking at the diff from what you posted I only see
>
> 47c42
> < ->33.24% (4,000B) 0x........: main (new-cpp.cpp:20)
> ---
> > ->33.24% (4,000B) 0x........: main (new-cpp.cpp:20)
>
> That's an extra trailing whitespace.
>
> Could you post the post.diff files, if they aren't too big?
OK, not too big. Here is the diff.
--- new-cpp.post.exp 2023-04-21 20:54:40.000000000 -0400
+++ new-cpp.post.out 2023-04-24 16:29:56.907990371 -0400
@@ -6,54 +6,61 @@
KB
-11.75^ ###########
- | #
- | #
- | #
- | :::::::#
- | : #
- | : #
- | ::::::: # ::::::::::::
- | : : # :
- | : : # :
- | : : # :
- | : : # :
- | : : # :
- | : : # :
- | ::::::::::::: : # : ::::::
- | : : : # : :
- | : : : # : :
- | : : : # : : ::::::
- | : : : # : : :
- | : : : # : : :
+82.76^ #
+ | ::#::
+ | ::::#: :
+ | ::: ::#: ::::::::::::::::::::::::::::::::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
+ | : : ::#: :::
0 +----------------------------------------------------------------------->K
B
- 0 23.50
+ 0 165.5
-Number of snapshots: 10
- Detailed snapshots: [5 (peak)]
+Number of snapshots: 12
+ Detailed snapshots: [6 (peak)]
-------------------------------------------------------------------------------
-
n time(B) total(B) useful-heap(B) extra-heap(B) stacks(B)
-------------------------------------------------------------------------------
-
0 0 0 0 0 0
- 1 4,008 4,008 4,000 8 0
- 2 8,016 8,016 8,000 16 0
- 3 10,024 10,024 10,000 24 0
- 4 12,032 12,032 12,000 32 0
- 5 12,032 12,032 12,000 32 0
-99.73% (12,000B) (heap allocation functions) malloc/new/new[], --alloc-fns, etc
.
-->33.24% (4,000B) 0x........: main (new-cpp.cpp:19)
+ 1 72,712 72,712 72,704 8 0
+ 2 76,720 76,720 76,704 16 0
+ 3 80,728 80,728 80,704 24 0
+ 4 82,736 82,736 82,704 32 0
+ 5 84,744 84,744 84,704 40 0
+ 6 84,744 84,744 84,704 40 0
+99.95% (84,704B) (heap allocation functions) malloc/new/new[], --alloc-fns, etc
.
+->85.79% (72,704B) 0x........: ??? (m_trampoline.S:458)
+| ->85.79% (72,704B) 0x........: call_init (dl-init.c:70)
+| ->85.79% (72,704B) 0x........: _dl_init (dl-init.c:117)
+| ->85.79% (72,704B) 0x........: _dl_start_user (in /usr/lib64/ld64.so.2)
+|
+->04.72% (4,000B) 0x........: main (new-cpp.cpp:19)
|
-->33.24% (4,000B) 0x........: main (new-cpp.cpp:20)
+->04.72% (4,000B) 0x........: main (new-cpp.cpp:20)
|
-->16.62% (2,000B) 0x........: main (new-cpp.cpp:21)
+->02.36% (2,000B) 0x........: main (new-cpp.cpp:21)
|
-->16.62% (2,000B) 0x........: main (new-cpp.cpp:22)
+->02.36% (2,000B) 0x........: main (new-cpp.cpp:22)
-------------------------------------------------------------------------------
-
n time(B) total(B) useful-heap(B) extra-heap(B) stacks(B)
-------------------------------------------------------------------------------
-
- 6 16,040 8,024 8,000 24 0
- 7 20,048 4,016 4,000 16 0
- 8 22,056 2,008 2,000 8 0
- 9 24,064 0 0 0 0
+ 7 88,752 80,736 80,704 32 0
+ 8 92,760 76,728 76,704 24 0
+ 9 94,768 74,720 74,704 16 0
+ 10 96,776 72,712 72,704 8 0
+ 11 169,488 0 0 0 0
|
|
From: Paul F. <pj...@wa...> - 2023-04-28 18:31:10
|
On 28-04-23 18:04, Carl Love wrote:
> I don't see any explicit "post" errors printed? So I am clearly
> missing something. :-)
>
> I am hoping you can give me a hint here as I am not seeing where the
> issue with the test is. Thanks.
Hi Carl
The test is supposed to be profiling calls to new. That should turn
s* p1 = new s;
s* p2 = new (std::nothrow) s;
char* c1 = new char[2000];
char* c2 = new (std::nothrow) char[2000];
into
KB
11.75^ ###########
| #
| #
| #
| :::::::#
| : #
| : #
| ::::::: # ::::::::::::
| : : # :
| : : # :
| : : # :
| : : # :
| : : # :
| : : # :
| ::::::::::::: : # : ::::::
| : : : # : :
| : : : # : :
| : : : # : : :
| : : : # : : :
| : : : # : : :
0
+----------------------------------------------------------------------->KB
0
23.50
Unfortunately the pesky libc and libstdc++ can get in the way and do
other, system dependent allocations. These allocations are for stuff
like exception handlers and dynamic loading.
The --ignore-fn options are supposed to filter out all those extras,
leaving us with only the calls to operator new and delete.
I thought that you might have a different function on power 10. But
looking at the diff from what you posted I only see
47c42
< ->33.24% (4,000B) 0x........: main (new-cpp.cpp:20)
---
> ->33.24% (4,000B) 0x........: main (new-cpp.cpp:20)
That's an extra trailing whitespace.
Could you post the post.diff files, if they aren't too big?
A+
Paul
|
|
From: Carl L. <ce...@us...> - 2023-04-28 17:42:13
|
Paul:
On Thu, 2023-04-27 at 22:01 +0200, Paul Floyd wrote:
> On 24/04/2023 23:29, Carl Love via Valgrind-developers wrote:
> > == 714 tests, 2 stderr failures, 0 stdout failures, 0 stderrB
> > failures,
> > 0 stdoutB failures, 2 post failures ==
> > massif/tests/new-cpp (post)
> > massif/tests/overloaded-new (post)
> >
> And these two might be easy to fix if you run the testcase normally
> and
> see if you can identify the extra allocating functions and add them
> to
> the vgtest files in the --ignore-fn list.
So, just playing around with this to try and understand what causes the
post failures.
Looking at the new-cpp.vgtest file and the output from running regtes,
It looks like the test is run with the command (edited a little to make
it readable):
valgrind --tool=massif --stacks=no --time-unit=B --massif-out-file=massif.out
--ignore-fn=__part_load_locale --ignore-fn=__time_load_locale
--ignore-fn=dwarf2_unwind_dyld_add_image_hook --ignore-fn=get_or_create_key_element
--ignore-fn=_GLOBAL__sub_I_eh_alloc.cc --ignore-fn=call_init.part.0
--ignore-fn=call_init ./new-cpp
The command line output is:
==789558== Massif, a heap profiler
==789558== Copyright (C) 2003-2017, and GNU GPL'd, by Nicholas Nethercote
==789558== Using Valgrind-3.21.0.RC2 and LibVEX; rerun with -h for copyright info
==789558== Command: ./new-cpp
==789558==
==789558==
The contents of the output file massif.out is:
time_unit: B
#-----------
snapshot=0
#-----------
time=0
mem_heap_B=0
mem_heap_extra_B=0
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=1
#-----------
time=4008
mem_heap_B=4000
mem_heap_extra_B=8
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=2
#-----------
time=8016
mem_heap_B=8000
mem_heap_extra_B=16
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=3
#-----------
time=10024
mem_heap_B=10000
mem_heap_extra_B=24
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=4
#-----------
time=12032
mem_heap_B=12000
mem_heap_extra_B=32
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=5
#-----------
time=12032
mem_heap_B=12000
mem_heap_extra_B=32
mem_stacks_B=0
heap_tree=peak
n4: 12000 (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
n0: 4000 0x10000973: main (new-cpp.cpp:19)
n0: 4000 0x1000098F: main (new-cpp.cpp:20)
n0: 2000 0x100009A3: main (new-cpp.cpp:21)
n0: 2000 0x100009BB: main (new-cpp.cpp:22)
#-----------
snapshot=6
#-----------
time=16040
mem_heap_B=8000
mem_heap_extra_B=24
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=7
#-----------
time=20048
mem_heap_B=4000
mem_heap_extra_B=16
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=8
#-----------
time=22056
mem_heap_B=2000
mem_heap_extra_B=8
mem_stacks_B=0
heap_tree=empty
#-----------
snapshot=9
#-----------
time=24064
mem_heap_B=0
mem_heap_extra_B=0
mem_stacks_B=0
heap_tree=empty
I then ran the perl script:
perl ../../massif/ms_print massif.out | sed 's/gcc[0-9]*/gcc/' | ../../tests/filter_addresses
KB
11.75^ ###########
| #
| #
| #
| :::::::#
| : #
| : #
| ::::::: # ::::::::::::
| : : # :
| : : # :
| : : # :
| : : # :
| : : # :
| : : # :
| ::::::::::::: : # : ::::::
| : : : # : :
| : : : # : :
| : : : # : : ::::::
| : : : # : : :
| : : : # : : :
0 +----------------------------------------------------------------------->KB
0 23.50
Number of snapshots: 10
Detailed snapshots: [5 (peak)]
--------------------------------------------------------------------------------
n time(B) total(B) useful-heap(B) extra-heap(B) stacks(B)
--------------------------------------------------------------------------------
0 0 0 0 0 0
1 4,008 4,008 4,000 8 0
2 8,016 8,016 8,000 16 0
3 10,024 10,024 10,000 24 0
4 12,032 12,032 12,000 32 0
5 12,032 12,032 12,000 32 0
99.73% (12,000B) (heap allocation functions) malloc/new/new[], --alloc-fns, etc.
->33.24% (4,000B) 0x........: main (new-cpp.cpp:19)
|
->33.24% (4,000B) 0x........: main (new-cpp.cpp:20)
|
->16.62% (2,000B) 0x........: main (new-cpp.cpp:21)
|
->16.62% (2,000B) 0x........: main (new-cpp.cpp:22)
--------------------------------------------------------------------------------
n time(B) total(B) useful-heap(B) extra-heap(B) stacks(B)
--------------------------------------------------------------------------------
6 16,040 8,024 8,000 24 0
7 20,048 4,016 4,000 16 0
8 22,056 2,008 2,000 8 0
9 24,064 0 0 0 0
I don't see any explicit "post" errors printed? So I am clearly
missing something. :-)
I am hoping you can give me a hint here as I am not seeing where the
issue with the test is. Thanks.
Carl
|
|
From: Mark W. <ma...@so...> - 2023-04-28 16:04:56
|
The signed tag 'VALGRIND_3_21_0' was created pointing to:
d97fed7c3e... -> 3.21.0 final
Tagger: Mark Wielaard <ma...@kl...>
Date: Fri Apr 28 18:04:18 2023 +0200
valgrind 3.21.0 release
|
|
From: Mark W. <ma...@so...> - 2023-04-28 15:52:52
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=071742f11b8966d6eb4f06d7a14693cb07efe64f commit 071742f11b8966d6eb4f06d7a14693cb07efe64f Author: Mark Wielaard <ma...@kl...> Date: Fri Apr 28 17:27:35 2023 +0200 Add bug 469049 (--enable-lto=yes) to known issues Diff: --- NEWS | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index 118c5e65d0..510f21fc2a 100644 --- a/NEWS +++ b/NEWS @@ -195,6 +195,11 @@ To see details of a given bug, visit https://bugs.kde.org/show_bug.cgi?id=XXXXXX where XXXXXX is the bug number as listed above. +* ==================== KNOWN ISSUES =================== + +* configure --enable-lto=yes is know to not work in all setups. + See bug 469049. Workaround: Build without LTO. + (3.21.0.RC1: 14 Apr 2023) (3.21.0.RC2: 21 Apr 2023) |
|
From: Mark W. <ma...@so...> - 2023-04-28 15:52:51
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=d97fed7c3e4aa7c910dfa0b6c5de12fd6cf08155 commit d97fed7c3e4aa7c910dfa0b6c5de12fd6cf08155 Author: Mark Wielaard <ma...@kl...> Date: Fri Apr 28 17:30:04 2023 +0200 -> 3.21.0 final Diff: --- NEWS | 2 +- configure.ac | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 510f21fc2a..342a733650 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Release 3.21.0 (?? Apr 2023) +Release 3.21.0 (28 Apr 2023) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This release supports X86/Linux, AMD64/Linux, ARM32/Linux, ARM64/Linux, diff --git a/configure.ac b/configure.ac index d1af9de0d3..79b17f3940 100755 --- a/configure.ac +++ b/configure.ac @@ -17,8 +17,8 @@ m4_define([v_major_ver], [3]) m4_define([v_minor_ver], [21]) m4_define([v_micro_ver], [0]) -m4_define([v_suffix_ver], [RC2]) -m4_define([v_rel_date], ["21 Apr 2023"]) +m4_define([v_suffix_ver], []) +m4_define([v_rel_date], ["28 Apr 2023"]) m4_define([v_version], m4_if(v_suffix_ver, [], [v_major_ver.v_minor_ver.v_micro_ver], |
|
From: Mark W. <ma...@so...> - 2023-04-28 13:11:17
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=b4ec6a6ff767098714ffa8c4e3e3081d98fd2d66 commit b4ec6a6ff767098714ffa8c4e3e3081d98fd2d66 Author: Mark Wielaard <ma...@kl...> Date: Fri Apr 28 13:34:48 2023 +0200 Support SCV_FLAG also on VGP_ppc64be_linux Running on a kernel that supports the SCV instruction (sets PPC_FEATURE2_SCV in auxv AT_HWCAPS2) valgrind will assert: valgrind: m_syswrap/syswrap-main.c:549 (getSyscallArgsFromGuestState): Assertion 'gst->guest_syscall_flag == SC_FLAG' failed. Removing that assert makes most things work. But also filter out PPC_FEATURE2_SCV from AT_HWCAPS2 for the client, so it shouldn't try using the SCV instruction. https://bugs.kde.org/show_bug.cgi?id=469097 Diff: --- NEWS | 1 + coregrind/m_initimg/initimg-linux.c | 4 ++++ coregrind/m_syswrap/syswrap-main.c | 5 ----- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index 22d5d4a1d8..118c5e65d0 100644 --- a/NEWS +++ b/NEWS @@ -188,6 +188,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. 468401 [PATCH] Add a style file for clang-format 468556 Build failure for vgdb 468606 build: remove "Valgrind relies on GCC" check/output +469097 ppc64(be) doesn't support SCV syscall instruction n-i-bz FreeBSD rfork syscall fail with EINVAL or ENOSYS rather than VG_(unimplemented) To see details of a given bug, visit diff --git a/coregrind/m_initimg/initimg-linux.c b/coregrind/m_initimg/initimg-linux.c index 4da9a8b976..7a7d453350 100644 --- a/coregrind/m_initimg/initimg-linux.c +++ b/coregrind/m_initimg/initimg-linux.c @@ -852,7 +852,11 @@ Addr setup_client_stack( void* init_sp, | 0x04000000ULL /* TAR */ | 0x04000000ULL /* VEC_CRYPTO */ | 0x00800000ULL /* ARCH_3_00 */ +#if defined(VGP_ppc64le_linux) + /* Should also be supported on ppc64be, + but see https://bugs.kde.org/show_bug.cgi?id=469097 */ | 0x00100000ULL /* PPC_FEATURE2_SCV */ +#endif | 0x00400000ULL /* HAS_IEEE128 */ | 0x00200000ULL /* PPC_FEATURE2_DARN */ | 0x00040000ULL /* ARCH_3_1 */ diff --git a/coregrind/m_syswrap/syswrap-main.c b/coregrind/m_syswrap/syswrap-main.c index abd8472e92..4f8c0fe1cb 100644 --- a/coregrind/m_syswrap/syswrap-main.c +++ b/coregrind/m_syswrap/syswrap-main.c @@ -544,11 +544,6 @@ void getSyscallArgsFromGuestState ( /*OUT*/SyscallArgs* canonical, canonical->arg7 = gst->guest_syscall_flag; canonical->arg8 = 0; -#if defined(VGP_ppc64be_linux) - /* The sc instruction is currently only supported on LE systems. */ - vg_assert(gst->guest_syscall_flag == SC_FLAG); -#endif - #elif defined(VGP_x86_freebsd) VexGuestX86State* gst = (VexGuestX86State*)gst_vanilla; UWord *stack = (UWord *)gst->guest_ESP; |
|
From: Nicholas N. <n.n...@gm...> - 2023-04-28 06:08:27
|
On Fri, 28 Apr 2023 at 03:08, Bart Van Assche <bva...@ac...> wrote: > > Can you name one major open source project written in C or C++, that is > not controlled by Mozilla and that enforces the formatting of the code by > rejecting push requests that do not comply with the code style of that > project? > MongoDB <https://github.com/mongodb/mongo/wiki/Server-Code-Style>, Blender <https://wiki.blender.org/wiki/Tools/ClangFormat>, Godot <https://docs.godotengine.org/en/stable/contributing/development/code_style_guidelines.html> all mandate the use of clang-format. (I didn't check whether they enforce this with a pre-push check, but the language in the linked documents makes it clear that auto-formatting is mandatory.) There's no good reason to ignore other languages, though. I know for certain that mandatory autoformatting is ubiquitous in Rust projects, with rustc and Cargo being obvious examples. I suspect there are countless Go and Swift projects that use it too. Nick |
|
From: Nicholas N. <nj...@so...> - 2023-04-28 00:31:27
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=d061b81f402f92df63a9843743259cd7fb68e477 commit d061b81f402f92df63a9843743259cd7fb68e477 Author: Nicholas Nethercote <n.n...@gm...> Date: Fri Apr 28 10:28:30 2023 +1000 Only do git configuration if in a git repo. Diff: --- autogen.sh | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/autogen.sh b/autogen.sh index 27f54f7d62..611bb14618 100755 --- a/autogen.sh +++ b/autogen.sh @@ -16,6 +16,10 @@ run autoheader run automake -a run autoconf -# Valgrind-specific Git configuration. -echo "running: git configuration" -git config blame.ignoreRevsFile .git-blame-ignore-revs +# Valgrind-specific Git configuration, if appropriate. +if git rev-parse --is-inside-work-tree > /dev/null 2>&1 ; then + echo "running: git configuration" + git config blame.ignoreRevsFile .git-blame-ignore-revs +else + echo "skipping: git configuration" +fi |