You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
1
|
2
|
3
|
|
4
|
5
|
6
|
7
(1) |
8
|
9
|
10
|
|
11
|
12
|
13
|
14
|
15
|
16
|
17
|
|
18
|
19
|
20
|
21
|
22
(4) |
23
(3) |
24
(2) |
|
25
(9) |
26
(2) |
27
(1) |
28
|
29
(7) |
30
(5) |
31
(2) |
|
From: Paul F. <pa...@so...> - 2022-12-23 15:53:51
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=2de91d914cc5ed4ed7ea8e70d5e06c46e991f39f commit 2de91d914cc5ed4ed7ea8e70d5e06c46e991f39f Author: Paul Floyd <pj...@wa...> Date: Fri Dec 23 16:49:20 2022 +0100 Bug 444488 - Use glibc.pthread.stack_cache_size tunable Try to use GLIBC_TUNABLES to disable the pthread stack cache. Diff: --- NEWS | 1 + coregrind/m_clientstate.c | 2 ++ coregrind/m_initimg/initimg-linux.c | 61 +++++++++++++++++++++++++++++-------- coregrind/m_redir.c | 19 +++++++++++- coregrind/m_scheduler/scheduler.c | 32 +++++++++++++++++-- coregrind/pub_core_clientstate.h | 2 ++ 6 files changed, 102 insertions(+), 15 deletions(-) diff --git a/NEWS b/NEWS index c9376dcca9..4dd33a364e 100644 --- a/NEWS +++ b/NEWS @@ -25,6 +25,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. 170510 Don't warn about ioctl of size 0 without direction hint 351857 confusing error message about valid command line option 444110 priv/guest_ppc_toIR.c:36198:31: warning: duplicated 'if' condition. +444488 Use glibc.pthread.stack_cache_size tunable 459476 vgdb: allow address reuse to avoid "address already in use" errorsuse" errors 462830 WARNING: unhandled amd64-freebsd syscall: 474 463027 broken check for MPX instruction support in assembler diff --git a/coregrind/m_clientstate.c b/coregrind/m_clientstate.c index 23c846d6b8..93662dcb3d 100644 --- a/coregrind/m_clientstate.c +++ b/coregrind/m_clientstate.c @@ -121,6 +121,8 @@ Addr VG_(client__dl_sysinfo_int80) = 0; in nptl/allocatestack.c */ SizeT* VG_(client__stack_cache_actsize__addr) = 0; +client__gnu_get_libc_version_type VG_(client__gnu_get_libc_version_addr) = 0; + #if defined(VGO_solaris) /* Address of variable vg_vfork_fildes in vgpreload_core.so.0 (vg_preloaded.c). */ diff --git a/coregrind/m_initimg/initimg-linux.c b/coregrind/m_initimg/initimg-linux.c index 48df8c1225..4da9a8b976 100644 --- a/coregrind/m_initimg/initimg-linux.c +++ b/coregrind/m_initimg/initimg-linux.c @@ -120,19 +120,19 @@ static void load_client ( /*MOD*/ExeInfo* info, If this needs to handle any more variables it should be hacked into something table driven. The copy is VG_(malloc)'d space. */ -static HChar** setup_client_env ( HChar** origenv, const HChar* toolname) +static HChar** setup_client_env ( HChar** origenv, const HChar* toolname, Bool use_stack_cache_tunable) { vg_assert(origenv); vg_assert(toolname); - const HChar* preload_core = "vgpreload_core"; - const HChar* ld_preload = "LD_PRELOAD="; - const HChar* v_launcher = VALGRIND_LAUNCHER "="; - Int ld_preload_len = VG_(strlen)( ld_preload ); - Int v_launcher_len = VG_(strlen)( v_launcher ); - Bool ld_preload_done = False; - Int vglib_len = VG_(strlen)(VG_(libdir)); - Bool debug = False; + const HChar* preload_core = "vgpreload_core"; + const HChar* ld_preload = "LD_PRELOAD="; + const HChar* v_launcher = VALGRIND_LAUNCHER "="; + Int ld_preload_len = VG_(strlen)( ld_preload ); + Int v_launcher_len = VG_(strlen)( v_launcher ); + Bool ld_preload_done = False; + Int vglib_len = VG_(strlen)(VG_(libdir)); + Bool debug = False; HChar** cpp; HChar** ret; @@ -175,9 +175,10 @@ static HChar** setup_client_env ( HChar** origenv, const HChar* toolname) if (debug) VG_(printf)("XXXXXXXXX: BEFORE %s\n", *cpp); } - /* Allocate a new space */ + /* Allocate a new space + * Size is envc + 1 new entry + maybe one for GLIBC_TUNABLES + NULL */ ret = VG_(malloc) ("initimg-linux.sce.3", - sizeof(HChar *) * (envc+1+1)); /* 1 new entry + NULL */ + sizeof(HChar *) * (envc+1+1+(use_stack_cache_tunable ? 1 : 0))); /* copy it over */ for (cpp = ret; *origenv; ) { @@ -201,6 +202,18 @@ static HChar** setup_client_env ( HChar** origenv, const HChar* toolname) ld_preload_done = True; } + if (use_stack_cache_tunable) { + /* overwrite value found with zeroes */ + const HChar* search_string = "glibc.pthread.stack_cache_size="; + HChar* val; + if ((val = VG_(strstr)(*cpp, search_string))) { + val += VG_(strlen)(search_string); + while (*val != '\0' && *val != ':') { + *val++ = '0'; + } + use_stack_cache_tunable = False; + } + } if (debug) VG_(printf)("XXXXXXXXX: MASH %s\n", *cpp); } @@ -215,6 +228,10 @@ static HChar** setup_client_env ( HChar** origenv, const HChar* toolname) if (debug) VG_(printf)("XXXXXXXXX: ADD %s\n", cp); } + if (use_stack_cache_tunable) { + ret[envc++] = VG_(strdup)("initimg-linux.sce.6", "GLIBC_TUNABLES=glibc.pthread.stack_cache_size=0"); + } + /* ret[0 .. envc-1] is live now. */ /* Find and remove a binding for VALGRIND_LAUNCHER. */ for (i = 0; i < envc; i++) @@ -1004,6 +1021,26 @@ static void setup_client_dataseg ( SizeT max_size ) vg_assert(sr_Res(sres) == anon_start); } +/* + * In glibc 2.34 we need to use the TUNABLE mechanism to + * disable stack cache when --sim-hints=no-nptl-pthread-stackcache + * is specified. This needs to be done in the same manner + * as LD_PRELOAD. + * + * See https://bugs.kde.org/show_bug.cgi?id=444488 + */ +static Bool need_stack_cache_tunable(HChar** argv) +{ + while (argv && *argv) { + if (VG_(strncmp)(*argv, "--sim-hints=", VG_(strlen)("--sim-hints=")) == 0) { + if (VG_(strstr)(*argv, "no-nptl-pthread-stackcache")) { + return True; + } + } + ++argv; + } + return False; +} /*====================================================================*/ /*=== TOP-LEVEL: VG_(setup_client_initial_image) ===*/ @@ -1046,7 +1083,7 @@ IIFinaliseImageInfo VG_(ii_create_image)( IICreateImageInfo iicii, // p: get_helprequest_and_toolname [for toolname] //-------------------------------------------------------------- VG_(debugLog)(1, "initimg", "Setup client env\n"); - env = setup_client_env(iicii.envp, iicii.toolname); + env = setup_client_env(iicii.envp, iicii.toolname, need_stack_cache_tunable(iicii.argv)); //-------------------------------------------------------------- // Setup client stack, eip, and VG_(client_arg[cv]) diff --git a/coregrind/m_redir.c b/coregrind/m_redir.c index 66a3c0c4f9..37c67f4c13 100644 --- a/coregrind/m_redir.c +++ b/coregrind/m_redir.c @@ -405,6 +405,8 @@ void VG_(redir_notify_new_DebugInfo)( const DebugInfo* newdi ) const HChar* const pthread_soname = "libpthread.so.0"; const HChar* const pthread_stack_cache_actsize_varname = "stack_cache_actsize"; + const HChar* const libc_soname = "libc.so.6"; + const HChar* const libc_gnu_get_libc_version_funcname = "gnu_get_libc_version"; #if defined(VGO_solaris) Bool vg_vfork_fildes_var_search = False; const HChar* const vg_preload_core_soname = "vgpreload_core.so.0"; @@ -506,7 +508,8 @@ void VG_(redir_notify_new_DebugInfo)( const DebugInfo* newdi ) dehacktivate_pthread_stack_cache_var_search = SimHintiS(SimHint_no_nptl_pthread_stackcache, VG_(clo_sim_hints)) - && 0 == VG_(strcmp)(newdi_soname, pthread_soname); + && (0 == VG_(strcmp)(newdi_soname, pthread_soname) || + 0 == VG_(strcmp)(newdi_soname, libc_soname)); #if defined(VGO_solaris) vg_vfork_fildes_var_search = @@ -529,6 +532,20 @@ void VG_(redir_notify_new_DebugInfo)( const DebugInfo* newdi ) &demangled_sopatt, &demangled_fnpatt, &isWrap, &becTag, &becPrio ); + + if (isText && dehacktivate_pthread_stack_cache_var_search) { + if (0 == VG_(strcmp)(*names, libc_gnu_get_libc_version_funcname)) { + if ( VG_(clo_verbosity) > 1 ) { + VG_(message)( Vg_DebugMsg, + "deactivate nptl pthread stackcache via tunable:" + " found symbol %s at addr %p\n", + *names, (void*) sym_avmas.main); + } + VG_(client__gnu_get_libc_version_addr) = (client__gnu_get_libc_version_type) sym_avmas.main; + dehacktivate_pthread_stack_cache_var_search = False; + } + } + /* ignore data symbols */ if (!isText) { /* But search for dehacktivate stack cache var if needed. */ diff --git a/coregrind/m_scheduler/scheduler.c b/coregrind/m_scheduler/scheduler.c index 00cc0c6889..027560c2ad 100644 --- a/coregrind/m_scheduler/scheduler.c +++ b/coregrind/m_scheduler/scheduler.c @@ -1348,8 +1348,36 @@ VgSchedReturnCode VG_(scheduler) ( ThreadId tid ) to be added without risk of overflow. */ } } else { - VG_(debugLog)(0,"sched", - "WARNING: pthread stack cache cannot be disabled!\n"); + /* + * glibc 2.34 no longer has stack_cache_actsize as a visible variable + * so we switch to using the GLIBC_TUNABLES env var. Processing for that + * is done in initimg-linux.c / setup_client_env for all glibc + * + * If we don't detect stack_cache_actsize we want to be able to tell + * whether it is an unexpected error or if it is no longer there. + * In the latter case we don't print a warning. + */ + Bool print_warning = True; + if (VG_(client__gnu_get_libc_version_addr) != NULL) { + const HChar* gnu_libc_version = VG_(client__gnu_get_libc_version_addr)(); + if (gnu_libc_version != NULL) { + HChar* glibc_version_tok = VG_(strdup)("scheduler.1", gnu_libc_version); + const HChar* str_major = VG_(strtok)(glibc_version_tok, "."); + Long major = VG_(strtoll10)(str_major, NULL); + const HChar* str_minor = VG_(strtok)(NULL, "."); + Long minor = VG_(strtoll10)(str_minor, NULL); + if (major >= 2 && minor >= 34) { + print_warning = False; + } + VG_(free)(glibc_version_tok); + } + } else { + + } + if (print_warning) { + VG_(debugLog)(0,"sched", + "WARNING: pthread stack cache cannot be disabled!\n"); + } VG_(clo_sim_hints) &= ~SimHint2S(SimHint_no_nptl_pthread_stackcache); /* Remove SimHint_no_nptl_pthread_stackcache from VG_(clo_sim_hints) to avoid having a msg for all following threads. */ diff --git a/coregrind/pub_core_clientstate.h b/coregrind/pub_core_clientstate.h index fb83a9ea23..824ce1e05f 100644 --- a/coregrind/pub_core_clientstate.h +++ b/coregrind/pub_core_clientstate.h @@ -118,6 +118,8 @@ extern Addr VG_(get_initial_client_SP)(void); It would be much cleaner to have a documented and supported way to disable the pthread stack cache. */ extern SizeT* VG_(client__stack_cache_actsize__addr); +typedef const HChar* (*client__gnu_get_libc_version_type)(void); +extern client__gnu_get_libc_version_type VG_(client__gnu_get_libc_version_addr); #if defined(VGO_solaris) /* Address of variable vg_vfork_fildes in vgpreload_core.so.0 |
|
From: Philippe W. <phi...@so...> - 2022-12-23 15:15:52
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=7e03a15d8d4f9a6fb50b59353a13f93ed0bafc3c commit 7e03a15d8d4f9a6fb50b59353a13f93ed0bafc3c Author: Philippe Waroquiers <phi...@sk...> Date: Fri Dec 23 16:12:53 2022 +0100 Pass a dummy process_option_state for dynamic options The process_option_state is functionally needed during initial parsing of CLO options. When later changing them, only changing the CLO itself is good enough. But the processing of option needs to have a state. Diff: --- coregrind/m_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/coregrind/m_main.c b/coregrind/m_main.c index f02a8b0eb5..2b4a8748ff 100644 --- a/coregrind/m_main.c +++ b/coregrind/m_main.c @@ -889,9 +889,9 @@ static void process_option (Clo_Mode mode, void VG_(process_dynamic_option) (Clo_Mode mode, HChar *value) { - process_option (mode, value, NULL); - // This is not supposed to change values in process_option_state, - // so we can give a NULL. + struct process_option_state dummy; + process_option (mode, value, &dummy); + // No need to handle a process_option_state once valgrind has started. } /* Peer at previously set up VG_(args_for_valgrind) and do some |
|
From: Paul F. <pa...@so...> - 2022-12-23 13:51:14
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=316282cd3b357fe94cac466754adb42c17fad7d2 commit 316282cd3b357fe94cac466754adb42c17fad7d2 Author: Paul Floyd <pj...@wa...> Date: Fri Dec 23 14:49:39 2022 +0100 Bug 463027 - broken check for MPX instruction support in assembler Diff: --- NEWS | 1 + configure.ac | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index d777d9160c..c9376dcca9 100644 --- a/NEWS +++ b/NEWS @@ -27,6 +27,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. 444110 priv/guest_ppc_toIR.c:36198:31: warning: duplicated 'if' condition. 459476 vgdb: allow address reuse to avoid "address already in use" errorsuse" errors 462830 WARNING: unhandled amd64-freebsd syscall: 474 +463027 broken check for MPX instruction support in assembler To see details of a given bug, visit https://bugs.kde.org/show_bug.cgi?id=XXXXXX diff --git a/configure.ac b/configure.ac index 41047dc2c6..5ae9377119 100755 --- a/configure.ac +++ b/configure.ac @@ -3410,9 +3410,9 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[ asm ("bndmov %bnd0,(%rsp)"); asm ("bndldx 3(%rbx,%rdx), %bnd2"); asm ("bnd call foo\n" - bnd jmp end\n" - foo: bnd ret\n" - end: nop"); + "bnd jmp end\n" + "foo: bnd ret\n" + "end: nop"); } while (0) ]])], [ ac_have_as_mpx=yes |