You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
1
|
2
|
3
|
4
|
5
|
|
6
|
7
|
8
|
9
|
10
|
11
|
12
|
|
13
|
14
|
15
|
16
|
17
|
18
|
19
|
|
20
|
21
(1) |
22
|
23
(1) |
24
|
25
(1) |
26
|
|
27
|
28
|
29
|
30
(2) |
31
(1) |
|
|
|
From: Carl L. <ca...@so...> - 2022-03-25 15:12:24
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=00017cda521fb3aa3e5d8b892941dbb6bd6c3c25 commit 00017cda521fb3aa3e5d8b892941dbb6bd6c3c25 Author: Carl Love <ce...@us...> Date: Wed Mar 23 13:41:16 2022 -0500 Powerpc, re-implement the vbpermq instruction support The instruction support generates too many Iops when multiple vbpermq instructions occur together in the binary. This patch changes the implementation to use a clean helper and thus avoid overflowing the internal Valgrind buffer. bugzilla 451827 Diff: --- NEWS | 1 + VEX/priv/guest_ppc_defs.h | 2 + VEX/priv/guest_ppc_helpers.c | 30 +++++++++++++++ VEX/priv/guest_ppc_toIR.c | 88 +++++++++++--------------------------------- 4 files changed, 55 insertions(+), 66 deletions(-) diff --git a/NEWS b/NEWS index 404467180e..709f287842 100644 --- a/NEWS +++ b/NEWS @@ -72,6 +72,7 @@ are not entered into bugzilla tend to get forgotten about or ignored. registers. 450536 Powerpc: valgrind throws 'facility scv unavailable exception' 451626 Syscall param bpf(attr->raw_tracepoint.name) points to unaddressable byte(s) +451827 [ppc64le] VEX temporary storage exhausted with several vbpermq instructions To see details of a given bug, visit https://bugs.kde.org/show_bug.cgi?id=XXXXXX diff --git a/VEX/priv/guest_ppc_defs.h b/VEX/priv/guest_ppc_defs.h index 93ada1ba98..e79b86cd76 100644 --- a/VEX/priv/guest_ppc_defs.h +++ b/VEX/priv/guest_ppc_defs.h @@ -164,6 +164,8 @@ extern UInt count_bits_under_mask_helper( ULong src, ULong mask, UInt flag ); extern ULong deposit_bits_under_mask_helper( ULong src, ULong mask ); extern ULong population_count64_helper( ULong src ); +extern ULong vbpermq_clean_helper( ULong vA_high, ULong vA_low, + ULong vB_high, ULong vB_low ); extern ULong vector_evaluate64_helper( ULong srcA, ULong srcB, ULong srcC, ULong IMM ); void write_ACC_entry (VexGuestPPC64State* gst, UInt offset, UInt acc, diff --git a/VEX/priv/guest_ppc_helpers.c b/VEX/priv/guest_ppc_helpers.c index 0ae3a5aa17..a6f63f5d26 100644 --- a/VEX/priv/guest_ppc_helpers.c +++ b/VEX/priv/guest_ppc_helpers.c @@ -701,6 +701,36 @@ ULong vector_evaluate64_helper( ULong srcA, ULong srcB, ULong srcC, #undef MAX_IMM_BITS } +/*---------------------------------------------------------------*/ +/* --- Clean helper for vbpermq instruction ---*/ +/*---------------------------------------------------------------*/ +ULong vbpermq_clean_helper( ULong vA_high, ULong vA_low, + ULong vB_high, ULong vB_low) { + ULong bit, result = 0x0; + UInt i, index; + + /* IBM numbering bit 0 on is MSB, bit 63 is LSB */ + for ( i = 0; i < 16; i++) { + if (i < 8) + index = 0xFFULL & (vB_high >> (56 - 8*i) ); + else + index = 0xFFULL & (vB_low >> (56 - 8*(i-8))); + + if (index < 64) { + bit = 0x1 & (vA_high >> (63 - index)); + + } else if (index < 128) { + bit = 0x1 & (vA_low >> (127 - index)); + + } else + bit = 0; + + result |= bit << (15 - i); + } + return result; +} + + /*--------------------------------------------------*/ /*---- VSX Vector Generate PCV from Mask helpers ---*/ /*--------------------------------------------------*/ diff --git a/VEX/priv/guest_ppc_toIR.c b/VEX/priv/guest_ppc_toIR.c index e340562bf0..94bf798726 100644 --- a/VEX/priv/guest_ppc_toIR.c +++ b/VEX/priv/guest_ppc_toIR.c @@ -31771,7 +31771,7 @@ static Bool dis_VSR_byte_mask ( UInt prefix, UInt theInstr, } } -static Bool dis_av_quad ( UInt prefix, UInt theInstr ) +static Bool dis_av_quad ( UInt prefix, UInt theInstr, const VexAbiInfo* vbi ) { /* VX-Form */ UChar opc1 = ifieldOPC(theInstr); @@ -31828,71 +31828,27 @@ static Bool dis_av_quad ( UInt prefix, UInt theInstr ) return True; case 0x054C: // vbpermq { -#define BPERMD_IDX_MASK 0x00000000000000FFULL -#define BPERMD_BIT_MASK 0x8000000000000000ULL - int i; - IRExpr * vB_expr = mkexpr(vB); - IRExpr * res = binop(Iop_AndV128, mkV128(0), mkV128(0)); - DIP("vbpermq v%d,v%d,v%d\n", vRT_addr, vRA_addr, vRB_addr); - for (i = 0; i < 16; i++) { - IRTemp idx_tmp = newTemp( Ity_V128 ); - IRTemp perm_bit = newTemp( Ity_V128 ); - IRTemp idx = newTemp( Ity_I8 ); - IRTemp idx_LT127 = newTemp( Ity_I1 ); - IRTemp idx_LT127_ity128 = newTemp( Ity_V128 ); - - assign( idx_tmp, - binop( Iop_AndV128, - binop( Iop_64HLtoV128, - mkU64(0), - mkU64(BPERMD_IDX_MASK) ), - vB_expr ) ); - assign( idx_LT127, - binop( Iop_CmpEQ32, - unop ( Iop_64to32, - unop( Iop_V128to64, binop( Iop_ShrV128, - mkexpr(idx_tmp), - mkU8(7) ) ) ), - mkU32(0) ) ); - - /* Below, we set idx to determine which bit of vA to use for the - * perm bit. If idx_LT127 is 0, the perm bit is forced to '0'. - */ - assign( idx, - binop( Iop_And8, - unop( Iop_1Sto8, - mkexpr(idx_LT127) ), - unop( Iop_32to8, - unop( Iop_V128to32, mkexpr( idx_tmp ) ) ) ) ); + /* The original supports was done with Iops but it caused the internal + temorary storage to be exhausted if there were three or more vbpermq + instructions in a row. Changed to a clean helper on 3/24/2022 */ + IRTemp res_hi = newTemp( Ity_I64 ); + IRExpr * res_low = mkU64(0); + assign( res_hi, + mkIRExprCCall( Ity_I64, 0 /*regparms*/, + "vbpermq_clean_helper", + fnptr_to_fnentry( vbi, + &vbpermq_clean_helper ), + mkIRExprVec_4( unop( Iop_V128HIto64, + mkexpr(vA) ), + unop( Iop_V128to64, + mkexpr(vA) ), + unop( Iop_V128HIto64, + mkexpr(vB) ), + unop( Iop_V128to64, + mkexpr(vB) ) ) ) ); - assign( idx_LT127_ity128, - binop( Iop_64HLtoV128, - mkU64(0), - unop( Iop_32Uto64, - unop( Iop_1Uto32, mkexpr(idx_LT127 ) ) ) ) ); - assign( perm_bit, - binop( Iop_AndV128, - mkexpr( idx_LT127_ity128 ), - binop( Iop_ShrV128, - binop( Iop_AndV128, - binop (Iop_64HLtoV128, - mkU64( BPERMD_BIT_MASK ), - mkU64(0)), - binop( Iop_ShlV128, - mkexpr( vA ), - mkexpr( idx ) ) ), - mkU8( 127 ) ) ) ); - res = binop( Iop_OrV128, - res, - binop( Iop_ShlV128, - mkexpr( perm_bit ), - mkU8( i + 64 ) ) ); - vB_expr = binop( Iop_ShrV128, vB_expr, mkU8( 8 ) ); - } - putVReg( vRT_addr, res); + putVReg( vRT_addr, binop( Iop_64HLtoV128, mkexpr( res_hi ), res_low ) ); return True; -#undef BPERMD_IDX_MASK -#undef BPERMD_BIT_MASK } default: @@ -37680,7 +37636,7 @@ DisResult disInstr_PPC_WRK ( case 0x3D: case 0x3C: // vaddecuq, vaddeuqm case 0x3F: case 0x3E: // vsubecuq, vsubeuqm if (!allow_V) goto decode_noV; - if (dis_av_quad( prefix, theInstr)) goto decode_success; + if (dis_av_quad( prefix, theInstr, abiinfo)) goto decode_success; goto decode_failure; default: @@ -38026,7 +37982,7 @@ DisResult disInstr_PPC_WRK ( case 0x540: case 0x500: // vsubcuq, vsubuqm case 0x54C: // vbpermq if (!allow_V) goto decode_noV; - if (dis_av_quad( prefix, theInstr)) goto decode_success; + if (dis_av_quad( prefix, theInstr, abiinfo)) goto decode_success; goto decode_failure; default: |