You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
1
(5) |
2
(10) |
3
(9) |
4
(8) |
5
(2) |
6
|
|
7
|
8
(1) |
9
(4) |
10
(2) |
11
|
12
(1) |
13
(2) |
|
14
|
15
(7) |
16
(1) |
17
(9) |
18
(1) |
19
(4) |
20
(4) |
|
21
(1) |
22
(3) |
23
(1) |
24
|
25
|
26
|
27
|
|
28
|
29
(2) |
30
(2) |
31
(6) |
|
|
|
|
From: Julian S. <se...@so...> - 2021-03-17 17:16:59
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=1e4a20c6dbd2e2a10586d4b122047afcacd69c7f commit 1e4a20c6dbd2e2a10586d4b122047afcacd69c7f Author: Julian Seward <js...@ac...> Date: Wed Mar 17 18:16:03 2021 +0100 Improve the summary paragraph for the 3.17 NEWS entry. Diff: --- NEWS | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 8ff6912f99..2da344d204 100644 --- a/NEWS +++ b/NEWS @@ -1,9 +1,10 @@ Release 3.17.0 (18 Mar 2021) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -3.17.0 is a primarily a bug-fix release. There are also some architecture and -tool updates. Support for recent toolchains -- GCC 11 and Clang 11 -- has -been improved. +3.17.0 fixes a number of bugs and adds some functional changes: support for +GCC 11, Clang 11, DWARF5 debuginfo, the 'debuginfod' debuginfo server, and +some new instructions for Arm64, S390 and POWER. There are also some tool +updates. This release supports X86/Linux, AMD64/Linux, ARM32/Linux, ARM64/Linux, PPC32/Linux, PPC64BE/Linux, PPC64LE/Linux, S390X/Linux, MIPS32/Linux, |
|
From: Mark W. <ma...@kl...> - 2021-03-17 17:00:17
|
Hi Carl,
On Wed, 2021-03-17 at 09:36 -0700, Carl Love wrote:
> On Wed, 2021-03-17 at 13:08 +0100, Mark Wielaard wrote:
> The testing on the ISA 3.1 because the file
> none/tests/ppc64/isa_3_1_register_defines.h is missing from RC2. I
> checked and it is also missing from RC1. The file does exist in the
> Vaglrind git tree. Not sure why it is missing in the RCs. Not sure
> why I didn't pick that up with the previous RC1 testing. Sorry about
> that.
Oops. It looks like that was missed because it isn't used unless
building for ISA3.1. I committed the following to make sure it will be
in the final release tarball:
commit 8616808ab3cc691699bd1f733eb9b3106a1a6256
Author: Mark Wielaard <ma...@kl...>
Date: Wed Mar 17 17:56:07 2021 +0100
Add isa_3_1_register_defines.h to Makefile.am noinst_HEADERS
Make sure isa_3_1_register_defines.h ends up in the dist tarball.
diff --git a/none/tests/ppc64/Makefile.am b/none/tests/ppc64/Makefile.am
index 23a22d922..38a3dc483 100644
--- a/none/tests/ppc64/Makefile.am
+++ b/none/tests/ppc64/Makefile.am
@@ -3,7 +3,7 @@ include $(top_srcdir)/Makefile.tool-tests.am
dist_noinst_SCRIPTS = filter_stderr
-noinst_HEADERS = ppc64_helpers.h isa_3_1_helpers.h
+noinst_HEADERS = ppc64_helpers.h isa_3_1_helpers.h isa_3_1_register_defines.h
EXTRA_DIST = \
jm-int.stderr.exp jm-int.stdout.exp jm-int.vgtest jm-int.stdout.exp-LE \
Thanks,
Mark
|
|
From: Mark W. <ma...@so...> - 2021-03-17 16:57:28
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=8616808ab3cc691699bd1f733eb9b3106a1a6256 commit 8616808ab3cc691699bd1f733eb9b3106a1a6256 Author: Mark Wielaard <ma...@kl...> Date: Wed Mar 17 17:56:07 2021 +0100 Add isa_3_1_register_defines.h to Makefile.am noinst_HEADERS Make sure isa_3_1_register_defines.h ends up in the dist tarball. Diff: --- none/tests/ppc64/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/none/tests/ppc64/Makefile.am b/none/tests/ppc64/Makefile.am index 23a22d922b..38a3dc4833 100644 --- a/none/tests/ppc64/Makefile.am +++ b/none/tests/ppc64/Makefile.am @@ -3,7 +3,7 @@ include $(top_srcdir)/Makefile.tool-tests.am dist_noinst_SCRIPTS = filter_stderr -noinst_HEADERS = ppc64_helpers.h isa_3_1_helpers.h +noinst_HEADERS = ppc64_helpers.h isa_3_1_helpers.h isa_3_1_register_defines.h EXTRA_DIST = \ jm-int.stderr.exp jm-int.stdout.exp jm-int.vgtest jm-int.stdout.exp-LE \ |
|
From: Carl L. <ce...@us...> - 2021-03-17 16:36:44
|
Mark:
On Wed, 2021-03-17 at 13:08 +0100, Mark Wielaard wrote:
> Greetings.
>
> A second release candidate for 3.17.0 is available at
>
Looks fairly good. The testing on Power 8 LE and BE, Power 9 all pass
fine.
The testing on the ISA 3.1 because the file
none/tests/ppc64/isa_3_1_register_defines.h is missing from RC2. I
checked and it is also missing from RC1. The file does exist in the
Vaglrind git tree. Not sure why it is missing in the RCs. Not sure
why I didn't pick that up with the previous RC1 testing. Sorry about
that.
After I manually added the file to the RC2 tree on the ISA3.1 machine,
the regression tests ran fine.
Other than the missing file, RC2 looks good on PPC.
Carl
|
|
From: Mark W. <ma...@kl...> - 2021-03-17 12:08:51
|
Greetings. A second release candidate for 3.17.0 is available at https://sourceware.org/pub/valgrind/valgrind-3.17.0.RC2.tar.bz2 (md5 = 5dcf7c42635e19b074714c53f3a57580) Thanks for the testing of RC1. The changes between RC1 and RC2 are minimal: - debuginfod-check.pl is now included to fix make regtest. - libmpiwrap.c now compiles whether or not openmpi has MPI1 support. - Two fixes for make check on Darwin/MacOS X are included. Please give it a try on platforms that are important for you. If no serious issues are reported, the 3.17.0 final release will happen on 19 March, that is, on Friday of this week. |
|
From: Julian S. <se...@so...> - 2021-03-17 11:36:11
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=ce929211d54178be7a043e42964f7b0428e94298 commit ce929211d54178be7a043e42964f7b0428e94298 Author: Julian Seward <js...@ac...> Date: Wed Mar 17 12:35:38 2021 +0100 -> 3.17.0.RC2 Diff: --- NEWS | 7 +++++-- configure.ac | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index f43a8dee78..8ff6912f99 100644 --- a/NEWS +++ b/NEWS @@ -1,7 +1,9 @@ Release 3.17.0 (18 Mar 2021) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -3.17.0 is a primarily a bug-fix release. +3.17.0 is a primarily a bug-fix release. There are also some architecture and +tool updates. Support for recent toolchains -- GCC 11 and Clang 11 -- has +been improved. This release supports X86/Linux, AMD64/Linux, ARM32/Linux, ARM64/Linux, PPC32/Linux, PPC64BE/Linux, PPC64LE/Linux, S390X/Linux, MIPS32/Linux, @@ -187,7 +189,8 @@ where XXXXXX is the bug number as listed below. n-i-bz helgrind: If hg_cli__realloc fails, return NULL. n-i-bz arm64 front end: avoid Memcheck false positives relating to CPUID -(3.17.0.RC1: 13 Mar 2021, git a049da18b3c045fc8929bd56d404a01046e4c26c) +(3.17.0.RC1: 13 Mar 2021) +(3.17.0.RC2: 17 Mar 2021) diff --git a/configure.ac b/configure.ac index 319401047c..a2bad072f0 100755 --- a/configure.ac +++ b/configure.ac @@ -8,7 +8,7 @@ ##------------------------------------------------------------## # Process this file with autoconf to produce a configure script. -AC_INIT([Valgrind],[3.17.0.RC1],[val...@li...]) +AC_INIT([Valgrind],[3.17.0.RC2],[val...@li...]) AC_CONFIG_SRCDIR(coregrind/m_main.c) AC_CONFIG_HEADERS([config.h]) AM_INIT_AUTOMAKE([foreign dist-bzip2 subdir-objects]) |
|
From: Paul F. <pa...@so...> - 2021-03-17 08:17:58
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=e531f994c6742364aa7ea3160f3a340f8a2a9828 commit e531f994c6742364aa7ea3160f3a340f8a2a9828 Author: Paul Floyd <pj...@wa...> Date: Wed Mar 17 09:12:21 2021 +0100 Two fixes for Darwin 'make check' mempcpy is not available on Darwin, so make it conditional like Solaris. also sys/auxv.h does not exist so make including it conditional. Diff: --- dhat/tests/copy.c | 2 +- tests/arm64_features.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dhat/tests/copy.c b/dhat/tests/copy.c index dd94ec19f8..25bb221ecf 100644 --- a/dhat/tests/copy.c +++ b/dhat/tests/copy.c @@ -43,7 +43,7 @@ void f(char* a, char* b, wchar_t* wa, wchar_t* wb) { memcpy (a, b, 1000); // Redirects to memmove memcpy (a, b, 1000); // Redirects to memmove memmove(a, b, 1000); -#if defined(VGO_solaris) +#if defined(VGO_solaris) || defined(VGO_darwin) memcpy(a, b, 1000); #else mempcpy(a, b, 1000); diff --git a/tests/arm64_features.c b/tests/arm64_features.c index 01b12f784a..916a4e24dd 100644 --- a/tests/arm64_features.c +++ b/tests/arm64_features.c @@ -1,7 +1,9 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#if !defined(__APPLE__) #include <sys/auxv.h> +#endif // This file determines arm64 features a processor supports. // Arm processors do not have a x86-like cpuinfo instruction. Instead the |
|
From: Julian S. <se...@so...> - 2021-03-17 07:13:46
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=3415e1e1acc5095607663071db299f961bd65bde commit 3415e1e1acc5095607663071db299f961bd65bde Author: Julian Seward <js...@ac...> Date: Wed Mar 17 08:10:49 2021 +0100 Bug 401416 - Compile failure with openmpi 4.0. In short, use the missing symbol names only when compiling against OpenMPI version 3 or below, or when compiling against a non-OpenMPI implementation. Modified version of a patch originally from Mark Wielaard. Diff: --- NEWS | 1 + mpi/libmpiwrap.c | 39 ++++++++++++++++++++++++++++----------- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index 3f5dc5d09b..f43a8dee78 100644 --- a/NEWS +++ b/NEWS @@ -128,6 +128,7 @@ where XXXXXX is the bug number as listed below. 391853 Makefile.all.am:L247 and @SOLARIS_UNDEF_LARGESOURCE@ being empty 396656 Warnings while reading debug info 397605 ioctl FICLONE mishandled +401416 Compile failure with openmpi 4.0 408663 Suppression file for musl libc 404076 s390x: z14 vector instructions not implemented 410743 shmat() calls for 32-bit programs fail when running in 64-bit valgrind diff --git a/mpi/libmpiwrap.c b/mpi/libmpiwrap.c index 488bb13fdf..20d7c60f7c 100644 --- a/mpi/libmpiwrap.c +++ b/mpi/libmpiwrap.c @@ -278,8 +278,14 @@ static void showTy ( FILE* f, MPI_Datatype ty ) else if (ty == MPI_LONG_INT) fprintf(f,"LONG_INT"); else if (ty == MPI_SHORT_INT) fprintf(f,"SHORT_INT"); else if (ty == MPI_2INT) fprintf(f,"2INT"); +# if defined(MPI_UB) && \ + (!defined(OMPI_MAJOR_VERSION) || OMPI_MAJOR_VERSION < 3) else if (ty == MPI_UB) fprintf(f,"UB"); +# endif +# if defined(MPI_LB) && \ + (!defined(OMPI_MAJOR_VERSION) || OMPI_MAJOR_VERSION < 3) else if (ty == MPI_LB) fprintf(f,"LB"); +# endif # if defined(MPI_WCHAR) else if (ty == MPI_WCHAR) fprintf(f,"WCHAR"); # endif @@ -345,43 +351,46 @@ static void showCombiner ( FILE* f, int combiner ) { switch (combiner) { case MPI_COMBINER_NAMED: fprintf(f, "NAMED"); break; -#if defined(MPI_COMBINER_DUP) +# if defined(MPI_COMBINER_DUP) case MPI_COMBINER_DUP: fprintf(f, "DUP"); break; # endif case MPI_COMBINER_CONTIGUOUS: fprintf(f, "CONTIGUOUS"); break; case MPI_COMBINER_VECTOR: fprintf(f, "VECTOR"); break; -#if defined(MPI_COMBINER_HVECTOR_INTEGER) +# if defined(MPI_COMBINER_HVECTOR_INTEGER) && \ + (!defined(OMPI_MAJOR_VERSION) || OMPI_MAJOR_VERSION < 3) case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, "HVECTOR_INTEGER"); break; # endif case MPI_COMBINER_HVECTOR: fprintf(f, "HVECTOR"); break; case MPI_COMBINER_INDEXED: fprintf(f, "INDEXED"); break; -#if defined(MPI_COMBINER_HINDEXED_INTEGER) +# if defined(MPI_COMBINER_HINDEXED_INTEGER) && \ + (!defined(OMPI_MAJOR_VERSION) || OMPI_MAJOR_VERSION < 3) case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, "HINDEXED_INTEGER"); break; # endif case MPI_COMBINER_HINDEXED: fprintf(f, "HINDEXED"); break; -#if defined(MPI_COMBINER_INDEXED_BLOCK) +# if defined(MPI_COMBINER_INDEXED_BLOCK) case MPI_COMBINER_INDEXED_BLOCK: fprintf(f, "INDEXED_BLOCK"); break; # endif -#if defined(MPI_COMBINER_STRUCT_INTEGER) +# if defined(MPI_COMBINER_STRUCT_INTEGER) && \ + (!defined(OMPI_MAJOR_VERSION) || OMPI_MAJOR_VERSION < 3) case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, "STRUCT_INTEGER"); break; # endif case MPI_COMBINER_STRUCT: fprintf(f, "STRUCT"); break; -#if defined(MPI_COMBINER_SUBARRAY) +# if defined(MPI_COMBINER_SUBARRAY) case MPI_COMBINER_SUBARRAY: fprintf(f, "SUBARRAY"); break; # endif -#if defined(MPI_COMBINER_DARRAY) +# if defined(MPI_COMBINER_DARRAY) case MPI_COMBINER_DARRAY: fprintf(f, "DARRAY"); break; # endif -#if defined(MPI_COMBINER_F90_REAL) +# if defined(MPI_COMBINER_F90_REAL) case MPI_COMBINER_F90_REAL: fprintf(f, "F90_REAL"); break; # endif -#if defined(MPI_COMBINER_F90_COMPLEX) +# if defined(MPI_COMBINER_F90_COMPLEX) case MPI_COMBINER_F90_COMPLEX: fprintf(f, "F90_COMPLEX"); break; # endif -#if defined(MPI_COMBINER_F90_INTEGER) +# if defined(MPI_COMBINER_F90_INTEGER) case MPI_COMBINER_F90_INTEGER: fprintf(f, "F90_INTEGER"); break; # endif -#if defined(MPI_COMBINER_RESIZED) +# if defined(MPI_COMBINER_RESIZED) case MPI_COMBINER_RESIZED: fprintf(f, "RESIZED"); break; # endif default: fprintf(f, "showCombiner:??"); break; @@ -459,7 +468,12 @@ static long extentOfTy ( MPI_Datatype ty ) { int r; MPI_Aint n; +# if defined(MPI_TYPE_EXTENT) r = PMPI_Type_extent(ty, &n); +# else + MPI_Aint lb; + r = MPI_Type_get_extent(ty, &lb, &n); +# endif assert(r == MPI_SUCCESS); return (long)n; } @@ -733,8 +747,11 @@ void walk_type ( void(*f)(void*,long), char* base, MPI_Datatype ty ) f(base + offsetof(Ty,loc), sizeof(int)); return; } +# if defined(MPI_LB) && defined(MPI_UB) && \ + (!defined(OMPI_MAJOR_VERSION) || OMPI_MAJOR_VERSION < 3) if (ty == MPI_LB || ty == MPI_UB) return; /* have zero size, so nothing needs to be done */ +# endif goto unhandled; /*NOTREACHED*/ } |
|
From: Mark W. <ma...@kl...> - 2021-03-16 12:19:47
|
Hi Carl, On Mon, 2021-03-15 at 11:33 -0700, Carl Love wrote: > Will Schmidt posted an email with regards to the build issue: > > I think so.. we ran into a similar issue late last year, which I > think > we had determined was due to the MPI packages in the > environment. > The patch in comment #3 of this bugzilla helped us at that time. > https://bugs.kde.org/show_bug.cgi?id=401416 Thanks. That explains why I am not seeing it on Fedora, but you are seeing it on Ubuntu. OpenMPI4 disables MPI1 support by default, but fedora still enables it (for now). > I applied the MPI patch to the mainline git tree on the system where > I had the compile error. It fixed the compile issue. I applied the > patch to another system which didn't have the compile issue. The patch > did not break anything. As far as I can tell, the MPI patch is fine. It seems fine if MPI1 is removed. But I am not 100% sure if it is fine when you still have MPI1 support. I'll try and test it a bit. > I pulled the mainline git tree and retested on Power 8LE, Power 8BE, > Power 9, and prototype hardware. The regression tests all look fine > with the above mentioned MPI fix where needed. Nice. Thanks, Mark |
|
From: Carl L. <ce...@us...> - 2021-03-15 18:34:14
|
Mark: > Unfortunately debuginfod-check.pl was missing. I just added it: > I see you did a commit to add it to the Valgrind upstream git. Will Schmidt posted an email with regards to the build issue: I think so.. we ran into a similar issue late last year, which I think we had determined was due to the MPI packages in the environment. The patch in comment #3 of this bugzilla helped us at that time. https://bugs.kde.org/show_bug.cgi?id=401416 I applied the MPI patch to the mainline git tree on the system where I had the compile error. It fixed the compile issue. I applied the patch to another system which didn't have the compile issue. The patch did not break anything. As far as I can tell, the MPI patch is fine. I pulled the mainline git tree and retested on Power 8LE, Power 8BE, Power 9, and prototype hardware. The regression tests all look fine with the above mentioned MPI fix where needed. Carl Love |
|
From: will s. <wil...@vn...> - 2021-03-15 18:16:15
|
On Mon, 2021-03-15 at 17:14 +0100, Mark Wielaard wrote: > Hi Carl, > > On Mon, 2021-03-15 at 09:05 -0700, Carl Love wrote: > > I am seeing issues on various power platforms. > > > > <snip> > > > > I am seeing compilation issues on Power 8LE > > > > gcc --version > > gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 > > > > NAME="Ubuntu" > > VERSION="20.04.1 LTS (Focal Fossa)" > > ID=ubuntu > > ID_LIKE=debian > > PRETTY_NAME="Ubuntu 20.04.1 LTS" > > VERSION_ID="20.04" > > HOME_URL="https://www.ubuntu.com/" > > SUPPORT_URL="https://help.ubuntu.com/" > > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" > > PRIVACY_POLICY_URL=" > > https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" > > VERSION_CODENAME=focal > > UBUNTU_CODENAME=focal > > > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1112:24: > > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 1112 | # define MPI_UB > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_UB, MPI_Type_create_resized); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:281:19: note: in expansion of macro ‘MPI_UB’ > > 281 | else if (ty == MPI_UB) fprintf(f,"UB"); > > | ^~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: > > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 1113 | # define MPI_LB > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:282:19: note: in expansion of macro ‘MPI_LB’ > > 282 | else if (ty == MPI_LB) fprintf(f,"LB"); > > | ^~~~~~ > > libmpiwrap.c: In function ‘showCombiner’: > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: > > note: > > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 743 | # define MPI_COMBINER_HVECTOR_INTEGER > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, > > MPI_COMBINER_HVECTOR); > > | ^~~~~~~~~~~ > > ~~ > > ~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:354:12: note: in expansion of macro > > ‘MPI_COMBINER_HVECTOR_INTEGER’ > > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > > "HVECTOR_INTEGER"); break; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: > > note: > > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 743 | # define MPI_COMBINER_HVECTOR_INTEGER > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, > > MPI_COMBINER_HVECTOR); > > | ^~~~~~~~~~~ > > ~~ > > ~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:354:12: note: in expansion of macro > > ‘MPI_COMBINER_HVECTOR_INTEGER’ > > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > > "HVECTOR_INTEGER"); break; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:354:40: error: expected expression before ‘:’ token > > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > > "HVECTOR_INTEGER"); break; > > | ^ > > In file included from libmpiwrap.c:116: > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: > > note: > > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 744 | # define MPI_COMBINER_HINDEXED_INTEGER > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, > > MPI_COMBINER_HINDEXED); > > | ^~~~~~~~~~ > > ~~ > > ~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:359:12: note: in expansion of macro > > ‘MPI_COMBINER_HINDEXED_INTEGER’ > > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > > "HINDEXED_INTEGER"); break; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: > > note: > > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 744 | # define MPI_COMBINER_HINDEXED_INTEGER > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, > > MPI_COMBINER_HINDEXED); > > | ^~~~~~~~~~ > > ~~ > > ~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:359:12: note: in expansion of macro > > ‘MPI_COMBINER_HINDEXED_INTEGER’ > > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > > "HINDEXED_INTEGER"); break; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:359:41: error: expected expression before ‘:’ token > > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > > "HINDEXED_INTEGER"); break; > > | ^ > > In file included from libmpiwrap.c:116: > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: > > note: > > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 745 | # define MPI_COMBINER_STRUCT_INTEGER > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, > > MPI_COMBINER_STRUCT); > > | ^~~~~~~~~~~~ > > ~~ > > ~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:366:12: note: in expansion of macro > > ‘MPI_COMBINER_STRUCT_INTEGER’ > > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > > "STRUCT_INTEGER"); break; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: > > note: > > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 745 | # define MPI_COMBINER_STRUCT_INTEGER > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, > > MPI_COMBINER_STRUCT); > > | ^~~~~~~~~~~~ > > ~~ > > ~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:366:12: note: in expansion of macro > > ‘MPI_COMBINER_STRUCT_INTEGER’ > > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > > "STRUCT_INTEGER"); break; > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:366:39: error: expected expression before ‘:’ token > > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > > "STRUCT_INTEGER"); break; > > | ^ > > libmpiwrap.c: In function ‘extentOfTy’: > > libmpiwrap.c:462:8: warning: implicit declaration of function > > ‘PMPI_Type_extent’; did you mean ‘MPI_Type_extent’? [-Wimplicit- > > function-declaration] > > 462 | r = PMPI_Type_extent(ty, &n); > > | ^~~~~~~~~~~~~~~~ > > | MPI_Type_extent > > In file included from libmpiwrap.c:116: > > libmpiwrap.c: In function ‘walk_type’: > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > > error: expected expression before ‘_Static_assert’ > > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > > instead.") > > | > > ^~ > > ~~~~~~~~~~~~ > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: > > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > > 1113 | # define MPI_LB > > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > libmpiwrap.c:736:17: note: in expansion of macro ‘MPI_LB’ > > 736 | if (ty == MPI_LB || ty == MPI_UB) > > | ^~~~~~ > > make[2]: *** [Makefile:716: libmpiwrap_ppc64le_linux_so- > > libmpiwrap.o] Error 1 > > make[2]: Leaving directory '/home/carll/Valgrind/valgrind- > > 3.17.0.RC1/mpi' > > make[1]: *** [Makefile:855: check-recursive] Error 1 > > make[1]: Leaving directory '/home/carll/Valgrind/valgrind- > > 3.17.0.RC1' > > make: *** [Makefile:1149: check] Error 2 > > > > I will dig into this a bit more and see if I can find a fix for the > > error. I will let you know. > > I just did a build on Fedora, and I am not seeing these issues. It > might depend on the version of openmpi installed I assume. > > https://koji.fedoraproject.org/koji/buildinfo?buildID=1723501 > I think so.. we ran into a similar issue late last year, which I think we had determined was due to the MPI packages in the environment. The patch in comment #3 of this bugzilla helped us at that time. https://bugs.kde.org/show_bug.cgi?id=401416 > Cheers, > > Mark |
|
From: Paul F. <pj...@wa...> - 2021-03-15 17:53:32
|
On 3/15/21 1:33 PM, Mark Wielaard wrote: > Greetings. > > A first release candidate for 3.17.0 is available at > https://sourceware.org/pub/valgrind/valgrind-3.17.0.RC1.tar.bz2 > (md5 = 9df201b3461a1709993ffc50d0920bd7) > > Please give it a try on platforms that are important for you. If no > serious issues are reported, the 3.17.0 final release will happen on 19 > March, that is, on Friday of this week. On Solaris 11.3 I don't see any regressions == 785 tests, 14 stderr failures, 3 stdout failures, 1 stderrB failure, 1 stdoutB failure, 0 post failures == gdbserver_tests/hginfo (stderrB) gdbserver_tests/solaris/nlcontrolc (stdoutB) memcheck/tests/amd64-solaris/context_fpu (stderr) memcheck/tests/sem (stderr) memcheck/tests/solaris/lsframe2 (stderr) memcheck/tests/vcpu_fnfns (stdout) helgrind/tests/bar_bad (stderr) helgrind/tests/bar_trivial (stderr) helgrind/tests/bug322621 (stderr) helgrind/tests/free_is_write (stderr) helgrind/tests/pth_barrier1 (stderr) helgrind/tests/pth_barrier2 (stderr) helgrind/tests/pth_barrier3 (stderr) helgrind/tests/tc21_pthonce (stderr) drd/tests/std_mutex (stderr) drd/tests/swapcontext (stderr) none/tests/amd64/fxtract (stdout) none/tests/sem (stderr) none/tests/x86/fxtract (stdout) A+ Paul |
|
From: Mark W. <ma...@kl...> - 2021-03-15 16:14:25
|
Hi Carl, On Mon, 2021-03-15 at 09:05 -0700, Carl Love wrote: > I am seeing issues on various power platforms. > > Power 8 BE > > gcc --version > gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) > > more /etc/os-release > NAME=Fedora > VERSION="27 (Server Edition)" > ID=fedora > VERSION_ID=27 > PRETTY_NAME="Fedora 27 (Server Edition)" > ANSI_COLOR="0;34" > CPE_NAME="cpe:/o:fedoraproject:fedora:27" > HOME_URL="https://fedoraproject.org/" > SUPPORT_URL=" > https://fedoraproject.org/wiki/Communicating_and_getting_help" > BUG_REPORT_URL="https://bugzilla.redhat.com/" > REDHAT_BUGZILLA_PRODUCT="Fedora" > REDHAT_BUGZILLA_PRODUCT_VERSION=27 > REDHAT_SUPPORT_PRODUCT="Fedora" > REDHAT_SUPPORT_PRODUCT_VERSION=27 > PRIVACY_POLICY_URL=" > https://fedoraproject.org/wiki/Legal:PrivacyPolicy" > VARIANT="Server Edition" > VARIANT_ID=server > > I am getting the following error while running make regtest > > leak-pool-4: valgrind ./leak-pool 4 > leak-pool-5: valgrind ./leak-pool 5 > leak-segv-jmp: (skipping, prereq failed: ! ../../tests/os_test > darwin && ! ../../tests/arch_test mips32 && ! > ../../tests/arch_test > ppc64) > leak-tree: valgrind -q --leak-check=full --leak- > resolution=high ./leak-tree > leak_cpp_interior: valgrind --leak-check=summary --leak-check- > heuristics=multipleinheritance,stdstring,newarray,length64 -- > suppressions=libstdc++.supp ./leak_cpp_interior > -- Running tests in memcheck/tests/linux ------------------------ > -- > ---- > brk: valgrind ./brk > capget: valgrind ./capget > /bin/sh: ./debuginfod-check.pl: No such file or directory > prereq returned 127: ./debuginfod-check.pl > ...checking makefile consistency > ...checking header files and include directives > make: *** [Makefile:1367: regtest] Error 1 Unfortunately debuginfod-check.pl was missing. I just added it: https://sourceware.org/git/?p=valgrind.git;a=commit;h=3751e963fab1d644508a9c25b0f147ad609d5dff > I see the same error on a Power 9 > > more /etc/os-release > NAME="Ubuntu" > VERSION="18.04.5 LTS (Bionic Beaver)" > ID=ubuntu > ID_LIKE=debian > PRETTY_NAME="Ubuntu 18.04.5 LTS" > VERSION_ID="18.04" > HOME_URL="https://www.ubuntu.com/" > SUPPORT_URL="https://help.ubuntu.com/" > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" > PRIVACY_POLICY_URL=" > https://www.ubuntu.com/legal/terms-and-policies/privacy-poli > cy" > VERSION_CODENAME=bionic > UBUNTU_CODENAME=bionic > > > I am seeing compilation issues on Power 8LE > > gcc --version > gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 > > NAME="Ubuntu" > VERSION="20.04.1 LTS (Focal Fossa)" > ID=ubuntu > ID_LIKE=debian > PRETTY_NAME="Ubuntu 20.04.1 LTS" > VERSION_ID="20.04" > HOME_URL="https://www.ubuntu.com/" > SUPPORT_URL="https://help.ubuntu.com/" > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" > PRIVACY_POLICY_URL=" > https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" > VERSION_CODENAME=focal > UBUNTU_CODENAME=focal > > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1112:24: > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 1112 | # define MPI_UB > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_UB, MPI_Type_create_resized); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:281:19: note: in expansion of macro ‘MPI_UB’ > 281 | else if (ty == MPI_UB) fprintf(f,"UB"); > | ^~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 1113 | # define MPI_LB > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:282:19: note: in expansion of macro ‘MPI_LB’ > 282 | else if (ty == MPI_LB) fprintf(f,"LB"); > | ^~~~~~ > libmpiwrap.c: In function ‘showCombiner’: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 743 | # define MPI_COMBINER_HVECTOR_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, > MPI_COMBINER_HVECTOR); > | ^~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:354:12: note: in expansion of macro > ‘MPI_COMBINER_HVECTOR_INTEGER’ > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > "HVECTOR_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 743 | # define MPI_COMBINER_HVECTOR_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, > MPI_COMBINER_HVECTOR); > | ^~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:354:12: note: in expansion of macro > ‘MPI_COMBINER_HVECTOR_INTEGER’ > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > "HVECTOR_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:354:40: error: expected expression before ‘:’ token > 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, > "HVECTOR_INTEGER"); break; > | ^ > In file included from libmpiwrap.c:116: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 744 | # define MPI_COMBINER_HINDEXED_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, > MPI_COMBINER_HINDEXED); > | ^~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:359:12: note: in expansion of macro > ‘MPI_COMBINER_HINDEXED_INTEGER’ > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > "HINDEXED_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 744 | # define MPI_COMBINER_HINDEXED_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, > MPI_COMBINER_HINDEXED); > | ^~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:359:12: note: in expansion of macro > ‘MPI_COMBINER_HINDEXED_INTEGER’ > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > "HINDEXED_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:359:41: error: expected expression before ‘:’ token > 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, > "HINDEXED_INTEGER"); break; > | ^ > In file included from libmpiwrap.c:116: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 745 | # define MPI_COMBINER_STRUCT_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, > MPI_COMBINER_STRUCT); > | ^~~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:366:12: note: in expansion of macro > ‘MPI_COMBINER_STRUCT_INTEGER’ > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > "STRUCT_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: note: > in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 745 | # define MPI_COMBINER_STRUCT_INTEGER > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, > MPI_COMBINER_STRUCT); > | ^~~~~~~~~~~~~~ > ~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:366:12: note: in expansion of macro > ‘MPI_COMBINER_STRUCT_INTEGER’ > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > "STRUCT_INTEGER"); break; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:366:39: error: expected expression before ‘:’ token > 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, > "STRUCT_INTEGER"); break; > | ^ > libmpiwrap.c: In function ‘extentOfTy’: > libmpiwrap.c:462:8: warning: implicit declaration of function > ‘PMPI_Type_extent’; did you mean ‘MPI_Type_extent’? [-Wimplicit- > function-declaration] > 462 | r = PMPI_Type_extent(ty, &n); > | ^~~~~~~~~~~~~~~~ > | MPI_Type_extent > In file included from libmpiwrap.c:116: > libmpiwrap.c: In function ‘walk_type’: > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: > error: expected expression before ‘_Static_assert’ > 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) > _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " > instead.") > | ^~ > ~~~~~~~~~~~~ > /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: > note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ > 1113 | # define MPI_LB > THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > libmpiwrap.c:736:17: note: in expansion of macro ‘MPI_LB’ > 736 | if (ty == MPI_LB || ty == MPI_UB) > | ^~~~~~ > make[2]: *** [Makefile:716: libmpiwrap_ppc64le_linux_so- > libmpiwrap.o] Error 1 > make[2]: Leaving directory '/home/carll/Valgrind/valgrind- > 3.17.0.RC1/mpi' > make[1]: *** [Makefile:855: check-recursive] Error 1 > make[1]: Leaving directory '/home/carll/Valgrind/valgrind- > 3.17.0.RC1' > make: *** [Makefile:1149: check] Error 2 > > I will dig into this a bit more and see if I can find a fix for the > error. I will let you know. I just did a build on Fedora, and I am not seeing these issues. It might depend on the version of openmpi installed I assume. https://koji.fedoraproject.org/koji/buildinfo?buildID=1723501 Cheers, Mark |
|
From: Carl L. <ce...@us...> - 2021-03-15 16:05:49
|
Mark: I am seeing issues on various power platforms. Power 8 BE gcc --version gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) more /etc/os-release NAME=Fedora VERSION="27 (Server Edition)" ID=fedora VERSION_ID=27 PRETTY_NAME="Fedora 27 (Server Edition)" ANSI_COLOR="0;34" CPE_NAME="cpe:/o:fedoraproject:fedora:27" HOME_URL="https://fedoraproject.org/" SUPPORT_URL=" https://fedoraproject.org/wiki/Communicating_and_getting_help" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=27 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=27 PRIVACY_POLICY_URL=" https://fedoraproject.org/wiki/Legal:PrivacyPolicy" VARIANT="Server Edition" VARIANT_ID=server I am getting the following error while running make regtest leak-pool-4: valgrind ./leak-pool 4 leak-pool-5: valgrind ./leak-pool 5 leak-segv-jmp: (skipping, prereq failed: ! ../../tests/os_test darwin && ! ../../tests/arch_test mips32 && ! ../../tests/arch_test ppc64) leak-tree: valgrind -q --leak-check=full --leak- resolution=high ./leak-tree leak_cpp_interior: valgrind --leak-check=summary --leak-check- heuristics=multipleinheritance,stdstring,newarray,length64 -- suppressions=libstdc++.supp ./leak_cpp_interior -- Running tests in memcheck/tests/linux -------------------------- ---- brk: valgrind ./brk capget: valgrind ./capget /bin/sh: ./debuginfod-check.pl: No such file or directory prereq returned 127: ./debuginfod-check.pl ...checking makefile consistency ...checking header files and include directives make: *** [Makefile:1367: regtest] Error 1 I see the same error on a Power 9 more /etc/os-release NAME="Ubuntu" VERSION="18.04.5 LTS (Bionic Beaver)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 18.04.5 LTS" VERSION_ID="18.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL=" https://www.ubuntu.com/legal/terms-and-policies/privacy-poli cy" VERSION_CODENAME=bionic UBUNTU_CODENAME=bionic I am seeing compilation issues on Power 8LE gcc --version gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 NAME="Ubuntu" VERSION="20.04.1 LTS (Focal Fossa)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 20.04.1 LTS" VERSION_ID="20.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL=" https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1112:24: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 1112 | # define MPI_UB THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_UB, MPI_Type_create_resized); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:281:19: note: in expansion of macro ‘MPI_UB’ 281 | else if (ty == MPI_UB) fprintf(f,"UB"); | ^~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 1113 | # define MPI_LB THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:282:19: note: in expansion of macro ‘MPI_LB’ 282 | else if (ty == MPI_LB) fprintf(f,"LB"); | ^~~~~~ libmpiwrap.c: In function ‘showCombiner’: /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 743 | # define MPI_COMBINER_HVECTOR_INTEGER THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, MPI_COMBINER_HVECTOR); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:354:12: note: in expansion of macro ‘MPI_COMBINER_HVECTOR_INTEGER’ 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, "HVECTOR_INTEGER"); break; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:743:46: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 743 | # define MPI_COMBINER_HVECTOR_INTEGER THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HVECTOR_INTEGER, MPI_COMBINER_HVECTOR); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:354:12: note: in expansion of macro ‘MPI_COMBINER_HVECTOR_INTEGER’ 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, "HVECTOR_INTEGER"); break; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:354:40: error: expected expression before ‘:’ token 354 | case MPI_COMBINER_HVECTOR_INTEGER: fprintf(f, "HVECTOR_INTEGER"); break; | ^ In file included from libmpiwrap.c:116: /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 744 | # define MPI_COMBINER_HINDEXED_INTEGER THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, MPI_COMBINER_HINDEXED); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:359:12: note: in expansion of macro ‘MPI_COMBINER_HINDEXED_INTEGER’ 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, "HINDEXED_INTEGER"); break; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:744:47: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 744 | # define MPI_COMBINER_HINDEXED_INTEGER THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_HINDEXED_INTEGER, MPI_COMBINER_HINDEXED); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:359:12: note: in expansion of macro ‘MPI_COMBINER_HINDEXED_INTEGER’ 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, "HINDEXED_INTEGER"); break; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:359:41: error: expected expression before ‘:’ token 359 | case MPI_COMBINER_HINDEXED_INTEGER: fprintf(f, "HINDEXED_INTEGER"); break; | ^ In file included from libmpiwrap.c:116: /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 745 | # define MPI_COMBINER_STRUCT_INTEGER THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, MPI_COMBINER_STRUCT); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:366:12: note: in expansion of macro ‘MPI_COMBINER_STRUCT_INTEGER’ 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, "STRUCT_INTEGER"); break; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:745:45: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 745 | # define MPI_COMBINER_STRUCT_INTEGER THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_COMBINER_STRUCT_INTEGER, MPI_COMBINER_STRUCT); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:366:12: note: in expansion of macro ‘MPI_COMBINER_STRUCT_INTEGER’ 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, "STRUCT_INTEGER"); break; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:366:39: error: expected expression before ‘:’ token 366 | case MPI_COMBINER_STRUCT_INTEGER: fprintf(f, "STRUCT_INTEGER"); break; | ^ libmpiwrap.c: In function ‘extentOfTy’: libmpiwrap.c:462:8: warning: implicit declaration of function ‘PMPI_Type_extent’; did you mean ‘MPI_Type_extent’? [-Wimplicit-function-declaration] 462 | r = PMPI_Type_extent(ty, &n); | ^~~~~~~~~~~~~~~~ | MPI_Type_extent In file included from libmpiwrap.c:116: libmpiwrap.c: In function ‘walk_type’: /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:322:57: error: expected expression before ‘_Static_assert’ 322 | #define THIS_SYMBOL_WAS_REMOVED_IN_MPI30(func, newfunc) _Static_assert(0, #func " was removed in MPI-3.0. Use " #newfunc " instead.") | ^~~~~~~~~~~~~~ /usr/lib/powerpc64le-linux-gnu/openmpi/include/mpi.h:1113:24: note: in expansion of macro ‘THIS_SYMBOL_WAS_REMOVED_IN_MPI30’ 1113 | # define MPI_LB THIS_SYMBOL_WAS_REMOVED_IN_MPI30(MPI_LB, MPI_Type_create_resized); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ libmpiwrap.c:736:17: note: in expansion of macro ‘MPI_LB’ 736 | if (ty == MPI_LB || ty == MPI_UB) | ^~~~~~ make[2]: *** [Makefile:716: libmpiwrap_ppc64le_linux_so-libmpiwrap.o] Error 1 make[2]: Leaving directory '/home/carll/Valgrind/valgrind-3.17.0.RC1/mpi' make[1]: *** [Makefile:855: check-recursive] Error 1 make[1]: Leaving directory '/home/carll/Valgrind/valgrind-3.17.0.RC1' make: *** [Makefile:1149: check] Error 2 I will dig into this a bit more and see if I can find a fix for the error. I will let you know. Carl Love |
|
From: Mark W. <ma...@so...> - 2021-03-15 14:49:39
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=3751e963fab1d644508a9c25b0f147ad609d5dff commit 3751e963fab1d644508a9c25b0f147ad609d5dff Author: Mark Wielaard <ma...@kl...> Date: Mon Mar 15 15:47:48 2021 +0100 Add memcheck/tests/linux/debuginfod-check.pl to EXTRA_DIST debuginfod-check.pl is necessary as pre-check for make regtest. Diff: --- memcheck/tests/linux/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/memcheck/tests/linux/Makefile.am b/memcheck/tests/linux/Makefile.am index 90a24e4abe..f7cf5a456c 100644 --- a/memcheck/tests/linux/Makefile.am +++ b/memcheck/tests/linux/Makefile.am @@ -7,6 +7,7 @@ EXTRA_DIST = \ brk.stderr.exp brk.vgtest \ capget.vgtest capget.stderr.exp capget.stderr.exp2 capget.stderr.exp3 \ debuginfod-check.stderr.exp debuginfod-check.vgtest.in \ + debuginfod-check.pl \ dlclose_leak-no-keep.stderr.exp dlclose_leak-no-keep.stdout.exp \ dlclose_leak-no-keep.vgtest \ dlclose_leak.stderr.exp dlclose_leak.stdout.exp \ |
|
From: Mark W. <ma...@kl...> - 2021-03-15 12:34:16
|
Greetings. A first release candidate for 3.17.0 is available at https://sourceware.org/pub/valgrind/valgrind-3.17.0.RC1.tar.bz2 (md5 = 9df201b3461a1709993ffc50d0920bd7) Please give it a try on platforms that are important for you. If no serious issues are reported, the 3.17.0 final release will happen on 19 March, that is, on Friday of this week. |
|
From: Julian S. <se...@so...> - 2021-03-13 19:53:21
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=d695fb68e580d33b7c00e7d72f44bb9202b0d6a2 commit d695fb68e580d33b7c00e7d72f44bb9202b0d6a2 Author: Julian Seward <js...@ac...> Date: Sat Mar 13 20:52:01 2021 +0100 -> 3.17.0.RC1 Diff: --- AUTHORS | 4 ++- NEWS | 90 ++++++++++++++++++++++++++++-------------------- configure.ac | 2 +- docs/xml/vg-entities.xml | 6 ++-- 4 files changed, 60 insertions(+), 42 deletions(-) diff --git a/AUTHORS b/AUTHORS index 84c47b4384..c508a95689 100644 --- a/AUTHORS +++ b/AUTHORS @@ -49,7 +49,7 @@ Vince Weaver wrote and maintains BBV. Frederic Gobry helped with autoconf and automake. Daniel Berlin modified readelf's dwarf2 source line reader, written by Nick -Clifton, for use in Valgrind.o +Clifton, for use in Valgrind. Michael Matz and Simon Hausmann modified the GNU binutils demangler(s) for use in Valgrind. @@ -79,6 +79,8 @@ Jakub Jelinek helped out extensively with the AVX and AVX2 support. Mark Wielaard fixed a bunch of bugs and acts as our Fedora/RHEL liaison. +Assad Hashmi contributed support for AArch64 v8.1 and later. + Maran Pakkirisamy implemented support for decimal floating point on s390. diff --git a/NEWS b/NEWS index 028725c038..3f5dc5d09b 100644 --- a/NEWS +++ b/NEWS @@ -1,8 +1,7 @@ -Release 3.17.0 (?? ??? 202?) +Release 3.17.0 (18 Mar 2021) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -3.17.0 is a feature release with many improvements and the usual collection -of bug fixes. +3.17.0 is a primarily a bug-fix release. This release supports X86/Linux, AMD64/Linux, ARM32/Linux, ARM64/Linux, PPC32/Linux, PPC64BE/Linux, PPC64LE/Linux, S390X/Linux, MIPS32/Linux, @@ -12,60 +11,73 @@ support for X86/macOS 10.13, AMD64/macOS 10.13 and nanoMIPS/Linux. * ==================== CORE CHANGES =================== -* DWARF version 5 support +* DWARF version 5 support. Valgrind can now read DWARF version 5 debuginfo as + produced by GCC 11. - - Valgrind can now read DWARF version 5 debuginfo as produced by GCC 11 +* Valgrind now supports debuginfod, an HTTP server for distributing ELF/DWARF + debugging information. When a debuginfo file cannot be found locally, + Valgrind is able to query debuginfod servers for the file using its + build-id. See the user manual for more information about debuginfod support. * ================== PLATFORM CHANGES ================= +* arm64: + + - Inaccuracies resulting from double-rounding in the simulation of + floating-point multiply-add/subtract instructions have been fixed. These + should now behave exactly as the hardware does. + + - Partial support for the ARM v8.2 instruction set. v8.2 support work is + ongoing. Support for the half-word variants of at least the following + instructions has been added: + FABS <Hd>, <Hn> + FABS <Vd>.<T>, <Vn>.<T> + FNEG <Hd>, <Hn> + FNEG <Vd>.<T>, <Vn>.<T> + FSQRT <Hd>, <Hn> + FSQRT <Vd>.<T>, <Vn>.<T> + FADDP + * s390: - - Implement the new instructions/features that were added to - z/Architecture with the vector-enhancements facility 1. Also - cover the instructions from the vector-packed-decimal facility - that are defined outside the chapter "Vector Decimal - Instructions", but not the ones from that chapter itself. + - Implement the new instructions/features that were added to z/Architecture + with the vector-enhancements facility 1. Also cover the instructions from + the vector-packed-decimal facility that are defined outside the chapter + "Vector Decimal Instructions", but not the ones from that chapter itself. - For a detailed list of newly supported instructions see the - updates to `docs/internals/s390-opcodes.csv'. + For a detailed list of newly supported instructions see the updates to + `docs/internals/s390-opcodes.csv'. - Since the miscellaneous instruction extensions facility 2 was - already added in Valgrind 3.16.0, this completes the support - necessary to run general programs built with `--march=z14' under - Valgrind. The vector-packed-decimal facility is currently not - exploited by the standard toolchain and libraries. + Since the miscellaneous instruction extensions facility 2 was already + added in Valgrind 3.16.0, this completes the support necessary to run + general programs built with `--march=z14' under Valgrind. The + vector-packed-decimal facility is currently not exploited by the standard + toolchain and libraries. * ppc64: - - Various bug fixes. Fix for the sync field to limit setting just two - of the two bits in the L-field. Fix the write size for the stxsibx and + - Various bug fixes. Fix for the sync field to limit setting just two of + the two bits in the L-field. Fix the write size for the stxsibx and stxsihx instructions. Fix the modsw and modsd instructions. - - Partial support for ISA 3.1 has been added. Support for the VSX PCV - mask instructions, bfloat16 GER instructions, and bfloat16 to/from float - 32-bit conversion instructions are still missing. - -* Valgrind now supports debuginfod, an HTTP server for distributing - ELF/DWARF debugging information. When a debuginfo file cannot be - found locally, Valgrind is able to query debuginfod servers for the - file using its build-id. See the user manual for more information - about debuginfod support. + - Partial support for ISA 3.1 has been added. Support for the VSX PCV mask + instructions, bfloat16 GER instructions, and bfloat16 to/from float 32-bit + conversion instructions are still missing. * ==================== TOOL CHANGES ==================== * General tool changes - All the tools and their vgpreload libraries are now installed under - libexec because they cannot be executed directly and should be run - through the valgrind executable. This should be an internal, not user - visible, change, but might impact valgrind packagers. + libexec because they cannot be executed directly and should be run through + the valgrind executable. This should be an internal, not user visible, + change, but might impact valgrind packagers. - - The --track-fds option now respects -q, --quiet and won't output - anything if no file descriptors are leaked. It also won't report - the standard stdin (0), stdout (1) or stderr (2) descriptors as - being leaked with --trace-fds=yes anymore. To track whether the - standard file descriptors are still open at the end of the program - run use --trace-fds=all. + - The --track-fds option now respects -q, --quiet and won't output anything + if no file descriptors are leaked. It also won't report the standard stdin + (0), stdout (1) or stderr (2) descriptors as being leaked with + --trace-fds=yes anymore. To track whether the standard file descriptors + are still open at the end of the program run use --trace-fds=all. * DHAT: @@ -172,6 +184,10 @@ where XXXXXX is the bug number as listed below. 433898 arm64: Handle sp, lr, fp as DwReg in CfiExpr 434193 GCC 9+ inlined strcmp causes "Conditional jump or move [..] value" report n-i-bz helgrind: If hg_cli__realloc fails, return NULL. +n-i-bz arm64 front end: avoid Memcheck false positives relating to CPUID + +(3.17.0.RC1: 13 Mar 2021, git a049da18b3c045fc8929bd56d404a01046e4c26c) + Release 3.16.1 (22 June 2020) diff --git a/configure.ac b/configure.ac index be5d99ee0c..319401047c 100755 --- a/configure.ac +++ b/configure.ac @@ -8,7 +8,7 @@ ##------------------------------------------------------------## # Process this file with autoconf to produce a configure script. -AC_INIT([Valgrind],[3.17.0.GIT],[val...@li...]) +AC_INIT([Valgrind],[3.17.0.RC1],[val...@li...]) AC_CONFIG_SRCDIR(coregrind/m_main.c) AC_CONFIG_HEADERS([config.h]) AM_INIT_AUTOMAKE([foreign dist-bzip2 subdir-objects]) diff --git a/docs/xml/vg-entities.xml b/docs/xml/vg-entities.xml index aa14f3b47e..36cde647f2 100644 --- a/docs/xml/vg-entities.xml +++ b/docs/xml/vg-entities.xml @@ -2,12 +2,12 @@ <!ENTITY vg-jemail "ju...@va..."> <!ENTITY vg-vemail "val...@va..."> <!ENTITY cl-email "Jos...@gm..."> -<!ENTITY vg-lifespan "2000-2019"> +<!ENTITY vg-lifespan "2000-2021"> <!-- valgrind release + version stuff --> <!ENTITY rel-type "Release"> -<!ENTITY rel-version "3.16.0"> -<!ENTITY rel-date "27 May 2020"> +<!ENTITY rel-version "3.17.0"> +<!ENTITY rel-date "18 Mar 2021"> <!-- where the docs are installed --> <!ENTITY vg-docs-path "$INSTALL/share/doc/valgrind/html/index.html"> |
|
From: Julian S. <se...@so...> - 2021-03-13 18:23:52
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=a049da18b3c045fc8929bd56d404a01046e4c26c commit a049da18b3c045fc8929bd56d404a01046e4c26c Author: Julian Seward <js...@ac...> Date: Sat Mar 13 19:20:50 2021 +0100 amd64 front end: try to avoid a Memcheck false positive related to CPUID. n-i-bz. In the amd64 front end, CPUID is implemented by calling dirty helper. The way the side-effects for this call are declared can lead to false positives from Memcheck. This is a somewhat inelegant "fix", but it's the least-worst that can be done without changing parameter-passing for the helper functions involved. A big in-line comment explains the problem and fix. Diff: --- VEX/priv/guest_amd64_toIR.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/VEX/priv/guest_amd64_toIR.c b/VEX/priv/guest_amd64_toIR.c index 30487065d7..2b40f6a5aa 100644 --- a/VEX/priv/guest_amd64_toIR.c +++ b/VEX/priv/guest_amd64_toIR.c @@ -21999,7 +21999,28 @@ Long dis_ESC_0F ( } d = unsafeIRDirty_0_N ( 0/*regparms*/, fName, fAddr, args ); - /* declare guest state effects */ + /* Declare guest state effects. EAX, EBX, ECX and EDX are written. EAX + is also read, hence is marked as Modified. ECX is sometimes also + read, depending on the value in EAX; that much is obvious from + inspection of the helper function. + + This is a bit of a problem: if we mark ECX as Modified -- hence, by + implication, Read -- then we may get false positives from Memcheck in + the case where ECX contains undefined bits, but the EAX value is such + that the instruction wouldn't read ECX anyway. The obvious way out + of this is to mark it as written only, but that means Memcheck will + effectively ignore undefinedness in the incoming ECX value. That + seems like a small loss to take to avoid false positives here, + though. Fundamentally the problem exists because CPUID itself has + conditional dataflow -- whether ECX is read depends on the value in + EAX -- but the annotation mechanism for dirty helpers can't represent + that conditionality. + + A fully-accurate solution might be to change the helpers so that the + EAX and ECX values are passed as parameters. Then, for the ECX + value, we can pass, effectively "if EAX is some value for which ECX + is ignored { 0 } else { ECX }", and Memcheck will see and understand + this conditionality. */ d->nFxState = 4; vex_bzero(&d->fxState, sizeof(d->fxState)); d->fxState[0].fx = Ifx_Modify; @@ -22008,13 +22029,13 @@ Long dis_ESC_0F ( d->fxState[1].fx = Ifx_Write; d->fxState[1].offset = OFFB_RBX; d->fxState[1].size = 8; - d->fxState[2].fx = Ifx_Modify; + d->fxState[2].fx = Ifx_Write; /* was: Ifx_Modify; */ d->fxState[2].offset = OFFB_RCX; d->fxState[2].size = 8; d->fxState[3].fx = Ifx_Write; d->fxState[3].offset = OFFB_RDX; d->fxState[3].size = 8; - /* execute the dirty call, side-effecting guest state */ + /* Execute the dirty call, side-effecting guest state. */ stmt( IRStmt_Dirty(d) ); /* CPUID is a serialising insn. So, just in case someone is using it as a memory fence ... */ |
|
From: Julian S. <se...@so...> - 2021-03-12 16:59:50
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=21571252964c4d7860210cbe9f60a49eb6881824 commit 21571252964c4d7860210cbe9f60a49eb6881824 Author: Julian Seward <js...@ac...> Date: Fri Mar 12 17:55:46 2021 +0100 mc_translate.c: enable further uses of DLexpensive for scalar EQ/NE comparisons mc_translate.c: enable further cases where scalar integer EQ/NE comparisons use expensive instrumentation by default: x86, amd64 for 16-bit comparisons arm, arm64 for 32-bit comparisons This fixes 'Bug 434193 - GCC 9+ inlined strcmp causes "Conditional jump or move depends on uninitialised value" report'. Patch from Mike Crowe <ma...@mc...>. Diff: --- NEWS | 1 + memcheck/mc_translate.c | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/NEWS b/NEWS index cd8a509faa..028725c038 100644 --- a/NEWS +++ b/NEWS @@ -170,6 +170,7 @@ where XXXXXX is the bug number as listed below. 433629 valgrind/README has type "abd" instead of "and" 433641 Rust std::sys::unix::fs::try_statx Syscall param fstatat(file_name) 433898 arm64: Handle sp, lr, fp as DwReg in CfiExpr +434193 GCC 9+ inlined strcmp causes "Conditional jump or move [..] value" report n-i-bz helgrind: If hg_cli__realloc fails, return NULL. diff --git a/memcheck/mc_translate.c b/memcheck/mc_translate.c index 516988bdd4..739f67cbf9 100644 --- a/memcheck/mc_translate.c +++ b/memcheck/mc_translate.c @@ -8586,17 +8586,22 @@ IRSB* MC_(instrument) ( VgCallbackClosure* closure, approximation to the above, and is self-contained.*/ # if defined(VGA_x86) mce.dlbo.dl_Add32 = DLauto; + mce.dlbo.dl_CmpEQ16_CmpNE16 = DLexpensive; mce.dlbo.dl_CmpEQ32_CmpNE32 = DLexpensive; # elif defined(VGA_amd64) mce.dlbo.dl_Add32 = DLexpensive; mce.dlbo.dl_Add64 = DLauto; + mce.dlbo.dl_CmpEQ16_CmpNE16 = DLexpensive; mce.dlbo.dl_CmpEQ32_CmpNE32 = DLexpensive; mce.dlbo.dl_CmpEQ64_CmpNE64 = DLexpensive; # elif defined(VGA_ppc64le) // Needed by (at least) set_AV_CR6() in the front end. mce.dlbo.dl_CmpEQ64_CmpNE64 = DLexpensive; # elif defined(VGA_arm64) + mce.dlbo.dl_CmpEQ32_CmpNE32 = DLexpensive; mce.dlbo.dl_CmpEQ64_CmpNE64 = DLexpensive; +# elif defined(VGA_arm) + mce.dlbo.dl_CmpEQ32_CmpNE32 = DLexpensive; # endif /* preInstrumentationAnalysis() will allocate &mce.tmpHowUsed and then |
|
From: Andreas A. <ar...@so...> - 2021-03-10 18:17:48
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=ce4b0e067772677fde0449242968dc89fa13dc63 commit ce4b0e067772677fde0449242968dc89fa13dc63 Author: Andreas Arnez <ar...@li...> Date: Wed Mar 10 19:16:00 2021 +0100 s390x: Update "reading material" in README.s390 Update the links to the z/Architecture and the s390x ABI. Diff: --- README.s390 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.s390 b/README.s390 index 7df386ef41..a146eba259 100644 --- a/README.s390 +++ b/README.s390 @@ -46,9 +46,9 @@ false positives due to builtin string operations when running memcheck. Reading Material ---------------- -(1) Linux for zSeries ELF ABI Supplement - http://refspecs.linuxfoundation.org/ELF/zSeries/index.html +(1) ELF ABI s390x Supplement + https://github.com/IBM/s390x-abi/releases (2) z/Architecture Principles of Operation - http://publibfi.boulder.ibm.com/epubs/pdf/dz9zr011.pdf + http://publibfp.dhe.ibm.com/epubs/pdf/a227832c.pdf (3) z/Architecture Reference Summary - http://publibfi.boulder.ibm.com/epubs/pdf/dz9zs009.pdf + https://www.ibm.com/support/pages/system/files/2020-07/SA22-7871-10.pdf |
|
From: Andreas A. <ar...@so...> - 2021-03-10 17:19:05
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=6ed09a6603d357f60f363049e383d7b90070c1da commit 6ed09a6603d357f60f363049e383d7b90070c1da Author: Andreas Arnez <ar...@li...> Date: Fri Mar 5 20:16:46 2021 +0100 s390x: Improve isel for Iop_V128to64 and friends The existing instruction selector for Iop_V128to64, Iop_V128HIto64, and Iop_V128to32 stores the vector register on the stack and then reads the requested integer value back from the stack into the target GPR. This is fairly inefficient. Load the requested value directly from the vector register into the target GPR instead, using S390_VEC_GET_ELEM. Diff: --- VEX/priv/host_s390_isel.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/VEX/priv/host_s390_isel.c b/VEX/priv/host_s390_isel.c index 2f9854038d..2000ec2240 100644 --- a/VEX/priv/host_s390_isel.c +++ b/VEX/priv/host_s390_isel.c @@ -1812,31 +1812,24 @@ s390_isel_int_expr_wrk(ISelEnv *env, IRExpr *expr) dst = newVRegI(env); HReg vec = s390_isel_vec_expr(env, arg); /* This is big-endian machine */ - Int off; + Int idx; switch (unop) { case Iop_V128HIto64: - off = 0; + idx = 0; break; case Iop_V128to64: - off = 8; + idx = 1; break; case Iop_V128to32: - off = 12; + idx = 3; break; default: ppIROp(unop); vpanic("s390_isel_int_expr: unhandled V128toSMTH operation"); } - s390_amode* m16_sp = s390_amode_for_stack_pointer(0); - s390_amode* off_sp = s390_amode_for_stack_pointer(off); - - /* We could use negative displacement but vector instructions - require 12bit unsigned ones. So we have to allocate space on - stack just for one load and free it after. */ - sub_from_SP(env, 16); - addInstr(env, s390_insn_store(sizeof(V128), m16_sp, vec)); - addInstr(env, s390_insn_load(sizeof(ULong), dst, off_sp)); - add_to_SP(env, 16); + s390_amode* am = s390_amode_b12(idx, s390_hreg_gpr(0)); + addInstr(env, s390_insn_vec_amodeop(size, S390_VEC_GET_ELEM, + dst, vec, am)); return dst; } |
|
From: Andreas A. <ar...@so...> - 2021-03-09 18:14:28
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=19dc8c467edf3c10a2e3a19a87853f8dc2156e92 commit 19dc8c467edf3c10a2e3a19a87853f8dc2156e92 Author: Andreas Arnez <ar...@li...> Date: Fri Mar 5 20:14:32 2021 +0100 s390x: Fix printing wrong/no vector registers in disassembler A typo in s390_disasm.c causes some vector registers to be printed wrong, or not at all. This is fixed. Diff: --- VEX/priv/s390_disasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/VEX/priv/s390_disasm.c b/VEX/priv/s390_disasm.c index e3fbc11af5..16b9560cbd 100644 --- a/VEX/priv/s390_disasm.c +++ b/VEX/priv/s390_disasm.c @@ -141,6 +141,7 @@ vr_operand(UInt archreg) "%v0", "%v1", "%v2", "%v3", "%v4", "%v5", "%v6", "%v7", "%v8", "%v9", "%v10", "%v11", + "%v12", "%v13", "%v14", "%v15", "%v16", "%v17", "%v18", "%v19", "%v20", "%v21", "%v22", "%v23", "%v24", "%v25", "%v26", "%v27", |
|
From: Mark W. <ma...@so...> - 2021-03-09 17:54:36
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=0f0205f683f70400406276936b1e0d1a7fa9cf72 commit 0f0205f683f70400406276936b1e0d1a7fa9cf72 Author: Mark Wielaard <ma...@kl...> Date: Tue Mar 9 18:51:57 2021 +0100 vgdb might crash if valgrind is killed This is an odd corner case, but happens specifically with the gdb testcase make check TESTS=gdb.base/valgrind-infcall-2.exp. At the end valgrind gets killed with SIGKILL (-9) which cannot be blocked. But vgdb at the time is inside waitstopped. It sees the process wasn't exited (WIFEXITED(status) is false) and so assumes the process was stopped by a signal. Which it asserts: assert (WIFSTOPPED(status)); signal_received = WSTOPSIG(status); if (signal_received == signal_expected) break; But the assert fails and vgdb dumps core. The gdb testcase doesn't care, because it already finished its test and just makes sure all processes are gone. But it slowly fills your disk with core files (if you have enabled them) when running the testsuite. The fix is to simply check first whether the program has termined normally or by getting a fatal signal. https://bugs.kde.org/show_bug.cgi?id=434035 Diff: --- NEWS | 1 + coregrind/vgdb-invoker-ptrace.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d1bf7b09f2..cd8a509faa 100644 --- a/NEWS +++ b/NEWS @@ -356,6 +356,7 @@ where XXXXXX is the bug number as listed below. 419503 s390x: Avoid modifying registers returned from isel functions 421321 gcc10 arm64 build needs __getauxval for linking with libgcc 421570 std_mutex fails on Arm v8.1 h/w +434035 vgdb might crash if valgrind is killed n-i-bz Fix minor one time leaks in dhat. n-i-bz Add --run-cxx-freeres=no in outer args to avoid inner crashes. n-i-bz Add support for the Linux io_uring system calls diff --git a/coregrind/vgdb-invoker-ptrace.c b/coregrind/vgdb-invoker-ptrace.c index cb37677d5c..389748960f 100644 --- a/coregrind/vgdb-invoker-ptrace.c +++ b/coregrind/vgdb-invoker-ptrace.c @@ -267,7 +267,8 @@ Bool waitstopped (pid_t pid, int signal_expected, const char *msg) return False; } - if (WIFEXITED(status)) { + /* The process either exited or was terminated by a (fatal) signal. */ + if (WIFEXITED(status) || WIFSIGNALED(status)) { shutting_down = True; return False; } |
|
From: Andreas A. <ar...@so...> - 2021-03-09 16:36:49
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=484b7dd1e862b1624cb8e7aa453df277da4f7a15 commit 484b7dd1e862b1624cb8e7aa453df277da4f7a15 Author: Andreas Arnez <ar...@li...> Date: Tue Mar 9 17:22:47 2021 +0100 Bug 430429 - s390x: Fix clang compile error in valgrind.h It has been observed that clang emits an error in valgrind.h for the macro VALGRIND_DO_CLIENT_REQUEST_EXPR: "[...] unsupported inline asm: input with type 'int' matching output with type 'volatile unsigned long'" Fix this with an explicit cast of the input to 'unsigned long int.' The patch has been suggested by Jonathan Albrecht. Diff: --- NEWS | 1 + include/valgrind.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 93fad51810..d1bf7b09f2 100644 --- a/NEWS +++ b/NEWS @@ -153,6 +153,7 @@ where XXXXXX is the bug number as listed below. diagnostics 429952 Errors when building regtest with clang 430354 ppc stxsibx and stxsihx instructions write too much data +430429 valgrind.h doesn't compile on s390x with clang 430485 expr_is_guardable doesn't handle Iex_Qop 431556 Complete arm64 FADDP v8.2 instruction support 432102 Add support for DWARF5 as produced by GCC11 diff --git a/include/valgrind.h b/include/valgrind.h index d33dd30932..04a747c7a8 100644 --- a/include/valgrind.h +++ b/include/valgrind.h @@ -876,7 +876,8 @@ typedef /* results = r3 */ \ "lgr %0, 3\n\t" \ : "=d" (_zzq_result) \ - : "a" (&_zzq_args[0]), "0" (_zzq_default) \ + : "a" (&_zzq_args[0]), \ + "0" ((unsigned long int)_zzq_default) \ : "cc", "2", "3", "memory" \ ); \ _zzq_result; \ |
|
From: Mark W. <ma...@so...> - 2021-03-09 15:53:24
|
https://sourceware.org/git/gitweb.cgi?p=valgrind.git;h=8b1961511c93962ea2a9b918af8e9c32e3c24d71 commit 8b1961511c93962ea2a9b918af8e9c32e3c24d71 Author: Balint Reczey <bal...@ca...> Date: Thu Nov 28 13:34:21 2019 +0100 Don't look for debug alt file in debug image if it is already found With dwz the .gnu_debuglink section may appear duplicated in the debug file referenced originally in the .gnu_debuglink section. https://bugs.launchpad.net/ubuntu/+source/valgrind/+bug/1848211 https://bugs.kde.org/show_bug.cgi?id=396656 https://bugs.kde.org/show_bug.cgi?id=427969 Signed-off-by: Balint Reczey <bal...@ca...> Diff: --- NEWS | 2 ++ coregrind/m_debuginfo/readelf.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 6679177b89..93fad51810 100644 --- a/NEWS +++ b/NEWS @@ -114,6 +114,7 @@ where XXXXXX is the bug number as listed below. 384729 __libc_freeres inhibits cross-platform valgrind 388787 Support for C++17 new/delete 391853 Makefile.all.am:L247 and @SOLARIS_UNDEF_LARGESOURCE@ being empty +396656 Warnings while reading debug info 397605 ioctl FICLONE mishandled 408663 Suppression file for musl libc 404076 s390x: z14 vector instructions not implemented @@ -140,6 +141,7 @@ where XXXXXX is the bug number as listed below. 427404 PPC ISA 3.1 support is missing, part 6 427870 lmw, lswi and related PowerPC insns aren't allowed on ppc64le 427787 Support new faccessat2 linux syscall (439) +427969 debuginfo section duplicates a section in the main ELF file 428035 drd: Unbreak the musl build 428648 s390_emit_load_mem panics due to 20-bit offset for vector load 428716 cppcheck detects potential leak in VEX/useful/smchash.c diff --git a/coregrind/m_debuginfo/readelf.c b/coregrind/m_debuginfo/readelf.c index 3f5f48c703..b0f062ddc6 100644 --- a/coregrind/m_debuginfo/readelf.c +++ b/coregrind/m_debuginfo/readelf.c @@ -3170,7 +3170,8 @@ Bool ML_(read_elf_debug_info) ( struct _DebugInfo* di ) if (!ML_(sli_is_valid)(debug_frame_escn)) FIND(need_dwarf2, ".zdebug_frame", debug_frame_escn) - FIND( need_dwarf2, ".gnu_debugaltlink", debugaltlink_escn) + if (!ML_(sli_is_valid)(debugaltlink_escn)) + FIND( need_dwarf2, ".gnu_debugaltlink", debugaltlink_escn) FIND( need_dwarf1, ".debug", dwarf1d_escn) FIND( need_dwarf1, ".line", dwarf1l_escn) |