You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
1
|
2
|
3
(1) |
4
(1) |
5
|
6
(1) |
7
|
|
8
|
9
(1) |
10
(4) |
11
(3) |
12
(6) |
13
(13) |
14
(1) |
|
15
(1) |
16
(3) |
17
|
18
(1) |
19
(3) |
20
(7) |
21
(5) |
|
22
|
23
(1) |
24
|
25
(3) |
26
|
27
(3) |
28
|
|
29
(1) |
30
(1) |
31
(5) |
|
|
|
|
|
From: Austin E. <aus...@gm...> - 2017-01-20 19:11:20
|
On Fri, Jan 20, 2017 at 4:15 AM, Julian Seward <js...@ac...> wrote: > On 20/01/17 09:12, Austin English wrote: > >>> I have attached a new series which is hopefully less hacky: >>> >>> https://bugs.kde.org/show_bug.cgi?id=344139#c3 (*) >>> https://bugs.kde.org/show_bug.cgi?id=344139#c4 > > Landed, r16204, r3299. Great, thanks! >> My wine/valgrind branch has one other patch, for >> https://bugs.winehq.org/show_bug.cgi?id=39097. So I also tried >> reapplying 4a1629c4117fda9eca63b6f56ea45771dc9734ac, and rerunning >> dlls/comdlg32/tests/filedlg.c with valgrind, but it still hangs. > > What's the Valgrind patch there? I can't see any patch attached to > https://bugs.winehq.org/show_bug.cgi?id=39097. Sorry if I was unclear, there's not one. It was a wine change that causes problems for me running under valgrind, but apparently not others. -- -Austin GPG: 14FB D7EA A041 937B |
|
From: Julian S. <js...@ac...> - 2017-01-20 10:16:02
|
On 20/01/17 09:12, Austin English wrote: >> I have attached a new series which is hopefully less hacky: >> >> https://bugs.kde.org/show_bug.cgi?id=344139#c3 (*) >> https://bugs.kde.org/show_bug.cgi?id=344139#c4 Landed, r16204, r3299. > My wine/valgrind branch has one other patch, for > https://bugs.winehq.org/show_bug.cgi?id=39097. So I also tried > reapplying 4a1629c4117fda9eca63b6f56ea45771dc9734ac, and rerunning > dlls/comdlg32/tests/filedlg.c with valgrind, but it still hangs. What's the Valgrind patch there? I can't see any patch attached to https://bugs.winehq.org/show_bug.cgi?id=39097. J |
|
From: <sv...@va...> - 2017-01-20 10:01:49
|
Author: sewardj
Date: Fri Jan 20 10:01:42 2017
New Revision: 3299
Log:
x86: Recognize the SS segment prefix on x86. Bug 344139 comment 4.
Patch from Sebastian Lackner, seb...@fd....
Modified:
trunk/priv/guest_x86_toIR.c
Modified: trunk/priv/guest_x86_toIR.c
==============================================================================
--- trunk/priv/guest_x86_toIR.c (original)
+++ trunk/priv/guest_x86_toIR.c Fri Jan 20 10:01:42 2017
@@ -1409,6 +1409,7 @@
case 0x26: return "%es:";
case 0x64: return "%fs:";
case 0x65: return "%gs:";
+ case 0x36: return "%ss:";
default: vpanic("sorbTxt(x86,guest)");
}
}
@@ -1433,6 +1434,7 @@
case 0x26: sreg = R_ES; break;
case 0x64: sreg = R_FS; break;
case 0x65: sreg = R_GS; break;
+ case 0x36: sreg = R_SS; break;
default: vpanic("handleSegOverride(x86,guest)");
}
@@ -8101,7 +8103,7 @@
Int sz = 4;
/* sorb holds the segment-override-prefix byte, if any. Zero if no
- prefix has been seen, else one of {0x26, 0x3E, 0x64, 0x65}
+ prefix has been seen, else one of {0x26, 0x36, 0x3E, 0x64, 0x65}
indicating the prefix. */
UChar sorb = 0;
@@ -8255,6 +8257,7 @@
case 0x26: /* %ES: */
case 0x64: /* %FS: */
case 0x65: /* %GS: */
+ case 0x36: /* %SS: */
if (sorb != 0)
goto decode_failure; /* only one seg override allowed */
sorb = pre;
@@ -8274,9 +8277,6 @@
}
break;
}
- case 0x36: /* %SS: */
- /* SS override cases are not handled */
- goto decode_failure;
default:
goto not_a_prefix;
}
|
Author: philippe
Date: Fri Jan 20 09:59:05 2017
New Revision: 3298
Log:
Small comment fix: point at the correct file name
Modified:
trunk/priv/guest_amd64_defs.h
trunk/priv/guest_arm64_defs.h
trunk/priv/guest_arm_defs.h
trunk/priv/guest_mips_defs.h
trunk/priv/guest_ppc_defs.h
trunk/priv/guest_s390_defs.h
trunk/priv/guest_tilegx_defs.h
trunk/priv/guest_x86_defs.h
Modified: trunk/priv/guest_amd64_defs.h
==============================================================================
--- trunk/priv/guest_amd64_defs.h (original)
+++ trunk/priv/guest_amd64_defs.h Fri Jan 20 09:59:05 2017
@@ -48,7 +48,7 @@
/*---------------------------------------------------------*/
/* Convert one amd64 insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ guest_generic_bb_to_IR.h. */
extern
DisResult disInstr_AMD64 ( IRSB* irbb,
Bool (*resteerOkFn) ( void*, Addr ),
Modified: trunk/priv/guest_arm64_defs.h
==============================================================================
--- trunk/priv/guest_arm64_defs.h (original)
+++ trunk/priv/guest_arm64_defs.h Fri Jan 20 09:59:05 2017
@@ -38,7 +38,7 @@
/*---------------------------------------------------------*/
/* Convert one ARM64 insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ guest_generic_bb_to_IR.h. */
extern
DisResult disInstr_ARM64 ( IRSB* irbb,
Bool (*resteerOkFn) ( void*, Addr ),
Modified: trunk/priv/guest_arm_defs.h
==============================================================================
--- trunk/priv/guest_arm_defs.h (original)
+++ trunk/priv/guest_arm_defs.h Fri Jan 20 09:59:05 2017
@@ -40,7 +40,7 @@
/*---------------------------------------------------------*/
/* Convert one ARM insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ geust_generic_ bb_to_IR.h. */
extern
DisResult disInstr_ARM ( IRSB* irbb,
Bool (*resteerOkFn) ( void*, Addr ),
Modified: trunk/priv/guest_mips_defs.h
==============================================================================
--- trunk/priv/guest_mips_defs.h (original)
+++ trunk/priv/guest_mips_defs.h Fri Jan 20 09:59:05 2017
@@ -40,7 +40,8 @@
/*--- mips to IR conversion ---*/
/*---------------------------------------------------------*/
-/* Convert one MIPS insn to IR. See the type DisOneInstrFn in bb_to_IR.h. */
+/* Convert one MIPS insn to IR. See the type DisOneInstrFn in
+ guest_generic_bb_to_IR.h. */
extern DisResult disInstr_MIPS ( IRSB* irbb,
Bool (*resteerOkFn) (void *, Addr),
Bool resteerCisOk,
Modified: trunk/priv/guest_ppc_defs.h
==============================================================================
--- trunk/priv/guest_ppc_defs.h (original)
+++ trunk/priv/guest_ppc_defs.h Fri Jan 20 09:59:05 2017
@@ -49,7 +49,7 @@
/*---------------------------------------------------------*/
/* Convert one ppc insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ guest_generic_bb_to_IR.h. */
extern
DisResult disInstr_PPC ( IRSB* irbb,
Bool (*resteerOkFn) ( void*, Addr ),
Modified: trunk/priv/guest_s390_defs.h
==============================================================================
--- trunk/priv/guest_s390_defs.h (original)
+++ trunk/priv/guest_s390_defs.h Fri Jan 20 09:59:05 2017
@@ -39,7 +39,7 @@
/* Convert one s390 insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ guest_generic_bb_to_IR.h. */
DisResult disInstr_S390 ( IRSB* irbb,
Bool (*resteerOkFn) ( void*, Addr ),
Bool resteerCisOk,
Modified: trunk/priv/guest_tilegx_defs.h
==============================================================================
--- trunk/priv/guest_tilegx_defs.h (original)
+++ trunk/priv/guest_tilegx_defs.h Fri Jan 20 09:59:05 2017
@@ -40,7 +40,7 @@
/*---------------------------------------------------------*/
/* Convert one TILEGX insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ guest_generic_bb_to_IR.h. */
extern DisResult disInstr_TILEGX ( IRSB* irbb,
Bool (*resteerOkFn) ( void *, Addr ),
Bool resteerCisOk,
Modified: trunk/priv/guest_x86_defs.h
==============================================================================
--- trunk/priv/guest_x86_defs.h (original)
+++ trunk/priv/guest_x86_defs.h Fri Jan 20 09:59:05 2017
@@ -48,7 +48,7 @@
/*---------------------------------------------------------*/
/* Convert one x86 insn to IR. See the type DisOneInstrFn in
- bb_to_IR.h. */
+ guest_generic_bb_to_IR.h. */
extern
DisResult disInstr_X86 ( IRSB* irbb,
Bool (*resteerOkFn) ( void*, Addr ),
|
|
From: <sv...@va...> - 2017-01-20 09:58:23
|
Author: sewardj
Date: Fri Jan 20 09:58:15 2017
New Revision: 16204
Log:
x86-linux: Initialize x86 system GDT on first use. Bug 344139 comment 3.
Patch from Sebastian Lackner, seb...@fd....
Modified:
trunk/coregrind/m_syswrap/syswrap-x86-linux.c
Modified: trunk/coregrind/m_syswrap/syswrap-x86-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-x86-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-x86-linux.c Fri Jan 20 09:58:15 2017
@@ -294,11 +294,37 @@
out->LdtEnt.Words.word2 = entry_2;
}
-/* Create a zeroed-out GDT. */
-static VexGuestX86SegDescr* alloc_zeroed_x86_GDT ( void )
+/* Create initial GDT. */
+static VexGuestX86SegDescr* alloc_system_x86_GDT ( void )
{
Int nbytes = VEX_GUEST_X86_GDT_NENT * sizeof(VexGuestX86SegDescr);
- return VG_(calloc)("di.syswrap-x86.azxG.1", nbytes, 1);
+ VexGuestX86SegDescr* gdt = VG_(calloc)("di.syswrap-x86.azxG.1", nbytes, 1);
+ vki_modify_ldt_t info;
+ UShort seg;
+
+ VG_(memset)(&info, 0, sizeof(info));
+ info.entry_number = 0;
+ info.base_addr = 0;
+ info.limit = 0xfffff;
+ info.seg_32bit = 1;
+ info.contents = 0;
+ info.read_exec_only = 0;
+ info.limit_in_pages = 1;
+ info.seg_not_present = 0;
+ info.useable = 0;
+ info.reserved = 0;
+
+ asm volatile("movw %%ds, %0" : : "m" (seg));
+ if (!(seg & 4)) translate_to_hw_format(&info, &gdt[seg >> 3], 0);
+ asm volatile("movw %%ss, %0" : : "m" (seg));
+ if (!(seg & 4)) translate_to_hw_format(&info, &gdt[seg >> 3], 0);
+
+ info.contents = 2;
+
+ asm volatile("movw %%cs, %0" : : "m" (seg));
+ if (!(seg & 4)) translate_to_hw_format(&info, &gdt[seg >> 3], 0);
+
+ return gdt;
}
/* Create a zeroed-out LDT. */
@@ -505,7 +531,7 @@
/* If the thread doesn't have a GDT, allocate it now. */
if (!gdt) {
- gdt = alloc_zeroed_x86_GDT();
+ gdt = alloc_system_x86_GDT();
VG_(threads)[tid].arch.vex.guest_GDT = (HWord)gdt;
}
@@ -564,7 +590,7 @@
/* If the thread doesn't have a GDT, allocate it now. */
if (!gdt) {
- gdt = alloc_zeroed_x86_GDT();
+ gdt = alloc_system_x86_GDT();
VG_(threads)[tid].arch.vex.guest_GDT = (HWord)gdt;
}
@@ -616,7 +642,7 @@
child->vex.guest_GDT = (HWord)NULL;
if (parent->vex.guest_GDT != (HWord)NULL) {
- child->vex.guest_GDT = (HWord)alloc_zeroed_x86_GDT();
+ child->vex.guest_GDT = (HWord)alloc_system_x86_GDT();
copy_GDT_from_to( (VexGuestX86SegDescr*)parent->vex.guest_GDT,
(VexGuestX86SegDescr*)child->vex.guest_GDT );
}
|
|
From: Austin E. <aus...@gm...> - 2017-01-20 08:13:04
|
On Thu, Jan 19, 2017 at 9:40 PM, Sebastian Lackner <seb...@fd...> wrote: > On 19.01.2017 20:30, Julian Seward wrote: >> >> Hi Sebastian, >> >>> The Valgrind bugtracker also contains three patches I proposed back then. I >>> was hoping that this would speed up the process of getting this fixed, but >>> unfortunately it didn't help much. At many places Valgrind does not yet >>> handle signal registers correctly and doesn't complain - except here, which >>> is really unfortunate because even ignoring would be sufficient to make Wine >>> happy. >> >> Sorry this fell through the cracks. One underlying problem is that, some >> time back in 2003, I learnt just enough about x86 segment stuff to hack up >> what's currently in Valgrind, and then promptly forgot about it. So I'm >> not in much of a position to make an informed judgement now. >> >> That said .. I would be OK with a partial fix which improves Valgrind's >> SS handling enough to make Wine work, so long as it doesn't create a >> situation where other cases are silently handled incorrectly. That is, >> if the fix only moves forwards on the correctness scale, and doesn't >> introduce any regressions. >> >> On rereading https://bugs.kde.org/show_bug.cgi?id=344139#c1 I see that you >> have a candidate patch (http://ix.io/gKt, "Correctly handle the SS prefix >> when explicitly specified.") which appears to have the abovementioned >> properties. Is that correct? >> >> J >> > > As discussed on IRC, this direction probably makes most sense. In contrast to > the other approaches, no special handling for the SS segment is required - > nevertheless, we have to initialize some GDT entries to make this work. > > I have attached a new series which is hopefully less hacky: > > https://bugs.kde.org/show_bug.cgi?id=344139#c3 (*) > https://bugs.kde.org/show_bug.cgi?id=344139#c4 > > (*) On some systems the segment for DS and SS is the same, but initializing > twice shouldn't hurt. > > For me it fixes the Wine tests (@Austin: Could you confirm?). > Please let me know if you have any other suggestions for improvement (either > here or on the bugtracker). Thanks! > > Best regards, > Sebastian > With those two patches on top of r16203, I can run dlls/advapi32/tests/service.c again without the trap 0 occurring My wine/valgrind branch has one other patch, for https://bugs.winehq.org/show_bug.cgi?id=39097. So I also tried reapplying 4a1629c4117fda9eca63b6f56ea45771dc9734ac, and rerunning dlls/comdlg32/tests/filedlg.c with valgrind, but it still hangs. So the patches are good for me, but there's still at least one wine and valgrind regression that needs to be investigated. -- -Austin GPG: 14FB D7EA A041 937B |
|
From: Sebastian L. <seb...@fd...> - 2017-01-20 03:40:31
|
On 19.01.2017 20:30, Julian Seward wrote: > > Hi Sebastian, > >> The Valgrind bugtracker also contains three patches I proposed back then. I >> was hoping that this would speed up the process of getting this fixed, but >> unfortunately it didn't help much. At many places Valgrind does not yet >> handle signal registers correctly and doesn't complain - except here, which >> is really unfortunate because even ignoring would be sufficient to make Wine >> happy. > > Sorry this fell through the cracks. One underlying problem is that, some > time back in 2003, I learnt just enough about x86 segment stuff to hack up > what's currently in Valgrind, and then promptly forgot about it. So I'm > not in much of a position to make an informed judgement now. > > That said .. I would be OK with a partial fix which improves Valgrind's > SS handling enough to make Wine work, so long as it doesn't create a > situation where other cases are silently handled incorrectly. That is, > if the fix only moves forwards on the correctness scale, and doesn't > introduce any regressions. > > On rereading https://bugs.kde.org/show_bug.cgi?id=344139#c1 I see that you > have a candidate patch (http://ix.io/gKt, "Correctly handle the SS prefix > when explicitly specified.") which appears to have the abovementioned > properties. Is that correct? > > J > As discussed on IRC, this direction probably makes most sense. In contrast to the other approaches, no special handling for the SS segment is required - nevertheless, we have to initialize some GDT entries to make this work. I have attached a new series which is hopefully less hacky: https://bugs.kde.org/show_bug.cgi?id=344139#c3 (*) https://bugs.kde.org/show_bug.cgi?id=344139#c4 (*) On some systems the segment for DS and SS is the same, but initializing twice shouldn't hurt. For me it fixes the Wine tests (@Austin: Could you confirm?). Please let me know if you have any other suggestions for improvement (either here or on the bugtracker). Thanks! Best regards, Sebastian |