You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
|
1
(6) |
|
2
(4) |
3
(9) |
4
(11) |
5
(16) |
6
(6) |
7
(1) |
8
(11) |
|
9
(11) |
10
(6) |
11
(10) |
12
(23) |
13
(23) |
14
(6) |
15
(10) |
|
16
(5) |
17
(13) |
18
(9) |
19
(4) |
20
(6) |
21
(16) |
22
(3) |
|
23
(5) |
24
(7) |
25
(6) |
26
(4) |
27
(8) |
28
|
29
(3) |
|
30
(2) |
31
(17) |
|
|
|
|
|
|
From: Philippe W. <phi...@sk...> - 2015-08-06 17:05:29
|
On Wed, 2015-08-05 at 22:30 -0400, Zhi-Gang Liu wrote:
> Philippe,
>
>
> I'm not sure how to create the right XML files for tilegx right now.
> For ARM64, its target_xml() just simply returns NULL.
>
> I'd like to do same here i.e. the patch below. Any thought?
Defining xml files allows GDB to display shadow registers.
The classical way to define xml files is to start from the xml
files part of gdb, in directory gdb/features.
However, I see that in GDB 7.9.1, there is no tilegx xml files.
So, the alternative is to start from an existing file set
(e.g. starting from mips64-linux.xml and mips64-linux-valgrind.xml)
and modify the file content (and the content of the included files).
Basically, you describe the registers as expected by GDB,
using the predefined types.
This file has then to be duplicated to define the equivalent
shadow 1 and shadow 2 sets.
So, in theory, no difficulty expected
(but maybe tilegx is special, as gdb has no xml files for it?).
Otherwise, the alternative is the patch below, which effectively
ensures no xml files are needed (but it means users cannot look
at shadow registers).
If no user complained for lack of --vgdb-shadow-registers=yes support
on tilegx, then the patch below will ensure a consistent distribution.
Thanks
Philippe
>
>
> ---ZhiGang
>
>
>
> Index: coregrind/m_gdbserver/valgrind-low-tilegx.c
> ===================================================================
> --- coregrind/m_gdbserver/valgrind-low-tilegx.c (revision 15500)
> +++ coregrind/m_gdbserver/valgrind-low-tilegx.c (working copy)
> @@ -225,11 +225,13 @@
> static
> const char* target_xml ( Bool shadow_mode )
> {
> - if (shadow_mode) {
> + return NULL;
> +#if 0
> + if (shadow_mode)
> return "tilegx-linux-valgrind.xml";
> - } else {
> + else
> return "tilegx-linux.xml";
> - }
> +#endif
> }
>
> static CORE_ADDR** target_get_dtv (ThreadState *tst)
>
>
> On Wed, Aug 5, 2015 at 12:49 PM, Philippe Waroquiers
> <phi...@sk...> wrote:
> On Mon, 2015-08-03 at 11:33 +0200, Florian Krohm wrote:
> > You ought to run "make regtest" when making changes that
> have the
> > potential to break stuff.
> > There are zillions of messages like this one:
> >
> > none/tests/tilegx/Makefile.am:1: error:
> > insn_test_ldnt4u_add_X1.stderr.exp is in EXTRA_DIST but
> doesn't exist
> > none/tests/tilegx/Makefile.am:1: error:
> insn_test_ldnt4u_add_X1.vgtest
> > is in EXTRA_DIST but doesn't exist
> > none/tests/tilegx/Makefile.am:1: error:
> insn_test_ldnt_add_X1.stdout.exp
> > is in EXTRA_DIST but doesn't exist
> Hello Zhigang,
>
> While we are speaking about missing files ...
>
>
> The tilegx xml files are referenced in
> coregrind/m_gdbserver/valgrind-low-tilegx.c
> but are not present in coregrind/m_gdbserver directory
> and are not mentionned in coregrind/Makefile.am
>
>
> So, could you also add the missing tilegx gdbserver xml files
> and add them to the Makefile.am 'GDBSERVER_XML_FILES =' ?
>
> Thanks
>
> Philippe
>
>
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>
>
>
|
|
From: <sv...@va...> - 2015-08-06 16:42:20
|
Author: philippe
Date: Thu Aug 6 17:42:12 2015
New Revision: 15504
Log:
Ensure gdbserver_tests/mcbreak.vgtest works with gcc 4.9
At least on x86+gcc4.9, the test fails because step+finish
makes the program stop on the breakme call line (after the call)
instead of reaching line 120.
So; change the gdb commands so as to ensure we reach line 120
Modified:
trunk/gdbserver_tests/mcbreak.stdinB.gdb
trunk/gdbserver_tests/mcbreak.stdoutB.exp
Modified: trunk/gdbserver_tests/mcbreak.stdinB.gdb
==============================================================================
--- trunk/gdbserver_tests/mcbreak.stdinB.gdb (original)
+++ trunk/gdbserver_tests/mcbreak.stdinB.gdb Thu Aug 6 17:42:12 2015
@@ -51,9 +51,9 @@
print whoami("after next: inferior call pushed from mcbreak.stdinB.gdb")
continue
#
-# encountered second break
-step
-finish
+# encountered second break. Ensure we stop on line 120 : if (argc > 1)
+break 120
+continue
# delete all breaks
delete
continue
Modified: trunk/gdbserver_tests/mcbreak.stdoutB.exp
==============================================================================
--- trunk/gdbserver_tests/mcbreak.stdoutB.exp (original)
+++ trunk/gdbserver_tests/mcbreak.stdoutB.exp Thu Aug 6 17:42:12 2015
@@ -36,10 +36,9 @@
Continuing.
Breakpoint 2, main (argc=1, argv=0x........) at t.c:118
118 breakme(__LINE__); //break2
-breakme (line=118) at t.c:101
-101 if (line > 1000)
-Run till exit from #0 breakme (line=118) at t.c:101
-main (argc=1, argv=0x........) at t.c:120
+Breakpoint 3 at 0x........: file t.c, line 120.
+Continuing.
+Breakpoint 3, main (argc=1, argv=0x........) at t.c:120
120 if (argc > 1)
Delete all breakpoints? (y or n) [answered Y; input not from terminal]
Continuing.
|
|
From: <sv...@va...> - 2015-08-06 12:11:40
|
Author: florian
Date: Thu Aug 6 13:11:33 2015
New Revision: 15503
Log:
Fix printf format inconsistencies as pointed out by gcc -Wformat-signedness.
Modified:
trunk/coregrind/m_gdbserver/m_gdbserver.c
trunk/coregrind/m_gdbserver/remote-utils.c
trunk/coregrind/m_gdbserver/server.c
trunk/coregrind/m_gdbserver/signals.c
trunk/coregrind/m_gdbserver/target.c
trunk/coregrind/m_gdbserver/utils.c
Modified: trunk/coregrind/m_gdbserver/m_gdbserver.c
==============================================================================
--- trunk/coregrind/m_gdbserver/m_gdbserver.c (original)
+++ trunk/coregrind/m_gdbserver/m_gdbserver.c Thu Aug 6 13:11:33 2015
@@ -425,7 +425,7 @@
vg_assert (kind == access_watchpoint
|| kind == read_watchpoint
|| kind == write_watchpoint);
- dlog(1, "tid %d VG_(is_watched) %s addr %p szB %d\n",
+ dlog(1, "tid %u VG_(is_watched) %s addr %p szB %d\n",
tid, VG_(ppPointKind) (kind), C2v(addr), szB);
for (i = 0; i < n_elems; i++) {
@@ -622,7 +622,7 @@
data from its parent */
static void gdbserver_cleanup_in_child_after_fork(ThreadId me)
{
- dlog(1, "thread %d gdbserver_cleanup_in_child_after_fork pid %d\n",
+ dlog(1, "thread %u gdbserver_cleanup_in_child_after_fork pid %d\n",
me, VG_(getpid) ());
/* finish connection inheritated from parent */
@@ -663,7 +663,7 @@
Addr saved_pc;
dlog(1,
- "entering call_gdbserver %s ... pid %d tid %d status %s "
+ "entering call_gdbserver %s ... pid %d tid %u status %s "
"sched_jmpbuf_valid %d\n",
ppCallReason (reason),
VG_(getpid) (), tid, VG_(name_of_ThreadStatus)(tst->status),
@@ -754,7 +754,7 @@
Otherwise we just return to continue executing the
current block. */
if (VG_(get_IP) (tid) != saved_pc) {
- dlog(1, "tid %d %s PC changed from %s to %s\n",
+ dlog(1, "tid %u %s PC changed from %s to %s\n",
tid, VG_(name_of_ThreadStatus) (tst->status),
sym(saved_pc, /* is_code */ True),
sym(VG_(get_IP) (tid), /* is_code */ True));
@@ -841,7 +841,7 @@
ptrace handling. */
vg_assert2(0,
"vgdb did not took control. Did you kill vgdb ?\n"
- "busy %d vgdb_interrupted_tid %d\n",
+ "busy %d vgdb_interrupted_tid %u\n",
busy, vgdb_interrupted_tid);
#else /* defined(VGO_solaris) */
/* On Solaris, this code is run within the context of an agent thread
@@ -912,12 +912,12 @@
From here onwards, function calls are ok: it is
safe to call valgrind core functions: all threads are blocked in
a system call or are yielding or ... */
- dlog(1, "invoke_gdbserver running_tid %d vgdb_interrupted_tid %d\n",
+ dlog(1, "invoke_gdbserver running_tid %u vgdb_interrupted_tid %u\n",
VG_(running_tid), vgdb_interrupted_tid);
call_gdbserver (vgdb_interrupted_tid, vgdb_reason);
vgdb_interrupted_tid = 0;
dlog(1,
- "exit invoke_gdbserver running_tid %d\n", VG_(running_tid));
+ "exit invoke_gdbserver running_tid %u\n", VG_(running_tid));
give_control_back_to_vgdb();
vg_assert2(0, "end of invoke_gdbserver reached");
@@ -948,7 +948,7 @@
ThreadId tid)
{
dlog(1, "VG core calling %s "
- "vki_nr %d %s gdb_nr %d %s tid %d\n",
+ "vki_nr %d %s gdb_nr %u %s tid %u\n",
who,
info->si_signo, VG_(signame)(info->si_signo),
target_signal_from_host (info->si_signo),
@@ -1014,7 +1014,7 @@
void VG_(gdbserver_exit) (ThreadId tid, VgSchedReturnCode tids_schedretcode)
{
- dlog(1, "VG core calling VG_(gdbserver_exit) tid %d will exit\n", tid);
+ dlog(1, "VG core calling VG_(gdbserver_exit) tid %u will exit\n", tid);
if (remote_connected()) {
/* Make sure vgdb knows we are about to die and why. */
switch(tids_schedretcode) {
@@ -1505,7 +1505,7 @@
VG_(umsg)
("nr of calls to gdbserver: %d\n"
"single stepping %d\n"
- "interrupts intr_tid %d gs_non_busy %d gs_busy %d tid_non_intr %d\n"
+ "interrupts intr_tid %u gs_non_busy %d gs_busy %d tid_non_intr %d\n"
"gdbserved addresses %d (-1 = not initialized)\n"
"watchpoints %d (-1 = not initialized)\n"
"vgdb-error %d\n"
Modified: trunk/coregrind/m_gdbserver/remote-utils.c
==============================================================================
--- trunk/coregrind/m_gdbserver/remote-utils.c (original)
+++ trunk/coregrind/m_gdbserver/remote-utils.c Thu Aug 6 13:11:33 2015
@@ -53,7 +53,7 @@
VG_(dmsg)("current sigmask value { ");
for (i = 1; i <= _VKI_NSIG; i++) {
if (VG_(sigismember)(&cursigset, i))
- VG_(dmsg)("%u ", i);
+ VG_(dmsg)("%d ", i);
}
VG_(dmsg)("}\n");
}
@@ -598,7 +598,7 @@
else if (a >= 'a' && a <= 'f')
return a - 'a' + 10;
else
- error ("Reply contains invalid hex digit 0x%x\n", a);
+ error ("Reply contains invalid hex digit 0x%x\n", (unsigned)a);
return 0;
}
@@ -878,7 +878,7 @@
cc = readchar (1);
if (cc > 0)
- dlog(3, "[received '%c' (0x%x)]\n", cc, cc);
+ dlog(3, "[received '%c' (0x%x)]\n", cc, (unsigned)cc);
if (cc <= 0) {
if (cc == 0)
@@ -1038,7 +1038,7 @@
break;
dlog (0, "Bad checksum, sentsum=0x%x, csum=0x%x, buf=%s\n",
- (c1 << 4) + c2, csum, buf);
+ (unsigned)(c1 << 4) + c2, (unsigned)csum, buf);
if (!ensure_write_remote_desc()) {
dlog(1, "getpkt(write nack) no write_remote_desc");
}
@@ -1164,7 +1164,7 @@
((struct inferior_list_entry *)current_inferior)->id;
gdb_id_from_wait = thread_to_gdb_id (current_inferior);
- dlog(1, "Writing resume reply for %ld\n", thread_from_wait);
+ dlog(1, "Writing resume reply for %lu\n", thread_from_wait);
/* This if (1) ought to be unnecessary. But remote_wait in GDB
will claim this event belongs to inferior_ptid if we do not
specify a thread, and there's no way for gdbserver to know
Modified: trunk/coregrind/m_gdbserver/server.c
==============================================================================
--- trunk/coregrind/m_gdbserver/server.c (original)
+++ trunk/coregrind/m_gdbserver/server.c Thu Aug 6 13:11:33 2015
@@ -375,7 +375,7 @@
VG_(show_all_errors)(/* verbosity */ 2, /* xml */ False);
break;
case 1: // n_errs_found
- VG_(printf) ("n_errs_found %d n_errs_shown %d (vgdb-error %d) %s\n",
+ VG_(printf) ("n_errs_found %u n_errs_shown %u (vgdb-error %d) %s\n",
VG_(get_n_errs_found) (),
VG_(get_n_errs_shown) (),
VG_(dyn_vgdb_error),
@@ -763,12 +763,12 @@
len = (PBUFSIZ + POVERHSIZ) / 2;
char status[len];
if (tst->thread_name) {
- VG_(snprintf) (status, sizeof(status), "tid %d %s %s",
+ VG_(snprintf) (status, sizeof(status), "tid %u %s %s",
tst->tid,
VG_(name_of_ThreadStatus)(tst->status),
tst->thread_name);
} else {
- VG_(snprintf) (status, sizeof(status), "tid %d %s",
+ VG_(snprintf) (status, sizeof(status), "tid %u %s",
tst->tid,
VG_(name_of_ThreadStatus)(tst->status));
}
@@ -900,7 +900,7 @@
UWord *client_auxv = VG_(client_auxv);
unsigned int client_auxv_len = 0;
while (*client_auxv != 0) {
- dlog(4, "auxv %lld %llx\n",
+ dlog(4, "auxv %llu %llx\n",
(ULong)*client_auxv,
(ULong)*(client_auxv+1));
client_auxv++;
@@ -908,7 +908,7 @@
client_auxv_len += 2 * sizeof(UWord);
}
client_auxv_len += 2 * sizeof(UWord);
- dlog(4, "auxv len %d\n", client_auxv_len);
+ dlog(4, "auxv len %u\n", client_auxv_len);
if (ofs >= client_auxv_len)
n = -1;
@@ -1030,7 +1030,7 @@
/* Protocol features query. */
if (strncmp ("qSupported", arg_own_buf, 10) == 0
&& (arg_own_buf[10] == ':' || arg_own_buf[10] == '\0')) {
- VG_(sprintf) (arg_own_buf, "PacketSize=%x", PBUFSIZ - 1);
+ VG_(sprintf) (arg_own_buf, "PacketSize=%x", (UInt)PBUFSIZ - 1);
/* Note: max packet size including frame and checksum, but without
trailing null byte, which is not sent/received. */
@@ -1414,7 +1414,7 @@
VG_(umsg) ("\nChild exited with status %d\n", zignal);
if (status == 'X')
VG_(umsg) ("\nChild terminated with signal = 0x%x (%s)\n",
- target_signal_to_host (zignal),
+ (UInt)target_signal_to_host (zignal),
target_signal_to_name (zignal));
if (status == 'W' || status == 'X') {
VG_(umsg) ("Process exiting\n");
Modified: trunk/coregrind/m_gdbserver/signals.c
==============================================================================
--- trunk/coregrind/m_gdbserver/signals.c (original)
+++ trunk/coregrind/m_gdbserver/signals.c Thu Aug 6 13:11:33 2015
@@ -741,7 +741,7 @@
}
#endif
error ("Valgrind GDBSERVER bug: (do_target_signal_to_host):"
- " unrecognized target signal %d\n", oursig);
+ " unrecognized target signal %u\n", oursig);
*oursig_ok = 0;
return 0;
}
Modified: trunk/coregrind/m_gdbserver/target.c
==============================================================================
--- trunk/coregrind/m_gdbserver/target.c (original)
+++ trunk/coregrind/m_gdbserver/target.c Thu Aug 6 13:11:33 2015
@@ -44,7 +44,7 @@
char *image_ptid(unsigned long ptid)
{
static char result[50]; // large enough
- VG_(sprintf) (result, "id %ld", ptid);
+ VG_(sprintf) (result, "id %lu", ptid);
return result;
}
#define get_thread(inf) ((struct thread_info *)(inf))
@@ -74,7 +74,7 @@
/* call add_thread for all valgrind threads not known in gdb all_threads */
for (tid = 1; tid < VG_N_THREADS; tid++) {
-#define LOCAL_THREAD_TRACE " ti* %p vgtid %d status %s as gdb ptid %s lwpid %d\n", \
+#define LOCAL_THREAD_TRACE " ti* %p vgtid %u status %s as gdb ptid %s lwpid %d\n", \
ti, tid, VG_(name_of_ThreadStatus) (ts->status), \
image_ptid (ptid), ts->os_state.lwpid
@@ -293,7 +293,7 @@
if (*ourstatus == 'X') {
sig = target_signal_from_host(exit_code_to_report);
exit_code_to_report = 0;
- dlog(1, "exit valgrind_wait status X signal %d\n", sig);
+ dlog(1, "exit valgrind_wait status X signal %u\n", sig);
return sig;
}
}
@@ -320,7 +320,7 @@
stop_pc = (*the_low_target.get_pc) ();
dlog(1,
- "exit valgrind_wait status T ptid %s stop_pc %s signal %d\n",
+ "exit valgrind_wait status T ptid %s stop_pc %s signal %u\n",
image_ptid (wptid), sym (stop_pc), sig);
return sig;
}
@@ -351,7 +351,7 @@
if (mod && VG_(debugLog_getLevel)() > 1) {
char bufimage [2*size + 1];
heximage (bufimage, buf, size);
- dlog(3, "fetched register %d size %d name %s value %s tid %d status %s\n",
+ dlog(3, "fetched register %d size %d name %s value %s tid %u status %s\n",
regno, size, the_low_target.reg_defs[regno].name, bufimage,
tid, VG_(name_of_ThreadStatus) (tst->status));
}
@@ -419,7 +419,7 @@
heximage (bufimage, buf, size);
dlog(2,
"stored register %d size %d name %s value %s "
- "tid %d status %s\n",
+ "tid %u status %s\n",
regno, size, the_low_target.reg_defs[regno].name, bufimage,
tid, VG_(name_of_ThreadStatus) (tst->status));
}
@@ -681,7 +681,7 @@
// Check we can read at least 2 address at the beginning of dtv.
CHECK_DEREF(dtv, 2*sizeof(CORE_ADDR), "dtv 2 first entries");
- dlog (2, "tid %d dtv %p\n", tst->tid, (void*)dtv);
+ dlog (2, "tid %u dtv %p\n", tst->tid, (void*)dtv);
// Check we can read the modid
CHECK_DEREF(lm+lm_modid_offset, sizeof(unsigned long int), "link_map modid");
@@ -766,7 +766,7 @@
{
ThreadState *tst = (ThreadState *) inferior_target_data (current_inferior);
ThreadId tid = tst->tid;
- dlog(1, "set_desired_inferior use_general %d found %p tid %d lwpid %d\n",
+ dlog(1, "set_desired_inferior use_general %d found %p tid %u lwpid %d\n",
use_general, found, tid, tst->os_state.lwpid);
}
}
Modified: trunk/coregrind/m_gdbserver/utils.c
==============================================================================
--- trunk/coregrind/m_gdbserver/utils.c (original)
+++ trunk/coregrind/m_gdbserver/utils.c Thu Aug 6 13:11:33 2015
@@ -30,7 +30,7 @@
{
va_list args;
if (sr_isError (sr))
- VG_(umsg) ("error %ld %s\n", sr_Err(sr), VG_(strerror) (sr_Err(sr)));
+ VG_(umsg) ("error %lu %s\n", sr_Err(sr), VG_(strerror) (sr_Err(sr)));
else
VG_(umsg) ("sr_perror called with no error!!!\n");
va_start (args, string);
|
|
From: <sv...@va...> - 2015-08-06 09:34:27
|
Author: florian
Date: Thu Aug 6 10:34:20 2015
New Revision: 15502
Log:
As per discussion with Julian comment out some dead assignments.
Now matches what is done for arm64.
Modified:
trunk/coregrind/m_sigframe/sigframe-arm-linux.c
Modified: trunk/coregrind/m_sigframe/sigframe-arm-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-arm-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-arm-linux.c Thu Aug 6 10:34:20 2015
@@ -279,25 +279,25 @@
sigNo = priv->sigNo_private;
- //XXX: restore regs
-# define REST(reg,REG) tst->arch.vex.guest_##REG = mc->arm_##reg;
- REST(r0,R0);
- REST(r1,R1);
- REST(r2,R2);
- REST(r3,R3);
- REST(r4,R4);
- REST(r5,R5);
- REST(r6,R6);
- REST(r7,R7);
- REST(r8,R8);
- REST(r9,R9);
- REST(r10,R10);
- REST(fp,R11);
- REST(ip,R12);
- REST(sp,R13);
- REST(lr,R14);
- REST(pc,R15T);
-# undef REST
+//ZZ //XXX: restore regs
+//ZZ # define REST(reg,REG) tst->arch.vex.guest_##REG = mc->arm_##reg;
+//ZZ REST(r0,R0);
+//ZZ REST(r1,R1);
+//ZZ REST(r2,R2);
+//ZZ REST(r3,R3);
+//ZZ REST(r4,R4);
+//ZZ REST(r5,R5);
+//ZZ REST(r6,R6);
+//ZZ REST(r7,R7);
+//ZZ REST(r8,R8);
+//ZZ REST(r9,R9);
+//ZZ REST(r10,R10);
+//ZZ REST(fp,R11);
+//ZZ REST(ip,R12);
+//ZZ REST(sp,R13);
+//ZZ REST(lr,R14);
+//ZZ REST(pc,R15T);
+//ZZ # undef REST
/* Uh, the next line makes all the REST() above pointless. */
tst->arch.vex = priv->vex;
|
|
From: <sv...@va...> - 2015-08-06 09:00:57
|
Author: florian
Date: Thu Aug 6 10:00:48 2015
New Revision: 15501
Log:
Fix printf format inconsistencies as pointed out by gcc -Wformat-signedness.
Modified:
trunk/coregrind/m_sigframe/sigframe-amd64-darwin.c
trunk/coregrind/m_sigframe/sigframe-amd64-linux.c
trunk/coregrind/m_sigframe/sigframe-arm-linux.c
trunk/coregrind/m_sigframe/sigframe-arm64-linux.c
trunk/coregrind/m_sigframe/sigframe-common.c
trunk/coregrind/m_sigframe/sigframe-mips32-linux.c
trunk/coregrind/m_sigframe/sigframe-mips64-linux.c
trunk/coregrind/m_sigframe/sigframe-ppc32-linux.c
trunk/coregrind/m_sigframe/sigframe-ppc64-linux.c
trunk/coregrind/m_sigframe/sigframe-s390x-linux.c
trunk/coregrind/m_sigframe/sigframe-solaris.c
trunk/coregrind/m_sigframe/sigframe-tilegx-linux.c
trunk/coregrind/m_sigframe/sigframe-x86-darwin.c
trunk/coregrind/m_sigframe/sigframe-x86-linux.c
Modified: trunk/coregrind/m_sigframe/sigframe-amd64-darwin.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-amd64-darwin.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-amd64-darwin.c Thu Aug 6 10:00:48 2015
@@ -222,7 +222,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "sigframe_create (thread %d): "
+ "sigframe_create (thread %u): "
"next RIP=%#lx, next RSP=%#lx\n",
tid, (Addr)handler, (Addr)frame );
}
Modified: trunk/coregrind/m_sigframe/sigframe-amd64-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-amd64-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-amd64-linux.c Thu Aug 6 10:00:48 2015
@@ -494,7 +494,7 @@
if (0)
VG_(printf)("pushed signal frame; %%RSP now = %#lx, "
"next %%RIP = %#llx, status=%d\n",
- rsp, tst->arch.vex.guest_RIP, tst->status);
+ rsp, tst->arch.vex.guest_RIP, (Int)tst->status);
}
@@ -510,7 +510,7 @@
{
if (frame->magicPI != 0x31415927 ||
frame->magicE != 0x27182818) {
- VG_(message)(Vg_UserMsg, "Thread %d return signal frame "
+ VG_(message)(Vg_UserMsg, "Thread %u return signal frame "
"corrupted. Killing process.\n",
tst->tid);
VG_(set_default_handler)(VKI_SIGSEGV);
@@ -594,7 +594,7 @@
if (VG_(clo_trace_signals))
VG_(message)(
Vg_DebugMsg,
- "VG_(signal_return) (thread %d): isRT=%d valid magic; RIP=%#llx\n",
+ "VG_(signal_return) (thread %u): isRT=%d valid magic; RIP=%#llx\n",
tid, isRT, tst->arch.vex.guest_RIP);
/* tell the tools */
Modified: trunk/coregrind/m_sigframe/sigframe-arm-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-arm-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-arm-linux.c Thu Aug 6 10:00:48 2015
@@ -310,7 +310,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "vg_pop_signal_frame (thread %d): "
+ "vg_pop_signal_frame (thread %u): "
"isRT=%d valid magic; PC=%#x\n",
tid, has_siginfo, tst->arch.vex.guest_R15T);
Modified: trunk/coregrind/m_sigframe/sigframe-arm64-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-arm64-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-arm64-linux.c Thu Aug 6 10:00:48 2015
@@ -283,7 +283,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "vg_pop_signal_frame (thread %d): "
+ "vg_pop_signal_frame (thread %u): "
"isRT=%d valid magic; PC=%#llx\n",
tid, has_siginfo, tst->arch.vex.guest_PC);
Modified: trunk/coregrind/m_sigframe/sigframe-common.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-common.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-common.c Thu Aug 6 10:00:48 2015
@@ -83,7 +83,7 @@
if (stackseg == NULL || !stackseg->hasR || !stackseg->hasW) {
VG_(umsg)("Can't extend stack to %#lx during signal delivery for "
- "thread %d:\n", addr, tid);
+ "thread %u:\n", addr, tid);
if (stackseg == NULL)
VG_(umsg)(" no stack segment\n");
else
Modified: trunk/coregrind/m_sigframe/sigframe-mips32-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-mips32-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-mips32-linux.c Thu Aug 6 10:00:48 2015
@@ -339,7 +339,7 @@
VG_TRACK(die_mem_stack_signal, sp, frame_size);
if (VG_(clo_trace_signals))
VG_(message)( Vg_DebugMsg,
- "VG_(signal_return) (thread %d): isRT=%d valid magic; EIP=%#x\n",
+ "VG_(signal_return) (thread %u): isRT=%d valid magic; EIP=%#x\n",
tid, isRT, tst->arch.vex.guest_PC);
/* tell the tools */
VG_TRACK( post_deliver_signal, tid, sigNo );
Modified: trunk/coregrind/m_sigframe/sigframe-mips64-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-mips64-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-mips64-linux.c Thu Aug 6 10:00:48 2015
@@ -266,7 +266,7 @@
VG_TRACK(die_mem_stack_signal, sp, frame_size);
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "VG_(signal_return) (thread %d): isRT=%d valid magic; EIP=%#llx\n",
+ "VG_(signal_return) (thread %u): isRT=%d valid magic; EIP=%#llx\n",
tid, isRT, tst->arch.vex.guest_PC);
/* tell the tools */
VG_TRACK( post_deliver_signal, tid, sigNo );
Modified: trunk/coregrind/m_sigframe/sigframe-ppc32-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-ppc32-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-ppc32-linux.c Thu Aug 6 10:00:48 2015
@@ -752,7 +752,7 @@
if (0)
VG_(printf)("pushed signal frame; %%R1 now = %#lx, "
"next %%CIA = %#x, status=%d\n",
- sp, tst->arch.vex.guest_CIA, tst->status);
+ sp, tst->arch.vex.guest_CIA, (Int)tst->status);
}
@@ -901,7 +901,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "vg_pop_signal_frame (thread %d): "
+ "vg_pop_signal_frame (thread %u): "
"isRT=%d valid magic; EIP=%#x\n",
tid, has_siginfo, tst->arch.vex.guest_CIA);
@@ -928,7 +928,7 @@
//.. if (VG_(clo_trace_signals))
//.. VG_(message)(
//.. Vg_DebugMsg,
-//.. "VG_(signal_return) (thread %d): isRT=%d valid magic; EIP=%p",
+//.. "VG_(signal_return) (thread %u): isRT=%d valid magic; EIP=%p",
//.. tid, isRT, tst->arch.vex.guest_EIP);
//..
//.. /* tell the tools */
Modified: trunk/coregrind/m_sigframe/sigframe-ppc64-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-ppc64-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-ppc64-linux.c Thu Aug 6 10:00:48 2015
@@ -279,7 +279,7 @@
if (0)
VG_(printf)("pushed signal frame; %%R1 now = %#lx, "
"next %%CIA = %#llx, status=%d\n",
- sp, tst->arch.vex.guest_CIA, tst->status);
+ sp, tst->arch.vex.guest_CIA, (Int)tst->status);
}
@@ -345,7 +345,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "vg_pop_signal_frame (thread %d): isRT=%d "
+ "vg_pop_signal_frame (thread %u): isRT=%d "
"valid magic; EIP=%#llx\n",
tid, has_siginfo, tst->arch.vex.guest_CIA);
Modified: trunk/coregrind/m_sigframe/sigframe-s390x-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-s390x-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-s390x-linux.c Thu Aug 6 10:00:48 2015
@@ -449,7 +449,7 @@
{
if (frame->magicPI != 0x31415927 ||
frame->magicE != 0x27182818) {
- VG_(message)(Vg_UserMsg, "Thread %d return signal frame "
+ VG_(message)(Vg_UserMsg, "Thread %u return signal frame "
"corrupted. Killing process.\n",
tst->tid);
VG_(set_default_handler)(VKI_SIGSEGV);
@@ -495,7 +495,7 @@
Addr sp;
ThreadState* tst;
SizeT size;
- Int sigNo;
+ Int sigNo;
tst = VG_(get_ThreadState)(tid);
@@ -515,7 +515,7 @@
if (VG_(clo_trace_signals))
VG_(message)(
Vg_DebugMsg,
- "VG_(sigframe_destroy) (thread %d): isRT=%d valid magic; IP=%#llx\n",
+ "VG_(sigframe_destroy) (thread %u): isRT=%d valid magic; IP=%#llx\n",
tid, isRT, tst->arch.vex.guest_IA);
/* tell the tools */
Modified: trunk/coregrind/m_sigframe/sigframe-solaris.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-solaris.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-solaris.c Thu Aug 6 10:00:48 2015
@@ -221,7 +221,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "sigframe_create (thread %d): next IP=%#lx, "
+ "sigframe_create (thread %u): next IP=%#lx, "
"next SP=%#lx\n",
tid, (Addr)handler, (Addr)frame);
}
@@ -256,7 +256,7 @@
/* Returning from a signal handler. */
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "sigframe_return (thread %d): IP=%#lx\n",
+ "sigframe_return (thread %u): IP=%#lx\n",
tid, VG_(get_IP)(tid));
/* Tell the tool. */
Modified: trunk/coregrind/m_sigframe/sigframe-tilegx-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-tilegx-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-tilegx-linux.c Thu Aug 6 10:00:48 2015
@@ -239,7 +239,7 @@
if (0)
VG_(printf)("pushed signal frame; sp now = %lx, "
"next %pc = %lx, status=%d\n",
- (Addr)frame, tst->arch.vex.guest_pc, tst->status);
+ (Addr)frame, tst->arch.vex.guest_pc, (Int)tst->status);
}
/* EXPORTED */
@@ -264,7 +264,7 @@
if (0)
VG_(printf)("destroy signal frame; sp = %lx, "
" %pc = %lx, status=%d\n",
- (Addr)frame, tst->arch.vex.guest_pc, tst->status);
+ (Addr)frame, tst->arch.vex.guest_pc, (Int)tst->status);
frame_size = sizeof(*frame);
mc = &ucp->uc_mcontext;
@@ -339,7 +339,7 @@
VG_TRACK(die_mem_stack_signal, sp, frame_size);
if (VG_(clo_trace_signals))
VG_(message)( Vg_DebugMsg,
- "VG_(signal_return) (thread %d): isRT=%d valid magic; EIP=%#x\n",
+ "VG_(signal_return) (thread %u): isRT=%d valid magic; EIP=%#x\n",
tid, isRT, tst->arch.vex.guest_pc);
/* tell the tools */
VG_TRACK( post_deliver_signal, tid, sigNo );
Modified: trunk/coregrind/m_sigframe/sigframe-x86-darwin.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-x86-darwin.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-x86-darwin.c Thu Aug 6 10:00:48 2015
@@ -209,7 +209,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "sigframe_create (thread %d): "
+ "sigframe_create (thread %u): "
"next EIP=%#lx, next ESP=%#lx\n",
tid, (Addr)handler, (Addr)frame );
}
@@ -252,7 +252,7 @@
if (VG_(clo_trace_signals))
VG_(message)(Vg_DebugMsg,
- "sigframe_destroy (thread %d): "
+ "sigframe_destroy (thread %u): "
"valid magic; next EIP=%#x\n",
tid, tst->arch.vex.guest_EIP);
Modified: trunk/coregrind/m_sigframe/sigframe-x86-linux.c
==============================================================================
--- trunk/coregrind/m_sigframe/sigframe-x86-linux.c (original)
+++ trunk/coregrind/m_sigframe/sigframe-x86-linux.c Thu Aug 6 10:00:48 2015
@@ -567,7 +567,7 @@
if (0)
VG_(printf)("pushed signal frame; %%ESP now = %#lx, "
"next %%EIP = %#x, status=%d\n",
- esp, tst->arch.vex.guest_EIP, tst->status);
+ esp, tst->arch.vex.guest_EIP, (Int)tst->status);
}
@@ -583,7 +583,7 @@
{
if (frame->magicPI != 0x31415927 ||
frame->magicE != 0x27182818) {
- VG_(message)(Vg_UserMsg, "Thread %d return signal frame "
+ VG_(message)(Vg_UserMsg, "Thread %u return signal frame "
"corrupted. Killing process.\n",
tst->tid);
VG_(set_default_handler)(VKI_SIGSEGV);
@@ -673,7 +673,7 @@
if (VG_(clo_trace_signals))
VG_(message)(
Vg_DebugMsg,
- "VG_(signal_return) (thread %d): isRT=%d valid magic; EIP=%#x\n",
+ "VG_(signal_return) (thread %u): isRT=%d valid magic; EIP=%#x\n",
tid, isRT, tst->arch.vex.guest_EIP);
/* tell the tools */
|
|
From: Zhi-Gang L. <zh...@gm...> - 2015-08-06 02:30:54
|
Philippe,
I'm not sure how to create the right XML files for tilegx right now. For
ARM64, its target_xml() just simply returns NULL.
I'd like to do same here i.e. the patch below. Any thought?
---ZhiGang
Index: coregrind/m_gdbserver/valgrind-low-tilegx.c
===================================================================
--- coregrind/m_gdbserver/valgrind-low-tilegx.c (revision 15500)
+++ coregrind/m_gdbserver/valgrind-low-tilegx.c (working copy)
@@ -225,11 +225,13 @@
static
const char* target_xml ( Bool shadow_mode )
{
- if (shadow_mode) {
+ return NULL;
+#if 0
+ if (shadow_mode)
return "tilegx-linux-valgrind.xml";
- } else {
+ else
return "tilegx-linux.xml";
- }
+#endif
}
static CORE_ADDR** target_get_dtv (ThreadState *tst)
On Wed, Aug 5, 2015 at 12:49 PM, Philippe Waroquiers <
phi...@sk...> wrote:
> On Mon, 2015-08-03 at 11:33 +0200, Florian Krohm wrote:
> > You ought to run "make regtest" when making changes that have the
> > potential to break stuff.
> > There are zillions of messages like this one:
> >
> > none/tests/tilegx/Makefile.am:1: error:
> > insn_test_ldnt4u_add_X1.stderr.exp is in EXTRA_DIST but doesn't exist
> > none/tests/tilegx/Makefile.am:1: error: insn_test_ldnt4u_add_X1.vgtest
> > is in EXTRA_DIST but doesn't exist
> > none/tests/tilegx/Makefile.am:1: error: insn_test_ldnt_add_X1.stdout.exp
> > is in EXTRA_DIST but doesn't exist
> Hello Zhigang,
>
> While we are speaking about missing files ...
>
>
> The tilegx xml files are referenced in
> coregrind/m_gdbserver/valgrind-low-tilegx.c
> but are not present in coregrind/m_gdbserver directory
> and are not mentionned in coregrind/Makefile.am
>
>
> So, could you also add the missing tilegx gdbserver xml files
> and add them to the Makefile.am 'GDBSERVER_XML_FILES =' ?
>
> Thanks
>
> Philippe
>
>
>
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
>
|