You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
1
(30) |
2
(8) |
3
(5) |
4
(5) |
|
5
(3) |
6
(9) |
7
(5) |
8
(14) |
9
(17) |
10
(27) |
11
(10) |
|
12
(6) |
13
(10) |
14
(7) |
15
(16) |
16
(9) |
17
(14) |
18
(8) |
|
19
(5) |
20
(13) |
21
(21) |
22
(13) |
23
(4) |
24
(1) |
25
(4) |
|
26
(2) |
27
(7) |
28
(4) |
29
(5) |
30
(12) |
|
|
Author: carll
Date: Tue Apr 21 00:38:33 2015
New Revision: 15120
Log:
Add support for the lbarx, lharx, stbcx and sthcs instructions.
One of the expect files was missing. Also found that there
was a bug in the stq, stqcx, lq and lqarx instructions for LE.
The VEX commit for the instruction fix was 3138.
This commit updates the expect files for the corrected instructions
and adds the missing expect files.
The bugzilla for the orginal issue of the missing instructions
is 346324.
Added:
trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp-LE
Removed:
trunk/memcheck/tests/ppc32/power_ISA2_07.stdout.exp-LE
Modified:
trunk/memcheck/tests/ppc32/Makefile.am
trunk/none/tests/ppc32/Makefile.am
trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp
Modified: trunk/memcheck/tests/ppc32/Makefile.am
==============================================================================
--- trunk/memcheck/tests/ppc32/Makefile.am (original)
+++ trunk/memcheck/tests/ppc32/Makefile.am Tue Apr 21 00:38:33 2015
@@ -6,7 +6,7 @@
EXTRA_DIST = $(noinst_SCRIPTS) \
power_ISA2_05.stderr.exp power_ISA2_05.stdout.exp power_ISA2_05.vgtest \
power_ISA2_05.stdout.exp_Without_FPPO \
- power_ISA2_07.stdout.exp power_ISA2_07.stdout.exp-LE \
+ power_ISA2_07.stdout.exp \
power_ISA2_07.stderr.exp power_ISA2_07.vgtest
check_PROGRAMS = \
@@ -16,11 +16,11 @@
-I$(top_srcdir)/include @FLAG_M32@
if HAS_ISA_2_07
- BUILD_FLAGS_ISA_2_07 = -mhtm -mcpu=power8
- ISA_2_07_FLAG = -DHAS_ISA_2_07
+BUILD_FLAGS_ISA_2_07 = -mhtm -mcpu=power8
+ISA_2_07_FLAG = -DHAS_ISA_2_07
else
- BUILD_FLAGS_ISA_2_07 =
- ISA_2_07_FLAG =
+BUILD_FLAGS_ISA_2_07 =
+ISA_2_07_FLAG =
endif
power_ISA2_07_CFLAGS = $(AM_CFLAGS) $(WERROR) -Winline -Wall -Wshadow -g \
Removed: trunk/memcheck/tests/ppc32/power_ISA2_07.stdout.exp-LE
==============================================================================
--- trunk/memcheck/tests/ppc32/power_ISA2_07.stdout.exp-LE (original)
+++ trunk/memcheck/tests/ppc32/power_ISA2_07.stdout.exp-LE (removed)
@@ -1,2 +0,0 @@
-lbarx => 0x77
-lharx => 0xbeef
Modified: trunk/none/tests/ppc32/Makefile.am
==============================================================================
--- trunk/none/tests/ppc32/Makefile.am (original)
+++ trunk/none/tests/ppc32/Makefile.am Tue Apr 21 00:38:33 2015
@@ -40,7 +40,7 @@
test_dfp5.stderr.exp test_dfp5.stdout.exp test_dfp5.vgtest \
jm_vec_isa_2_07.stderr.exp jm_vec_isa_2_07.stdout.exp jm_vec_isa_2_07.vgtest \
jm_fp_isa_2_07.stderr.exp jm_fp_isa_2_07.stdout.exp jm_fp_isa_2_07.vgtest \
- jm_int_isa_2_07.stdout.exp jm_int_isa_2_07.stdout.exp-LE \
+ jm_int_isa_2_07.stdout.exp \
jm_int_isa_2_07.stderr.exp jm_int_isa_2_07.vgtest \
test_isa_2_07_part2.stderr.exp test_isa_2_07_part2.stdout.exp test_isa_2_07_part2.vgtest \
test_tm.stderr.exp test_tm.stdout.exp test_tm.vgtest \
Modified: trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp
==============================================================================
--- trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp (original)
+++ trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp Tue Apr 21 00:38:33 2015
@@ -1,17 +1 @@
-stq abcdef0123456789,1133557722446688, 0 => abcdef0123456789,1133557722446688)
-
-lq (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0xaaccee0011335577, 0xabcdef0123456789)
-
-lbarx (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0x00000000000000aa, 0x0000000000000000)
-
-lharx (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0x000000000000aacc, 0x0000000000000000)
-
-lqarx (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0xaaccee0011335577, 0xabcdef0123456789)
-
-stbcx. abefcd0145236789,1155337744226688 => 8900000000000000,0000000000000001; CR=20000000
-
-sthcx. abefcd0145236789,1155337744226688 => 6789000000000000,0000000000000001; CR=20000000
-
-stqcx. abefcd0145236789,1155337744226688 => abefcd0145236789,1155337744226688; CR=20000000
-
-All done. Tested 8 different instructions
+NO ISA 2.07 SUPPORT
Added: trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp-LE
==============================================================================
--- trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp-LE (added)
+++ trunk/none/tests/ppc64/jm_int_isa_2_07.stdout.exp-LE Tue Apr 21 00:38:33 2015
@@ -0,0 +1,17 @@
+stq abcdef0123456789,1133557722446688, 0 => 1133557722446688,abcdef0123456789)
+
+lq (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0xabcdef0123456789, 0xaaccee0011335577)
+
+lbarx (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0x0000000000000077, 0x0000000000000000)
+
+lharx (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0x0000000000005577, 0x0000000000000000)
+
+lqarx (0xaaccee0011335577, 0xabcdef0123456789) => (reg_pair = 0xabcdef0123456789, 0xaaccee0011335577)
+
+stbcx. abefcd0145236789,1155337744226688 => 0000000000000089,0000000000000001; CR=20000000
+
+sthcx. abefcd0145236789,1155337744226688 => 0000000000006789,0000000000000001; CR=20000000
+
+stqcx. abefcd0145236789,1155337744226688 => 1155337744226688,abefcd0145236789; CR=20000000
+
+All done. Tested 8 different instructions
|
|
From: <sv...@va...> - 2015-04-20 23:34:41
|
Author: carll
Date: Tue Apr 21 00:34:33 2015
New Revision: 3138
Log:
Fix for an error in the stq, stqcx, lqarx and lq instructions with LE.
Modified:
trunk/priv/guest_ppc_toIR.c
Modified: trunk/priv/guest_ppc_toIR.c
==============================================================================
--- trunk/priv/guest_ppc_toIR.c (original)
+++ trunk/priv/guest_ppc_toIR.c Tue Apr 21 00:34:33 2015
@@ -5125,10 +5125,17 @@
*/
// trap if EA misaligned on 16 byte address
if (mode64) {
- assign(high, load(ty, mkexpr( EA ) ) );
- assign(low, load(ty, binop( Iop_Add64,
- mkexpr( EA ),
- mkU64( 8 ) ) ) );
+ if (host_endness == VexEndnessBE) {
+ assign(high, load(ty, mkexpr( EA ) ) );
+ assign(low, load(ty, binop( Iop_Add64,
+ mkexpr( EA ),
+ mkU64( 8 ) ) ) );
+ } else {
+ assign(low, load(ty, mkexpr( EA ) ) );
+ assign(high, load(ty, binop( Iop_Add64,
+ mkexpr( EA ),
+ mkU64( 8 ) ) ) );
+ }
} else {
assign(high, load(ty, binop( Iop_Add32,
mkexpr( EA ),
@@ -5336,11 +5343,20 @@
DIP("stq r%u,%d(r%u)\n", rS_addr, simm16, rA_addr);
if (mode64) {
- /* upper 64-bits */
- assign( EA_hi, ea_rAor0_simm( rA_addr, simm16 ) );
+ if (host_endness == VexEndnessBE) {
+
+ /* upper 64-bits */
+ assign( EA_hi, ea_rAor0_simm( rA_addr, simm16 ) );
- /* lower 64-bits */
- assign( EA_lo, ea_rAor0_simm( rA_addr, simm16+8 ) );
+ /* lower 64-bits */
+ assign( EA_lo, ea_rAor0_simm( rA_addr, simm16+8 ) );
+ } else {
+ /* upper 64-bits */
+ assign( EA_hi, ea_rAor0_simm( rA_addr, simm16+8 ) );
+
+ /* lower 64-bits */
+ assign( EA_lo, ea_rAor0_simm( rA_addr, simm16 ) );
+ }
} else {
/* upper half of upper 64-bits */
assign( EA_hi, ea_rAor0_simm( rA_addr, simm16+4 ) );
@@ -6535,11 +6551,19 @@
// and actually do the load
if (mode64) {
- stmt( stmt_load( res_hi,
- mkexpr(EA), NULL/*this is a load*/) );
- stmt( stmt_load( res_lo,
- binop(Iop_Add64, mkexpr(EA), mkU64(8) ),
- NULL/*this is a load*/) );
+ if (host_endness == VexEndnessBE) {
+ stmt( stmt_load( res_hi,
+ mkexpr(EA), NULL/*this is a load*/) );
+ stmt( stmt_load( res_lo,
+ binop(Iop_Add64, mkexpr(EA), mkU64(8) ),
+ NULL/*this is a load*/) );
+ } else {
+ stmt( stmt_load( res_lo,
+ mkexpr(EA), NULL/*this is a load*/) );
+ stmt( stmt_load( res_hi,
+ binop(Iop_Add64, mkexpr(EA), mkU64(8) ),
+ NULL/*this is a load*/) );
+ }
} else {
stmt( stmt_load( res_hi,
binop( Iop_Add32, mkexpr(EA), mkU32(4) ),
@@ -6575,8 +6599,15 @@
resSC = newTemp(Ity_I1);
if (mode64) {
- stmt( stmt_load( resSC, mkexpr(EA), mkexpr(rS_hi) ) );
- store( binop( Iop_Add64, mkexpr(EA), mkU64(8) ), mkexpr(rS_lo) );
+ if (host_endness == VexEndnessBE) {
+ stmt( stmt_load( resSC, mkexpr(EA), mkexpr(rS_hi) ) );
+ store( binop( Iop_Add64, mkexpr(EA), mkU64(8) ),
+ mkexpr(rS_lo) );
+ } else {
+ stmt( stmt_load( resSC, mkexpr(EA), mkexpr(rS_lo) ) );
+ store( binop( Iop_Add64, mkexpr(EA), mkU64(8) ),
+ mkexpr(rS_hi) );
+ }
} else {
stmt( stmt_load( resSC, binop( Iop_Add32,
mkexpr(EA),
|
|
From: Florian K. <fl...@ei...> - 2015-04-20 21:46:51
|
On 20.04.2015 23:28, Philippe Waroquiers wrote: > Nice cleanup. > One small comment: wouldn't the description of VG_(sr_as_string)() > better be put in the .h rather than in the .c file ? > The fact that the memory is static (or must be freed by the caller) > is better described there ? I tend to favour small comments in header files and put noteworthy details next to the implementation. But I have no strong feelings and we don't have a policy for this either. So if you want to change it please feel free. Florian |
|
From: <sv...@va...> - 2015-04-20 21:33:26
|
Author: philippe
Date: Mon Apr 20 22:33:16 2015
New Revision: 15119
Log:
This patch changes the policy that does the GC of OldRef and RCEC
conflict cache size.
The current policy is:
A 'more or less' LRU policy is implemented by giving
to each OldRef a generation nr in which it was last touched.
A new generation is created every 50000 new access.
GC is done when the nr of OldRef reaches --conflict-cache-size.
The GC consists in removing enough generations to free
half of the entries.
After GC of OldRef, the RCEC (Ref Counted Exe Contexts)
not referenced anymore are GC-ed.
The new policy is:
An exact LRU policy is implemented using a doubly linked list
of OldRef.
When reaching --conflict-cache-size, the LRU entry is re-used.
The not referenced RCEC are GC-ed when less than 75% of the RCEC
are referenced, and the nr of RCEC is 'big' (at least half the
size of the contextTab, and at least the max nr of RCEC reached
previously).
(note: tried to directly recover a unref'ed RCEC when recovering
the LRU oldref, but that gives a lot of re-creation of RCEC).
new policy has the following advantages/disadvantages:
1. It is faster (at least for big applications)
On a firefox startup/exit, we gain about 1m30 second on 11m.
Similar 5..10% speed up encountered on other big applications
or on the new perf/memrw test.
The speed increase depends on the amount of memory
touched by the application. For applications with a
working set fitting in conflict-cache-size, the new policy
might be marginally slower than previous policy on platforms
having a small cache : the current policy only sets a generation
nr when an address is re-accessed, while the new policy
has to unchain and rechain the OldRef access in the LRU
doubly linked list.
2. It uses less memory (at least for big applications)
Firefox startup/exit "core" arena max use decreases from
1175MB mmap-ed/1060MB alloc-ed
to
994MB mmap-ed/913MB alloc-ed
The decrease in memory is the result of having a lot less RCEC:
The current policy let the nr of RCEC grow till the conflict
cache size is GC-ed.
The new policy limits the nr of RCEC to 133% of the RCEC
really referenced. So, we end up with a max nr of RCEC
a lot smaller with the new policy : max RCEC 191000
versus 1317000, for a total nr of discard RCEC operations
almost the same: 33M versus 32M.
Also, the current policy allocates a big temporary array
to do the GC of OldRef.
With the new policy, size of an OldRef increases because
we need 2 pointers for the LRU doubly linked list, and
we need the accessed address.
In total, the OldRef increase is limited to one Word,
as we do not need anymore the gen, and the 'magic'
for sanity check was removed (the check somewhat
becomes less needed, because an OldRef is never freed
anymore. Also, we do a new cross-check between
the ga in the OldRef and the sparseWA key).
For applications using small memory and having
a small nr of different stack traces accessing memory,
the new policy causes an increase in memory (one Word
per OldRef).
3. Functionally, the new policy gives better past information:
once the steady state is reached (i.e. the conflict cache
is full), the new policy has always --conflict-cache-size
entries of past information.
The current policy has a nr of past information varying
between --conflict-cache-size/2 and --conflict-cache-size
(so in average, 75% of conflict-cache-size).
4. The new code is a little bit smaller/simpler:
The generation based GC is replaced by a simpler LRU policy.
So, in summary, this patch should allow big applications
to use less cpu/memory, while having very little
or no impact on memory/cpu of small applications.
Note that the OldRef data structure LRU policy
is not really explicitely tested by a regtest.
Not easy at first sight to make such a test portable
between platforms/OS/compilers/....
Added:
trunk/perf/memrw.c
trunk/perf/memrw.vgperf
Modified:
trunk/helgrind/libhb_core.c
trunk/perf/Makefile.am
Modified: trunk/helgrind/libhb_core.c
==============================================================================
--- trunk/helgrind/libhb_core.c (original)
+++ trunk/helgrind/libhb_core.c Mon Apr 20 22:33:16 2015
@@ -3818,8 +3818,6 @@
// //
/////////////////////////////////////////////////////////
-#define EVENT_MAP_GC_DISCARD_FRACTION 0.5
-
/* This is in two parts:
1. A hash table of RCECs. This is a set of reference-counted stack
@@ -3832,8 +3830,9 @@
2. A SparseWA of OldRefs. These store information about each old
ref that we need to record. It is indexed by address of the
location for which the information is recorded. For LRU
- purposes, each OldRef also contains a generation number,
- indicating when it was most recently accessed.
+ purposes, each OldRef in the SparseWA is also on a doubly
+ linked list maintaining the order in which the OldRef were most
+ recently accessed.
The important part of an OldRef is, however, its accs[] array.
This is an array of N_OLDREF_ACCS which binds (thread, R/W,
@@ -3843,9 +3842,8 @@
falls off the end, that's too bad -- we will lose info about
that triple's access to this location.
- When the SparseWA becomes too big, we can throw away the OldRefs
- whose generation numbers are below some threshold; hence doing
- approximate LRU discarding. For each discarded OldRef we must
+ We allocate a maximum of VG_(clo_conflict_cache_size) OldRef.
+ Then we do exact LRU discarding. For each discarded OldRef we must
of course decrement the reference count on the all RCECs it
refers to, in order that entries from (1) eventually get
discarded too.
@@ -3903,8 +3901,22 @@
}
RCEC;
+//////////// BEGIN RCEC pool allocator
+static PoolAlloc* rcec_pool_allocator;
+static RCEC* alloc_RCEC ( void ) {
+ return VG_(allocEltPA) ( rcec_pool_allocator );
+}
+
+static void free_RCEC ( RCEC* rcec ) {
+ tl_assert(rcec->magic == RCEC_MAGIC);
+ VG_(freeEltPA)( rcec_pool_allocator, rcec );
+}
+//////////// END RCEC pool allocator
+
static RCEC** contextTab = NULL; /* hash table of RCEC*s */
+/* Count of allocated RCEC having ref count > 0 */
+static UWord RCEC_referenced = 0;
/* Gives an arbitrary total order on RCEC .frames fields */
static Word RCEC__cmp_by_frames ( RCEC* ec1, RCEC* ec2 ) {
@@ -3928,29 +3940,19 @@
tl_assert(ec && ec->magic == RCEC_MAGIC);
tl_assert(ec->rc > 0);
ec->rc--;
+ if (ec->rc == 0)
+ RCEC_referenced--;
}
static void ctxt__rcinc ( RCEC* ec )
{
tl_assert(ec && ec->magic == RCEC_MAGIC);
+ if (ec->rc == 0)
+ RCEC_referenced++;
ec->rc++;
}
-//////////// BEGIN RCEC pool allocator
-static PoolAlloc* rcec_pool_allocator;
-
-static RCEC* alloc_RCEC ( void ) {
- return VG_(allocEltPA) ( rcec_pool_allocator );
-}
-
-static void free_RCEC ( RCEC* rcec ) {
- tl_assert(rcec->magic == RCEC_MAGIC);
- VG_(freeEltPA)( rcec_pool_allocator, rcec );
-}
-//////////// END RCEC pool allocator
-
-
/* Find 'ec' in the RCEC list whose head pointer lives at 'headp' and
move it one step closer the the front of the list, so as to make
subsequent searches for it cheaper. */
@@ -4072,9 +4074,6 @@
/// A SparseWA guest-addr -> OldRef, that refers to (1)
///
-// (UInt) `echo "Old Reference Information" | md5sum`
-#define OldRef_MAGIC 0x30b1f075UL
-
/* Records an access: a thread, a context (size & writeness) and the
number of held locks. The size (1,2,4,8) is encoded as 00 = 1, 01 =
2, 10 = 4, 11 = 8.
@@ -4092,34 +4091,98 @@
#define N_OLDREF_ACCS 5
typedef
- struct {
- UWord magic; /* sanity check only */
- UWord gen; /* when most recently accessed */
- /* or free list when not in use */
+ struct OldRef {
+ struct OldRef *prev; // to refs older than this one
+ struct OldRef *next; // to refs newer that this one
+ Addr ga; // Address for which we record up to N_OLDREF_ACCS accesses.
/* unused slots in this array have .thrid == 0, which is invalid */
Thr_n_RCEC accs[N_OLDREF_ACCS];
}
OldRef;
-
+/* We need ga in OldRef in order to remove OldRef from the sparsewa
+ by key (i.e. ga) when re-using the lru OldRef. */
//////////// BEGIN OldRef pool allocator
static PoolAlloc* oldref_pool_allocator;
-
-static OldRef* alloc_OldRef ( void ) {
- return VG_(allocEltPA) ( oldref_pool_allocator );
-}
-
-static void free_OldRef ( OldRef* r ) {
- tl_assert(r->magic == OldRef_MAGIC);
- VG_(freeEltPA)( oldref_pool_allocator, r );
-}
+// Note: We only allocate elements in this pool allocator, we never free them.
+// We stop allocating elements at VG_(clo_conflict_cache_size).
//////////// END OldRef pool allocator
+static OldRef mru;
+static OldRef lru;
+// A double linked list, chaining all OldREf in a mru/lru order.
+// mru/lru are sentinel nodes.
+// Whenever an oldref is re-used, its position is changed as the most recently
+// used (i.e. pointed to by mru.prev).
+// When a new oldref is needed, it is allocated from the pool
+// if we have not yet reached --conflict-cache-size.
+// Otherwise, if all oldref have already been allocated,
+// the least recently used (i.e. pointed to by lru.next) is re-used.
+// When an OldRef is used, it is moved as the most recently used entry
+// (i.e. pointed to by mru.prev).
+
+// Removes r from the double linked list
+// Note: we do not need to test for special cases such as
+// NULL next or prev pointers, because we have sentinel nodes
+// at both sides of the list. So, a node is always forward and
+// backward linked.
+static inline void OldRef_unchain(OldRef *r)
+{
+ r->next->prev = r->prev;
+ r->prev->next = r->next;
+}
+
+// Insert new as the newest OldRef
+// Similarly to OldRef_unchain, no need to test for NULL
+// pointers, as e.g. mru.prev is always guaranteed to point
+// to a non NULL node (lru when the list is empty).
+static inline void OldRef_newest(OldRef *new)
+{
+ new->next = &mru;
+ new->prev = mru.prev;
+ mru.prev = new;
+ new->prev->next = new;
+}
static SparseWA* oldrefTree = NULL; /* SparseWA* OldRef* */
-static UWord oldrefGen = 0; /* current LRU generation # */
static UWord oldrefTreeN = 0; /* # elems in oldrefTree */
-static UWord oldrefGenIncAt = 0; /* inc gen # when size hits this */
+/* Note: the nr of ref in the oldrefTree will always be equal to
+ the nr of elements that were allocated from the OldRef pool allocator
+ as we never free an OldRef : we just re-use them. */
+
+
+/* allocates a new OldRef or re-use the lru one if all allowed OldRef
+ have already been allocated. */
+static OldRef* alloc_or_reuse_OldRef ( void )
+{
+ if (oldrefTreeN < HG_(clo_conflict_cache_size)) {
+ oldrefTreeN++;
+ return VG_(allocEltPA) ( oldref_pool_allocator );
+ } else {
+ Bool b;
+ UWord valW;
+ OldRef *oldref = lru.next;
+
+ OldRef_unchain(oldref);
+ b = VG_(delFromSWA)( oldrefTree, &valW, oldref->ga );
+ tl_assert(b);
+ tl_assert (oldref == (OldRef*)valW);
+
+ for (UInt i = 0; i < N_OLDREF_ACCS; i++) {
+ ThrID aThrID = oldref->accs[i].thrid;
+ RCEC* aRef = oldref->accs[i].rcec;
+ if (aRef) {
+ tl_assert(aThrID != 0);
+ stats__ctxt_rcdec3++;
+ ctxt__rcdec( aRef );
+ } else {
+ tl_assert(aThrID == 0);
+ }
+ }
+ return oldref;
+ }
+}
+
inline static UInt min_UInt ( UInt a, UInt b ) {
return a < b ? a : b;
@@ -4181,7 +4244,8 @@
see if we have a stack trace pertaining to this (thrid, R/W,
size) triple. */
ref = (OldRef*)valW;
- tl_assert(ref->magic == OldRef_MAGIC);
+
+ tl_assert (ref->ga == a);
for (i = 0; i < N_OLDREF_ACCS; i++) {
if (ref->accs[i].thrid != thrid)
@@ -4236,21 +4300,14 @@
/* tl_assert(thrid != 0); */ /* There's a dominating assert above. */
}
- ref->gen = oldrefGen;
+ OldRef_unchain(ref);
+ OldRef_newest(ref);
} else {
/* We don't have a record for this address. Create a new one. */
- if (oldrefTreeN >= oldrefGenIncAt) {
- oldrefGen++;
- oldrefGenIncAt = oldrefTreeN + 50000;
- if (0) VG_(printf)("oldrefTree: new gen %lu at size %lu\n",
- oldrefGen, oldrefTreeN );
- }
-
- ref = alloc_OldRef();
- ref->magic = OldRef_MAGIC;
- ref->gen = oldrefGen;
+ ref = alloc_or_reuse_OldRef();
+ ref->ga = a;
ref->accs[0].thrid = thrid;
ref->accs[0].szLg2B = szLg2B;
ref->accs[0].isW = (UInt)(isW & 1);
@@ -4270,8 +4327,7 @@
ref->accs[j].locksHeldW = 0;
}
VG_(addToSWA)( oldrefTree, a, (UWord)ref );
- oldrefTreeN++;
-
+ OldRef_newest (ref);
}
}
@@ -4323,7 +4379,6 @@
continue;
ref = (OldRef*)valW;
- tl_assert(ref->magic == OldRef_MAGIC);
tl_assert(ref->accs[0].thrid != 0); /* first slot must always be used */
cand_thrid = 0; /* invalid; see comments in event_map_bind */
@@ -4429,12 +4484,22 @@
HG_(free)
);
- oldrefGen = 0;
- oldrefGenIncAt = 0;
oldrefTreeN = 0;
+ mru.prev = &lru;
+ mru.next = NULL;
+ lru.prev = NULL;
+ lru.next = &mru;
+ for (i = 0; i < N_OLDREF_ACCS; i++) {
+ mru.accs[i] = (Thr_n_RCEC) {.rcec = NULL,
+ .locksHeldW = 0,
+ .thrid = 0,
+ .szLg2B = 0,
+ .isW = 0};
+ lru.accs[i] = mru.accs[i];
+ }
}
-static void event_map__check_reference_counts ( Bool before )
+static void event_map__check_reference_counts ( void )
{
RCEC* rcec;
OldRef* oldref;
@@ -4452,8 +4517,6 @@
nEnts++;
tl_assert(rcec);
tl_assert(rcec->magic == RCEC_MAGIC);
- if (!before)
- tl_assert(rcec->rc > 0);
rcec->rcX = 0;
}
}
@@ -4466,7 +4529,6 @@
VG_(initIterSWA)( oldrefTree );
while (VG_(nextIterSWA)( oldrefTree, &keyW, &valW )) {
oldref = (OldRef*)valW;
- tl_assert(oldref->magic == OldRef_MAGIC);
for (i = 0; i < N_OLDREF_ACCS; i++) {
ThrID aThrID = oldref->accs[i].thrid;
RCEC* aRef = oldref->accs[i].rcec;
@@ -4489,244 +4551,22 @@
}
__attribute__((noinline))
-static void event_map_GC ( void )
+static void do_RCEC_GC ( void )
{
- OldRef* oldref;
- UWord keyW, valW, retained, maxGen;
- XArray* refs2del;
- Word i, j, n2del;
-
- UWord* genMap = NULL;
- UWord genMap_min = 0;
- UWord genMap_size = 0;
-
- if (0)
- VG_(printf)("libhb: event_map GC at size %lu\n", oldrefTreeN);
-
- /* Check for sane command line params. Limit values must match
- those in hg_process_cmd_line_option. */
- tl_assert( HG_(clo_conflict_cache_size) >= 10*1000 );
- tl_assert( HG_(clo_conflict_cache_size) <= 30*1000*1000 );
-
- /* Check our counting is sane (expensive) */
- if (CHECK_CEM)
- tl_assert(oldrefTreeN == VG_(sizeSWA)( oldrefTree ));
-
- /* Check the reference counts (expensive) */
- if (CHECK_CEM)
- event_map__check_reference_counts( True/*before*/ );
-
- /* Compute the distribution of generation values in the ref tree.
- There are likely only to be a few different generation numbers
- in the whole tree, but we don't know what they are. Hence use a
- dynamically resized array of counters. The array is genMap[0
- .. genMap_size-1], where genMap[0] is the count for the
- generation number genMap_min, genMap[1] is the count for
- genMap_min+1, etc. If a new number is seen outside the range
- [genMap_min .. genMap_min + genMap_size - 1] then the array is
- copied into a larger array, and genMap_min and genMap_size are
- adjusted accordingly. */
-
- /* genMap :: generation-number -> count-of-nodes-with-that-number */
-
- VG_(initIterSWA)( oldrefTree );
- while ( VG_(nextIterSWA)( oldrefTree, &keyW, &valW )) {
-
- UWord ea, key;
- oldref = (OldRef*)valW;
- key = oldref->gen;
-
- /* BEGIN find 'ea', which is the index in genMap holding the
- count for generation number 'key'. */
- if (UNLIKELY(genMap == NULL)) {
- /* deal with the first key to be seen, so that the following
- cases don't need to handle the complexity of a NULL count
- array. */
- genMap_min = key;
- genMap_size = 1;
- genMap = HG_(zalloc)( "libhb.emmG.1a",
- genMap_size * sizeof(UWord) );
- ea = 0;
- if (0) VG_(printf)("(%lu) case 1 [%lu .. %lu]\n",
- key, genMap_min, genMap_min+genMap_size- 1 );
- }
- else
- if (LIKELY(key >= genMap_min && key < genMap_min + genMap_size)) {
- /* this is the expected (almost-always-happens) case: 'key'
- is already mapped in the array. */
- ea = key - genMap_min;
- }
- else
- if (key < genMap_min) {
- /* 'key' appears before the start of the current array.
- Extend the current array by allocating a larger one and
- copying the current one to the upper end of it. */
- Word more;
- UWord* map2;
- more = genMap_min - key;
- tl_assert(more > 0);
- map2 = HG_(zalloc)( "libhb.emmG.1b",
- (genMap_size + more) * sizeof(UWord) );
- VG_(memcpy)( &map2[more], genMap, genMap_size * sizeof(UWord) );
- HG_(free)( genMap );
- genMap = map2;
- genMap_size += more;
- genMap_min -= more;
- ea = 0;
- tl_assert(genMap_min == key);
- if (0) VG_(printf)("(%lu) case 2 [%lu .. %lu]\n",
- key, genMap_min, genMap_min+genMap_size- 1 );
- }
- else {
- /* 'key' appears after the end of the current array. Extend
- the current array by allocating a larger one and copying
- the current one to the lower end of it. */
- Word more;
- UWord* map2;
- tl_assert(key >= genMap_min + genMap_size);
- more = key - (genMap_min + genMap_size) + 1;
- tl_assert(more > 0);
- map2 = HG_(zalloc)( "libhb.emmG.1c",
- (genMap_size + more) * sizeof(UWord) );
- VG_(memcpy)( &map2[0], genMap, genMap_size * sizeof(UWord) );
- HG_(free)( genMap );
- genMap = map2;
- genMap_size += more;
- ea = genMap_size - 1;;
- tl_assert(genMap_min + genMap_size - 1 == key);
- if (0) VG_(printf)("(%lu) case 3 [%lu .. %lu]\n",
- key, genMap_min, genMap_min+genMap_size- 1 );
- }
- /* END find 'ea' from 'key' */
-
- tl_assert(ea >= 0 && ea < genMap_size);
- /* and the whole point of this elaborate computation of 'ea' is .. */
- genMap[ea]++;
- }
-
- tl_assert(genMap);
- tl_assert(genMap_size > 0);
-
- /* Sanity check what we just computed */
- { UWord sum = 0;
- for (i = 0; i < genMap_size; i++) {
- if (0) VG_(printf)(" xxx: gen %ld has %lu\n",
- i + genMap_min, genMap[i] );
- sum += genMap[i];
- }
- tl_assert(sum == oldrefTreeN);
- }
-
- /* Figure out how many generations to throw away */
- retained = oldrefTreeN;
- maxGen = 0;
-
- for (i = 0; i < genMap_size; i++) {
- keyW = i + genMap_min;
- valW = genMap[i];
- tl_assert(keyW > 0); /* can't allow a generation # 0 */
- if (0) VG_(printf)(" XXX: gen %lu has %lu\n", keyW, valW );
- tl_assert(keyW >= maxGen);
- tl_assert(retained >= valW);
- if (retained - valW
- > (UWord)(HG_(clo_conflict_cache_size)
- * EVENT_MAP_GC_DISCARD_FRACTION)) {
- retained -= valW;
- maxGen = keyW;
- } else {
- break;
- }
- }
-
- HG_(free)(genMap);
+ UInt i;
- tl_assert(retained >= 0 && retained <= oldrefTreeN);
-
- /* Now make up a big list of the oldrefTree entries we want to
- delete. We can't simultaneously traverse the tree and delete
- stuff from it, so first we need to copy them off somewhere
- else. (sigh) */
- refs2del = VG_(newXA)( HG_(zalloc), "libhb.emmG.2",
- HG_(free), sizeof(Addr) );
-
- if (retained < oldrefTreeN) {
-
- /* This is the normal (expected) case. We discard any ref whose
- generation number <= maxGen. */
- VG_(initIterSWA)( oldrefTree );
- while (VG_(nextIterSWA)( oldrefTree, &keyW, &valW )) {
- oldref = (OldRef*)valW;
- tl_assert(oldref->magic == OldRef_MAGIC);
- if (oldref->gen <= maxGen) {
- VG_(addToXA)( refs2del, &keyW );
- }
- }
- if (VG_(clo_stats)) {
- VG_(message)(Vg_DebugMsg,
- "libhb: EvM GC: delete generations %lu and below, "
- "retaining %lu entries\n",
- maxGen, retained );
- }
-
- } else {
-
- static UInt rand_seed = 0; /* leave as static */
-
- /* Degenerate case: there's only one generation in the entire
- tree, so we need to have some other way of deciding which
- refs to throw away. Just throw out half of them randomly. */
- tl_assert(retained == oldrefTreeN);
- VG_(initIterSWA)( oldrefTree );
- while (VG_(nextIterSWA)( oldrefTree, &keyW, &valW )) {
- UInt n;
- oldref = (OldRef*)valW;
- tl_assert(oldref->magic == OldRef_MAGIC);
- n = VG_(random)( &rand_seed );
- if ((n & 0xFFF) < 0x800) {
- VG_(addToXA)( refs2del, &keyW );
- retained--;
- }
- }
- if (VG_(clo_stats)) {
- VG_(message)(Vg_DebugMsg,
- "libhb: EvM GC: randomly delete half the entries, "
- "retaining %lu entries\n",
- retained );
- }
-
- }
-
- n2del = VG_(sizeXA)( refs2del );
- tl_assert(n2del == (Word)(oldrefTreeN - retained));
-
- if (0) VG_(printf)("%s","deleting entries\n");
- for (i = 0; i < n2del; i++) {
- Bool b;
- Addr ga2del = *(Addr*)VG_(indexXA)( refs2del, i );
- b = VG_(delFromSWA)( oldrefTree, &valW, ga2del );
- tl_assert(b);
- oldref = (OldRef*)valW;
- for (j = 0; j < N_OLDREF_ACCS; j++) {
- ThrID aThrID = oldref->accs[j].thrid;
- RCEC* aRef = oldref->accs[j].rcec;
- if (aRef) {
- tl_assert(aThrID != 0);
- stats__ctxt_rcdec3++;
- ctxt__rcdec( aRef );
- } else {
- tl_assert(aThrID == 0);
- }
- }
-
- free_OldRef( oldref );
+ if (VG_(clo_stats)) {
+ static UInt ctr = 1;
+ VG_(message)(Vg_DebugMsg,
+ "libhb: RCEC GC: #%u %lu slots,"
+ " %lu cur ents(ref'd %lu),"
+ " %lu max ents\n",
+ ctr++,
+ (UWord)N_RCEC_TAB,
+ stats__ctxt_tab_curr, RCEC_referenced,
+ stats__ctxt_tab_max );
}
-
- VG_(deleteXA)( refs2del );
-
- tl_assert( VG_(sizeSWA)( oldrefTree ) == retained );
-
- oldrefTreeN = retained;
- oldrefGenIncAt = oldrefTreeN; /* start new gen right away */
+ tl_assert (stats__ctxt_tab_curr > RCEC_referenced);
/* Throw away all RCECs with zero reference counts */
for (i = 0; i < N_RCEC_TAB; i++) {
@@ -4747,17 +4587,9 @@
}
}
- /* Check the reference counts (expensive) */
- if (CHECK_CEM)
- event_map__check_reference_counts( False/*after*/ );
-
- //if (0)
- //VG_(printf)("XXXX final sizes: oldrefTree %ld, contextTree %ld\n\n",
- // VG_(OSetGen_Size)(oldrefTree), VG_(OSetGen_Size)(contextTree));
-
+ tl_assert (stats__ctxt_tab_curr == RCEC_referenced);
}
-
/////////////////////////////////////////////////////////
// //
// Core MSM //
@@ -6294,10 +6126,12 @@
stats__ctxt_rcdec3 );
VG_(printf)( " libhb: ctxt__rcdec: calls %lu, discards %lu\n",
stats__ctxt_rcdec_calls, stats__ctxt_rcdec_discards);
- VG_(printf)( " libhb: contextTab: %lu slots, %lu cur ents,"
+ VG_(printf)( " libhb: contextTab: %lu slots,"
+ " %lu cur ents(ref'd %lu),"
" %lu max ents\n",
(UWord)N_RCEC_TAB,
- stats__ctxt_tab_curr, stats__ctxt_tab_max );
+ stats__ctxt_tab_curr, RCEC_referenced,
+ stats__ctxt_tab_max );
VG_(printf)( " libhb: contextTab: %lu queries, %lu cmps\n",
stats__ctxt_tab_qs,
stats__ctxt_tab_cmps );
@@ -6581,8 +6415,16 @@
void libhb_maybe_GC ( void )
{
- if (UNLIKELY(oldrefTreeN >= HG_(clo_conflict_cache_size)))
- event_map_GC();
+ /* GC the unreferenced (zero rc) RCECs when
+ (1) reaching a significant nr of RCECs (to avoid scanning a contextTab
+ with mostly NULL ptr)
+ and (2) reaching at least the max nr of RCEC (as we have in any case
+ at least that amount of RCEC in the pool allocator)
+ and (3) the nr of referenced RCECs is less than 75% than total nr RCECs. */
+ if (UNLIKELY(stats__ctxt_tab_curr > N_RCEC_TAB/2
+ && stats__ctxt_tab_curr >= stats__ctxt_tab_max
+ && stats__ctxt_tab_curr * 0.75 > RCEC_referenced))
+ do_RCEC_GC();
/* If there are still freelist entries available, no need for a
GC. */
@@ -6593,6 +6435,10 @@
if (VG_(sizeXA)( vts_tab ) < vts_next_GC_at)
return;
vts_tab__do_GC( False/*don't show stats*/ );
+
+ /* Check the reference counts (expensive) */
+ if (CHECK_CEM)
+ event_map__check_reference_counts();
}
Modified: trunk/perf/Makefile.am
==============================================================================
--- trunk/perf/Makefile.am (original)
+++ trunk/perf/Makefile.am Mon Apr 20 22:33:16 2015
@@ -13,12 +13,14 @@
heap_pdb4.vgperf \
many-loss-records.vgperf \
many-xpts.vgperf \
+ memrw.vgperf \
sarp.vgperf \
tinycc.vgperf \
test_input_for_tinycc.c
check_PROGRAMS = \
- bigcode bz2 fbench ffbench heap many-loss-records many-xpts sarp tinycc
+ bigcode bz2 fbench ffbench heap many-loss-records many-xpts \
+ memrw sarp tinycc
AM_CFLAGS += -O $(AM_FLAG_M3264_PRI)
AM_CXXFLAGS += -O $(AM_FLAG_M3264_PRI)
@@ -29,6 +31,7 @@
fbench_CFLAGS = $(AM_CFLAGS) -O2
ffbench_LDADD = -lm
+memrw_LDADD = -lpthread
tinycc_CFLAGS = $(AM_CFLAGS) -Wno-shadow -Wno-inline
if HAS_POINTER_SIGN_WARNING
Added: trunk/perf/memrw.c
==============================================================================
--- trunk/perf/memrw.c (added)
+++ trunk/perf/memrw.c Mon Apr 20 22:33:16 2015
@@ -0,0 +1,128 @@
+#define _GNU_SOURCE
+#include <string.h>
+#include <pthread.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <unistd.h>
+#include <sys/types.h>
+
+// memrw provides a simulation of an application
+// reading and writing memory, for the sake of tuning helgrind.
+// It is a very simple (simplistic) model:
+// * only one thread
+// * only one exe context reading or writing the memory
+// * the working set of the application is unrealistically
+// concentrated on a consecutive nr of MB.
+// At this moment, it was just used to tune the EvM data structure
+// of helgrind.
+// It would be nice to enhance this program to cope with a richer
+// model e.g. multiple threads, many different stack traces touching
+// the memory, better working set distribution, ...
+
+static int nr_mb = 0; // total nr of mb used by the program
+static int nr_mb_ws = 0; // nr_mb in program working set
+static int nr_loops = 0; // nr of loops reading or writing the ws
+static int nr_thr; // nr of threads (hardcoded to 1 currently)
+
+// Note: the total nr of mb is what is explicitely allocated.
+// On top of that, we have the stacks, local vars, lib vars, ...
+// The working set is just the first nr_mb_ws of nr_mb.
+
+static int verbose = 0;
+static unsigned char **mb;
+
+static void *memrw_fn(void *v)
+{
+ int loops, m, b;
+ int write;
+ int differs = 0;
+ unsigned char prev = 0;
+
+ for (loops = 0; loops < nr_loops; loops++) {
+ // printf("loop %d write %d\n", loops, write);
+ // Note: in case of multiple threads, we will have
+ // to add lock/unlock somewhere in the below, maybe to lock
+ // the MB we are reading or writing.
+ for (m = 0; m < nr_mb_ws; m++) {
+ for (b = 0; b < 1024 * 1024; b++) {
+ write = b % 5 == 0;
+ // Do some write or read operations.
+ if (write) {
+ if (mb[m][b] < 255)
+ mb[m][b] += differs;
+ else
+ mb[m][b] = 0;
+ } else {
+ differs = mb[m][b] != prev;
+ prev = mb[m][b];
+ }
+ }
+ }
+ }
+ return NULL;
+}
+
+int main (int argc, char *argv[])
+{
+ int a;
+ int ret;
+ int i;
+ pthread_t thr;
+
+ // usage: memrw [-t nr_mb default 10] [-w nr_mb_ws default 10]
+ // [-l nr_loops_on_ws default 3]
+ // [-f fan_out default 0]
+ // [-v verbosity default 0]
+ nr_mb = 10;
+ nr_mb_ws = 10;
+ nr_loops = 3;
+ verbose = 0;
+ for (a = 1; a < argc; a+=2) {
+ if (strcmp(argv[a], "-t") == 0) {
+ nr_mb = atoi(argv[a+1]);
+ } else if (strcmp(argv[a], "-w") == 0) {
+ nr_mb_ws = atoi(argv[a+1]);
+ } else if (strcmp(argv[a], "-l") == 0) {
+ nr_loops = atoi(argv[a+1]);
+ } else if (strcmp(argv[a], "-v") == 0) {
+ verbose = atoi(argv[a+1]);
+ } else {
+ printf("unknown arg %s\n", argv[a]);
+ }
+ }
+ if (nr_mb_ws > nr_mb)
+ nr_mb_ws = nr_mb; // to make it easy to do loops combining values
+
+ nr_thr = 1;
+
+ printf ("total program memory -t %d MB"
+ " working set -w %d MB"
+ " working set R or W -l %d times"
+ "\n",
+ nr_mb,
+ nr_mb_ws,
+ nr_loops);
+
+ printf ("creating and initialising the total program memory\n");
+ mb = malloc(nr_mb * sizeof(char*));
+ if (mb == NULL)
+ perror("malloc mb");
+ for (i = 0; i < nr_mb; i++) {
+ mb[i] = calloc(1024*1024, 1);
+ if (mb[i] == NULL)
+ perror("malloc mb[i]");
+ }
+
+ printf("starting thread that will read or write the working set\n");
+ ret = pthread_create(&thr, NULL, memrw_fn, &nr_thr);
+ if (ret != 0)
+ perror("pthread_create");
+ printf("waiting for thread termination\n");
+
+ ret = pthread_join(thr, NULL);
+ if (ret != 0)
+ perror("pthread_join");
+ printf("thread terminated\n");
+
+ return 0;
+}
Added: trunk/perf/memrw.vgperf
==============================================================================
--- trunk/perf/memrw.vgperf (added)
+++ trunk/perf/memrw.vgperf Mon Apr 20 22:33:16 2015
@@ -0,0 +1,2 @@
+prog: memrw
+
|
|
From: Philippe W. <phi...@sk...> - 2015-04-20 21:26:59
|
Nice cleanup.
One small comment: wouldn't the description of VG_(sr_as_string)()
better be put in the .h rather than in the .c file ?
The fact that the memory is static (or must be freed by the caller)
is better described there ?
Philippe
On Mon, 2015-04-20 at 20:42 +0000, sv...@va... wrote:
> +/* ---------------------------------------------------------------------
> + VG_(sr_as_string)()
> + ------------------------------------------------------------------ */
> +
> +/* Return a textual representation of a SysRes value in a statically
> + allocated buffer. The buffer will be overwritten with the next
> + invocation. */
> +#if defined(VGO_linux)
> +// FIXME: Does this function need to be adjusted for MIPS's _valEx ?
> +const HChar *VG_(sr_as_string) ( SysRes sr )
> +{
....
> Modified: trunk/include/pub_tool_libcprint.h
> ==============================================================================
> --- trunk/include/pub_tool_libcprint.h (original)
> +++ trunk/include/pub_tool_libcprint.h Mon Apr 20 21:42:42 2015
> @@ -154,6 +154,9 @@
> /* Flush any output cached by previous calls to VG_(message) et al. */
> extern void VG_(message_flush) ( void );
>
> +/* Return a SysRes value as a character string. */
> +extern const HChar *VG_(sr_as_string) ( SysRes sr );
> +
> #endif // __PUB_TOOL_LIBCPRINT_H
>
> /*--------------------------------------------------------------------*/
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> Valgrind-developers mailing list
> Val...@li...
> https://lists.sourceforge.net/lists/listinfo/valgrind-developers
|
|
From: <sv...@va...> - 2015-04-20 21:13:10
|
Author: florian
Date: Mon Apr 20 22:13:03 2015
New Revision: 15118
Log:
Use the proper function.
Modified:
trunk/coregrind/m_signals.c
Modified: trunk/coregrind/m_signals.c
==============================================================================
--- trunk/coregrind/m_signals.c (original)
+++ trunk/coregrind/m_signals.c Mon Apr 20 22:13:03 2015
@@ -574,7 +574,7 @@
# define VG_UCONTEXT_SYSCALL_NUM(uc) ((uc)->uc_mcontext.gregs[10])
# define VG_UCONTEXT_SYSCALL_SYSRES(uc) \
/* Convert the value in uc_mcontext.rax into a SysRes. */ \
- VG_(mk_SysRes_amd64_linux)((uc)->uc_mcontext.gregs[0])
+ VG_(mk_SysRes_tilegx_linux)((uc)->uc_mcontext.gregs[0])
# define VG_UCONTEXT_TO_UnwindStartRegs(srP, uc) \
{ (srP)->r_pc = (uc)->uc_mcontext.pc; \
(srP)->r_sp = (uc)->uc_mcontext.sp; \
|
|
From: Florian K. <fl...@ei...> - 2015-04-20 21:10:33
|
On 20.04.2015 15:05, Julian Seward wrote: > >>> Your yesterday's change r15060 breaks MIPS port in general, >> as comparing _valEx will fail immediately. >> >> MIPS support has been broken in trunk for two weeks. Does anyone >> have a fix for this incoming? Maybe it should be posted as a bug >> in the tracker. > > Perhaps it would be wise to back out 15060 until such time as it > gets fixed properly, and at the same time file a bug in the tracker > for the underlying problem. It would be even better if the issue was fixed. I've made some adjustments. In particular, I removed _valEx from the common code. We don't want it there. https://bugs.kde.org/show_bug.cgi?id=346411 Florian |
|
From: <sv...@va...> - 2015-04-20 21:02:25
|
Author: florian
Date: Mon Apr 20 22:02:18 2015
New Revision: 15117
Log:
Remove SysRes::_valEx from common code as it is specific to mips.
ifdef'ed accordingly.
Modified:
trunk/coregrind/m_syscall.c
trunk/include/pub_tool_basics.h
Modified: trunk/coregrind/m_syscall.c
==============================================================================
--- trunk/coregrind/m_syscall.c (original)
+++ trunk/coregrind/m_syscall.c Mon Apr 20 22:02:18 2015
@@ -62,7 +62,6 @@
SysRes VG_(mk_SysRes_x86_linux) ( Int val ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = val >= -4095 && val <= -1;
if (res._isError) {
res._val = (UInt)(-val);
@@ -75,7 +74,6 @@
/* Similarly .. */
SysRes VG_(mk_SysRes_amd64_linux) ( Long val ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = val >= -4095 && val <= -1;
if (res._isError) {
res._val = (ULong)(-val);
@@ -87,7 +85,6 @@
SysRes VG_(mk_SysRes_tilegx_linux) ( Long val ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = val >= -4095 && val <= -1;
if (res._isError) {
res._val = (ULong)(-val);
@@ -101,7 +98,6 @@
/* Note this must be in the bottom bit of the second arg */
SysRes VG_(mk_SysRes_ppc32_linux) ( UInt val, UInt cr0so ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = (cr0so & 1) != 0;
res._val = val;
return res;
@@ -110,7 +106,6 @@
/* As per ppc32 version, cr0.so must be in l.s.b. of 2nd arg */
SysRes VG_(mk_SysRes_ppc64_linux) ( ULong val, ULong cr0so ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = (cr0so & 1) != 0;
res._val = val;
return res;
@@ -118,7 +113,6 @@
SysRes VG_(mk_SysRes_s390x_linux) ( Long val ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = val >= -4095 && val <= -1;
if (res._isError) {
res._val = -val;
@@ -130,7 +124,6 @@
SysRes VG_(mk_SysRes_arm_linux) ( Int val ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = val >= -4095 && val <= -1;
if (res._isError) {
res._val = (UInt)(-val);
@@ -142,7 +135,6 @@
SysRes VG_(mk_SysRes_arm64_linux) ( Long val ) {
SysRes res;
- res._valEx = 0; /* unused except on mips-linux */
res._isError = val >= -4095 && val <= -1;
if (res._isError) {
res._val = (ULong)(-val);
@@ -152,6 +144,7 @@
return res;
}
+#if defined(VGA_mips64) || defined(VGA_mips32)
/* MIPS uses a3 != 0 to flag an error */
SysRes VG_(mk_SysRes_mips32_linux) ( UWord v0, UWord v1, UWord a3 ) {
SysRes res;
@@ -169,11 +162,14 @@
res._valEx = v1;
return res;
}
+#endif
/* Generic constructors. */
SysRes VG_(mk_SysRes_Error) ( UWord err ) {
SysRes r;
- r._valEx = 0; /* unused except on mips-linux */
+#if defined(VGA_mips64) || defined(VGA_mips32)
+ r._valEx = 0;
+#endif
r._isError = True;
r._val = err;
return r;
@@ -181,7 +177,9 @@
SysRes VG_(mk_SysRes_Success) ( UWord res ) {
SysRes r;
- r._valEx = 0; /* unused except on mips-linux */
+#if defined(VGA_mips64) || defined(VGA_mips32)
+ r._valEx = 0;
+#endif
r._isError = False;
r._val = res;
return r;
Modified: trunk/include/pub_tool_basics.h
==============================================================================
--- trunk/include/pub_tool_basics.h (original)
+++ trunk/include/pub_tool_basics.h Mon Apr 20 22:02:18 2015
@@ -153,9 +153,11 @@
#if defined(VGO_linux)
typedef
struct {
- UWord _val;
- UWord _valEx; // only used on mips-linux
Bool _isError;
+ UWord _val;
+#if defined(VGA_mips64) || defined(VGA_mips32)
+ UWord _valEx;
+#endif
}
SysRes;
#elif defined(VGO_darwin)
@@ -189,15 +191,17 @@
static inline UWord sr_Res ( SysRes sr ) {
return sr._isError ? 0 : sr._val;
}
+#if defined(VGA_mips64) || defined(VGA_mips32)
static inline UWord sr_ResEx ( SysRes sr ) {
return sr._isError ? 0 : sr._valEx;
}
+#endif
static inline UWord sr_Err ( SysRes sr ) {
return sr._isError ? sr._val : 0;
}
+// FIXME: this function needs to be fixed for MIPS
static inline Bool sr_EQ ( SysRes sr1, SysRes sr2 ) {
return sr1._val == sr2._val
- && sr1._valEx == sr2._valEx
&& sr1._isError == sr2._isError;
}
|
Author: florian
Date: Mon Apr 20 21:42:42 2015
New Revision: 15116
Log:
Remove function sr_ResHI from Linux specific code.
Add function VG_(sr_as_string).
Modified:
trunk/coregrind/m_libcprint.c
trunk/coregrind/m_syswrap/priv_types_n_macros.h
trunk/coregrind/m_syswrap/syswrap-main.c
trunk/include/pub_tool_basics.h
trunk/include/pub_tool_libcprint.h
Modified: trunk/coregrind/m_libcprint.c
==============================================================================
--- trunk/coregrind/m_libcprint.c (original)
+++ trunk/coregrind/m_libcprint.c Mon Apr 20 21:42:42 2015
@@ -643,6 +643,44 @@
VG_(exit)(1);
}
+/* ---------------------------------------------------------------------
+ VG_(sr_as_string)()
+ ------------------------------------------------------------------ */
+
+/* Return a textual representation of a SysRes value in a statically
+ allocated buffer. The buffer will be overwritten with the next
+ invocation. */
+#if defined(VGO_linux)
+// FIXME: Does this function need to be adjusted for MIPS's _valEx ?
+const HChar *VG_(sr_as_string) ( SysRes sr )
+{
+ static HChar buf[7+1+2+16+1+1]; // large enough
+
+ if (sr_isError(sr))
+ VG_(sprintf)(buf, "Failure(0x%lx)", sr_Err(sr));
+ else
+ VG_(sprintf)(buf, "Success(0x%lx)", sr_Res(sr));
+ return buf;
+}
+
+#elif defined(VGO_darwin)
+
+const HChar *VG_(sr_as_string) ( SysRes sr )
+{
+ static HChar buf[7+1+2+16+1+2+16+1+1]; // large enough
+
+ if (sr_isError(sr))
+ VG_(sprintf)(buf, "Failure(0x%lx)", sr_Err(sr));
+ else
+ VG_(sprintf)(buf, "Success(0x%lx:0x%lx)", sr_ResHI(sr), sr_Res(sr));
+ return buf;
+}
+
+#else
+
+#error unknown OS
+
+#endif
/*--------------------------------------------------------------------*/
/*--- end ---*/
Modified: trunk/coregrind/m_syswrap/priv_types_n_macros.h
==============================================================================
--- trunk/coregrind/m_syswrap/priv_types_n_macros.h (original)
+++ trunk/coregrind/m_syswrap/priv_types_n_macros.h Mon Apr 20 21:42:42 2015
@@ -331,11 +331,13 @@
return sr_Res(st->sres);
}
+#if defined(VGO_darwin)
static inline UWord getRESHI ( SyscallStatus* st ) {
vg_assert(st->what == SsComplete);
vg_assert(!sr_isError(st->sres));
return sr_ResHI(st->sres);
}
+#endif
static inline UWord getERR ( SyscallStatus* st ) {
vg_assert(st->what == SsComplete);
Modified: trunk/coregrind/m_syswrap/syswrap-main.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-main.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-main.c Mon Apr 20 21:42:42 2015
@@ -1669,9 +1669,7 @@
if (sci->flags & SfNoWriteResult) {
PRINT(" --> [pre-success] NoWriteResult");
} else {
- PRINT(" --> [pre-success] Success(0x%llx:0x%llx)",
- (ULong)sr_ResHI(sci->status.sres),
- (ULong)sr_Res(sci->status.sres));
+ PRINT(" --> [pre-success] %s", VG_(sr_as_string)(sci->status.sres));
}
/* In this case the allowable flags are to ask for a signal-poll
and/or a yield after the call. Changing the args isn't
@@ -1684,7 +1682,7 @@
else
if (sci->status.what == SsComplete && sr_isError(sci->status.sres)) {
/* The pre-handler decided to fail syscall itself. */
- PRINT(" --> [pre-fail] Failure(0x%llx)", (ULong)sr_Err(sci->status.sres));
+ PRINT(" --> [pre-fail] %s", VG_(sr_as_string)(sci->status.sres));
/* In this case, the pre-handler is also allowed to ask for the
post-handler to be run anyway. Changing the args is not
allowed. */
@@ -1769,18 +1767,9 @@
/* Be decorative, if required. */
if (VG_(clo_trace_syscalls)) {
- Bool failed = sr_isError(sci->status.sres);
- if (failed) {
- PRINT("SYSCALL[%d,%d](%s) ... [async] --> Failure(0x%llx)",
- VG_(getpid)(), tid, VG_SYSNUM_STRING(sysno),
- (ULong)sr_Err(sci->status.sres));
- } else {
- PRINT("SYSCALL[%d,%d](%s) ... [async] --> "
- "Success(0x%llx:0x%llx)",
- VG_(getpid)(), tid, VG_SYSNUM_STRING(sysno),
- (ULong)sr_ResHI(sci->status.sres),
- (ULong)sr_Res(sci->status.sres) );
- }
+ PRINT("SYSCALL[%d,%d](%s) ... [async] --> %s",
+ VG_(getpid)(), tid, VG_SYSNUM_STRING(sysno),
+ VG_(sr_as_string)(sci->status.sres));
}
} else {
@@ -1800,15 +1789,7 @@
/* Be decorative, if required. */
if (VG_(clo_trace_syscalls)) {
- Bool failed = sr_isError(sci->status.sres);
- if (failed) {
- PRINT("[sync] --> Failure(0x%llx)",
- (ULong)sr_Err(sci->status.sres) );
- } else {
- PRINT("[sync] --> Success(0x%llx:0x%llx)",
- (ULong)sr_ResHI(sci->status.sres),
- (ULong)sr_Res(sci->status.sres) );
- }
+ PRINT("[sync] --> %s", VG_(sr_as_string)(sci->status.sres));
}
}
}
Modified: trunk/include/pub_tool_basics.h
==============================================================================
--- trunk/include/pub_tool_basics.h (original)
+++ trunk/include/pub_tool_basics.h Mon Apr 20 21:42:42 2015
@@ -192,9 +192,6 @@
static inline UWord sr_ResEx ( SysRes sr ) {
return sr._isError ? 0 : sr._valEx;
}
-static inline UWord sr_ResHI ( SysRes sr ) {
- return 0;
-}
static inline UWord sr_Err ( SysRes sr ) {
return sr._isError ? sr._val : 0;
}
Modified: trunk/include/pub_tool_libcprint.h
==============================================================================
--- trunk/include/pub_tool_libcprint.h (original)
+++ trunk/include/pub_tool_libcprint.h Mon Apr 20 21:42:42 2015
@@ -154,6 +154,9 @@
/* Flush any output cached by previous calls to VG_(message) et al. */
extern void VG_(message_flush) ( void );
+/* Return a SysRes value as a character string. */
+extern const HChar *VG_(sr_as_string) ( SysRes sr );
+
#endif // __PUB_TOOL_LIBCPRINT_H
/*--------------------------------------------------------------------*/
|
|
From: <sv...@va...> - 2015-04-20 17:00:10
|
Author: florian
Date: Mon Apr 20 18:00:02 2015
New Revision: 15115
Log:
Update tilegx's do_clone function adopting the stack bound changes
made in r14392.
Modified:
trunk/coregrind/m_syswrap/syswrap-tilegx-linux.c
Modified: trunk/coregrind/m_syswrap/syswrap-tilegx-linux.c
==============================================================================
--- trunk/coregrind/m_syswrap/syswrap-tilegx-linux.c (original)
+++ trunk/coregrind/m_syswrap/syswrap-tilegx-linux.c Mon Apr 20 18:00:02 2015
@@ -337,7 +337,6 @@
ThreadState * ctst = VG_ (get_ThreadState) (ctid);
Long ret = 0;
Long * stack;
- NSegment const *seg;
SysRes res;
vki_sigset_t blockall, savedmask;
@@ -372,22 +371,7 @@
See #226116. */
ctst->os_state.threadgroup = ptst->os_state.threadgroup;
- seg = VG_ (am_find_nsegment) ((Addr) sp);
-
- if (seg && seg->kind != SkResvn) {
- ctst->client_stack_highest_byte = (Addr) VG_PGROUNDUP (sp);
- ctst->client_stack_szB = ctst->client_stack_highest_byte - seg->start;
- VG_ (register_stack) (seg->start, ctst->client_stack_highest_byte);
- if (debug)
- VG_ (printf) ("tid %d: guessed client stack range %#lx-%#lx\n",
-
- ctid, seg->start, VG_PGROUNDUP (sp));
- } else {
- VG_ (message) (Vg_UserMsg,
- "!? New thread %d starts with sp+%#lx) unmapped\n",
- ctid, sp);
- ctst->client_stack_szB = 0;
- }
+ ML_(guess_and_register_stack) (sp, ctst);
VG_TRACK (pre_thread_ll_create, ptid, ctid);
if (flags & VKI_CLONE_SETTLS) {
|
|
From: Julian S. <js...@ac...> - 2015-04-20 13:05:34
|
>> Your yesterday's change r15060 breaks MIPS port in general, > as comparing _valEx will fail immediately. > > MIPS support has been broken in trunk for two weeks. Does anyone > have a fix for this incoming? Maybe it should be posted as a bug > in the tracker. Perhaps it would be wise to back out 15060 until such time as it gets fixed properly, and at the same time file a bug in the tracker for the underlying problem. J |
|
From: Crestez D. L. <cdl...@gm...> - 2015-04-20 12:34:02
|
On 04/03/2015 05:14 AM, Petar Jovanovic wrote: > Hi Florian, > > Sorry for not responding to this earlier. > Field _valEx is used on MIPS only for pipe system call when kernel can return an array of two file descriptors. Otherwise, this field is undefined (actually, it has a value that happened to be in v1 register, which can be an arbitrary value and it is not deterministic). Thus, comparing _valEx does not make sense for an arbitrary SysRes. > > Your yesterday's change r15060 breaks MIPS port in general, as comparing _valEx will fail immediately. MIPS support has been broken in trunk for two weeks. Does anyone have a fix for this incoming? Maybe it should be posted as a bug in the tracker. It's not clear how valEx should be treated for syscalls other than pipe() since it's left undefined by the linux syscall ABI. I think that simply defining that all other syscalls return zero in valEx would be an acceptable solution. Regards, Leonard |
|
From: Liming S. <ls...@ez...> - 2015-04-20 01:01:01
|
I ran a quick test. The regression result is about the same as before. It looks safe to check in the patch...
Thanks,
Liming
________________________________________
From: Florian Krohm <fl...@ei...>
Sent: Saturday, April 18, 2015 2:30 PM
To: Zhigang Liu
Cc: Valgrind Developers
Subject: [Valgrind-developers] tilegx: do_clone() stack guessing and registration
I noticed that the do_clone function in syswrap-tilegx-linux.c
does its own stack guessing and registration instead of using
the generic ML_(guess_and_register_stack) function which is
used by all other archs for that purpose. If at all possible
we should strive to use the generic code unless there is a *really*
good reason not to..
Looking at your code I see some subtle differences and am wondering
whether those are correct:
tilegx code:
ctst->client_stack_highest_byte = (Addr) VG_PGROUNDUP (sp);
ctst->client_stack_szB = ctst->client_stack_highest_byte - seg->start;
generic code:
tst->client_stack_highest_byte = (Addr)VG_PGROUNDUP(sp)-1;
tst->client_stack_szB = tst->client_stack_highest_byte - seg->start + 1;
That looks like an off-by-one error to me. Could you elaborate?
I'm thinking about the patch below.
Florian
Index: coregrind/m_syswrap/syswrap-tilegx-linux.c
===================================================================
--- coregrind/m_syswrap/syswrap-tilegx-linux.c (revision 15111)
+++ coregrind/m_syswrap/syswrap-tilegx-linux.c (working copy)
@@ -337,7 +337,6 @@
ThreadState * ctst = VG_ (get_ThreadState) (ctid);
Long ret = 0;
Long * stack;
- NSegment const *seg;
SysRes res;
vki_sigset_t blockall, savedmask;
@@ -372,23 +371,8 @@
See #226116. */
ctst->os_state.threadgroup = ptst->os_state.threadgroup;
- seg = VG_ (am_find_nsegment) ((Addr) sp);
+ ML_(guess_and_register_stack) (sp, ctst);
- if (seg && seg->kind != SkResvn) {
- ctst->client_stack_highest_byte = (Addr) VG_PGROUNDUP (sp);
- ctst->client_stack_szB = ctst->client_stack_highest_byte - seg->start;
- VG_ (register_stack) (seg->start, ctst->client_stack_highest_byte);
- if (debug)
- VG_ (printf) ("tid %d: guessed client stack range %#lx-%#lx\n",
-
- ctid, seg->start, VG_PGROUNDUP (sp));
- } else {
- VG_ (message) (Vg_UserMsg,
- "!? New thread %d starts with sp+%#lx) unmapped\n",
- ctid, sp);
- ctst->client_stack_szB = 0;
- }
-
VG_TRACK (pre_thread_ll_create, ptid, ctid);
if (flags & VKI_CLONE_SETTLS) {
if (debug)
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Valgrind-developers mailing list
Val...@li...
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
|