You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
1
(13) |
2
(15) |
|
3
(16) |
4
(42) |
5
(9) |
6
(20) |
7
(22) |
8
(24) |
9
(12) |
|
10
(24) |
11
(11) |
12
(2) |
13
(13) |
14
(8) |
15
|
16
(16) |
|
17
(24) |
18
(36) |
19
(100) |
20
(94) |
21
(50) |
22
(39) |
23
(10) |
|
24
(14) |
25
(19) |
26
(2) |
27
(6) |
28
(17) |
29
(9) |
30
(8) |
|
31
(21) |
|
|
|
|
|
|
|
From: Nicholas N. <n.n...@gm...> - 2009-05-29 16:25:14
|
Nightly build on ocean ( Ubuntu 9.04, Intel x86-64 ) started at 2009-05-30 02:00:01 EST Results unchanged from 24 hours ago Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... failed Regression test results follow == 486 tests, 0 stderr failures, 1 stdout failure, 0 post failures == none/tests/linux/mremap2 (stdout) ================================================= ./valgrind/none/tests/linux/mremap2.stdout.diff ================================================= --- mremap2.stdout.exp 2009-05-30 02:12:48.000000000 +1000 +++ mremap2.stdout.out 2009-05-30 02:24:44.000000000 +1000 @@ -27,38 +27,38 @@ .................................................. .................................................. -maymv 0 fixed 0 newsz 21 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 0 fixed 0 newsz 21 dstpo 0 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 21 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 0 fixed 0 newsz 21 dstpo 1 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 0 fixed 0 newsz 29 dstpo 0 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 0 fixed 0 newsz 29 dstpo 1 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX +maymv 0 fixed 0 newsz 30 dstpo 0 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 30 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX +maymv 0 fixed 0 newsz 30 dstpo 1 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. @@ -173,40 +173,40 @@ .................................................. .................................................. -maymv 1 fixed 0 newsz 21 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 1 fixed 0 newsz 21 dstpo 0 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 1 fixed 0 newsz 21 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 1 fixed 0 newsz 21 dstpo 1 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 1 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 1 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXX..................... .................................................. -maymv 1 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 1 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXX..................... .................................................. -maymv 1 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX +maymv 1 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.................... .................................................. <truncated beyond 100 lines> ================================================= ./valgrind/none/tests/linux/mremap2.stdout.diff-glibc28-amd64 ================================================= --- mremap2.stdout.exp-glibc28-amd64 2009-05-30 02:12:48.000000000 +1000 +++ mremap2.stdout.out 2009-05-30 02:24:44.000000000 +1000 @@ -188,37 +188,37 @@ maymv 1 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== other) XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXX..................... .................................................. maymv 1 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== other) XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXX..................... .................................................. maymv 1 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== other) XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.................... .................................................. maymv 1 fixed 0 newsz 30 dstpo 1 dst 0x........ -> 0x........ (== other) XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.................... .................................................. maymv 1 fixed 0 newsz 31 dstpo 0 dst 0x........ -> 0x........ (== other) XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX................... .................................................. maymv 1 fixed 0 newsz 31 dstpo 1 dst 0x........ -> 0x........ (== other) XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX................... .................................................. ================================================= ./valgrind/none/tests/linux/mremap2.stdout.diff2 ================================================= --- mremap2.stdout.exp2 2009-05-30 02:12:48.000000000 +1000 +++ mremap2.stdout.out 2009-05-30 02:24:44.000000000 +1000 @@ -27,38 +27,38 @@ .................................................. .................................................. -maymv 0 fixed 0 newsz 21 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 0 fixed 0 newsz 21 dstpo 0 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 21 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 0 fixed 0 newsz 21 dstpo 1 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 0 fixed 0 newsz 29 dstpo 0 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 0 fixed 0 newsz 29 dstpo 1 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX +maymv 0 fixed 0 newsz 30 dstpo 0 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 0 fixed 0 newsz 30 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX +maymv 0 fixed 0 newsz 30 dstpo 1 dst 0x........ -> error 12 +XXXXXXXXX.XXXXXXXXXXXXXXXXXXXX..........XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. @@ -173,52 +173,52 @@ .................................................. .................................................. -maymv 1 fixed 0 newsz 21 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 1 fixed 0 newsz 21 dstpo 0 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 1 fixed 0 newsz 21 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXX.........XXXXXXXXXX +maymv 1 fixed 0 newsz 21 dstpo 1 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX .................................................. .................................................. -maymv 1 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 1 fixed 0 newsz 29 dstpo 0 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXX..................... .................................................. -maymv 1 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXX.XXXXXXXXXX +maymv 1 fixed 0 newsz 29 dstpo 1 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXX..................... .................................................. -maymv 1 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== src) -XXXXXXXXX.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX +maymv 1 fixed 0 newsz 30 dstpo 0 dst 0x........ -> 0x........ (== other) +XXXXXXXXX...............................XXXXXXXXXX XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX -.................................................. +XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.................... .................................................. <truncated beyond 100 lines> |
|
From: <sv...@va...> - 2009-05-29 15:30:16
|
Author: weidendo
Date: 2009-05-29 16:30:08 +0100 (Fri, 29 May 2009)
New Revision: 10169
Log:
Callgrind: fix (part of?) bug 191992.
Matching of function names was wrong.
Thanks to Timo Lindfors
Modified:
trunk/callgrind/clo.c
Modified: trunk/callgrind/clo.c
===================================================================
--- trunk/callgrind/clo.c 2009-05-29 08:19:22 UTC (rev 10168)
+++ trunk/callgrind/clo.c 2009-05-29 15:30:08 UTC (rev 10169)
@@ -264,13 +264,13 @@
while(name[offset] && (!is_wild(name[offset]))) offset++;
new_sub = new_config(name, offset);
- new_sub->next = n->sub_node[ name[offset]%NODE_DEGREE ];
- n->sub_node[ name[offset]%NODE_DEGREE ] = new_sub;
+ new_sub->next = n->sub_node[ name[0]%NODE_DEGREE ];
+ n->sub_node[ name[0]%NODE_DEGREE ] = new_sub;
return get_fnc2(new_sub, name+offset);
}
-static void print_config_node(int s, config_node* node)
+static void print_config_node(int depth, int hash, config_node* node)
{
config_node* n;
int i;
@@ -278,19 +278,22 @@
if (node != fn_configs) {
char sp[] = " ";
- if (s>40) s=40;
- VG_(printf)("%s", sp+40-s);
- VG_(printf)("'%s'/%d\n", node->name, node->length);
+ if (depth>40) depth=40;
+ VG_(printf)("%s", sp+40-depth);
+ if (hash >=0) VG_(printf)(" [hash %2d]", hash);
+ else if (hash == -2) VG_(printf)(" [wildc ?]");
+ else if (hash == -3) VG_(printf)(" [wildc *]");
+ VG_(printf)(" '%s' (len %d)\n", node->name, node->length);
}
for(i=0;i<NODE_DEGREE;i++) {
n = node->sub_node[i];
while(n) {
- print_config_node(s+1, n);
+ print_config_node(depth+1, i, n);
n = n->next;
}
}
- if (node->wild_char) print_config_node(s+1, node->wild_char);
- if (node->wild_star) print_config_node(s+1, node->wild_star);
+ if (node->wild_char) print_config_node(depth+1, -2, node->wild_char);
+ if (node->wild_star) print_config_node(depth+1, -3, node->wild_star);
}
/* get a function config for a name pattern (from command line) */
@@ -305,7 +308,7 @@
CLG_DEBUGIF(3) {
CLG_DEBUG(3, " -get_fnc(%s):\n", name);
- print_config_node(3, fn_configs);
+ print_config_node(3, -1, fn_configs);
}
return fnc;
}
@@ -358,7 +361,7 @@
CLG_DEBUG(3, " update_fn_config2('%s', node '%s'): \n",
name, node->name);
if ((*name == 0) && node->config) {
- CLG_DEBUG(3, "Found!\n");
+ CLG_DEBUG(3, " found!\n");
update_fn_config1(fn, node->config);
return;
}
@@ -368,12 +371,19 @@
if (VG_(strncmp)(name, n->name, n->length)==0) break;
n = n->next;
}
- if (n) update_fn_config2(fn, name+n->length, n);
+ if (n) {
+ CLG_DEBUG(3, " '%s' matching at hash %d\n",
+ n->name, name[0]%NODE_DEGREE);
+ update_fn_config2(fn, name+n->length, n);
+ }
- if (node->wild_char)
- update_fn_config2(fn, name+1, node->wild_char);
+ if (node->wild_char) {
+ CLG_DEBUG(3, " skip '%c' for wildcard '?'\n", *name);
+ update_fn_config2(fn, name+1, node->wild_char);
+ }
if (node->wild_star) {
+ CLG_DEBUG(3, " wildcard '*'\n");
while(*name) {
update_fn_config2(fn, name, node->wild_star);
name++;
|
|
From: Konstantin S. <kon...@gm...> - 2009-05-29 11:50:26
|
On Fri, May 29, 2009 at 3:19 PM, Bart Van Assche <bar...@gm...> wrote: > On Fri, May 29, 2009 at 12:58 PM, Konstantin Serebryany > <kon...@gm...> wrote: >> [changed subject] >> >> Do you plan to support annotations (aka client requests) in Helgrind >> and DRD in a compatible way (and possibly, in a way compatible with >> ThreadSanitizer)? >> Something like http://code.google.com/p/google-perftools/source/browse/trunk/src/base/dynamic_annotations.h, >> or completely different. >> Our experience shows that even a pure-happens-before race detector is >> completely useless w/o annotations if your code has lock-less >> synchronization and hundreds of benign races. > > Regarding the dynamic_annotations.h header file: which parts are > generic and which parts are ThreadSanitizer-specific ? Most are generic. But some of the annotations are usually required only with hybrid detectors. E.g. ANNOTATE_PUBLISH_MEMORY will be needed with a pure-h-b detector only if you publish your objects w/o locks. > I assume that > client programs should use the ANNOTATE_*() macro's and not the > Annotate*() functions ? Correct. Annotate*() functions are implementation details and may change. (comment at line 267) > > I assume that you have already developed unit tests for these macro's > in ThreadSanitizer. http://code.google.com/p/data-race-test/source/browse/trunk/unittest/racecheck_unittest.cc is a set of unittests for ThreadSanitizer. Some of the tests specifically test the annotations. > Are available under the GPL ? Yes, GPL v2+ As for annotations, I think they should go under a BSD-like license (as valgrind.h does) > > One aspect of the dynamic_annotations.h header file that I do not like > is that enabling / disabling the ANNOTATE*() macro's is controlled by > the NDEBUG macro. IMHO a new macro should be defined that allows to > enable / disable the ANNOTATE*() macro's. I don't have a strong opinion here. > > Adding support for the ANNOTATE_*() macro's in drd/drd.h is probably > not too hard. I'll have a look at it. Implementation-wise you need to support Annotate*() functions, or rewrite ANNOTATE*() macro's using client requests and support those client requests. I find the approach with Annotate*() functions simpler to maintain. --kcc > > Bart. > |
|
From: Bart V. A. <bar...@gm...> - 2009-05-29 11:19:49
|
On Fri, May 29, 2009 at 12:58 PM, Konstantin Serebryany <kon...@gm...> wrote: > [changed subject] > > Do you plan to support annotations (aka client requests) in Helgrind > and DRD in a compatible way (and possibly, in a way compatible with > ThreadSanitizer)? > Something like http://code.google.com/p/google-perftools/source/browse/trunk/src/base/dynamic_annotations.h, > or completely different. > Our experience shows that even a pure-happens-before race detector is > completely useless w/o annotations if your code has lock-less > synchronization and hundreds of benign races. Regarding the dynamic_annotations.h header file: which parts are generic and which parts are ThreadSanitizer-specific ? I assume that client programs should use the ANNOTATE_*() macro's and not the Annotate*() functions ? I assume that you have already developed unit tests for these macro's in ThreadSanitizer. Are available under the GPL ? One aspect of the dynamic_annotations.h header file that I do not like is that enabling / disabling the ANNOTATE*() macro's is controlled by the NDEBUG macro. IMHO a new macro should be defined that allows to enable / disable the ANNOTATE*() macro's. Adding support for the ANNOTATE_*() macro's in drd/drd.h is probably not too hard. I'll have a look at it. Bart. |
|
From: Konstantin S. <kon...@gm...> - 2009-05-29 10:58:34
|
[changed subject] Julian, Bart, Do you plan to support annotations (aka client requests) in Helgrind and DRD in a compatible way (and possibly, in a way compatible with ThreadSanitizer)? Something like http://code.google.com/p/google-perftools/source/browse/trunk/src/base/dynamic_annotations.h, or completely different. Our experience shows that even a pure-happens-before race detector is completely useless w/o annotations if your code has lock-less synchronization and hundreds of benign races. Thanks, --kcc On Thu, Feb 12, 2009 at 12:00 AM, Konstantin Serebryany <kon...@gm...> wrote: > On Wed, Feb 11, 2009 at 8:53 PM, Bart Van Assche > <bar...@gm...> wrote: >> On Tue, Feb 10, 2009 at 7:42 AM, Konstantin Serebryany >> <kon...@gm...> wrote: >>> On Mon, Feb 9, 2009 at 9:48 PM, Bart Van Assche >>> <bar...@gm...> wrote: >>>> IMHO it would be a significant advantage for Valgrind users if there >>>> would be a single set of source code annotations that is understood by >>>> all data race detectors built on top of Valgrind (Helgrind, DRD and >>>> ThreadSanitizer). >>> >>> Yes. >>> Another question: should these client requests be binary compatible >>> with each other, or only source compatible? >>> (source compatible == macro definitions with different >>> implementations for different tools) >>> If we push for binary compatibility, we may loose the ability to be >>> compatible with non-valgrind-based tools. >> >> Do you think it is possible to define the annotations such that >> recompilation would only be needed when switching between >> Valgrind-tools and non-Valgrind tools ? > > Yes, sure. > either define the same client requests in all three tools or intercept > the same functions (like AnnotateBlahBlahBlah()) > --kcc > > --kcc >> >> Bart. >> > |
|
From: Bart V. A. <bar...@gm...> - 2009-05-29 08:06:16
|
On Fri, May 29, 2009 at 9:06 AM, Nicholas Nethercote <n.n...@gm...> wrote: > On Wed, May 20, 2009 at 10:05 AM, Nicholas Nethercote > <n.n...@gm...> wrote: >> On Tue, May 19, 2009 at 6:06 PM, Julian Seward <js...@ac...> wrote: >>> Anyway, this leads to the current question, which is what to do about >>> the sources for check_PROGRAMS components which are only conditionally >>> defined, eg >>> >>> if HAVE_PTHREAD_BARRIER >>> check_PROGRAMS += matinv pth_barrier pth_barrier_race pth_barrier_reinit >>> endif >> >> Maybe we need this: >> >> if HAVE_PTHREAD_BARRIER >> check_PROGRAMS += matinv pth_barrier pth_barrier_race pth_barrier_reinit >> else >> EXTRA_DIST += matinv.c pth_barrier.c pth_barrier_race.c pth_barrier_reinit.c >> endif > > I just looked into this. It seems that automake includes the source > files for the programs listed in check_PROGRAMS above, even if > HAVE_PTHREAD_BARRIER isn't true. Which makes sense really, otherwise > everyone would face this problem. > > In other words, we don't have to do anything. Hooray! Thanks for figuring this out. Bart. |
|
From: Nicholas N. <n.n...@gm...> - 2009-05-29 07:06:14
|
On Wed, May 20, 2009 at 10:05 AM, Nicholas Nethercote <n.n...@gm...> wrote: > On Tue, May 19, 2009 at 6:06 PM, Julian Seward <js...@ac...> wrote: >> Anyway, this leads to the current question, which is what to do about >> the sources for check_PROGRAMS components which are only conditionally >> defined, eg >> >> if HAVE_PTHREAD_BARRIER >> check_PROGRAMS += matinv pth_barrier pth_barrier_race pth_barrier_reinit >> endif > > Maybe we need this: > > if HAVE_PTHREAD_BARRIER > check_PROGRAMS += matinv pth_barrier pth_barrier_race pth_barrier_reinit > else > EXTRA_DIST += matinv.c pth_barrier.c pth_barrier_race.c pth_barrier_reinit.c > endif I just looked into this. It seems that automake includes the source files for the programs listed in check_PROGRAMS above, even if HAVE_PTHREAD_BARRIER isn't true. Which makes sense really, otherwise everyone would face this problem. In other words, we don't have to do anything. Hooray! Nick |
|
From: Tom H. <th...@cy...> - 2009-05-29 02:45:03
|
Nightly build on mg ( x86_64, Fedora 9 ) started at 2009-05-29 03:10:02 BST Results unchanged from 24 hours ago Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... failed Regression test results follow == 487 tests, 0 stderr failures, 1 stdout failure, 0 post failures == none/tests/linux/mremap2 (stdout) |
|
From: Tom H. <th...@cy...> - 2009-05-29 02:44:56
|
Nightly build on lloyd ( x86_64, Fedora 7 ) started at 2009-05-29 03:05:04 BST Results unchanged from 24 hours ago Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... done Regression test results follow == 481 tests, 0 stderr failures, 0 stdout failures, 0 post failures == |