You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
1
(8) |
2
(8) |
3
(15) |
4
(14) |
5
(12) |
6
(40) |
7
(9) |
|
8
(5) |
9
(12) |
10
(9) |
11
(13) |
12
(7) |
13
(7) |
14
(19) |
|
15
(18) |
16
(13) |
17
(16) |
18
(8) |
19
(16) |
20
(16) |
21
(12) |
|
22
(21) |
23
(39) |
24
(27) |
25
(33) |
26
(41) |
27
(17) |
28
(15) |
|
From: Nicholas N. <n.n...@gm...> - 2009-02-19 23:26:56
|
On Thu, Feb 19, 2009 at 10:57 PM, Bart Van Assche
<bar...@gm...> wrote:
>
> Yes. There are several reasons why I want to see these tests being
> moved back to the drd/tests directory:
> - This makes it clear who spent the effort to write the test --
> currently the only way to know who wrote a Helgrind or Drd regression
> test is to look up in which directory the source code of the test
> resides.
I didn't expect the ownership of 3 simple test files, a total of 218
lines of code, to be an issue. None of our test files have the author
indicated, so for most of them the author is unclear.
> - Before I started using some of the Helgrind regression tests for
> testing Drd, I asked Julian for permission through private e-mail.
> Julian asked me not to copy the source code of the Helgrind regression
> tests but to create soft links from helgrind/tests/ to drd/tests/. I
> choose to specify the ../../helgrind/tests path explicitly in
> drd/tests/Makefile.am. I assume that Julian is using some of the Drd
> regression tests under the same conditions.
I believe Julian asked you to do that for a purely technical reason:
to avoid the code duplication. We do the same thing with the
{none,memcheck}/tests/x86/insn* tests.
> - The reason why I choose to recompile the Helgrind regression tests
> in the drd/tests/ directory instead of directly running the
> helgrind/tests/... binaries during testing Drd is that this decouples
> the regression tests of both tools better: this way the CFLAGS
> specified in drd/tests/Makefile.am apply to all binaries used for
> regression testing Drd. The latest trunk revision (r9202) some
> binaries that are being used to test Drd have been compiled with the
> CFLAGS specified in drd/tests/Makefile.am and some have been compiled
> with the CFLAGS specified in helgrind/tests/Makefile.am.
It's true that the CFLAGS are different. However, the only difference
is that DRD uses different -W flags, so the executables are actually
identical. I actually think the fact that DRD uses different -W flags
for its tests compared to every other tool is actually a bad thing,
I'd like to get rid of that difference.
(And if you're going to argue that the old approach allowed other
compilation changes, should they be needed:
http://en.wikipedia.org/wiki/You_Ain't_Gonna_Need_It. I again point
to the insn* tests which have been happily shared between Nulgrind and
Memcheck for years.)
> IMHO the above discussion should have been held before any changes
> were applied to the Helgrind or Drd regression tests.
Our usual procedure, which admittedly isn't explicitly documented, is
that developers don't bother discussing things before committing
unless they think they are controversial. Then if someone else
doesn't like it, they can complain in response to the log message.
This is a lightweight review process appropriate for a project like
Valgrind with a small number of developers. And that's exactly what
has happened here, which is fine. Obviously people will sometimes
disagree about the definition of controversial, and I'm sorry if this
process wasn't clear and I've upset you. But after all, it's just the
build system and the tests... I'd be much more careful about changing
DRD's code, for example, or even changing the contents of the tests,
but this change just moved them around and changed how they were
built.
Our build system is something of a mess and I've put quite a lot of
effort recently into improving it. My change reduced the size of
drd/tests/Makefile.am by 205 lines, made "make check" faster by
avoiding building 35 tests twice, and simplified the dependencies
between Helgrind and DRD. So I'd rather not revert it.
I'd be happy for you to put a comment in the tests you wrote
indicating that you are the author (we could do that for all the tests
you've written if you'd like.) If you're still not happy with that,
how's this for a compromise that I expect Julian won't mind: how
about we move all the shared test source files from helgrind/tests/
into drd/tests/ ?
Nick
|
|
From: Bart V. A. <bar...@gm...> - 2009-02-19 15:40:34
|
On Tue, Jan 27, 2009 at 12:08 PM, Bart Van Assche <bar...@gm...> wrote: > Regarding the nightly PPC build: this nightly build will work again as > soon as the system this build is run on is operational again. Update: by this time the cellbuzz cluster is up and running again. Bart. |
|
From: <sv...@va...> - 2009-02-19 14:59:53
|
Author: bart
Date: 2009-02-19 14:59:48 +0000 (Thu, 19 Feb 2009)
New Revision: 9203
Log:
Updated cellbuzz configuration according to the changes made during the big upgrade of the Cellbuzz cluster in February 2009.
Modified:
trunk/nightly/conf/georgia-tech-cellbuzz-native.conf
Modified: trunk/nightly/conf/georgia-tech-cellbuzz-native.conf
===================================================================
--- trunk/nightly/conf/georgia-tech-cellbuzz-native.conf 2009-02-19 09:52:05 UTC (rev 9202)
+++ trunk/nightly/conf/georgia-tech-cellbuzz-native.conf 2009-02-19 14:59:48 UTC (rev 9203)
@@ -14,9 +14,9 @@
cellbuzz_eval() {
rm -f cmd-output.txt done
jobid=`echo "{ cd $PWD && eval \"$*\"; } >& $PWD/cmd-output.txt" \
- | /usr/pbs/bin/qsub -m n -q cellq30`
+ | qsub -m n -q sdk3.0`
echo "Job ID = ${jobid}"
- while [ `/usr/pbs/bin/qstat "${jobid}" 2>/dev/null | wc --lines` -gt 0 ]
+ while [ `qstat "${jobid}" 2>/dev/null | wc --lines` -gt 0 ]
do
sleep 10
done
|
|
From: Bart V. A. <bar...@gm...> - 2009-02-19 13:36:14
|
On Thu, Feb 19, 2009 at 12:25 PM, Nicholas Nethercote <n.n...@gm...> wrote: > On Thu, Feb 19, 2009 at 9:51 PM, Bart Van Assche > <bar...@gm...> wrote: >> >> I do see it this way -- I do not agree that the DRD regression tests >> have been moved to another directory. I want to see these back in the >> drd directory. > > So you want pth_barrier.c, rwlock_race.c and rwlock_test.c to be moved > back into drd/tests/? Yes. There are several reasons why I want to see these tests being moved back to the drd/tests directory: - This makes it clear who spent the effort to write the test -- currently the only way to know who wrote a Helgrind or Drd regression test is to look up in which directory the source code of the test resides. - Before I started using some of the Helgrind regression tests for testing Drd, I asked Julian for permission through private e-mail. Julian asked me not to copy the source code of the Helgrind regression tests but to create soft links from helgrind/tests/ to drd/tests/. I choose to specify the ../../helgrind/tests path explicitly in drd/tests/Makefile.am. I assume that Julian is using some of the Drd regression tests under the same conditions. - The reason why I choose to recompile the Helgrind regression tests in the drd/tests/ directory instead of directly running the helgrind/tests/... binaries during testing Drd is that this decouples the regression tests of both tools better: this way the CFLAGS specified in drd/tests/Makefile.am apply to all binaries used for regression testing Drd. The latest trunk revision (r9202) some binaries that are being used to test Drd have been compiled with the CFLAGS specified in drd/tests/Makefile.am and some have been compiled with the CFLAGS specified in helgrind/tests/Makefile.am. IMHO the above discussion should have been held before any changes were applied to the Helgrind or Drd regression tests. > But if it really concerns you, I can do it tomorrow morning -- I'm > about to go to bed now. Thanks, Bart. |
|
From: Nicholas N. <n.n...@gm...> - 2009-02-19 11:25:49
|
On Thu, Feb 19, 2009 at 9:51 PM, Bart Van Assche <bar...@gm...> wrote: > > I do see it this way -- I do not agree that the DRD regression tests > have been moved to another directory. I want to see these back in the > drd directory. So you want pth_barrier.c, rwlock_race.c and rwlock_test.c to be moved back into drd/tests/? I think it's simpler to have dependencies in one direction rather than in both directions. But if it really concerns you, I can do it tomorrow morning -- I'm about to go to bed now. Nick |
|
From: Bart V. A. <bar...@gm...> - 2009-02-19 10:51:12
|
On Thu, Feb 19, 2009 at 11:33 AM, Nicholas Nethercote <n.n...@gm...> wrote: > On Thu, Feb 19, 2009 at 9:14 PM, Bart Van Assche > <bar...@gm...> wrote: >> On Thu, Feb 19, 2009 at 10:52 AM, <sv...@va...> wrote: >>> - A number of tests are shared between Helgrind and DRD. They used to be >>> built in both directories. Now they are only built in helgrind/tests/, >>> and the DRD .vgtest files just point to the executable in helgrind/tests/. >>> Most of these (about 30) had the source files in helgrind/tests/; I moved >>> the three that were in drd/tests/ into helgrind/tests/ for consistency. >> >> Shouldn't such changes be discussed on the valgrind-developers mailing >> list before being implemented ? > > It seemed like a clear simplification to me and thus not > controversial. What are your objections? I do see it this way -- I do not agree that the DRD regression tests have been moved to another directory. I want to see these back in the drd directory. Bart. |
|
From: Nicholas N. <n.n...@gm...> - 2009-02-19 10:33:14
|
On Thu, Feb 19, 2009 at 9:14 PM, Bart Van Assche <bar...@gm...> wrote: > On Thu, Feb 19, 2009 at 10:52 AM, <sv...@va...> wrote: >> - A number of tests are shared between Helgrind and DRD. They used to be >> built in both directories. Now they are only built in helgrind/tests/, >> and the DRD .vgtest files just point to the executable in helgrind/tests/. >> Most of these (about 30) had the source files in helgrind/tests/; I moved >> the three that were in drd/tests/ into helgrind/tests/ for consistency. > > Shouldn't such changes be discussed on the valgrind-developers mailing > list before being implemented ? It seemed like a clear simplification to me and thus not controversial. What are your objections? Nick |
|
From: Bart V. A. <bar...@gm...> - 2009-02-19 10:30:15
|
Nightly build on georgia-tech-cellbuzz-native ( cellbuzz, ppc64, Fedora 7, native ) started at 2009-02-19 03:42:14 EST Results unchanged from 24 hours ago Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... done Regression test results follow == 407 tests, 39 stderr failures, 10 stdout failures, 1 post failure == exp-ptrcheck/tests/bad_percentify (stderr) exp-ptrcheck/tests/base (stderr) exp-ptrcheck/tests/ccc (stderr) exp-ptrcheck/tests/fp (stderr) exp-ptrcheck/tests/globalerr (stderr) exp-ptrcheck/tests/hackedbz2 (stderr) exp-ptrcheck/tests/hp_bounds (stderr) exp-ptrcheck/tests/hp_dangle (stderr) exp-ptrcheck/tests/justify (stderr) exp-ptrcheck/tests/partial_bad (stderr) exp-ptrcheck/tests/partial_good (stderr) exp-ptrcheck/tests/preen_invars (stderr) exp-ptrcheck/tests/pth_create (stderr) exp-ptrcheck/tests/pth_specific (stderr) exp-ptrcheck/tests/realloc (stderr) exp-ptrcheck/tests/stackerr (stderr) exp-ptrcheck/tests/strcpy (stderr) exp-ptrcheck/tests/supp (stderr) exp-ptrcheck/tests/tricky (stderr) exp-ptrcheck/tests/unaligned (stderr) exp-ptrcheck/tests/zero (stderr) helgrind/tests/hg05_race2 (stderr) helgrind/tests/tc18_semabuse (stderr) helgrind/tests/tc20_verifywrap (stderr) massif/tests/overloaded-new (post) memcheck/tests/deep_templates (stdout) memcheck/tests/leak-cycle (stderr) memcheck/tests/leak-tree (stderr) memcheck/tests/origin5-bz2 (stderr) memcheck/tests/pointer-trace (stderr) memcheck/tests/varinfo1 (stderr) memcheck/tests/varinfo2 (stderr) memcheck/tests/varinfo3 (stderr) memcheck/tests/varinfo4 (stderr) memcheck/tests/varinfo5 (stderr) memcheck/tests/varinfo6 (stderr) memcheck/tests/wrap8 (stderr) memcheck/tests/zeropage (stdout) none/tests/faultstatus (stderr) none/tests/linux/mremap (stderr) none/tests/linux/mremap2 (stdout) none/tests/ppc32/jm-fp (stdout) none/tests/ppc32/jm-vmx (stdout) none/tests/ppc32/round (stdout) none/tests/ppc32/test_gx (stdout) none/tests/ppc64/jm-fp (stdout) none/tests/ppc64/jm-vmx (stdout) none/tests/ppc64/round (stdout) none/tests/shell_valid2 (stderr) none/tests/shell_valid3 (stderr) |
|
From: Bart V. A. <bar...@gm...> - 2009-02-19 10:15:01
|
On Thu, Feb 19, 2009 at 10:52 AM, <sv...@va...> wrote: > - A number of tests are shared between Helgrind and DRD. They used to be > built in both directories. Now they are only built in helgrind/tests/, > and the DRD .vgtest files just point to the executable in helgrind/tests/. > Most of these (about 30) had the source files in helgrind/tests/; I moved > the three that were in drd/tests/ into helgrind/tests/ for consistency. Shouldn't such changes be discussed on the valgrind-developers mailing list before being implemented ? Bart. |
|
From: <sv...@va...> - 2009-02-19 09:52:15
|
Author: njn
Date: 2009-02-19 09:52:05 +0000 (Thu, 19 Feb 2009)
New Revision: 9202
Log:
Various build system clean-ups and simplifications:
- Created Makefile.tool-tests.am, put standard AM_CFLAGS et al for tests in
it.
- A number of tests are shared between Helgrind and DRD. They used to be
built in both directories. Now they are only built in helgrind/tests/,
and the DRD .vgtest files just point to the executable in helgrind/tests/.
Most of these (about 30) had the source files in helgrind/tests/; I moved
the three that were in drd/tests/ into helgrind/tests/ for consistency.
- Fixed rwlock_test, which was failing to run due to a wrong name in the
.vgtest file.
- Removed remnants of unused 'hello' test for Memcheck.
- Avoided redundant flag specification in various places, esp.
memcheck/tests/Makefile.am.
- Removed unnecessary _AIX guards in some Linux-only tests.
Added:
trunk/Makefile.tool-tests.am
trunk/helgrind/tests/pth_barrier.c
trunk/helgrind/tests/rwlock_race.c
trunk/helgrind/tests/rwlock_test.c
Removed:
trunk/drd/tests/pth_barrier.c
trunk/drd/tests/rwlock_race.c
trunk/drd/tests/rwlock_test.c
trunk/memcheck/tests/hello.c
Modified:
trunk/cachegrind/tests/Makefile.am
trunk/callgrind/tests/Makefile.am
trunk/drd/tests/Makefile.am
trunk/drd/tests/bar_bad.vgtest
trunk/drd/tests/bar_trivial.vgtest
trunk/drd/tests/hg01_all_ok.vgtest
trunk/drd/tests/hg02_deadlock.vgtest
trunk/drd/tests/hg03_inherit.vgtest
trunk/drd/tests/hg04_race.vgtest
trunk/drd/tests/hg05_race2.vgtest
trunk/drd/tests/hg06_readshared.vgtest
trunk/drd/tests/pth_barrier.vgtest
trunk/drd/tests/pth_barrier2.vgtest
trunk/drd/tests/pth_barrier3.vgtest
trunk/drd/tests/rwlock_race.vgtest
trunk/drd/tests/rwlock_test.stderr.exp
trunk/drd/tests/rwlock_test.vgtest
trunk/drd/tests/tc01_simple_race.vgtest
trunk/drd/tests/tc02_simple_tls.vgtest
trunk/drd/tests/tc03_re_excl.vgtest
trunk/drd/tests/tc04_free_lock.vgtest
trunk/drd/tests/tc05_simple_race.vgtest
trunk/drd/tests/tc06_two_races.vgtest
trunk/drd/tests/tc07_hbl1.vgtest
trunk/drd/tests/tc08_hbl2.vgtest
trunk/drd/tests/tc09_bad_unlock.vgtest
trunk/drd/tests/tc10_rec_lock.vgtest
trunk/drd/tests/tc11_XCHG.vgtest
trunk/drd/tests/tc12_rwl_trivial.vgtest
trunk/drd/tests/tc13_laog1.vgtest
trunk/drd/tests/tc15_laog_lockdel.vgtest
trunk/drd/tests/tc16_byterace.vgtest
trunk/drd/tests/tc17_sembar.vgtest
trunk/drd/tests/tc18_semabuse.vgtest
trunk/drd/tests/tc19_shadowmem.vgtest
trunk/drd/tests/tc20_verifywrap.vgtest
trunk/drd/tests/tc20_verifywrap2.vgtest
trunk/drd/tests/tc21_pthonce.vgtest
trunk/drd/tests/tc22_exit_w_lock.vgtest
trunk/drd/tests/tc23_bogus_condwait.vgtest
trunk/drd/tests/tc24_nonzero_sem.vgtest
trunk/exp-ptrcheck/tests/Makefile.am
trunk/helgrind/tests/Makefile.am
trunk/massif/tests/Makefile.am
trunk/memcheck/tests/Makefile.am
trunk/memcheck/tests/amd64/Makefile.am
trunk/memcheck/tests/linux/Makefile.am
trunk/memcheck/tests/linux/brk.c
trunk/memcheck/tests/linux/timerfd-syscall.c
trunk/memcheck/tests/x86-linux/Makefile.am
trunk/memcheck/tests/x86/Makefile.am
trunk/none/tests/Makefile.am
trunk/none/tests/amd64/Makefile.am
trunk/none/tests/linux/Makefile.am
trunk/none/tests/ppc32/Makefile.am
trunk/none/tests/ppc64/Makefile.am
trunk/none/tests/x86/Makefile.am
trunk/perf/Makefile.am
Added: trunk/Makefile.tool-tests.am
===================================================================
--- trunk/Makefile.tool-tests.am (rev 0)
+++ trunk/Makefile.tool-tests.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -0,0 +1,12 @@
+include $(top_srcdir)/Makefile.flags.am # For AM_FLAG_M3264_PRI
+
+AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include \
+ -I$(top_srcdir)/coregrind -I$(top_builddir)/include \
+ -I@VEX_DIR@/pub \
+ -DVGA_$(VGCONF_ARCH_PRI)=1 \
+ -DVGO_$(VGCONF_OS)=1 \
+ -DVGP_$(VGCONF_ARCH_PRI)_$(VGCONF_OS)=1
+AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
+AM_CXXFLAGS = $(AM_CFLAGS)
+
+
Modified: trunk/cachegrind/tests/Makefile.am
===================================================================
--- trunk/cachegrind/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/cachegrind/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,5 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
SUBDIRS = .
if VGCONF_ARCHS_INCLUDE_X86
@@ -21,11 +20,7 @@
check_PROGRAMS = \
chdir clreq dlclose myprint.so
-AM_CPPFLAGS = -I$(top_srcdir)/include
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-
# C ones
dlclose_LDADD = -ldl
-myprint_so_SOURCES = myprint.c
myprint_so_LDFLAGS = $(AM_FLAG_M3264_PRI) -shared -fPIC
-myprint_so_CFLAGS = $(AM_FLAG_M3264_PRI) -fPIC
+myprint_so_CFLAGS = $(AM_CFLAGS) -fPIC
Modified: trunk/callgrind/tests/Makefile.am
===================================================================
--- trunk/callgrind/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/callgrind/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,6 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
+
SUBDIRS = .
DIST_SUBDIRS = .
@@ -19,7 +19,4 @@
check_PROGRAMS = clreq simwork threads
-AM_CPPFLAGS = -I$(top_srcdir)/include
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-
threads_LDADD = -lpthread
Modified: trunk/drd/tests/Makefile.am
===================================================================
--- trunk/drd/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,6 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
+
SUBDIRS = .
DIST_SUBDIRS = .
@@ -193,24 +193,11 @@
trylock.stderr.exp \
trylock.vgtest
-AM_CFLAGS = $(WERROR) -Wall @FLAG_W_EXTRA@ -Wno-inline -Wno-unused-parameter\
- -g $(AM_FLAG_M3264_PRI) -DVGA_$(VGCONF_ARCH_PRI)=1 \
- -DVGO_$(VGCONF_OS)=1 -DVGP_$(VGCONF_ARCH_PRI)_$(VGCONF_OS)=1
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include \
- -I$(top_builddir)/include -I$(top_srcdir)/VEX/pub
-AM_CXXFLAGS = $(AM_CFLAGS)
-
check_PROGRAMS = \
atomic_var \
circular_buffer \
drd_bitmap_test \
fp_race \
- hg01_all_ok \
- hg02_deadlock \
- hg03_inherit \
- hg04_race \
- hg05_race2 \
- hg06_readshared \
hold_lock \
linuxthreads_det \
memory_allocation \
@@ -224,32 +211,8 @@
pth_detached_sem \
pth_inconsistent_cond_wait \
recursive_mutex \
- rwlock_race \
- rwlock_test \
sem_as_mutex \
sigalrm \
- tc01_simple_race \
- tc02_simple_tls \
- tc03_re_excl \
- tc04_free_lock \
- tc05_simple_race \
- tc06_two_races \
- tc07_hbl1 \
- tc08_hbl2 \
- tc09_bad_unlock \
- tc10_rec_lock \
- tc11_XCHG \
- tc12_rwl_trivial \
- tc13_laog1 \
- tc15_laog_lockdel \
- tc16_byterace \
- tc17_sembar \
- tc18_semabuse \
- tc19_shadowmem \
- tc21_pthonce \
- tc22_exit_w_lock \
- tc23_bogus_condwait \
- tc24_nonzero_sem \
trylock
if HAVE_BOOST_1_35
@@ -261,13 +224,9 @@
endif
if HAVE_PTHREAD_BARRIER
-check_PROGRAMS += bar_bad bar_trivial matinv pth_barrier pth_barrier_reinit
+check_PROGRAMS += matinv pth_barrier_reinit
endif
-if HAVE_PTHREAD_MUTEX_TIMEDLOCK
-check_PROGRAMS += tc20_verifywrap
-endif
-
if HAVE_PTHREAD_SPINLOCK
check_PROGRAMS += pth_spinlock
endif
@@ -277,156 +236,18 @@
endif
-atomic_var_SOURCES = atomic_var.c
-atomic_var_LDADD = -lpthread
+AM_CFLAGS += @FLAG_W_EXTRA@ -Wno-inline -Wno-unused-parameter
+LDADD = -lpthread
-circular_buffer_SOURCES = circular_buffer.c
-circular_buffer_LDADD = -lpthread
-drd_bitmap_test_SOURCES = drd_bitmap_test.c
drd_bitmap_test_CFLAGS = $(AM_CFLAGS) -O2 \
-DENABLE_DRD_CONSISTENCY_CHECKS\
@FLAG_UNLIMITED_INLINE_UNIT_GROWTH@
+drd_bitmap_test_LDADD = # nothing, ie. not -lpthread
-fp_race_SOURCES = fp_race.c
-fp_race_LDADD = -lpthread
-
-hg01_all_ok_SOURCES = ../../helgrind/tests/hg01_all_ok.c
-hg01_all_ok_LDADD = -lpthread
-
-hg02_deadlock_SOURCES = ../../helgrind/tests/hg02_deadlock.c
-hg02_deadlock_LDADD = -lpthread
-
-hg03_inherit_SOURCES = ../../helgrind/tests/hg03_inherit.c
-hg03_inherit_LDADD = -lpthread
-
-hg04_race_SOURCES = ../../helgrind/tests/hg04_race.c
-hg04_race_LDADD = -lpthread
-
-hg05_race2_SOURCES = ../../helgrind/tests/hg05_race2.c
-hg05_race2_LDADD = -lpthread
-
-hg06_readshared_SOURCES = ../../helgrind/tests/hg06_readshared.c
-hg06_readshared_LDADD = -lpthread
-
-hold_lock_SOURCES = hold_lock.c
-hold_lock_LDADD = -lpthread
-
-linuxthreads_det_SOURCES = linuxthreads_det.c
-linuxthreads_det_LDADD = -lpthread
-
-memory_allocation_SOURCES = memory_allocation.c
-
monitor_example_SOURCES = monitor_example.cpp
-monitor_example_LDADD = -lpthread
-
new_delete_SOURCES = new_delete.cpp
-pth_broadcast_SOURCES = pth_broadcast.c
-pth_broadcast_LDADD = -lpthread
-
-pth_cancel_locked_SOURCES = pth_cancel_locked.c
-pth_cancel_locked_LDADD = -lpthread
-
-pth_cond_race_SOURCES = pth_cond_race.c
-pth_cond_race_LDADD = -lpthread
-
-pth_create_chain_SOURCES = pth_create_chain.c
-pth_create_chain_LDADD = -lpthread
-
-pth_detached_SOURCES = pth_detached.c
-pth_detached_LDADD = -lpthread
-
-pth_detached_sem_SOURCES = pth_detached_sem.c
-pth_detached_sem_LDADD = -lpthread
-
-pth_inconsistent_cond_wait_SOURCES = pth_inconsistent_cond_wait.c
-pth_inconsistent_cond_wait_LDADD = -lpthread
-
-recursive_mutex_SOURCES = recursive_mutex.c
-recursive_mutex_LDADD = -lpthread
-
-rwlock_race_SOURCES = rwlock_race.c
-rwlock_race_LDADD = -lpthread
-
-rwlock_test_SOURCES = rwlock_test.c
-rwlock_test_LDADD = -lpthread
-
-sem_as_mutex_SOURCES = sem_as_mutex.c
-sem_as_mutex_LDADD = -lpthread
-
-sigalrm_SOURCES = sigalrm.c
-sigalrm_LDADD = -lpthread
-
-tc01_simple_race_SOURCES = ../../helgrind/tests/tc01_simple_race.c
-tc01_simple_race_LDADD = -lpthread
-
-tc02_simple_tls_SOURCES = ../../helgrind/tests/tc02_simple_tls.c
-tc02_simple_tls_LDADD = -lpthread
-
-tc03_re_excl_SOURCES = ../../helgrind/tests/tc03_re_excl.c
-tc03_re_excl_LDADD = -lpthread
-
-tc04_free_lock_SOURCES = ../../helgrind/tests/tc04_free_lock.c
-tc04_free_lock_LDADD = -lpthread
-
-tc05_simple_race_SOURCES = ../../helgrind/tests/tc05_simple_race.c
-tc05_simple_race_LDADD = -lpthread
-
-tc06_two_races_SOURCES = ../../helgrind/tests/tc06_two_races.c
-tc06_two_races_LDADD = -lpthread
-
-tc07_hbl1_SOURCES = ../../helgrind/tests/tc07_hbl1.c
-tc07_hbl1_LDADD = -lpthread
-
-tc08_hbl2_SOURCES = ../../helgrind/tests/tc08_hbl2.c
-tc08_hbl2_LDADD = -lpthread
-
-tc09_bad_unlock_SOURCES = ../../helgrind/tests/tc09_bad_unlock.c
-tc09_bad_unlock_LDADD = -lpthread
-
-tc10_rec_lock_SOURCES = ../../helgrind/tests/tc10_rec_lock.c
-tc10_rec_lock_LDADD = -lpthread
-
-tc11_XCHG_SOURCES = ../../helgrind/tests/tc11_XCHG.c
-tc11_XCHG_LDADD = -lpthread
-
-tc12_rwl_trivial_SOURCES = ../../helgrind/tests/tc12_rwl_trivial.c
-tc12_rwl_trivial_LDADD = -lpthread
-
-tc13_laog1_SOURCES = ../../helgrind/tests/tc13_laog1.c
-tc13_laog1_LDADD = -lpthread
-
-tc15_laog_lockdel_SOURCES = ../../helgrind/tests/tc15_laog_lockdel.c
-tc15_laog_lockdel_LDADD = -lpthread
-
-tc16_byterace_SOURCES = ../../helgrind/tests/tc16_byterace.c
-tc16_byterace_LDADD = -lpthread
-
-tc17_sembar_SOURCES = ../../helgrind/tests/tc17_sembar.c
-tc17_sembar_LDADD = -lpthread
-
-tc18_semabuse_SOURCES = ../../helgrind/tests/tc18_semabuse.c
-tc18_semabuse_LDADD = -lpthread
-
-tc19_shadowmem_SOURCES = ../../helgrind/tests/tc19_shadowmem.c
-tc19_shadowmem_LDADD = -lpthread
-
-tc21_pthonce_SOURCES = ../../helgrind/tests/tc21_pthonce.c
-tc21_pthonce_LDADD = -lpthread
-
-tc22_exit_w_lock_SOURCES = ../../helgrind/tests/tc22_exit_w_lock.c
-tc22_exit_w_lock_LDADD = -lpthread
-
-tc23_bogus_condwait_SOURCES = ../../helgrind/tests/tc23_bogus_condwait.c
-tc23_bogus_condwait_LDADD = -lpthread
-
-tc24_nonzero_sem_SOURCES = ../../helgrind/tests/tc24_nonzero_sem.c
-tc24_nonzero_sem_LDADD = -lpthread
-
-trylock_SOURCES = trylock.c
-trylock_LDADD = -lpthread
-
if HAVE_BOOST_1_35
boost_thread_SOURCES = boost_thread.cpp
boost_thread_CXXFLAGS = $(AM_CXXFLAGS) $(BOOST_CFLAGS)
@@ -434,59 +255,33 @@
endif
if HAVE_OPENMP
-omp_matinv_SOURCES = omp_matinv.c
omp_matinv_CFLAGS = $(AM_CFLAGS) -fopenmp
omp_matinv_LDFLAGS = -fopenmp
-omp_matinv_LDADD = -lm
+omp_matinv_LDADD = $(LDADD) -lm
-omp_prime_SOURCES = omp_prime.c
omp_prime_CFLAGS = $(AM_CFLAGS) -fopenmp
omp_prime_LDFLAGS = -fopenmp
-omp_prime_LDADD = -lm
+omp_prime_LDADD = $(LDADD) -lm
-omp_printf_SOURCES = omp_printf.c
omp_printf_CFLAGS = $(AM_CFLAGS) -fopenmp
omp_printf_LDFLAGS = -fopenmp
-omp_printf_LDADD = -lm
+omp_printf_LDADD = $(LDADD) -lm
endif
if HAVE_PTHREAD_BARRIER
-bar_bad_SOURCES = ../../helgrind/tests/bar_bad.c
-bar_bad_LDADD = -lpthread
-
-bar_trivial_SOURCES = ../../helgrind/tests/bar_trivial.c
-bar_trivial_LDADD = -lpthread
-
-matinv_SOURCES = matinv.c
-matinv_LDADD = -lpthread -lm
-
-pth_barrier_SOURCES = pth_barrier.c
-pth_barrier_LDADD = -lpthread
-
-pth_barrier_reinit_SOURCES = pth_barrier_reinit.c
-pth_barrier_reinit_LDADD = -lpthread
+matinv_LDADD = $(LDADD) -lm
endif
-if HAVE_PTHREAD_MUTEX_TIMEDLOCK
-tc20_verifywrap_SOURCES = ../../helgrind/tests/tc20_verifywrap.c
-tc20_verifywrap_LDADD = -lpthread
-endif
-
-if HAVE_PTHREAD_SPINLOCK
-pth_spinlock_SOURCES = pth_spinlock.c
-pth_spinlock_LDADD = -lpthread
-endif
-
if HAVE_QTCORE
qt4_mutex_SOURCES = qt4_mutex.cpp
qt4_mutex_CXXFLAGS = $(AM_CXXFLAGS) $(QTCORE_CFLAGS)
-qt4_mutex_LDADD = $(QTCORE_LIBS)
+qt4_mutex_LDADD = $(LDADD) $(QTCORE_LIBS)
qt4_rwlock_SOURCES = qt4_rwlock.cpp
qt4_rwlock_CXXFLAGS = $(AM_CXXFLAGS) $(QTCORE_CFLAGS)
-qt4_rwlock_LDADD = $(QTCORE_LIBS)
+qt4_rwlock_LDADD = $(LDADD) $(QTCORE_LIBS)
qt4_semaphore_SOURCES = qt4_semaphore.cpp
qt4_semaphore_CXXFLAGS = $(AM_CXXFLAGS) $(QTCORE_CFLAGS)
-qt4_semaphore_LDADD = $(QTCORE_LIBS)
+qt4_semaphore_LDADD = $(LDADD) $(QTCORE_LIBS)
endif
Modified: trunk/drd/tests/bar_bad.vgtest
===================================================================
--- trunk/drd/tests/bar_bad.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/bar_bad.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
-prereq: test -e bar_bad && ./supported_libpthread
-prog: bar_bad
+prereq: test -e ../../helgrind/tests/bar_bad && ./supported_libpthread
+prog: ../../helgrind/tests/bar_bad
vgopts: -q
Modified: trunk/drd/tests/bar_trivial.vgtest
===================================================================
--- trunk/drd/tests/bar_trivial.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/bar_trivial.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
-prereq: test -e bar_trivial && ./supported_libpthread
-prog: bar_trivial
+prereq: test -e ../../helgrind/tests/bar_trivial && ./supported_libpthread
+prog: ../../helgrind/tests/bar_trivial
vgopts: -q
Modified: trunk/drd/tests/hg01_all_ok.vgtest
===================================================================
--- trunk/drd/tests/hg01_all_ok.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/hg01_all_ok.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: hg01_all_ok
+prog: ../../helgrind/tests/hg01_all_ok
Modified: trunk/drd/tests/hg02_deadlock.vgtest
===================================================================
--- trunk/drd/tests/hg02_deadlock.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/hg02_deadlock.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: hg02_deadlock
+prog: ../../helgrind/tests/hg02_deadlock
Modified: trunk/drd/tests/hg03_inherit.vgtest
===================================================================
--- trunk/drd/tests/hg03_inherit.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/hg03_inherit.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --show-confl-seg=no --var-info=yes
-prog: hg03_inherit
+prog: ../../helgrind/tests/hg03_inherit
Modified: trunk/drd/tests/hg04_race.vgtest
===================================================================
--- trunk/drd/tests/hg04_race.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/hg04_race.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --var-info=yes
-prog: hg04_race
+prog: ../../helgrind/tests/hg04_race
Modified: trunk/drd/tests/hg05_race2.vgtest
===================================================================
--- trunk/drd/tests/hg05_race2.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/hg05_race2.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --var-info=yes --check-stack-var=yes
-prog: hg05_race2
+prog: ../../helgrind/tests/hg05_race2
Modified: trunk/drd/tests/hg06_readshared.vgtest
===================================================================
--- trunk/drd/tests/hg06_readshared.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/hg06_readshared.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: hg06_readshared
+prog: ../../helgrind/tests/hg06_readshared
Deleted: trunk/drd/tests/pth_barrier.c
===================================================================
--- trunk/drd/tests/pth_barrier.c 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/pth_barrier.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,110 +0,0 @@
-/* Test whether all data races are detected in a multithreaded program with
- * barriers.
- */
-
-
-#define _GNU_SOURCE
-
-/***********************/
-/* Include directives. */
-/***********************/
-
-#include <assert.h>
-#include <pthread.h>
-#include <stdio.h>
-#include <stdlib.h>
-
-
-/*********************/
-/* Type definitions. */
-/*********************/
-
-struct threadinfo
-{
- pthread_barrier_t* b;
- pthread_t tid;
- int* array;
- int iterations;
-};
-
-
-/********************/
-/* Local variables. */
-/********************/
-
-static int s_silent;
-
-
-/*************************/
-/* Function definitions. */
-/*************************/
-
-/** Single thread, which touches p->iterations elements of array p->array.
- * Each modification of an element of p->array is a data race. */
-static void* threadfunc(struct threadinfo* p)
-{
- int i;
- int* const array = p->array;
- pthread_barrier_t* const b = p->b;
- if (! s_silent)
- printf("thread %lx iteration 0\n", pthread_self());
- pthread_barrier_wait(b);
- for (i = 0; i < p->iterations; i++)
- {
- if (! s_silent)
- printf("thread %lx iteration %d; writing to %p\n",
- pthread_self(), i + 1, &array[i]);
- array[i] = i;
- pthread_barrier_wait(b);
- }
- return 0;
-}
-
-/** Actual test, consisting of nthread threads. */
-static void barriers_and_races(const int nthread, const int iterations)
-{
- int i;
- struct threadinfo* t;
- pthread_barrier_t b;
- int* array;
-
- t = malloc(nthread * sizeof(struct threadinfo));
- array = malloc(iterations * sizeof(array[0]));
-
- if (! s_silent)
- printf("&array[0] = %p\n", array);
-
- pthread_barrier_init(&b, 0, nthread);
-
- for (i = 0; i < nthread; i++)
- {
- t[i].b = &b;
- t[i].array = array;
- t[i].iterations = iterations;
- pthread_create(&t[i].tid, 0, (void*(*)(void*))threadfunc, &t[i]);
- }
-
- for (i = 0; i < nthread; i++)
- {
- pthread_join(t[i].tid, 0);
- }
-
- pthread_barrier_destroy(&b);
-
- free(array);
- free(t);
-}
-
-int main(int argc, char** argv)
-{
- int nthread;
- int iterations;
-
- nthread = (argc > 1) ? atoi(argv[1]) : 2;
- iterations = (argc > 2) ? atoi(argv[2]) : 3;
- s_silent = (argc > 3) ? atoi(argv[3]) : 0;
-
- barriers_and_races(nthread, iterations);
-
- return 0;
-}
Modified: trunk/drd/tests/pth_barrier.vgtest
===================================================================
--- trunk/drd/tests/pth_barrier.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/pth_barrier.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,4 +1,4 @@
-prereq: test -e pth_barrier && ./supported_libpthread
-prog: pth_barrier
+prereq: test -e ../../helgrind/tests/pth_barrier && ./supported_libpthread
+prog: ../../helgrind/tests/pth_barrier
args: 2 1 1
stderr_filter: filter_error_summary
Modified: trunk/drd/tests/pth_barrier2.vgtest
===================================================================
--- trunk/drd/tests/pth_barrier2.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/pth_barrier2.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,4 +1,4 @@
-prereq: test -e pth_barrier && ./supported_libpthread
-prog: pth_barrier
+prereq: test -e ../../helgrind/tests/pth_barrier && ./supported_libpthread
+prog: ../../helgrind/tests/pth_barrier
args: 2 32 1
stderr_filter: filter_error_summary
Modified: trunk/drd/tests/pth_barrier3.vgtest
===================================================================
--- trunk/drd/tests/pth_barrier3.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/pth_barrier3.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,4 +1,4 @@
-prereq: test -e pth_barrier && ./supported_libpthread
-prog: pth_barrier
+prereq: test -e ../../helgrind/tests/pth_barrier && ./supported_libpthread
+prog: ../../helgrind/tests/pth_barrier
args: 32 1 1
stderr_filter: filter_error_summary
Deleted: trunk/drd/tests/rwlock_race.c
===================================================================
--- trunk/drd/tests/rwlock_race.c 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/rwlock_race.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,56 +0,0 @@
-/** Cause a race inside code protected by a reader lock.
- */
-
-
-/* Needed for older glibc's (2.3 and older, at least) who don't
- otherwise "know" about pthread_rwlock_anything or about
- PTHREAD_MUTEX_RECURSIVE (amongst things). */
-
-#define _GNU_SOURCE 1
-
-#include <pthread.h>
-#include <stdio.h>
-#include <unistd.h>
-
-
-
-static pthread_rwlock_t s_rwlock;
-static int s_racy;
-
-static void sleep_ms(const int ms)
-{
- struct timespec delay = { ms / 1000, (ms % 1000) * 1000 * 1000 };
- nanosleep(&delay, 0);
-}
-
-static void* thread_func(void* arg)
-{
- pthread_rwlock_rdlock(&s_rwlock);
- s_racy++;
- pthread_rwlock_unlock(&s_rwlock);
- sleep_ms(100);
- return 0;
-}
-
-int main(int argc, char** argv)
-{
- pthread_t thread1;
- pthread_t thread2;
-
-#if 0
- int res;
- VALGRIND_DO_CLIENT_REQUEST(res, 0, VG_USERREQ__DRD_TRACE_ADDR,
- &s_racy, 0, 0, 0, 0);
-#endif
-
- pthread_rwlock_init(&s_rwlock, 0);
- pthread_create(&thread1, 0, thread_func, 0);
- pthread_create(&thread2, 0, thread_func, 0);
- pthread_join(thread1, 0);
- pthread_join(thread2, 0);
- pthread_rwlock_destroy(&s_rwlock);
-
- fprintf(stderr, "Result: %d\n", s_racy);
-
- return 0;
-}
Modified: trunk/drd/tests/rwlock_race.vgtest
===================================================================
--- trunk/drd/tests/rwlock_race.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/rwlock_race.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --var-info=yes
-prog: rwlock_race
+prog: ../../helgrind/tests/rwlock_race
Deleted: trunk/drd/tests/rwlock_test.c
===================================================================
--- trunk/drd/tests/rwlock_test.c 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/rwlock_test.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,52 +0,0 @@
-/** Multithreaded test program that triggers various access patterns without
- * triggering any race conditions.
- */
-
-
-#define _GNU_SOURCE 1
-
-#include <pthread.h>
-#include <stdio.h>
-
-
-static pthread_rwlock_t s_rwlock;
-static int s_counter;
-
-static void* thread_func(void* arg)
-{
- int i;
- int sum = 0;
-
- for (i = 0; i < 1000; i++)
- {
- pthread_rwlock_rdlock(&s_rwlock);
- sum += s_counter;
- pthread_rwlock_unlock(&s_rwlock);
- pthread_rwlock_wrlock(&s_rwlock);
- s_counter++;
- pthread_rwlock_unlock(&s_rwlock);
- }
-
- return 0;
-}
-
-int main(int argc, char** argv)
-{
- const int thread_count = 10;
- pthread_t tid[thread_count];
- int i;
-
- for (i = 0; i < thread_count; i++)
- {
- pthread_create(&tid[i], 0, thread_func, 0);
- }
-
- for (i = 0; i < thread_count; i++)
- {
- pthread_join(tid[i], 0);
- }
-
- fprintf(stderr, "Finished.\n");
-
- return 0;
-}
Modified: trunk/drd/tests/rwlock_test.stderr.exp
===================================================================
--- trunk/drd/tests/rwlock_test.stderr.exp 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/rwlock_test.stderr.exp 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1 +1,4 @@
-valgrind: ./rwlock_vgtest: No such file or directory
+
+Finished.
+
+ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Modified: trunk/drd/tests/rwlock_test.vgtest
===================================================================
--- trunk/drd/tests/rwlock_test.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/rwlock_test.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1 +1 @@
-prog: rwlock_vgtest
+prog: ../../helgrind/tests/rwlock_test
Modified: trunk/drd/tests/tc01_simple_race.vgtest
===================================================================
--- trunk/drd/tests/tc01_simple_race.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc01_simple_race.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --var-info=yes
-prog: tc01_simple_race
+prog: ../../helgrind/tests/tc01_simple_race
Modified: trunk/drd/tests/tc02_simple_tls.vgtest
===================================================================
--- trunk/drd/tests/tc02_simple_tls.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc02_simple_tls.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc02_simple_tls
+prog: ../../helgrind/tests/tc02_simple_tls
Modified: trunk/drd/tests/tc03_re_excl.vgtest
===================================================================
--- trunk/drd/tests/tc03_re_excl.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc03_re_excl.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc03_re_excl
+prog: ../../helgrind/tests/tc03_re_excl
Modified: trunk/drd/tests/tc04_free_lock.vgtest
===================================================================
--- trunk/drd/tests/tc04_free_lock.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc04_free_lock.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --check-stack-var=yes
-prog: tc04_free_lock
+prog: ../../helgrind/tests/tc04_free_lock
Modified: trunk/drd/tests/tc05_simple_race.vgtest
===================================================================
--- trunk/drd/tests/tc05_simple_race.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc05_simple_race.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
-prog: tc05_simple_race
+prog: ../../helgrind/tests/tc05_simple_race
stderr_filter: filter_error_summary
Modified: trunk/drd/tests/tc06_two_races.vgtest
===================================================================
--- trunk/drd/tests/tc06_two_races.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc06_two_races.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
-prog: tc06_two_races
+prog: ../../helgrind/tests/tc06_two_races
stderr_filter: filter_error_summary
Modified: trunk/drd/tests/tc07_hbl1.vgtest
===================================================================
--- trunk/drd/tests/tc07_hbl1.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc07_hbl1.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc07_hbl1
+prog: ../../helgrind/tests/tc07_hbl1
Modified: trunk/drd/tests/tc08_hbl2.vgtest
===================================================================
--- trunk/drd/tests/tc08_hbl2.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc08_hbl2.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc08_hbl2
+prog: ../../helgrind/tests/tc08_hbl2
Modified: trunk/drd/tests/tc09_bad_unlock.vgtest
===================================================================
--- trunk/drd/tests/tc09_bad_unlock.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc09_bad_unlock.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --check-stack-var=yes
-prog: tc09_bad_unlock
+prog: ../../helgrind/tests/tc09_bad_unlock
Modified: trunk/drd/tests/tc10_rec_lock.vgtest
===================================================================
--- trunk/drd/tests/tc10_rec_lock.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc10_rec_lock.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc10_rec_lock
+prog: ../../helgrind/tests/tc10_rec_lock
Modified: trunk/drd/tests/tc11_XCHG.vgtest
===================================================================
--- trunk/drd/tests/tc11_XCHG.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc11_XCHG.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc11_XCHG
+prog: ../../helgrind/tests/tc11_XCHG
Modified: trunk/drd/tests/tc12_rwl_trivial.vgtest
===================================================================
--- trunk/drd/tests/tc12_rwl_trivial.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc12_rwl_trivial.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc12_rwl_trivial
+prog: ../../helgrind/tests/tc12_rwl_trivial
Modified: trunk/drd/tests/tc13_laog1.vgtest
===================================================================
--- trunk/drd/tests/tc13_laog1.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc13_laog1.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc13_laog1
+prog: ../../helgrind/tests/tc13_laog1
Modified: trunk/drd/tests/tc15_laog_lockdel.vgtest
===================================================================
--- trunk/drd/tests/tc15_laog_lockdel.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc15_laog_lockdel.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc15_laog_lockdel
+prog: ../../helgrind/tests/tc15_laog_lockdel
Modified: trunk/drd/tests/tc16_byterace.vgtest
===================================================================
--- trunk/drd/tests/tc16_byterace.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc16_byterace.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --var-info=yes
-prog: tc16_byterace
+prog: ../../helgrind/tests/tc16_byterace
Modified: trunk/drd/tests/tc17_sembar.vgtest
===================================================================
--- trunk/drd/tests/tc17_sembar.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc17_sembar.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc17_sembar
+prog: ../../helgrind/tests/tc17_sembar
Modified: trunk/drd/tests/tc18_semabuse.vgtest
===================================================================
--- trunk/drd/tests/tc18_semabuse.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc18_semabuse.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc18_semabuse
+prog: ../../helgrind/tests/tc18_semabuse
Modified: trunk/drd/tests/tc19_shadowmem.vgtest
===================================================================
--- trunk/drd/tests/tc19_shadowmem.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc19_shadowmem.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
-prog: tc19_shadowmem
+prog: ../../helgrind/tests/tc19_shadowmem
vgopts: --cmp-race-err-addrs=yes --error-limit=no
Modified: trunk/drd/tests/tc20_verifywrap.vgtest
===================================================================
--- trunk/drd/tests/tc20_verifywrap.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc20_verifywrap.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
-prereq: test -e tc20_verifywrap && ./supported_libpthread
+prereq: test -e ../../helgrind/tests/tc20_verifywrap && ./supported_libpthread
vgopts: --var-info=yes --check-stack-var=yes
-prog: tc20_verifywrap
+prog: ../../helgrind/tests/tc20_verifywrap
Modified: trunk/drd/tests/tc20_verifywrap2.vgtest
===================================================================
--- trunk/drd/tests/tc20_verifywrap2.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc20_verifywrap2.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
vgopts: --trace-mutex=yes --trace-cond=yes --trace-semaphore=yes --var-info=yes --check-stack-var=yes
-prog: tc20_verifywrap
+prog: ../../helgrind/tests/tc20_verifywrap
Modified: trunk/drd/tests/tc21_pthonce.vgtest
===================================================================
--- trunk/drd/tests/tc21_pthonce.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc21_pthonce.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc21_pthonce
+prog: ../../helgrind/tests/tc21_pthonce
Modified: trunk/drd/tests/tc22_exit_w_lock.vgtest
===================================================================
--- trunk/drd/tests/tc22_exit_w_lock.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc22_exit_w_lock.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc22_exit_w_lock
+prog: ../../helgrind/tests/tc22_exit_w_lock
Modified: trunk/drd/tests/tc23_bogus_condwait.vgtest
===================================================================
--- trunk/drd/tests/tc23_bogus_condwait.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc23_bogus_condwait.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,2 +1,2 @@
prereq: ./supported_libpthread
-prog: tc23_bogus_condwait
+prog: ../../helgrind/tests/tc23_bogus_condwait
Modified: trunk/drd/tests/tc24_nonzero_sem.vgtest
===================================================================
--- trunk/drd/tests/tc24_nonzero_sem.vgtest 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/drd/tests/tc24_nonzero_sem.vgtest 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,3 @@
prereq: ./supported_libpthread
-prog: tc24_nonzero_sem
+prog: ../../helgrind/tests/tc24_nonzero_sem
vgopts: --hg-sanity-flags=111111
Modified: trunk/exp-ptrcheck/tests/Makefile.am
===================================================================
--- trunk/exp-ptrcheck/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/exp-ptrcheck/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,5 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
#SUBDIRS = .
#if VGCONF_ARCHS_INCLUDE_X86
@@ -76,57 +75,18 @@
stackerr \
strcpy strlen sub supp syscall tricky unaligned xor zero
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include \
- -I$(top_srcdir)/coregrind -I$(top_builddir)/include \
- -I@VEX_DIR@/pub
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-AM_CXXFLAGS = $(AM_CFLAGS)
-
# To make it a bit more realistic, build hackedbz2.c with at
# least some optimisation.
-hackedbz2_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
+hackedbz2_CFLAGS = $(AM_CFLAGS) -O
# C ones
-add_SOURCES = add.c
-and_SOURCES = and.c
-arith_SOURCES = arith.c
-bad_percentify_SOURCES = bad_percentify.c
-base_SOURCES = base.c
-cmp_SOURCES = cmp.c
-fp_SOURCES = fp.c
-globalerr_SOURCE = globalerr.c
-hackedbz2_SOURCES = hackedbz2.c
-hp_bounds_SOURCES = hp_bounds.c
-hp_dangle_SOURCES = hp_dangle.c
-idiv_SOURCES = idiv.c
-imul_SOURCES = imul.c
-justify_SOURCES = justify.c
-mm_SOURCES = mm.c
-neg_SOURCES = neg.c
-not_SOURCES = not.c
-or_SOURCES = or.c
-partial_SOURCES = partial.c
-pth_create_SOURCES = pth_create.c
pth_create_LDADD = -lpthread
-pth_specific_SOURCES = pth_specific.c
pth_specific_LDADD = -lpthread
-realloc_SOURCES = realloc.c
-stackerr_SOURCES = stackerr.c
-strcpy_SOURCES = strcpy.c
-strlen_SOURCES = strlen.c
-sub_SOURCES = sub.c
-supp_SOURCES = supp.c
-syscall_SOURCES = syscall.c
-tricky_SOURCES = tricky.c
-unaligned_SOURCES = unaligned.c
-xor_SOURCES = xor.c
-zero_SOURCES = zero.c
# C++ ones
ccc_SOURCES = ccc.cpp
# Build shared object for preen_invars
-preen_invars_SOURCES = preen_invars.c
preen_invars_DEPENDENCIES = preen_invars_so.so
if VGCONF_PLATFORMS_INCLUDE_PPC64_AIX5
preen_invars_LDADD = -ldl
@@ -142,10 +102,7 @@
endif
endif
-preen_invars_so_so_SOURCES = preen_invars_so.c
-preen_invars_so_so_LDADD =
-preen_invars_so_so_DEPENDENCIES =
-preen_invars_so_so_CFLAGS = -fpic $(AM_FLAG_M3264_PRI) -g
+preen_invars_so_so_CFLAGS = $(AM_CFLAGS) -fpic
if VGCONF_PLATFORMS_INCLUDE_PPC64_AIX5
preen_invars_so_so_LDFLAGS = -fpic $(AM_FLAG_M3264_PRI) -shared
else
Modified: trunk/helgrind/tests/Makefile.am
===================================================================
--- trunk/helgrind/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/helgrind/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,5 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
noinst_SCRIPTS = filter_stderr
@@ -159,15 +158,5 @@
endif
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include \
- -I$(top_srcdir)/coregrind -I$(top_builddir)/include \
- -I@VEX_DIR@/pub
+LDADD = -lpthread
-# are these necessary?
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-LDADD = -lpthread
-
-# only needed because of referencing sources in drd/tests
-pth_barrier_SOURCES = ../../drd/tests/pth_barrier.c
-rwlock_race_SOURCES = ../../drd/tests/rwlock_race.c
-rwlock_test_SOURCES = ../../drd/tests/rwlock_test.c
Copied: trunk/helgrind/tests/pth_barrier.c (from rev 9200, trunk/drd/tests/pth_barrier.c)
===================================================================
--- trunk/helgrind/tests/pth_barrier.c (rev 0)
+++ trunk/helgrind/tests/pth_barrier.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -0,0 +1,110 @@
+/* Test whether all data races are detected in a multithreaded program with
+ * barriers.
+ */
+
+
+#define _GNU_SOURCE
+
+/***********************/
+/* Include directives. */
+/***********************/
+
+#include <assert.h>
+#include <pthread.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+
+/*********************/
+/* Type definitions. */
+/*********************/
+
+struct threadinfo
+{
+ pthread_barrier_t* b;
+ pthread_t tid;
+ int* array;
+ int iterations;
+};
+
+
+/********************/
+/* Local variables. */
+/********************/
+
+static int s_silent;
+
+
+/*************************/
+/* Function definitions. */
+/*************************/
+
+/** Single thread, which touches p->iterations elements of array p->array.
+ * Each modification of an element of p->array is a data race. */
+static void* threadfunc(struct threadinfo* p)
+{
+ int i;
+ int* const array = p->array;
+ pthread_barrier_t* const b = p->b;
+ if (! s_silent)
+ printf("thread %lx iteration 0\n", pthread_self());
+ pthread_barrier_wait(b);
+ for (i = 0; i < p->iterations; i++)
+ {
+ if (! s_silent)
+ printf("thread %lx iteration %d; writing to %p\n",
+ pthread_self(), i + 1, &array[i]);
+ array[i] = i;
+ pthread_barrier_wait(b);
+ }
+ return 0;
+}
+
+/** Actual test, consisting of nthread threads. */
+static void barriers_and_races(const int nthread, const int iterations)
+{
+ int i;
+ struct threadinfo* t;
+ pthread_barrier_t b;
+ int* array;
+
+ t = malloc(nthread * sizeof(struct threadinfo));
+ array = malloc(iterations * sizeof(array[0]));
+
+ if (! s_silent)
+ printf("&array[0] = %p\n", array);
+
+ pthread_barrier_init(&b, 0, nthread);
+
+ for (i = 0; i < nthread; i++)
+ {
+ t[i].b = &b;
+ t[i].array = array;
+ t[i].iterations = iterations;
+ pthread_create(&t[i].tid, 0, (void*(*)(void*))threadfunc, &t[i]);
+ }
+
+ for (i = 0; i < nthread; i++)
+ {
+ pthread_join(t[i].tid, 0);
+ }
+
+ pthread_barrier_destroy(&b);
+
+ free(array);
+ free(t);
+}
+
+int main(int argc, char** argv)
+{
+ int nthread;
+ int iterations;
+
+ nthread = (argc > 1) ? atoi(argv[1]) : 2;
+ iterations = (argc > 2) ? atoi(argv[2]) : 3;
+ s_silent = (argc > 3) ? atoi(argv[3]) : 0;
+
+ barriers_and_races(nthread, iterations);
+
+ return 0;
+}
Property changes on: trunk/helgrind/tests/pth_barrier.c
___________________________________________________________________
Name: svn:mergeinfo
+
Copied: trunk/helgrind/tests/rwlock_race.c (from rev 9200, trunk/drd/tests/rwlock_race.c)
===================================================================
--- trunk/helgrind/tests/rwlock_race.c (rev 0)
+++ trunk/helgrind/tests/rwlock_race.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -0,0 +1,56 @@
+/** Cause a race inside code protected by a reader lock.
+ */
+
+
+/* Needed for older glibc's (2.3 and older, at least) who don't
+ otherwise "know" about pthread_rwlock_anything or about
+ PTHREAD_MUTEX_RECURSIVE (amongst things). */
+
+#define _GNU_SOURCE 1
+
+#include <pthread.h>
+#include <stdio.h>
+#include <unistd.h>
+
+
+
+static pthread_rwlock_t s_rwlock;
+static int s_racy;
+
+static void sleep_ms(const int ms)
+{
+ struct timespec delay = { ms / 1000, (ms % 1000) * 1000 * 1000 };
+ nanosleep(&delay, 0);
+}
+
+static void* thread_func(void* arg)
+{
+ pthread_rwlock_rdlock(&s_rwlock);
+ s_racy++;
+ pthread_rwlock_unlock(&s_rwlock);
+ sleep_ms(100);
+ return 0;
+}
+
+int main(int argc, char** argv)
+{
+ pthread_t thread1;
+ pthread_t thread2;
+
+#if 0
+ int res;
+ VALGRIND_DO_CLIENT_REQUEST(res, 0, VG_USERREQ__DRD_TRACE_ADDR,
+ &s_racy, 0, 0, 0, 0);
+#endif
+
+ pthread_rwlock_init(&s_rwlock, 0);
+ pthread_create(&thread1, 0, thread_func, 0);
+ pthread_create(&thread2, 0, thread_func, 0);
+ pthread_join(thread1, 0);
+ pthread_join(thread2, 0);
+ pthread_rwlock_destroy(&s_rwlock);
+
+ fprintf(stderr, "Result: %d\n", s_racy);
+
+ return 0;
+}
Property changes on: trunk/helgrind/tests/rwlock_race.c
___________________________________________________________________
Name: svn:mergeinfo
+
Copied: trunk/helgrind/tests/rwlock_test.c (from rev 9200, trunk/drd/tests/rwlock_test.c)
===================================================================
--- trunk/helgrind/tests/rwlock_test.c (rev 0)
+++ trunk/helgrind/tests/rwlock_test.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -0,0 +1,52 @@
+/** Multithreaded test program that triggers various access patterns without
+ * triggering any race conditions.
+ */
+
+
+#define _GNU_SOURCE 1
+
+#include <pthread.h>
+#include <stdio.h>
+
+
+static pthread_rwlock_t s_rwlock;
+static int s_counter;
+
+static void* thread_func(void* arg)
+{
+ int i;
+ int sum = 0;
+
+ for (i = 0; i < 1000; i++)
+ {
+ pthread_rwlock_rdlock(&s_rwlock);
+ sum += s_counter;
+ pthread_rwlock_unlock(&s_rwlock);
+ pthread_rwlock_wrlock(&s_rwlock);
+ s_counter++;
+ pthread_rwlock_unlock(&s_rwlock);
+ }
+
+ return 0;
+}
+
+int main(int argc, char** argv)
+{
+ const int thread_count = 10;
+ pthread_t tid[thread_count];
+ int i;
+
+ for (i = 0; i < thread_count; i++)
+ {
+ pthread_create(&tid[i], 0, thread_func, 0);
+ }
+
+ for (i = 0; i < thread_count; i++)
+ {
+ pthread_join(tid[i], 0);
+ }
+
+ fprintf(stderr, "Finished.\n");
+
+ return 0;
+}
Property changes on: trunk/helgrind/tests/rwlock_test.c
___________________________________________________________________
Name: svn:mergeinfo
+
Modified: trunk/massif/tests/Makefile.am
===================================================================
--- trunk/massif/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/massif/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,5 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
noinst_SCRIPTS = filter_stderr filter_verbose
@@ -41,12 +40,6 @@
zero1.post.exp zero1.stderr.exp zero1.vgtest \
zero2.post.exp zero2.stderr.exp zero2.vgtest
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include \
- -I$(top_srcdir)/coregrind -I$(top_builddir)/include \
- -I@VEX_DIR@/pub
-
check_PROGRAMS = \
alloc-fns \
basic \
Modified: trunk/memcheck/tests/Makefile.am
===================================================================
--- trunk/memcheck/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,5 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
SUBDIRS = .
@@ -190,7 +189,7 @@
describe-block \
doublefree error_counts errs1 exitprog execve execve2 erringfds \
file_locking \
- fprw fwrite hello inits inline \
+ fprw fwrite inits inline \
leak-0 leak-cycle leak-pool leak-tree leak-regroot leakotron \
linux-syslog-syscall \
linux-syscalls-2007 \
@@ -226,23 +225,13 @@
writev zeropage
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include \
- -I$(top_srcdir)/coregrind -I$(top_builddir)/include \
- -I@VEX_DIR@/pub
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-AM_CXXFLAGS = $(AM_CFLAGS)
-
# Extra stuff for C tests
-memcmptest_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -fno-builtin-memcmp
-oset_test_CFLAGS = $(AM_FLAG_M3264_PRI) \
- -DVGA_$(VGCONF_ARCH_PRI)=1 \
- -DVGO_$(VGCONF_OS)=1 \
- -DVGP_$(VGCONF_ARCH_PRI)_$(VGCONF_OS)=1
-vcpu_bz2_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O2 -g
-vcpu_fbench_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O2 -g
-vcpu_fnfns_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O2 -g
+memcmptest_CFLAGS = $(AM_CFLAGS) -fno-builtin-memcmp
+vcpu_bz2_CFLAGS = $(AM_CFLAGS) -O2
+vcpu_fbench_CFLAGS = $(AM_CFLAGS) -O2
+vcpu_fnfns_CFLAGS = $(AM_CFLAGS) -O2
vcpu_fnfns_LDADD = -lm
-wrap6_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O2 -g
+wrap6_CFLAGS = $(AM_CFLAGS) -O2
# Don't allow GCC to inline memcpy(), because then we can't intercept it
overlap_CFLAGS = $(AM_CFLAGS) -fno-builtin-memcpy
@@ -252,17 +241,17 @@
supp2_SOURCES = supp.c
# To make it a bit more realistic, have some optimisation enabled
# for the varinfo tests. We still expect sane results.
-varinfo1_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-varinfo2_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g -Wno-shadow
-varinfo3_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-varinfo4_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-varinfo5_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-varinfo6_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-# This requires optimisation in order to get just one resulting error
-origin4_many_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-# Apply -O so as to run in reasonable time
-origin5_bz2_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
-origin6_fp_CFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -g
+varinfo1_CFLAGS = $(AM_CFLAGS) -O
+varinfo2_CFLAGS = $(AM_CFLAGS) -O -Wno-shadow
+varinfo3_CFLAGS = $(AM_CFLAGS) -O
+varinfo4_CFLAGS = $(AM_CFLAGS) -O
+varinfo5_CFLAGS = $(AM_CFLAGS) -O
+varinfo6_CFLAGS = $(AM_CFLAGS) -O
+# This requires optimisation in order to get just one resulting error.
+origin4_many_CFLAGS = $(AM_CFLAGS) -O
+# Apply -O so as to run in reasonable time.
+origin5_bz2_CFLAGS = $(AM_CFLAGS) -O
+origin6_fp_CFLAGS = $(AM_CFLAGS) -O
# C++ tests
mismatches_SOURCES = mismatches.cpp
@@ -270,7 +259,7 @@
new_override_SOURCES = new_override.cpp
deep_templates_SOURCES = deep_templates.cpp
long_namespace_xml_SOURCES = long_namespace_xml.cpp
-deep_templates_CXXFLAGS = $(AM_FLAG_M3264_PRI) $(AM_CFLAGS) -O -gstabs
+deep_templates_CXXFLAGS = $(AM_CFLAGS) -O -gstabs
if VGCONF_PLATFORMS_INCLUDE_PPC32_AIX5
if VGCONF_PLATFORMS_INCLUDE_PPC64_AIX5
@@ -279,13 +268,13 @@
# function descriptors. Unfortunately -Wl,-G -Wl,-bnogc
# produces a link error on 64-bit AIX, hence only 32-bit
# gets these flags.
- wrap1_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
- wrap2_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
- wrap3_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
- wrap4_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
- wrap5_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
- wrap6_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
- wrap8_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap1_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap2_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap3_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap4_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap5_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap6_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
+ wrap8_LDFLAGS = $(AM_FLAG_M3264_PRI) -Wl,-G -Wl,-bnogc
endif
endif
@@ -309,7 +298,7 @@
wrap7so_so_SOURCES = wrap7so.c
wrap7so_so_LDADD =
wrap7so_so_DEPENDENCIES =
-wrap7so_so_CFLAGS = -fpic $(AM_FLAG_M3264_PRI)
+wrap7so_so_CFLAGS = $(AM_CFLAGS) -fpic
if VGCONF_PLATFORMS_INCLUDE_PPC64_AIX5
wrap7so_so_LDFLAGS = -fpic $(AM_FLAG_M3264_PRI) -shared
else
@@ -342,7 +331,7 @@
varinfo5so_so_SOURCES = varinfo5so.c
varinfo5so_so_LDADD =
varinfo5so_so_DEPENDENCIES =
-varinfo5so_so_CFLAGS = -fpic $(AM_FLAG_M3264_PRI) -g -O
+varinfo5so_so_CFLAGS = $(AM_CFLAGS) -fpic -O
if VGCONF_PLATFORMS_INCLUDE_PPC64_AIX5
varinfo5so_so_LDFLAGS = -fpic $(AM_FLAG_M3264_PRI) -shared
else
@@ -355,8 +344,3 @@
endif
endif
-# Valgrind unit self-tests
-#hello_LDFLAGS = -Wl,-defsym,valt_load_address=0x50000000 \
-# -Wl,-T,$(top_builddir)/valt_load_address.lds
-#hello_DEPENDENCIES = $(top_builddir)/valt_load_address.lds
-
Modified: trunk/memcheck/tests/amd64/Makefile.am
===================================================================
--- trunk/memcheck/tests/amd64/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/amd64/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,6 @@
+
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_stderr
noinst_HEADERS =
@@ -23,10 +26,9 @@
int3-amd64 \
more_x87_fp sse_memory xor-undef-amd64
-AM_CPPFLAGS = -I$(top_srcdir)/include
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g -I$(top_srcdir)/include
- @FLAG_M64@
-AM_CXXFLAGS = $(AM_CFLAGS)
+AM_CFLAGS += @FLAG_M64@
+AM_CXXFLAGS += @FLAG_M64@
+AM_CCASFLAGS = @FLAG_M64@
more_x87_fp_CFLAGS = $(AM_CFLAGS) -O -ffast-math -mfpmath=387 \
-mfancy-math-387
Deleted: trunk/memcheck/tests/hello.c
===================================================================
--- trunk/memcheck/tests/hello.c 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/hello.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,9 +0,0 @@
-
-#include <stdio.h>
-
-int main(void)
-{
- fprintf(stderr, "Hello, world!\n");
- return 0;
-}
-
Modified: trunk/memcheck/tests/linux/Makefile.am
===================================================================
--- trunk/memcheck/tests/linux/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/linux/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,6 @@
+
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_stderr
EXTRA_DIST = $(noinst_SCRIPTS) \
@@ -12,10 +15,5 @@
stack_switch \
timerfd-syscall
-AM_CPPFLAGS = -I$(top_srcdir)/include
-AM_CFLAGS = $(WERROR) $(AM_FLAG_M3264_PRI) -Winline -Wall -Wshadow -g \
- $(FLAG_MMMX) $(FLAG_MSSE)
-AM_CXXFLAGS = $(AM_CFLAGS)
-
stack_switch_LDADD = -lpthread
timerfd_syscall_LDADD = -lrt
Modified: trunk/memcheck/tests/linux/brk.c
===================================================================
--- trunk/memcheck/tests/linux/brk.c 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/linux/brk.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,8 +1,6 @@
#include <assert.h>
#include <stdio.h>
-#if !defined(_AIX)
-# include <sys/syscall.h>
-#endif
+#include <sys/syscall.h>
#include <sys/types.h>
#include <unistd.h>
@@ -29,9 +27,7 @@
vals[8] = EOL;
for (i = 0; EOL != vals[i]; i++) {
-# if !defined(_AIX)
res = (void*)syscall(__NR_brk, vals[i]);
-# endif
}
assert( 0 == brk(orig_ds) ); // libc brk()
Modified: trunk/memcheck/tests/linux/timerfd-syscall.c
===================================================================
--- trunk/memcheck/tests/linux/timerfd-syscall.c 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/linux/timerfd-syscall.c 2009-02-19 09:52:05 UTC (rev 9202)
@@ -24,8 +24,6 @@
* See also http://www.xmailserver.org/timerfd-test2.c
*/
-#if defined(__linux__)
-
#define _GNU_SOURCE
#include "../../../config.h"
@@ -297,14 +295,3 @@
return 0;
}
-
-#endif /* __linux__ */
-
-#if defined(_AIX)
-#include <stdio.h>
-int main(int ac, char **av)
-{
- fprintf(stderr, "This test does not work on AIX5.\n");
- return 0;
-}
-#endif /* _AIX */
Modified: trunk/memcheck/tests/x86/Makefile.am
===================================================================
--- trunk/memcheck/tests/x86/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/x86/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,6 @@
+
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_stderr filter_pushfpopf filter_tronical
INSN_TESTS = insn_basic insn_fpu insn_cmov insn_mmx insn_mmxext insn_sse insn_sse2
@@ -34,11 +37,9 @@
pushpopmem sse_memory tronical \
more_x86_fp fprem xor-undef-x86
-AM_CPPFLAGS = -I$(top_srcdir)/include
-AM_CFLAGS = $(WERROR) @FLAG_M32@ -Winline -Wall -Wshadow -g \
- $(FLAG_MMMX) $(FLAG_MSSE)
-AM_CXXFLAGS = $(AM_CFLAGS)
-AM_CCASFLAGS = @FLAG_M32@
+AM_CFLAGS += @FLAG_M32@ $(FLAG_MMMX) $(FLAG_MSSE)
+AM_CXXFLAGS += @FLAG_M32@ $(FLAG_MMMX) $(FLAG_MSSE)
+AM_CCASFLAGS = @FLAG_M32@
# must be built with these flags -- bug only occurred with them
fpeflags_CFLAGS = $(AM_CFLAGS) -march=i686
Modified: trunk/memcheck/tests/x86-linux/Makefile.am
===================================================================
--- trunk/memcheck/tests/x86-linux/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/memcheck/tests/x86-linux/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,6 @@
+
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_stderr
noinst_HEADERS = scalar.h
@@ -14,8 +17,7 @@
check_PROGRAMS = \
scalar scalar_exit_group scalar_fork scalar_supp scalar_vfork
-AM_CPPFLAGS = -I$(top_srcdir)/include
-AM_CFLAGS = $(WERROR) @FLAG_M32@ -Winline -Wall -Wshadow -g \
- $(FLAG_MMMX) $(FLAG_MSSE)
-AM_CXXFLAGS = $(AM_CFLAGS)
-AM_CCASFLAGS = @FLAG_M32@
+AM_CFLAGS += @FLAG_M32@ $(FLAG_MMMX) $(FLAG_MSSE)
+AM_CXXFLAGS += @FLAG_M32@ $(FLAG_MMMX) $(FLAG_MSSE)
+AM_CCASFLAGS = @FLAG_M32@
+
Modified: trunk/none/tests/Makefile.am
===================================================================
--- trunk/none/tests/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/none/tests/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,6 +1,5 @@
-# For AM_FLAG_M3264_PRI
-include $(top_srcdir)/Makefile.flags.am
+include $(top_srcdir)/Makefile.tool-tests.am
SUBDIRS = .
@@ -150,18 +149,14 @@
tls tls.so tls2.so vgprintf \
coolo_sigaction gxx304
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include -I$(top_builddir)/include
-AM_CXXFLAGS = $(AM_CFLAGS)
-
# Extra stuff for C tests
-ansi_CFLAGS = $(AM_FLAG_M3264_PRI) -ansi
+ansi_CFLAGS = $(AM_CFLAGS) -ansi
floored_LDADD = -lm
manythreads_LDADD = -lpthread
mq_LDADD = -lrt
pth_atfork1_LDADD = -lpthread
pth_blockedsig_LDADD = -lpthread
-pth_cancel1_CFLAGS = $(AM_FLAG_M3264_PRI) -Wno-shadow
+pth_cancel1_CFLAGS = $(AM_CFLAGS) -Wno-shadow
pth_cancel1_LDADD = -lpthread
pth_cancel2_LDADD = -lpthread
pth_cvsimple_LDADD = -lpthread
@@ -199,7 +194,7 @@
tls_so_LDFLAGS = -Wl,-rpath,$(top_builddir)/none/tests -shared -fPIC
tls_so_LDADD = tls2.so
endif
-tls_so_CFLAGS = $(AM_FLAG_M3264_PRI) -fPIC
+tls_so_CFLAGS = $(AM_CFLAGS) -fPIC
tls2_so_SOURCES = tls2_so.c
tls2_so_LDFLAGS = -shared
Modified: trunk/none/tests/amd64/Makefile.am
===================================================================
--- trunk/none/tests/amd64/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/none/tests/amd64/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,4 +1,6 @@
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_cpuid filter_stderr filter_int gen_insn_test.pl
CLEANFILES = $(addsuffix .c,$(INSN_TESTS))
@@ -61,9 +63,9 @@
check_PROGRAMS += ssse3_misaligned
endif
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g -I$(top_srcdir)/include
- @FLAG_M64@
-AM_CXXFLAGS = $(AM_CFLAGS)
+AM_CFLAGS += @FLAG_M64@
+AM_CXXFLAGS += @FLAG_M64@
+AM_CCASFLAGS = @FLAG_M64@
# generic C ones
bug132918_LDADD = -lm
Modified: trunk/none/tests/linux/Makefile.am
===================================================================
--- trunk/none/tests/linux/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/none/tests/linux/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,3 +1,6 @@
+
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_stderr
EXTRA_DIST = $(noinst_SCRIPTS) \
@@ -9,6 +12,3 @@
mremap \
mremap2
-AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/include -I$(top_builddir)/include
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g $(AM_FLAG_M3264_PRI)
-AM_CXXFLAGS = $(AM_CFLAGS)
Modified: trunk/none/tests/ppc32/Makefile.am
===================================================================
--- trunk/none/tests/ppc32/Makefile.am 2009-02-19 04:05:41 UTC (rev 9201)
+++ trunk/none/tests/ppc32/Makefile.am 2009-02-19 09:52:05 UTC (rev 9202)
@@ -1,4 +1,6 @@
+include $(top_srcdir)/Makefile.tool-tests.am
+
noinst_SCRIPTS = filter_stderr
EXTRA_DIST = $(noinst_SCRIPTS) \
@@ -27,9 +29,9 @@
ldstrev lsw jm-insns mftocrf mcrfs round test_fx test_gx \
testVMX twi tw xlc_dbl_u32
-AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g -I$(top_srcdir)/include \
- @FLAG_M32@
-AM_CXXFLAGS = $(AM_...
[truncated message content] |
|
From: <sv...@va...> - 2009-02-19 04:06:01
|
Author: njn
Date: 2009-02-19 04:05:41 +0000 (Thu, 19 Feb 2009)
New Revision: 9201
Log:
Fix an incorrect conditional which meant that barrier intercepts weren't
being compiled. This fixes two Helgrind regtests.
Compile PIC modules with -O again. This fixes two more Helgrind regtests;
it's unfortunate that they are sensitive to minor differences like this.
With these changes, Linux functionality is fully restored on the DARWIN
branch -- I get 1 regtest failure, the same as I get for the trunk.
Modified:
branches/DARWIN/Makefile.flags.am
branches/DARWIN/helgrind/hg_intercepts.c
Modified: branches/DARWIN/Makefile.flags.am
===================================================================
--- branches/DARWIN/Makefile.flags.am 2009-02-18 09:26:04 UTC (rev 9200)
+++ branches/DARWIN/Makefile.flags.am 2009-02-19 04:05:41 UTC (rev 9201)
@@ -16,7 +16,7 @@
AM_PIC_FLAG = -fpic
endif
-AM_CFLAGS_PIC = $(AM_PIC_FLAG) -g -fno-omit-frame-pointer -fno-strict-aliasing
+AM_CFLAGS_PIC = $(AM_PIC_FLAG) -O -g -fno-omit-frame-pointer -fno-strict-aliasing
# Flags for specific targets.
# Nb: the AM_CPPFLAGS_* values are suitable for building tools and auxprogs.
Modified: branches/DARWIN/helgrind/hg_intercepts.c
===================================================================
--- branches/DARWIN/helgrind/hg_intercepts.c 2009-02-18 09:26:04 UTC (rev 9200)
+++ branches/DARWIN/helgrind/hg_intercepts.c 2009-02-19 04:05:41 UTC (rev 9201)
@@ -756,7 +756,7 @@
/*--- pthread_barrier_t functions ---*/
/*----------------------------------------------------------------*/
-#if defined(HAVE_PTHREAD_BARRIER)
+#if defined(HAVE_PTHREAD_BARRIER_INIT)
/* Handled: pthread_barrier_init
pthread_barrier_wait
@@ -863,7 +863,7 @@
return ret;
}
-#endif // defined(HAVE_PTHREAD_BARRIER)
+#endif // defined(HAVE_PTHREAD_BARRIER_INIT)
/*----------------------------------------------------------------*/
/*--- pthread_rwlock_t functions ---*/
|
|
From: Tom H. <th...@cy...> - 2009-02-19 03:47:49
|
Nightly build on vauxhall ( x86_64, Fedora 10 ) started at 2009-02-19 03:20:05 GMT
Results differ from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ... failed
Regression test results follow
== 487 tests, 0 stderr failures, 1 stdout failure, 0 post failures ==
drd/tests/pth_detached_sem (stdout)
=================================================
== Results from 24 hours ago ==
=================================================
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ... done
Regression test results follow
== 487 tests, 0 stderr failures, 0 stdout failures, 0 post failures ==
=================================================
== Difference between 24 hours ago and now ==
=================================================
*** old.short Thu Feb 19 03:33:57 2009
--- new.short Thu Feb 19 03:47:41 2009
***************
*** 4,6 ****
Building valgrind ... done
! Running regression tests ... done
--- 4,6 ----
Building valgrind ... done
! Running regression tests ... failed
***************
*** 8,10 ****
! == 487 tests, 0 stderr failures, 0 stdout failures, 0 post failures ==
--- 8,11 ----
! == 487 tests, 0 stderr failures, 1 stdout failure, 0 post failures ==
! drd/tests/pth_detached_sem (stdout)
|
|
From: Tom H. <th...@cy...> - 2009-02-19 03:44:21
|
Nightly build on lloyd ( x86_64, Fedora 7 ) started at 2009-02-19 03:05:05 GMT Results unchanged from 24 hours ago Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... failed Regression test results follow == 478 tests, 5 stderr failures, 0 stdout failures, 0 post failures == exp-ptrcheck/tests/ccc (stderr) exp-ptrcheck/tests/preen_invars (stderr) exp-ptrcheck/tests/pth_create (stderr) exp-ptrcheck/tests/pth_specific (stderr) helgrind/tests/tc20_verifywrap (stderr) |
|
From: Tom H. <th...@cy...> - 2009-02-19 03:32:09
|
Nightly build on mg ( x86_64, Fedora 9 ) started at 2009-02-19 03:10:04 GMT Results differ from 24 hours ago Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... failed Regression test results follow == 484 tests, 4 stderr failures, 3 stdout failures, 0 post failures == exp-ptrcheck/tests/ccc (stderr) exp-ptrcheck/tests/preen_invars (stderr) exp-ptrcheck/tests/pth_create (stderr) exp-ptrcheck/tests/pth_specific (stderr) memcheck/tests/linux/timerfd-syscall (stdout) none/tests/linux/mremap2 (stdout) none/tests/pth_cvsimple (stdout) ================================================= == Results from 24 hours ago == ================================================= Checking out valgrind source tree ... done Configuring valgrind ... done Building valgrind ... done Running regression tests ... failed Regression test results follow == 484 tests, 4 stderr failures, 2 stdout failures, 0 post failures == exp-ptrcheck/tests/ccc (stderr) exp-ptrcheck/tests/preen_invars (stderr) exp-ptrcheck/tests/pth_create (stderr) exp-ptrcheck/tests/pth_specific (stderr) memcheck/tests/linux/timerfd-syscall (stdout) none/tests/linux/mremap2 (stdout) ================================================= == Difference between 24 hours ago and now == ================================================= *** old.short Thu Feb 19 03:21:05 2009 --- new.short Thu Feb 19 03:31:55 2009 *************** *** 8,10 **** ! == 484 tests, 4 stderr failures, 2 stdout failures, 0 post failures == exp-ptrcheck/tests/ccc (stderr) --- 8,10 ---- ! == 484 tests, 4 stderr failures, 3 stdout failures, 0 post failures == exp-ptrcheck/tests/ccc (stderr) *************** *** 15,16 **** --- 15,17 ---- none/tests/linux/mremap2 (stdout) + none/tests/pth_cvsimple (stdout) |
|
From: Bill H. <bil...@ki...> - 2009-02-19 00:57:16
|
Julian Seward wrote: > > I am generally in favour of this functionality -- I think it would be > useful -- providing that a suitably robust and general implementation > can be arrived at. > Attached is a new version of the patch that is more robust and contains the requested documentation. It separates out each , string before doing the compare. -Bill |
|
From: Nicholas N. <n.n...@gm...> - 2009-02-19 00:22:17
|
This is interesting: http://overholt.ca/wp/?p=117 I particularly like the Massif integration, that's a significant improvement over the text output. N |