You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
1
(15) |
2
(12) |
3
(11) |
4
(20) |
5
(6) |
|
6
(6) |
7
(7) |
8
(8) |
9
(17) |
10
(25) |
11
(27) |
12
(6) |
|
13
(28) |
14
(16) |
15
(20) |
16
(9) |
17
(26) |
18
(7) |
19
(25) |
|
20
(7) |
21
(18) |
22
(25) |
23
(15) |
24
(21) |
25
(32) |
26
(15) |
|
27
(23) |
28
(33) |
|
|
|
|
|
|
From: Dirk M. <mu...@kd...> - 2005-02-27 00:40:06
|
CVS commit by mueller:
cvsrevertlast
M +22 -22 mac_shared.h 1.34
--- valgrind/memcheck/mac_shared.h #1.33:1.34
@@ -364,14 +364,14 @@ extern void MAC_(do_detect_memory_leaks)
);
-extern void MAC_(new_mem_stack_4) ( Addr old_ESP );
-extern void MAC_(die_mem_stack_4) ( Addr old_ESP );
-extern void MAC_(new_mem_stack_8) ( Addr old_ESP );
-extern void MAC_(die_mem_stack_8) ( Addr old_ESP );
-extern void MAC_(new_mem_stack_12) ( Addr old_ESP );
-extern void MAC_(die_mem_stack_12) ( Addr old_ESP );
-extern void MAC_(new_mem_stack_16) ( Addr old_ESP );
-extern void MAC_(die_mem_stack_16) ( Addr old_ESP );
-extern void MAC_(new_mem_stack_32) ( Addr old_ESP );
-extern void MAC_(die_mem_stack_32) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(new_mem_stack_4) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(die_mem_stack_4) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(new_mem_stack_8) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(die_mem_stack_8) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(new_mem_stack_12) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(die_mem_stack_12) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(new_mem_stack_16) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(die_mem_stack_16) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(new_mem_stack_32) ( Addr old_ESP );
+extern REGPARM(1) void MAC_(die_mem_stack_32) ( Addr old_ESP );
extern void MAC_(die_mem_stack) ( Addr a, SizeT len);
extern void MAC_(new_mem_stack) ( Addr a, SizeT len);
@@ -394,5 +394,5 @@ extern void MAC_(new_mem_stack) ( Addr a
UNALIGNED_NEW, UNALIGNED_DIE) \
\
-void MAC_(new_mem_stack_4)(Addr new_ESP) \
+void REGPARM(1) MAC_(new_mem_stack_4)(Addr new_ESP) \
{ \
PROF_EVENT(110); \
@@ -404,5 +404,5 @@ void MAC_(new_mem_stack_4)(Addr new_ESP)
} \
\
-void MAC_(die_mem_stack_4)(Addr new_ESP) \
+void REGPARM(1) MAC_(die_mem_stack_4)(Addr new_ESP) \
{ \
PROF_EVENT(120); \
@@ -414,5 +414,5 @@ void MAC_(die_mem_stack_4)(Addr new_ESP)
} \
\
-void MAC_(new_mem_stack_8)(Addr new_ESP) \
+void REGPARM(1) MAC_(new_mem_stack_8)(Addr new_ESP) \
{ \
PROF_EVENT(111); \
@@ -427,5 +427,5 @@ void MAC_(new_mem_stack_8)(Addr new_ESP)
} \
\
-void MAC_(die_mem_stack_8)(Addr new_ESP) \
+void REGPARM(1) MAC_(die_mem_stack_8)(Addr new_ESP) \
{ \
PROF_EVENT(121); \
@@ -440,5 +440,5 @@ void MAC_(die_mem_stack_8)(Addr new_ESP)
} \
\
-void MAC_(new_mem_stack_12)(Addr new_ESP) \
+void REGPARM(1) MAC_(new_mem_stack_12)(Addr new_ESP) \
{ \
PROF_EVENT(112); \
@@ -454,5 +454,5 @@ void MAC_(new_mem_stack_12)(Addr new_ESP
} \
\
-void MAC_(die_mem_stack_12)(Addr new_ESP) \
+void REGPARM(1) MAC_(die_mem_stack_12)(Addr new_ESP) \
{ \
PROF_EVENT(122); \
@@ -469,5 +469,5 @@ void MAC_(die_mem_stack_12)(Addr new_ESP
} \
\
-void MAC_(new_mem_stack_16)(Addr new_ESP) \
+void REGPARM(1) MAC_(new_mem_stack_16)(Addr new_ESP) \
{ \
PROF_EVENT(113); \
@@ -484,5 +484,5 @@ void MAC_(new_mem_stack_16)(Addr new_ESP
} \
\
-void MAC_(die_mem_stack_16)(Addr new_ESP) \
+void REGPARM(1) MAC_(die_mem_stack_16)(Addr new_ESP) \
{ \
PROF_EVENT(123); \
@@ -499,5 +499,5 @@ void MAC_(die_mem_stack_16)(Addr new_ESP
} \
\
-void MAC_(new_mem_stack_32)(Addr new_ESP) \
+void REGPARM(1) MAC_(new_mem_stack_32)(Addr new_ESP) \
{ \
PROF_EVENT(114); \
@@ -518,5 +518,5 @@ void MAC_(new_mem_stack_32)(Addr new_ESP
} \
\
-void MAC_(die_mem_stack_32)(Addr new_ESP) \
+void REGPARM(1) MAC_(die_mem_stack_32)(Addr new_ESP) \
{ \
PROF_EVENT(124); \
|
|
From: Dirk M. <mu...@kd...> - 2005-02-27 00:21:55
|
CVS commit by mueller:
fix compile (gcc 4.0)
M +1 -1 cg_main.c 1.84
--- valgrind/cachegrind/cg_main.c #1.83:1.84
@@ -660,5 +660,5 @@ UCodeBlock* SK_(instrument)(UCodeBlock*
/*------------------------------------------------------------*/
-#define UNDEFINED_CACHE ((cache_t) { -1, -1, -1 })
+#define UNDEFINED_CACHE { -1, -1, -1 }
static cache_t clo_I1_cache = UNDEFINED_CACHE;
|
|
From: Dirk M. <mu...@kd...> - 2005-02-27 00:17:19
|
CVS commit by mueller:
C90 style comments -> C89 style comments
M +17 -16 core_arch.h 1.25
M +1 -1 core_arch_asm.h 1.4
--- valgrind/coregrind/x86/core_arch.h #1.24:1.25
@@ -32,6 +32,6 @@
#define __X86_CORE_ARCH_H
-#include "core_arch_asm.h" // arch-specific asm stuff
-#include "tool_arch.h" // arch-specific tool stuff
+#include "core_arch_asm.h"
+#include "tool_arch.h"
/* ---------------------------------------------------------------------
@@ -39,5 +39,5 @@
------------------------------------------------------------------ */
-// Accessors for the arch_thread_t
+/* Accessors for the arch_thread_t */
#define ARCH_INSTR_PTR(regs) ((regs).m_eip)
#define ARCH_STACK_PTR(regs) ((regs).m_esp)
@@ -65,19 +65,19 @@
#define ARCH_CLREQ_RET(regs) ((regs).m_edx)
-// Accessors for the ThreadState
+/* Accessors for the ThreadState */
#define R_CLREQ_RET R_EDX
#define R_PTHREQ_RET R_EDX
-// Stack frame layout and linkage
+/* Stack frame layout and linkage */
#define FIRST_STACK_FRAME(ebp) (ebp)
#define STACK_FRAME_RET(ebp) (((UWord*)ebp)[1])
#define STACK_FRAME_NEXT(ebp) (((UWord*)ebp)[0])
-// Offsets of interesting registers
+/* Offsets of interesting registers */
#define VGOFF_INSTR_PTR VGOFF_(m_eip)
#define VGOFF_STACK_PTR VGOFF_(m_esp)
#define VGOFF_FRAME_PTR VGOFF_(m_ebp)
-// Get stack pointer and frame pointer
+/* Get stack pointer and frame pointer */
#define ARCH_GET_REAL_STACK_PTR(esp) do { \
asm("movl %%esp, %0" : "=r" (esp)); \
@@ -164,5 +164,5 @@ extern const Char VG_(helper_cmpxchg8b)[
------------------------------------------------------------------ */
-// XXX: eventually this will be x86-private, not seen by the core(?)
+/* XXX: eventually this will be x86-private, not seen by the core(?) */
/* This is the hardware-format for a segment descriptor, ie what the
@@ -197,11 +197,11 @@ typedef struct _LDT_ENTRY {
------------------------------------------------------------------ */
-// Total number of spill slots available for register allocation.
+/* Total number of spill slots available for register allocation. */
#define VG_MAX_SPILLSLOTS 24
-// Valgrind's stack size, in words.
+/* Valgrind's stack size, in words. */
#define VG_STACK_SIZE_W 16384
-// Base address of client address space.
+/* Base address of client address space. */
#define CLIENT_BASE 0x00000000ul
@@ -255,8 +255,9 @@ struct i387_fxsave_struct {
-// Architecture-specific part of a ThreadState
-// XXX: eventually this should be made abstract, ie. the fields not visible
-// to the core... then VgLdtEntry can be made non-visible to the core
-// also.
+/* Architecture-specific part of a ThreadState
+ XXX: eventually this should be made abstract, ie. the fields not visible
+ to the core... then VgLdtEntry can be made non-visible to the core
+ also.
+*/
typedef struct {
/* Saved machine context. Note the FPU state, %EIP and segment
@@ -332,5 +333,5 @@ arch_thread_t;
void VGA_(signal_return)(ThreadId tid, Bool isRT);
-#endif // __X86_CORE_ARCH_H
+#endif /* __X86_CORE_ARCH_H */
/*--------------------------------------------------------------------*/
--- valgrind/coregrind/x86/core_arch_asm.h #1.3:1.4
@@ -58,5 +58,5 @@
-#endif // __X86_CORE_ARCH_ASM_H
+#endif /* __X86_CORE_ARCH_ASM_H */
/*--------------------------------------------------------------------*/
|
|
From: Dirk M. <mu...@kd...> - 2005-02-27 00:16:06
|
CVS commit by mueller:
these are used as function pointers, can't use regparms here, as gcc
tries to tell you:
mc_main.c:1968: warning: passing arg 1 of `vgPlain_init_new_mem_stack_4' from incompatible pointer type
M +22 -22 mac_shared.h 1.33
--- valgrind/memcheck/mac_shared.h #1.32:1.33
@@ -364,14 +364,14 @@ extern void MAC_(do_detect_memory_leaks)
);
-extern REGPARM(1) void MAC_(new_mem_stack_4) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(die_mem_stack_4) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(new_mem_stack_8) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(die_mem_stack_8) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(new_mem_stack_12) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(die_mem_stack_12) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(new_mem_stack_16) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(die_mem_stack_16) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(new_mem_stack_32) ( Addr old_ESP );
-extern REGPARM(1) void MAC_(die_mem_stack_32) ( Addr old_ESP );
+extern void MAC_(new_mem_stack_4) ( Addr old_ESP );
+extern void MAC_(die_mem_stack_4) ( Addr old_ESP );
+extern void MAC_(new_mem_stack_8) ( Addr old_ESP );
+extern void MAC_(die_mem_stack_8) ( Addr old_ESP );
+extern void MAC_(new_mem_stack_12) ( Addr old_ESP );
+extern void MAC_(die_mem_stack_12) ( Addr old_ESP );
+extern void MAC_(new_mem_stack_16) ( Addr old_ESP );
+extern void MAC_(die_mem_stack_16) ( Addr old_ESP );
+extern void MAC_(new_mem_stack_32) ( Addr old_ESP );
+extern void MAC_(die_mem_stack_32) ( Addr old_ESP );
extern void MAC_(die_mem_stack) ( Addr a, SizeT len);
extern void MAC_(new_mem_stack) ( Addr a, SizeT len);
@@ -394,5 +394,5 @@ extern void MAC_(new_mem_stac
UNALIGNED_NEW, UNALIGNED_DIE) \
\
-void REGPARM(1) MAC_(new_mem_stack_4)(Addr new_ESP) \
+void MAC_(new_mem_stack_4)(Addr new_ESP) \
{ \
PROF_EVENT(110); \
@@ -404,5 +404,5 @@ void REGPARM(1) MAC_(new_mem_stack_4)(Ad
} \
\
-void REGPARM(1) MAC_(die_mem_stack_4)(Addr new_ESP) \
+void MAC_(die_mem_stack_4)(Addr new_ESP) \
{ \
PROF_EVENT(120); \
@@ -414,5 +414,5 @@ void REGPARM(1) MAC_(die_mem_stack_4)(Ad
} \
\
-void REGPARM(1) MAC_(new_mem_stack_8)(Addr new_ESP) \
+void MAC_(new_mem_stack_8)(Addr new_ESP) \
{ \
PROF_EVENT(111); \
@@ -427,5 +427,5 @@ void REGPARM(1) MAC_(new_mem_stack_8)(Ad
} \
\
-void REGPARM(1) MAC_(die_mem_stack_8)(Addr new_ESP) \
+void MAC_(die_mem_stack_8)(Addr new_ESP) \
{ \
PROF_EVENT(121); \
@@ -440,5 +440,5 @@ void REGPARM(1) MAC_(die_mem_stack_8)(Ad
} \
\
-void REGPARM(1) MAC_(new_mem_stack_12)(Addr new_ESP) \
+void MAC_(new_mem_stack_12)(Addr new_ESP) \
{ \
PROF_EVENT(112); \
@@ -454,5 +454,5 @@ void REGPARM(1) MAC_(new_mem_stack_12)(A
} \
\
-void REGPARM(1) MAC_(die_mem_stack_12)(Addr new_ESP) \
+void MAC_(die_mem_stack_12)(Addr new_ESP) \
{ \
PROF_EVENT(122); \
@@ -469,5 +469,5 @@ void REGPARM(1) MAC_(die_mem_stack_12)(A
} \
\
-void REGPARM(1) MAC_(new_mem_stack_16)(Addr new_ESP) \
+void MAC_(new_mem_stack_16)(Addr new_ESP) \
{ \
PROF_EVENT(113); \
@@ -484,5 +484,5 @@ void REGPARM(1) MAC_(new_mem_stack_16)(A
} \
\
-void REGPARM(1) MAC_(die_mem_stack_16)(Addr new_ESP) \
+void MAC_(die_mem_stack_16)(Addr new_ESP) \
{ \
PROF_EVENT(123); \
@@ -499,5 +499,5 @@ void REGPARM(1) MAC_(die_mem_stack_16)(A
} \
\
-void REGPARM(1) MAC_(new_mem_stack_32)(Addr new_ESP) \
+void MAC_(new_mem_stack_32)(Addr new_ESP) \
{ \
PROF_EVENT(114); \
@@ -518,5 +518,5 @@ void REGPARM(1) MAC_(new_mem_stack_32)(A
} \
\
-void REGPARM(1) MAC_(die_mem_stack_32)(Addr new_ESP) \
+void MAC_(die_mem_stack_32)(Addr new_ESP) \
{ \
PROF_EVENT(124); \
|
|
From: Dirk M. <mu...@kd...> - 2005-02-27 00:04:32
|
CVS commit by mueller:
C99 style comments -> c89 style comments
M +108 -107 vki_arch.h 1.14
M +4 -4 vki_arch_posixtypes.h 1.4
--- valgrind/include/x86-linux/vki_arch.h #1.13:1.14
@@ -32,10 +32,10 @@
#define __X86_LINUX_VKI_ARCH_H
-// x86 is little-endian.
+/* x86 is little-endian. */
#define VKI_LITTLE_ENDIAN 1
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/types.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/types.h */
+/*----------------------------------------------------------------------*/
typedef unsigned char __vki_u8;
@@ -53,7 +53,7 @@ typedef unsigned short vki_u16;
typedef unsigned int vki_u32;
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/page.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/page.h */
+/*----------------------------------------------------------------------*/
/* PAGE_SHIFT determines the page size */
@@ -61,7 +61,7 @@ typedef unsigned int vki_u32;
#define VKI_PAGE_SIZE (1UL << VKI_PAGE_SHIFT)
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/signal.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/signal.h */
+/*----------------------------------------------------------------------*/
#define VKI_MINSIGSTKSZ 2048
@@ -81,5 +81,5 @@ typedef __vki_restorefn_t __user *__vki_
#define VKI_SIG_IGN ((__vki_sighandler_t)1) /* ignore signal */
-//#ifdef __KERNEL__
+/*#ifdef __KERNEL__*/
/* Most things should be clean enough to redefine this at will, if care
is taken to make libc match. */
@@ -94,5 +94,5 @@ typedef struct {
unsigned long sig[_VKI_NSIG_WORDS];
} vki_sigset_t;
-//#endif
+/*#endif*/
#define VKI_SIGHUP 1
@@ -102,5 +102,5 @@ typedef struct {
#define VKI_SIGTRAP 5
#define VKI_SIGABRT 6
-//#define VKI_SIGIOT 6
+/*#define VKI_SIGIOT 6*/
#define VKI_SIGBUS 7
#define VKI_SIGFPE 8
@@ -132,11 +132,11 @@ typedef struct {
/* These should not be considered constants from userland. */
#define VKI_SIGRTMIN 32
-// [[This was (_NSIG-1) in 2.4.X... not sure if it matters.]]
+/* [[This was (_NSIG-1) in 2.4.X... not sure if it matters.]] */
#define VKI_SIGRTMAX _VKI_NSIG
/* Use high signals because native pthreads wants to use low */
-#define VKI_SIGVGKILL (VG_(max_signal)-0) // [[internal: kill]]
-#define VKI_SIGVGCHLD (VG_(max_signal)-1) // [[internal: thread death]]
-#define VKI_SIGVGRTUSERMAX (VG_(max_signal)-2) // [[internal: last user-usable RT signal]]
+#define VKI_SIGVGKILL (VG_(max_signal)-0) /* [[internal: kill]] */
+#define VKI_SIGVGCHLD (VG_(max_signal)-1) /* [[internal: thread death]] */
+#define VKI_SIGVGRTUSERMAX (VG_(max_signal)-2) /* [[internal: last user-usable RT signal]] */
#define VKI_SA_NOCLDSTOP 0x00000001u
@@ -150,5 +150,5 @@ typedef struct {
#define VKI_SA_NOMASK VKI_SA_NODEFER
#define VKI_SA_ONESHOT VKI_SA_RESETHAND
-//#define VKI_SA_INTERRUPT 0x20000000 /* dummy -- ignored */
+/*#define VKI_SA_INTERRUPT 0x20000000 dummy -- ignored */
#define VKI_SA_RESTORER 0x04000000
@@ -158,8 +158,9 @@ typedef struct {
struct vki_old_sigaction {
- // [[Nb: a 'k' prefix is added to "sa_handler" because
- // bits/sigaction.h (which gets dragged in somehow via signal.h)
- // #defines it as something else. Since that is done for glibc's
- // purposes, which we don't care about here, we use our own name.]]
+ /* [[Nb: a 'k' prefix is added to "sa_handler" because
+ bits/sigaction.h (which gets dragged in somehow via signal.h)
+ #defines it as something else. Since that is done for glibc's
+ purposes, which we don't care about here, we use our own name.]]
+ */
__vki_sighandler_t ksa_handler;
vki_old_sigset_t sa_mask;
@@ -169,5 +170,5 @@ struct vki_old_sigaction {
struct vki_sigaction {
- // [[See comment about extra 'k' above]]
+ /* [[See comment about extra 'k' above]] */
__vki_sighandler_t ksa_handler;
unsigned long sa_flags;
@@ -182,7 +183,7 @@ typedef struct vki_sigaltstack {
} vki_stack_t;
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/sigcontext.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/sigcontext.h */
+/*----------------------------------------------------------------------*/
struct _vki_fpreg {
@@ -248,7 +249,7 @@ struct vki_sigcontext {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/mman.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/mman.h */
+/*----------------------------------------------------------------------*/
#define VKI_PROT_NONE 0x0 /* No page permissions */
@@ -259,12 +260,12 @@ struct vki_sigcontext {
#define VKI_MAP_SHARED 0x01 /* Share changes */
#define VKI_MAP_PRIVATE 0x02 /* Changes are private */
-//#define VKI_MAP_TYPE 0x0f /* Mask for type of mapping */
+/*#define VKI_MAP_TYPE 0x0f */ /* Mask for type of mapping */
#define VKI_MAP_FIXED 0x10 /* Interpret addr exactly */
#define VKI_MAP_ANONYMOUS 0x20 /* don't use a file */
#define VKI_MAP_NORESERVE 0x4000 /* don't check for reservations */
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/fcntl.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/fcntl.h */
+/*----------------------------------------------------------------------*/
#define VKI_O_RDONLY 00
@@ -278,5 +279,5 @@ struct vki_sigcontext {
#define VKI_F_DUPFD 0 /* dup */
-//#define VKI_F_GETFD 1 /* get close_on_exec */
+/*#define VKI_F_GETFD 1*/ /* get close_on_exec */
#define VKI_F_SETFD 2 /* set/clear close_on_exec */
#define VKI_F_GETFL 3 /* get file->f_flags */
@@ -295,7 +296,7 @@ struct vki_sigcontext {
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/resource.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/resource.h */
+/*----------------------------------------------------------------------*/
#define VKI_RLIMIT_DATA 2 /* max data size */
@@ -304,7 +305,7 @@ struct vki_sigcontext {
#define VKI_RLIMIT_NOFILE 7 /* max number of open files */
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/socket.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/socket.h */
+/*----------------------------------------------------------------------*/
#define VKI_SOL_SOCKET 1
@@ -314,7 +315,7 @@ struct vki_sigcontext {
#define VKI_SOCK_STREAM 1 /* stream (connection) socket */
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/sockios.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/sockios.h
+ ----------------------------------------------------------------------*/
#define VKI_SIOCSPGRP 0x8902
@@ -322,7 +323,7 @@ struct vki_sigcontext {
#define VKI_SIOCGSTAMP 0x8906 /* Get stamp */
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/stat.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/stat.h
+ ----------------------------------------------------------------------*/
#define VKI_S_IFMT 00170000
@@ -401,7 +402,7 @@ struct vki_stat64 {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/statfs.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/statfs.h
+ ----------------------------------------------------------------------*/
struct vki_statfs {
@@ -419,7 +420,7 @@ struct vki_statfs {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/termios.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/termios.h
+ ----------------------------------------------------------------------*/
struct vki_winsize {
@@ -441,7 +442,7 @@ struct vki_termio {
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/termbits.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/termbits.h
+ ----------------------------------------------------------------------*/
typedef unsigned char vki_cc_t;
@@ -458,7 +459,7 @@ struct vki_termios {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/ioctl.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/ioctl.h
+ ----------------------------------------------------------------------*/
#define _VKI_IOC_NRBITS 8
@@ -506,7 +507,7 @@ extern unsigned int __vki_invalid_size_a
#define _VKI_IOC_SIZE(nr) (((nr) >> _VKI_IOC_SIZESHIFT) & _VKI_IOC_SIZEMASK)
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/ioctls.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/ioctls.h
+ ----------------------------------------------------------------------*/
#define VKI_TCGETS 0x5401
@@ -539,7 +540,7 @@ extern unsigned int __vki_invalid_size_a
#define VKI_FIOASYNC 0x5452
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/poll.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/poll.h
+ ----------------------------------------------------------------------*/
/* These are specified by iBCS2 */
@@ -552,7 +553,7 @@ struct vki_pollfd {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/user.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/user.h
+ ----------------------------------------------------------------------*/
struct vki_user_i387_struct {
@@ -599,7 +600,7 @@ struct vki_user_regs_struct {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/elf.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/elf.h
+ ----------------------------------------------------------------------*/
typedef unsigned long vki_elf_greg_t;
@@ -613,7 +614,7 @@ typedef struct vki_user_fxsr_struct vki_
#define VKI_AT_SYSINFO 32
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/ucontext.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/ucontext.h
+ ----------------------------------------------------------------------*/
struct vki_ucontext {
@@ -625,7 +626,7 @@ struct vki_ucontext {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/segment.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/segment.h
+ ----------------------------------------------------------------------*/
#define VKI_GDT_ENTRY_TLS_ENTRIES 3
@@ -633,7 +634,7 @@ struct vki_ucontext {
#define VKI_GDT_ENTRY_TLS_MAX (VKI_GDT_ENTRY_TLS_MIN + VKI_GDT_ENTRY_TLS_ENTRIES - 1)
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/ldt.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/ldt.h
+ ----------------------------------------------------------------------*/
/* [[Nb: This is the structure passed to the modify_ldt syscall. Just so as
@@ -651,18 +652,18 @@ struct vki_user_desc {
unsigned int seg_not_present:1;
unsigned int useable:1;
- // [[Nb: this field is not in the kernel sources, but it has always
- // been in the Valgrind sources so I will keep it there in case it's
- // important... this is an x86-defined data structure so who
- // knows; maybe it's important to set this field to zero at some
- // point. --njn]]
+ /* [[Nb: this field is not in the kernel sources, but it has always
+ been in the Valgrind sources so I will keep it there in case it's
+ important... this is an x86-defined data structure so who
+ knows; maybe it's important to set this field to zero at some
+ point. --njn]] */
unsigned int reserved:25;
};
-// [[Nb: for our convenience within Valgrind, use a more specific name]]
+/* [[Nb: for our convenience within Valgrind, use a more specific name]] */
typedef struct vki_user_desc vki_modify_ldt_t;
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/ipcbuf.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/ipcbuf.h
+ ----------------------------------------------------------------------*/
struct vki_ipc64_perm
@@ -681,7 +682,7 @@ struct vki_ipc64_perm
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/sembuf.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/sembuf.h
+ ----------------------------------------------------------------------*/
struct vki_semid64_ds {
@@ -696,7 +697,7 @@ struct vki_semid64_ds {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/msgbuf.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/msgbuf.h
+ ----------------------------------------------------------------------*/
struct vki_msqid64_ds {
@@ -717,7 +718,7 @@ struct vki_msqid64_ds {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/ipc.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/ipc.h
+ ----------------------------------------------------------------------*/
struct vki_ipc_kludge {
@@ -726,7 +727,7 @@ struct vki_ipc_kludge {
};
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/shmbuf.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ From linux-2.6.8.1/include/asm-i386/shmbuf.h
+ ----------------------------------------------------------------------*/
struct vki_shmid64_ds {
@@ -758,7 +759,7 @@ struct vki_shminfo64 {
};
-//----------------------------------------------------------------------
-// DRM ioctls
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ DRM ioctls
+ ----------------------------------------------------------------------*/
struct vki_drm_buf_pub {
Int idx; /**< Index into the master buffer list */
@@ -778,9 +779,9 @@ struct vki_drm_buf_map {
-//----------------------------------------------------------------------
-// And that's it!
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------
+ And that's it!
+ ----------------------------------------------------------------------*/
-#endif // __X86_LINUX_VKI_ARCH_H
+#endif /* __X86_LINUX_VKI_ARCH_H */
/*--------------------------------------------------------------------*/
--- valgrind/include/x86-linux/vki_arch_posixtypes.h #1.3:1.4
@@ -33,7 +33,7 @@
#define __X86_LINUX_VKI_ARCH_POSIXTYPES_H
-//----------------------------------------------------------------------
-// From linux-2.6.8.1/include/asm-i386/posix_types.h
-//----------------------------------------------------------------------
+/*----------------------------------------------------------------------*/
+/* From linux-2.6.8.1/include/asm-i386/posix_types.h */
+/*----------------------------------------------------------------------*/
typedef unsigned short __vki_kernel_mode_t;
@@ -62,5 +62,5 @@ typedef struct {
} __vki_kernel_fsid_t;
-#endif // __X86_LINUX_VKI_ARCH_POSIXTYPES_H
+#endif /* __X86_LINUX_VKI_ARCH_POSIXTYPES_H */
/*--------------------------------------------------------------------*/
|
|
From: Dirk M. <mu...@kd...> - 2005-02-27 00:03:14
|
CVS commit by mueller:
const-correctness, fix compiler warnings
M +3 -3 coregrind/vg_messages.c 1.18
M +10 -10 include/tool.h.base 1.26
--- valgrind/include/tool.h.base #1.25:1.26
@@ -35,6 +35,6 @@
#include "basic_types.h"
-#include "tool_asm.h" // asm stuff
-#include "tool_arch.h" // arch-specific tool stuff
+#include "tool_asm.h" /* asm stuff */
+#include "tool_arch.h" /* arch-specific tool stuff */
#include "vki.h"
@@ -132,5 +132,5 @@
#define VG_CLO_STREQN(nn,s1,s2) (0==VG_(strncmp_ws)((s1),(s2),(nn)))
-// Higher-level command-line option recognisers; use in if/else chains
+/* Higher-level command-line option recognisers; use in if/else chains */
#define VG_BOOL_CLO(qq_option, qq_var) \
@@ -148,5 +148,5 @@
}
-// Bounded integer arg
+/* Bounded integer arg */
#define VG_BNUM_CLO(qq_option, qq_var, qq_lo, qq_hi) \
if (VG_CLO_STREQN(VG_(strlen)(qq_option)+1, arg, qq_option"=")) { \
@@ -187,5 +187,5 @@
Vg_DebugMsg, /* '?' == '-' */
Vg_DebugExtraMsg, /* '?' == '+' */
- Vg_ClientMsg, /* '?' == '*' */
+ Vg_ClientMsg /* '?' == '*' */
}
VgMsgKind;
@@ -193,11 +193,11 @@
/* Functions for building a message from multiple parts. */
extern int VG_(start_msg) ( VgMsgKind kind );
-extern int VG_(add_to_msg) ( Char* format, ... );
+extern int VG_(add_to_msg) ( const Char* format, ... );
/* Ends and prints the message. Appends a newline. */
extern int VG_(end_msg) ( void );
/* Send a single-part message. Appends a newline. */
-extern int VG_(message) ( VgMsgKind kind, Char* format, ... );
-extern int VG_(vmessage) ( VgMsgKind kind, Char* format, va_list vargs );
+extern int VG_(message) ( VgMsgKind kind, const Char* format, ... );
+extern int VG_(vmessage) ( VgMsgKind kind, const Char* format, va_list vargs );
@@ -1343,5 +1343,5 @@
JP_NONE, /* no prediction */
JP_TAKEN, /* predict taken */
- JP_NOT_TAKEN, /* predict not taken */
+ JP_NOT_TAKEN /* predict not taken */
} JumpPred;
@@ -1571,5 +1571,5 @@
Vg_SectBSS,
Vg_SectGOT,
- Vg_SectPLT,
+ Vg_SectPLT
}
VgSectKind;
--- valgrind/coregrind/vg_messages.c #1.17:1.18
@@ -69,5 +69,5 @@ static void add_timestamp ( Char *buf )
int
-VG_(add_to_msg) ( Char *format, ... )
+VG_(add_to_msg) ( const Char *format, ... )
{
int count;
@@ -79,5 +79,5 @@ VG_(add_to_msg) ( Char *format, ... )
}
-int VG_(vmessage) ( VgMsgKind kind, Char* format, va_list vargs )
+int VG_(vmessage) ( VgMsgKind kind, const Char* format, va_list vargs )
{
int count;
@@ -89,5 +89,5 @@ int VG_(vmessage) ( VgMsgKind kind, Char
/* Send a simple single-part message. */
-int VG_(message) ( VgMsgKind kind, Char* format, ... )
+int VG_(message) ( VgMsgKind kind, const Char* format, ... )
{
int count;
|
|
From: Julian S. <js...@ac...> - 2005-02-26 21:54:03
|
> > add -Wno-pointer-sign if compiler supports it (removes 2000+ warnings > > when compiling with gcc 4.0) > > I thought that was discussed the other day and we decided to fix the > problem rather than hide it. Exactly so. Dirk, could you please undo this? J |
|
From: Tom H. <to...@co...> - 2005-02-26 21:36:09
|
In message <200...@of...>
Dirk Mueller <mu...@kd...> wrote:
> CVS commit by mueller:
>
> add -Wno-pointer-sign if compiler supports it (removes 2000+ warnings when compiling with gcc 4.0)
I thought that was discussed the other day and we decided to fix the
problem rather than hide it.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|
|
From: Dirk M. <mu...@kd...> - 2005-02-26 21:14:45
|
CVS commit by mueller: all gcc's I know support -Wno-long-long, so set it unconditionally M +1 -1 configure.in 1.150 --- valgrind/configure.in #1.149:1.150 @@ -8,5 +8,5 @@ # Checks for programs. -CFLAGS="" +CFLAGS="-Wno-long-long" AC_PROG_LN_S |
|
From: Dirk M. <mu...@kd...> - 2005-02-26 21:04:30
|
CVS commit by mueller:
add -Wno-pointer-sign if compiler supports it (removes 2000+ warnings when compiling with gcc 4.0)
M +22 -0 configure.in 1.149
--- valgrind/configure.in #1.148:1.149
@@ -252,4 +252,26 @@
AC_SUBST(PREFERRED_STACK_BOUNDARY)
+# does this compiler support -Wno-pointer-sign ?
+AC_MSG_CHECKING([if gcc accepts -Wno-pointer-sign ])
+
+safe_CFLAGS=$CFLAGS
+CFLAGS="-Wno-pointer-sign"
+
+AC_TRY_COMPILE(, [
+int main () { return 0 ; }
+],
+[
+no_pointer_sign=yes
+AC_MSG_RESULT([yes])
+], [
+no_pointer_sign=no
+AC_MSG_RESULT([no])
+])
+CFLAGS=$safe_CFLAGS
+
+if test x$no_pointer_sign = xyes; then
+ CFLAGS="$CFLAGS -Wno-pointer-sign"
+fi
+
# Check for TLS support in the compiler and linker
AC_CACHE_CHECK([for TLS support], vg_cv_tls,
|
|
From: Tom H. <th...@cy...> - 2005-02-26 17:49:52
|
CVS commit by thughes: More alternative memory leak results. A pointer-trace.stderr.exp2 1.1 A post-syscall.stderr.exp2 1.1 |
|
From: Tom H. <th...@cy...> - 2005-02-26 17:44:01
|
CVS commit by thughes:
Updated for recent changes to C library symbol filtering.
M +2 -2 badjump.stderr.exp2 1.2
--- valgrind/memcheck/tests/badjump.stderr.exp2 #1.1:1.2
@@ -2,5 +2,5 @@
Jump to the invalid address stated on the next line
at 0x........: ???
- by 0x........: __libc_start_main (...libc...)
+ by 0x........: __libc_start_main (in /...libc...)
by 0x........: ...
Address 0x........ is not stack'd, malloc'd or (recently) free'd
@@ -9,5 +9,5 @@
Access not within mapped region at address 0x........
at 0x........: ???
- by 0x........: __libc_start_main (...libc...)
+ by 0x........: __libc_start_main (in /...libc...)
by 0x........: ...
|
|
From: Dirk M. <mu...@kd...> - 2005-02-26 17:40:53
|
CVS commit by mueller:
fix compile (gcc 4.0)
M +1 -1 coregrind/vg_to_ucode.c 1.156
M +1 -1 include/tool.h.base 1.25
--- valgrind/coregrind/vg_to_ucode.c #1.155:1.156
@@ -420,5 +420,5 @@ const Char* VG_(name_of_mmx_gran) ( UCha
}
-const Char VG_(name_of_int_size) ( Int size )
+Char VG_(name_of_int_size) ( Int size )
{
switch (size) {
--- valgrind/include/tool.h.base #1.24:1.25
@@ -1244,5 +1244,5 @@
extern const Char* VG_(name_of_seg_reg) ( Int sreg );
extern const Char* VG_(name_of_int_reg) ( Int size, Int reg );
-extern const Char VG_(name_of_int_size) ( Int size );
+extern Char VG_(name_of_int_size) ( Int size );
/* Shorter macros for convenience */
|
|
From: Tom H. <to...@co...> - 2005-02-26 16:28:25
|
In message <421...@go...>
Jeremy Fitzhardinge <je...@go...> wrote:
> Nicholas Nethercote wrote:
>
> > I had a similar problem last night on my Debian 3.0 box. Strange
> > thing was, whether pth_exit hung or not seemed to depend on the value
> > of the --prefix path given to ./configure! I had two clean checkouts,
> > the only difference was the --prefix path, and one hung while the
> > other didn't. So I reconfigured, swapping the prefix paths, and this
> > time the other one hung. Very strange.
>
> I checked in a signals-related fix last night which could well fix it.
> I have no idea why --prefix would affect it though.
It doesn't seem to be happening as much but I do still have some
hangs in the thread tests on linuxthreads. It's intermittent though
which probably explains Nick's result.
I think I've now tracked down what is happening and why it works
sometimes. This is a trace from the end of pth_cancel2 when the
main thread is exiting and is waiting for the manager thread to
finish up:
SYSCALL[23924,1](175) special:sys_rt_sigprocmask ( 2, 0x0, 0xAFEFE150, 8 )
++23924++ do_setmask: tid = 1 how = 2 (SIG_SETMASK), set = 0x0 0000000000000000
++23924++ oldset=0xAFEFE150 0000000080000000
--> 0 (0x0)
SYSCALL[23924,1](179) mayBlock:sys_rt_sigsuspend ( 0xAFEFE150, 8 ) --> ...
--23924-- SCHED[1]: now sleeping in state VgTs_WaitSys
--23924-- SCHED[1]: now running
--23924-- Async handler got signal 32 for tid 1 info 0
interrupted_syscall: eip=0xB0084CC5; restart=0 eax=0
not started: restart
--23924-- delivering signal 32 (SIGRT0):0 to thread 1
--23924-- vg_push_signal_frame (thread 1): signal 32
SCHEDSETJMP(line 634) tid 1, jumped=1
SYSCALL[23924,1](119) special:sigreturn ( )
--23924-- vg_pop_signal_frame (thread 1): isRT=0 valid magic; EIP=0x420293D3
--> 179 (0xB3)
SYSCALL[23924,1](179) mayBlock:sys_rt_sigsuspend ( 0xAFEFE150, 8 ) --> ...
--23924-- SCHED[1]: now sleeping in state VgTs_WaitSys
So the main thread (thread 1) calls sigsuspend to wait for the signal
from the manager thread (thread 2) to say that it is done. Unfortunately
the signal arrives while the system call is still being setup so we
decide to restart the system call and wound up sat in sigsuspend waiting
for a signal that will never arrive.
Tom
--
Tom Hughes (to...@co...)
http://www.compton.nu/
|
|
From: Tom H. <th...@cy...> - 2005-02-26 15:30:05
|
CVS commit by thughes: Add some alternate results for various memory leak tests to account for systems which have an extra 24 byte block allocated by the C library. A addrcheck/tests/addressable.stderr.exp2 1.1 A addrcheck/tests/leak-0.stderr.exp2 1.1 A addrcheck/tests/leak-cycle.stderr.exp2 1.1 A addrcheck/tests/leak-regroot.stderr.exp2 1.1 A memcheck/tests/addressable.stderr.exp2 1.1 A memcheck/tests/leak-0.stderr.exp2 1.1 A memcheck/tests/leak-cycle.stderr.exp2 1.1 A memcheck/tests/leak-regroot.stderr.exp2 1.1 |
|
From: Tom H. <th...@cy...> - 2005-02-26 12:00:18
|
Nightly build on standard ( Red Hat 7.2 ) started at 2005-02-26 03:00:02 GMT Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow -- Finished tests in cachegrind/tests/x86 ------------------------------ -- Finished tests in cachegrind/tests ---------------------------------- -- Running tests in corecheck/tests ----------------------------------- as_mmap: valgrind ./as_mmap as_shm: valgrind ./as_shm erringfds: valgrind ./erringfds fdleak_cmsg: valgrind --track-fds=yes ./fdleak_cmsg < /dev/null fdleak_creat: valgrind --track-fds=yes ./fdleak_creat < /dev/null fdleak_dup: valgrind --track-fds=yes ./fdleak_dup < /dev/null fdleak_dup2: valgrind --track-fds=yes ./fdleak_dup2 < /dev/null fdleak_fcntl: valgrind --track-fds=yes ./fdleak_fcntl < /dev/null fdleak_ipv4: valgrind --track-fds=yes ./fdleak_ipv4 < /dev/null fdleak_open: valgrind --track-fds=yes ./fdleak_open < /dev/null fdleak_pipe: valgrind --track-fds=yes ./fdleak_pipe < /dev/null fdleak_socketpair: valgrind --track-fds=yes ./fdleak_socketpair < /dev/null pth_atfork1: valgrind ./pth_atfork1 pth_cancel1: valgrind ./pth_cancel1 pth_cancel2: valgrind ./pth_cancel2 Could not read `pth_cancel2.stderr.exp' make: *** [regtest] Error 2 |
|
From: Tom H. <to...@co...> - 2005-02-26 03:29:35
|
Nightly build on dunsmere ( Fedora Core 3 ) started at 2005-02-26 03:20:03 GMT Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow rm: cannot remove `vgcore.pid*': No such file or directory (cleanup operation failed: rm vgcore.pid*) pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert seg_override: valgrind ./seg_override -- Finished tests in none/tests/x86 ------------------------------------ yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 214 tests, 8 stderr failures, 0 stdout failures ================= helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) memcheck/tests/scalar (stderr) memcheck/tests/scalar_supp (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2005-02-26 03:22:49
|
Nightly build on audi ( Red Hat 9 ) started at 2005-02-26 03:15:02 GMT Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow insn_sse2: (skipping, prereq failed: ../../../tests/cputest x86-sse2) int: valgrind ./int rm: cannot remove `vgcore.pid*': No such file or directory (cleanup operation failed: rm vgcore.pid*) pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert seg_override: valgrind ./seg_override -- Finished tests in none/tests/x86 ------------------------------------ yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 213 tests, 6 stderr failures, 0 stdout failures ================= helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2005-02-26 03:17:38
|
Nightly build on ginetta ( Red Hat 8.0 ) started at 2005-02-26 03:10:03 GMT Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow rm: cannot remove `vgcore.pid*': No such file or directory (cleanup operation failed: rm vgcore.pid*) pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert seg_override: valgrind ./seg_override -- Finished tests in none/tests/x86 ------------------------------------ yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 212 tests, 8 stderr failures, 0 stdout failures ================= helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) memcheck/tests/pth_once (stderr) memcheck/tests/threadederrno (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2005-02-26 03:12:05
|
Nightly build on alvis ( Red Hat 7.3 ) started at 2005-02-26 03:05:02 GMT Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) massif/tests/toobig-allocs (stderr) massif/tests/true_html (stderr) massif/tests/true_text (stderr) memcheck/tests/addressable (stderr) memcheck/tests/badjump (stderr) memcheck/tests/leak-0 (stderr) memcheck/tests/leak-cycle (stderr) memcheck/tests/leak-regroot (stderr) memcheck/tests/leak-tree (stderr) memcheck/tests/pointer-trace (stderr) memcheck/tests/post-syscall (stderr) memcheck/tests/pth_once (stderr) memcheck/tests/threadederrno (stderr) memcheck/tests/vgtest_ume (stderr) make: *** [regtest] Error 1 |
|
From: Jeremy F. <je...@go...> - 2005-02-26 00:11:53
|
Julian Seward wrote:
> I hesitate to run the leak checker by default at exit. It can
> cause a huge amount of disk activity because it inspects bits of
> address space that had been swapped out during long runs of
> leaky programs, and which then gets forced back in as the checker
> traverses it all.
>
> But perhaps we should. In an underhand way it creates the
> expectation amongst programmers that their programs should have
> no detectable leaks, and that leaks will be tested for routinely
> -- every time V is run.
Well, since it's mark-sweep now, a basic leak check only traverses the
live heap. We could report the total number of leaked blocks/memory
pretty quickly. Its only doing a decent job of reporting specific leaks
which requires walking the leaked part of the heap.
Also, the checker touches a lot less memory than it used to; it doesn't
bother scanning read-only memory, for example (since it can never
contain pointers to the heap).
J
|
|
From: Julian S. <js...@ac...> - 2005-02-25 23:45:34
|
Nice summary. Definitely a good thing. > > - increase the default --num-callers size to 12 > > Yes! I was about to propose this. 4 has been way too small for a long > time. Also, the default --leak-resolution=low (2 frames matches) is too > low as well; I think it should default to "med". Yes, perhaps time to increase --num-callers. Problem with large values is that error messages take up tons of screen space. Oh well. Default 8 ? 12 ? > And should we consider defaulting to memcheck again? Personally I would like that. I find it annoying to constantly have to type --tool=memcheck (but not _always_, so .valgrindrc isn't the answer). Indeed, I am not the only one: the V that comes packaged with SuSE seems to already have been defaulted to memcheck, presumably by the SuSE folks themselves. (iow, "valgrind ls" works fine on SuSE). > I find --show-reachable is too noisy for common use. I agree. I hesitate to run the leak checker by default at exit. It can cause a huge amount of disk activity because it inspects bits of address space that had been swapped out during long runs of leaky programs, and which then gets forced back in as the checker traverses it all. But perhaps we should. In an underhand way it creates the expectation amongst programmers that their programs should have no detectable leaks, and that leaks will be tested for routinely -- every time V is run. And it helps our software engineering too. Currently the checker is basically an optional component and doesn't get tested enough. If it was engaged by default, we would know much sooner if there was anything broken about it. J |
|
From: Nicholas N. <nj...@cs...> - 2005-02-25 22:46:46
|
On Fri, 25 Feb 2005, Robert Walsh wrote: >>> And should we consider defaulting to memcheck again? >> >> I don't think so; it is still the best way to imply that there are other >> tools. > > I vote for a default too. I use memcheck 95% of the time and it's > getting tiring typing those extra letters :-) That's what the .valgrindrc file is for :) N |
|
From: Nicholas N. <nj...@cs...> - 2005-02-25 22:42:44
|
On Thu, 24 Feb 2005, Jeremy Fitzhardinge wrote: >>> * big-bang shadow allocation causes problems on kernels that don't >>> do overcommitment >>> >>> * a fixed partitioning scheme is less appropriate if we move towards >>> compressed representations of shadow memory, since that compression >>> ratio could be variable >> >> >> Plus all the other problems mentioned in bug #82301, which we've talked >> about at length multiple times in the past. > > The only additional problem in that bug is the difficulty with loading large > symbol files, which won't be helped by the superblock scheme at all; it will > be made worse. But that's OK, because the symtab reader needs to be fixed > anyway. That's not the only additional problem. Sometimes Valgrind tools run out of memory in their space when the client space is not full, and vice versa. N |
|
From: Robert W. <rj...@du...> - 2005-02-25 22:40:52
|
> > And should we consider defaulting to memcheck again? >=20 > I don't think so; it is still the best way to imply that there are other= =20 > tools. I vote for a default too. I use memcheck 95% of the time and it's getting tiring typing those extra letters :-) --=20 Robert Walsh Amalgamated Durables, Inc. - "We don't make the things you buy." Email: rj...@du... |