You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
1
(5) |
2
(5) |
|
3
(5) |
4
(6) |
5
(6) |
6
(10) |
7
(10) |
8
(10) |
9
(10) |
|
10
(6) |
11
(6) |
12
(8) |
13
(33) |
14
(19) |
15
(6) |
16
(15) |
|
17
(8) |
18
(29) |
19
(23) |
20
(20) |
21
(8) |
22
(6) |
23
(6) |
|
24
(6) |
25
(22) |
26
(21) |
27
(9) |
28
(21) |
29
(11) |
30
(7) |
|
31
(16) |
|
|
|
|
|
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 18:40:53
|
CVS commit by nethercote:
Build vg_replace_malloc.c into a library, because it makes the Makefiles a bit
neater. Also remove some dodgy CFLAGS+= lines.
I had to change the expected output of pth_once.c, because the change has
altered the order of the (non-deterministic) output.
M +5 -3 addrcheck/Makefile.am 1.53
M +1 -1 corecheck/tests/pth_once.c 1.3
M +0 -10 corecheck/tests/pth_once.stdout.exp 1.3
M +15 -16 coregrind/Makefile.am 1.94
M +5 -3 helgrind/Makefile.am 1.50
M +6 -3 massif/Makefile.am 1.6
M +5 -3 memcheck/Makefile.am 1.53
M +0 -10 memcheck/tests/pth_once.stdout.exp 1.2
--- valgrind/addrcheck/Makefile.am #1.52:1.53
@@ -15,9 +15,11 @@
vgpreload_addrcheck_so_SOURCES =
vgpreload_addrcheck_so_LDADD = \
- $(top_builddir)/coregrind/vg_replace_malloc.o \
../memcheck/mac_replace_strmem.o
vgpreload_addrcheck_so_DEPENDENCIES = \
- $(top_builddir)/coregrind/vg_replace_malloc.o \
+ $(top_builddir)/coregrind/lib_replace_malloc.a \
../memcheck/mac_replace_strmem.o
-vgpreload_addrcheck_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst
+vgpreload_addrcheck_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst \
+ -Wl,--whole-archive \
+ $(top_builddir)/coregrind/lib_replace_malloc.a \
+ -Wl,--no-whole-archive
--- valgrind/corecheck/tests/pth_once.c #1.2:1.3
@@ -76,5 +76,5 @@ main(void)
for (thread_num = 0; thread_num < NUM_THREADS; thread_num++) {
pthread_join(threads[thread_num], NULL);
- printf("main: joined to thread %d\n", thread_num);
+ //printf("main: joined to thread %d\n", thread_num);
}
printf("main: Goodbye\n");
--- valgrind/corecheck/tests/pth_once.stdout.exp #1.2:1.3
@@ -10,13 +10,3 @@
identify_yourself: Hi, I'm thread # 8
identify_yourself: Hi, I'm thread # 9
-main: joined to thread 0
-main: joined to thread 1
-main: joined to thread 2
-main: joined to thread 3
-main: joined to thread 4
-main: joined to thread 5
-main: joined to thread 6
-main: joined to thread 7
-main: joined to thread 8
-main: joined to thread 9
main: Goodbye
--- valgrind/coregrind/Makefile.am #1.93:1.94
@@ -20,4 +20,15 @@
vg_inject.so
+noinst_LIBRARIES = lib_replace_malloc.a
+
+noinst_HEADERS = \
+ core.h \
+ core_asm.h \
+ ume.h \
+ vg_symtab2.h \
+ vg_symtypes.h \
+ vg_toolint.h \
+ vg_unsafe.h
+
EXTRA_DIST = \
vg_libpthread.vs valgrind.vs \
@@ -116,5 +127,5 @@
libpthread_so_DEPENDENCIES = $(srcdir)/vg_libpthread.vs
libpthread_so_LDFLAGS = -Werror -fno-omit-frame-pointer -UVG_LIBDIR \
- -shared -fpic -ldl \
+ -shared -ldl \
-Wl,-version-script $(srcdir)/vg_libpthread.vs \
-Wl,-z,nodelete \
@@ -123,9 +134,5 @@
vg_inject_so_SOURCES = \
vg_intercept.c
-
-# Not really true, but we need to build vg_replace_malloc.o somehow
-vg_inject_so_DEPENDENCIES = \
- vg_replace_malloc.o
-
+vg_inject_so_CFLAGS = $(AM_CFLAGS) -fpic
vg_inject_so_LDFLAGS = \
-shared \
@@ -133,17 +140,9 @@
-Wl,-z,initfirst
-noinst_HEADERS = \
- core.h \
- core_asm.h \
- ume.h \
- vg_symtab2.h \
- vg_symtypes.h \
- vg_toolint.h \
- vg_unsafe.h
+lib_replace_malloc_a_SOURCES = vg_replace_malloc.c
+lib_replace_malloc_a_CFLAGS = $(AM_CFLAGS) -fpic
MANUAL_DEPS = $(noinst_HEADERS) $(include_HEADERS) $(inplacedir)/libpthread.so.0
-vg_replace_malloc.o vg_intercept.o vg_libpthread.o: CFLAGS += -fno-omit-frame-pointer -g -fpic
-
all-local:
mkdir -p $(inplacedir)
--- valgrind/helgrind/Makefile.am #1.49:1.50
@@ -7,7 +7,9 @@
vgpreload_helgrind_so_SOURCES =
-vgpreload_helgrind_so_LDADD = $(top_builddir)/coregrind/vg_replace_malloc.o
-vgpreload_helgrind_so_DEPENDENCIES = $(top_builddir)/coregrind/vg_replace_malloc.o
-vgpreload_helgrind_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst
+vgpreload_helgrind_so_DEPENDENCIES = $(top_builddir)/coregrind/lib_replace_malloc.a
+vgpreload_helgrind_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst \
+ -Wl,--whole-archive \
+ $(top_builddir)/coregrind/lib_replace_malloc.a \
+ -Wl,--no-whole-archive
hgincludedir = $(includedir)/valgrind
--- valgrind/massif/Makefile.am #1.5:1.6
@@ -9,6 +9,9 @@
vgpreload_massif_so_SOURCES =
-vgpreload_massif_so_LDADD = $(top_builddir)/coregrind/vg_replace_malloc.o
-vgpreload_massif_so_DEPENDENCIES = $(top_builddir)/coregrind/vg_replace_malloc.o
-vgpreload_massif_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst
+vgpreload_massif_so_DEPENDENCIES = $(top_builddir)/coregrind/lib_replace_malloc.a
+vgpreload_massif_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst \
+ -Wl,--whole-archive \
+ $(top_builddir)/coregrind/lib_replace_malloc.a \
+ -Wl,--no-whole-archive
+
--- valgrind/memcheck/Makefile.am #1.52:1.53
@@ -8,7 +8,9 @@
vgpreload_memcheck_so_SOURCES = \
mac_replace_strmem.c
-vgpreload_memcheck_so_LDADD = $(top_builddir)/coregrind/vg_replace_malloc.o
-vgpreload_memcheck_so_DEPENDENCIES = $(top_builddir)/coregrind/vg_replace_malloc.o
-vgpreload_memcheck_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst
+vgpreload_memcheck_so_DEPENDENCIES = $(top_builddir)/coregrind/lib_replace_malloc.a
+vgpreload_memcheck_so_LDFLAGS = -shared -Wl,-z,interpose,-z,initfirst \
+ -Wl,--whole-archive \
+ $(top_builddir)/coregrind/lib_replace_malloc.a \
+ -Wl,--no-whole-archive
vgskin_memcheck_so_SOURCES = \
--- valgrind/memcheck/tests/pth_once.stdout.exp #1.1:1.2
@@ -10,13 +10,3 @@
identify_yourself: Hi, I'm thread # 8
identify_yourself: Hi, I'm thread # 9
-main: joined to thread 0
-main: joined to thread 1
-main: joined to thread 2
-main: joined to thread 3
-main: joined to thread 4
-main: joined to thread 5
-main: joined to thread 6
-main: joined to thread 7
-main: joined to thread 8
-main: joined to thread 9
main: Goodbye
|
|
From: Tom H. <th...@cy...> - 2004-10-20 14:28:31
|
In message <016101c4b6ac$1be1f5c0$248...@os...>
Aleksander Salwa <A....@os...> wrote:
> I've found that pthread_attr_setstacksize doesn't work. Fix is very simple.
> Here comes patch for pthread_create, please commit it into cvs:
It looks like Nick beat me to it. For future reference though things
like this are much less likely to slip through the cracks if they are
posted to the bug tracker - if you post here then you're relying on
somebody either being able to do it straight away or else remembering
to come back later and commit it.
Thanks for catching the problem though.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 14:25:51
|
On Wed, 20 Oct 2004, Aleksander Salwa wrote: > I've found that pthread_attr_setstacksize doesn't work. Fix is very simple. > Here comes patch for pthread_create, please commit it into cvs: Done. It will be in the next release. Thanks a lot for the patch. N |
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 14:24:52
|
CVS commit by nethercote:
Fix typo, courtesy of Aleksander Salwa.
MERGED FROM HEAD
M +1 -1 vg_libpthread.c 1.161.2.1
--- valgrind/coregrind/vg_libpthread.c #1.161:1.161.2.1
@@ -1168,5 +1168,5 @@ pthread_create (pthread_t *__restrict __
sigprocmask(SIG_SETMASK, NULL, &info->sigmask);
- if (__attr) {
+ if (__vg_attr) {
si.base = (Addr)__vg_attr->__vg_stackaddr;
si.size = __vg_attr->__vg_stacksize;
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 14:23:06
|
CVS commit by nethercote:
Fix typo, courtesy of Aleksander Salwa.
M +1 -1 vg_libpthread.c 1.175
--- valgrind/coregrind/vg_libpthread.c #1.174:1.175
@@ -1069,5 +1069,5 @@ pthread_create (pthread_t *__restrict __
sigprocmask(SIG_SETMASK, NULL, &info->sigmask);
- if (__attr) {
+ if (__vg_attr) {
si.base = (Addr)__vg_attr->__vg_stackaddr;
si.size = __vg_attr->__vg_stacksize;
|
|
From: Aleksander S. <A....@os...> - 2004-10-20 13:53:15
|
Hi,
I've found that pthread_attr_setstacksize doesn't work. Fix is very simpl=
e.
Here comes patch for pthread_create, please commit it into cvs:
Index: coregrind/vg_libpthread.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/kde/valgrind/coregrind/vg_libpthread.c,v
retrieving revision 1.174
diff -u -r1.174 vg_libpthread.c
--- coregrind/vg_libpthread.c 19 Oct 2004 13:17:59 -0000 1.174
+++ coregrind/vg_libpthread.c 20 Oct 2004 13:44:23 -0000
@@ -1068,7 +1068,7 @@
info->arg =3D __arg;
sigprocmask(SIG_SETMASK, NULL, &info->sigmask);
- if (__attr) {
+ if (__vg_attr) {
si.base =3D (Addr)__vg_attr->__vg_stackaddr;
si.size =3D __vg_attr->__vg_stacksize;
si.guardsize =3D __vg_attr->__vg_guardsize;
--=20
Aleksander Salwa
OSMOSYS Technologies
ul. Ro=BCdzie=F1skiego 188B
Katowice, Poland
office: +48327810470
fax: +48618513128
http://www.osmosys.tv=20
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 13:33:10
|
CVS commit by nethercote: Make tests that cause coredumps remove them. Don't need the core entries in .cvsignore any more as a result. M +0 -1 memcheck/tests/.cvsignore 1.20 M +1 -0 memcheck/tests/badjump.vgtest 1.3 M +0 -1 none/tests/.cvsignore 1.21 M +1 -0 none/tests/x86/int.vgtest 1.2 --- valgrind/memcheck/tests/.cvsignore #1.19:1.20 @@ -61,5 +61,4 @@ realloc3 threadederrno -vgcore.pid* writev zeropage --- valgrind/memcheck/tests/badjump.vgtest #1.2:1.3 @@ -1 +1,2 @@ prog: badjump +delete: vgcore.pid* --- valgrind/none/tests/.cvsignore #1.20:1.21 @@ -60,5 +60,4 @@ pth_yield tls -vgcore.pid* yield *.stdout.diff --- valgrind/none/tests/x86/int.vgtest #1.1:1.2 @@ -1,2 +1,3 @@ prog: int stderr_filter: filter_int +delete: vgcore.pid* |
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 13:22:01
|
CVS commit by nethercote:
Arch-abstraction:
- conditionally compile x86-specific line within yield.c.
M +1 -0 Makefile.am 1.47
M +4 -0 yield.c 1.2
--- valgrind/none/tests/Makefile.am #1.46:1.47
@@ -108,4 +108,5 @@
#tls2_so_LDFLAGS = -shared
yield_SOURCES = yield.c
+yield_CFLAGS = $(AM_CFLAGS) -D__$(VG_ARCH)__
yield_LDADD = -lpthread
--- valgrind/none/tests/yield.c #1.1:1.2
@@ -36,5 +36,9 @@ static void *th2(void *v)
while(alive) {
rep_nop++;
+#ifdef __x86__
+ // This gives a hint to a P4, telling it to pause
+ // (ie. we're in a spin-wait loop)
asm volatile ("rep; nop" : : : "memory");
+#endif
}
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 13:02:29
|
CVS commit by nethercote:
whoops
M +1 -1 Makefile.am 1.3
--- valgrind/none/tests/x86/Makefile.am #1.2:1.3
@@ -15,5 +15,5 @@
$(addsuffix .stderr.exp,$(INSN_TESTS)) \
$(addsuffix .stdout.exp,$(INSN_TESTS)) \
- $(addsuffix .vgtest,$(INSN_TESTS))
+ $(addsuffix .vgtest,$(INSN_TESTS)) \
pushpopseg.stderr.exp pushpopseg.stdout.exp pushpopseg.vgtest \
rcl_assert.stderr.exp rcl_assert.vgtest \
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 12:36:57
|
CVS commit by nethercote:
Arch-abstraction:
- Factor out remaining x86-specific regtests in none/ into an x86/ subdir.
A x86/badseg.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/badseg.stderr.exp 1.1
A x86/badseg.stdout.exp 1.1
A x86/badseg.vgtest 1.1
A x86/bt_everything.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/bt_everything.stderr.exp 1.1
A x86/bt_everything.stdout.exp 1.1
A x86/bt_everything.vgtest 1.1
A x86/bt_literal.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/bt_literal.stderr.exp 1.1
A x86/bt_literal.stdout.exp 1.1
A x86/bt_literal.vgtest 1.1
A x86/cpuid.stderr.exp 1.1
A x86/cpuid.stdout.exp 1.1
A x86/cpuid.vgtest 1.1
A x86/cpuid_c.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/cpuid_s.s 1.1
A x86/dastest.stderr.exp 1.1
A x86/dastest.stdout.exp 1.1
A x86/dastest.vgtest 1.1
A x86/dastest_c.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/dastest_s.s 1.1
A x86/filter_cpuid 1.1
A x86/filter_int 1.1
A x86/fpu_lazy_eflags.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/fpu_lazy_eflags.stderr.exp 1.1
A x86/fpu_lazy_eflags.stdout.exp 1.1
A x86/fpu_lazy_eflags.vgtest 1.1
A x86/int.c 1.1 [no copyright]
A x86/int.stderr.exp 1.1
A x86/int.stdout.exp 1.1
A x86/int.vgtest 1.1
A x86/pushpopseg.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/pushpopseg.stderr.exp 1.1
A x86/pushpopseg.stdout.exp 1.1
A x86/pushpopseg.vgtest 1.1
A x86/rcl_assert.S 1.1
A x86/rcl_assert.stderr.exp 1.1
A x86/rcl_assert.vgtest 1.1
A x86/seg_override.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/seg_override.stderr.exp 1.1
A x86/seg_override.stdout.exp 1.1
A x86/seg_override.vgtest 1.1
M +3 -13 .cvsignore 1.20
M +7 -32 Makefile.am 1.46
M +1 -48 x86/.cvsignore 1.2
M +25 -2 x86/Makefile.am 1.2
R badseg.c 1.2
R badseg.stderr.exp 1.1
R badseg.stdout.exp 1.1
R badseg.vgtest 1.1
R bt_everything.c 1.2
R bt_everything.stderr.exp 1.2
R bt_everything.stdout.exp 1.2
R bt_everything.vgtest 1.2
R bt_literal.c 1.2
R bt_literal.stderr.exp 1.2
R bt_literal.stdout.exp 1.2
R bt_literal.vgtest 1.2
R cpuid.stderr.exp 1.2
R cpuid.stdout.exp 1.4
R cpuid.vgtest 1.3
R cpuid_c.c 1.2
R cpuid_s.s 1.2
R dastest.stderr.exp 1.2
R dastest.stdout.exp 1.2
R dastest.vgtest 1.2
R dastest_c.c 1.2
R dastest_s.s 1.2
R filter_cpuid 1.1
R filter_int 1.1
R fpu_lazy_eflags.c 1.1
R fpu_lazy_eflags.stderr.exp 1.1
R fpu_lazy_eflags.stdout.exp 1.1
R fpu_lazy_eflags.vgtest 1.1
R int.c 1.1
R int.stderr.exp 1.2
R int.stdout.exp 1.1
R int.vgtest 1.1
R pushpopseg.c 1.2
R pushpopseg.stderr.exp 1.1
R pushpopseg.stdout.exp 1.1
R pushpopseg.vgtest 1.1
R rcl_assert.S 1.2
R rcl_assert.stderr.exp 1.2
R rcl_assert.vgtest 1.2
R seg_override.c 1.2
R seg_override.stderr.exp 1.1
R seg_override.stdout.exp 1.1
R seg_override.vgtest 1.1
--- valgrind/none/tests/.cvsignore #1.19:1.20
@@ -2,13 +2,8 @@
Makefile
args
-badseg
bitfield1
-bt_everything
-bt_literal
closeall
coolo_sigaction
coolo_strlen
-cpuid
-dastest
discard
exec-sigmask
@@ -17,5 +12,4 @@
floored
fork
-fpu_lazy_eflags
fucomip
gxx304
@@ -34,5 +28,4 @@
insn_sse2
insn_sse2.c
-int
map_unmap
mq
@@ -41,10 +34,8 @@
pluto
pth_blockedsig
-rcl_assert
rcrl
readline1
resolv
rlimit_nofile
-seg_override
sem
semlimit
@@ -68,10 +59,9 @@
pth_specific
pth_yield
-pushpopseg
+tls
+vgcore.pid*
+yield
*.stdout.diff
*.stderr.diff
*.stdout.out
*.stderr.out
-tls
-vgcore.pid*
-yield
--- valgrind/none/tests/Makefile.am #1.45:1.46
@@ -1,14 +1,9 @@
SUBDIRS = ${VG_ARCH} .
-noinst_SCRIPTS = filter_cpuid filter_none_discards filter_stderr filter_int
+noinst_SCRIPTS = filter_none_discards filter_stderr
EXTRA_DIST = $(noinst_SCRIPTS) \
args.stderr.exp args.stdout.exp args.vgtest \
- badseg.stderr.exp badseg.stdout.exp badseg.vgtest \
bitfield1.stderr.exp bitfield1.vgtest \
- bt_everything.stderr.exp \
- bt_everything.stdout.exp bt_everything.vgtest \
- bt_literal.stderr.exp bt_literal.stdout.exp \
- bt_literal.vgtest \
closeall.stderr.exp closeall.vgtest \
cmdline1.stderr.exp cmdline1.stdout.exp cmdline1.vgtest \
@@ -21,7 +16,4 @@
coolo_sigaction.stdout.exp coolo_sigaction.vgtest \
coolo_strlen.stderr.exp coolo_strlen.vgtest \
- cpuid.stderr.exp cpuid.stdout.exp cpuid.vgtest \
- dastest.stderr.exp dastest.stdout.exp \
- dastest.vgtest \
discard.stderr.exp discard.stdout.exp \
discard.vgtest \
@@ -32,9 +24,6 @@
floored.vgtest \
fork.stderr.exp fork.stdout.exp fork.vgtest \
- fpu_lazy_eflags.stderr.exp fpu_lazy_eflags.stdout.exp \
- fpu_lazy_eflags.vgtest \
fucomip.stderr.exp fucomip.vgtest \
gxx304.stderr.exp gxx304.vgtest \
- int.stderr.exp int.stdout.exp int.vgtest \
map_unmap.stderr.exp map_unmap.stdout.exp map_unmap.vgtest \
mq.stderr.exp mq.vgtest \
@@ -43,6 +32,4 @@
pth_blockedsig.stderr.exp \
pth_blockedsig.stdout.exp pth_blockedsig.vgtest \
- pushpopseg.stderr.exp pushpopseg.stdout.exp pushpopseg.vgtest \
- rcl_assert.stderr.exp rcl_assert.vgtest \
rcrl.stderr.exp rcrl.stdout.exp rcrl.vgtest \
readline1.stderr.exp readline1.stdout.exp \
@@ -50,6 +37,4 @@
resolv.stderr.exp resolv.stdout.exp resolv.vgtest \
rlimit_nofile.stderr.exp rlimit_nofile.stdout.exp rlimit_nofile.vgtest \
- seg_override.stderr.exp \
- seg_override.stdout.exp seg_override.vgtest \
sem.stderr.exp sem.stdout.exp sem.vgtest \
semlimit.stderr.exp semlimit.stdout.exp semlimit.vgtest \
@@ -66,10 +51,10 @@
check_PROGRAMS = \
- args badseg bitfield1 bt_everything bt_literal closeall coolo_strlen \
- cpuid dastest discard exec-sigmask execve fcntl_setown floored fork \
- fpu_lazy_eflags fucomip \
- int munmap_exe map_unmap mq mremap rcl_assert rcrl readline1 \
- resolv rlimit_nofile seg_override sem semlimit sha1_test \
- shortpush shorts smc1 susphello pth_blockedsig pushpopseg \
+ args bitfield1 closeall coolo_strlen \
+ discard exec-sigmask execve fcntl_setown floored fork \
+ fucomip \
+ munmap_exe map_unmap mq mremap rcrl readline1 \
+ resolv rlimit_nofile sem semlimit sha1_test \
+ shortpush shorts smc1 susphello pth_blockedsig \
syscall-restart1 syscall-restart2 system \
coolo_sigaction gxx304 yield
@@ -80,12 +65,7 @@
# generic C ones
args_SOURCES = args.c
-badseg_SOURCES = badseg.c
bitfield1_SOURCES = bitfield1.c
-bt_everything_SOURCES = bt_everything.c
-bt_literal_SOURCES = bt_literal.c
closeall_SOURCES = closeall.c
-cpuid_SOURCES = cpuid_c.c cpuid_s.s
coolo_strlen_SOURCES = coolo_strlen.c
-dastest_SOURCES = dastest_c.c dastest_s.s
discard_SOURCES = discard.c
exec_sigmask_SOURCES = exec-sigmask.c
@@ -95,7 +75,5 @@
floored_SOURCES = floored.c
floored_LDADD = -lm
-fpu_lazy_eflags_SOURCES = fpu_lazy_eflags.c
fucomip_SOURCES = fucomip.c
-int_SOURCES = int.c
map_unmap_SOURCES = map_unmap.c
mq_SOURCES = mq.c
@@ -103,11 +81,8 @@
mremap_SOURCES = mremap.c
munmap_exe_SOURCES = munmap_exe.c
-pushpopseg_SOURCES = pushpopseg.c
-rcl_assert_SOURCES = rcl_assert.S
rcrl_SOURCES = rcrl.c
readline1_SOURCES = readline1.c
resolv_SOURCES = resolv.c
rlimit_nofile_SOURCES = rlimit_nofile.c
-seg_override_SOURCES = seg_override.c
sem_SOURCES = sem.c
semlimit_SOURCES = semlimit.c
--- valgrind/none/tests/x86/.cvsignore #1.1:1.2
@@ -1,23 +1,10 @@
Makefile.in
Makefile
-args
badseg
-bitfield1
bt_everything
bt_literal
-closeall
-coolo_sigaction
-coolo_strlen
cpuid
dastest
-discard
-exec-sigmask
-execve
-fcntl_setown
-floored
-fork
fpu_lazy_eflags
-fucomip
-gxx304
insn_basic
insn_basic.c
@@ -35,43 +22,9 @@
insn_sse2.c
int
-map_unmap
-mq
-mremap
-munmap_exe
-pluto
-pth_blockedsig
+pushpopseg
rcl_assert
-rcrl
-readline1
-resolv
-rlimit_nofile
seg_override
-sem
-semlimit
-sha1_test
-shortpush
-shorts
-smc1
-susphello
-syscall-restart1
-syscall-restart2
-system
-pth_atfork1
-pth_cancel1
-pth_cancel2
-pth_cvsimple
-pth_mutexspeed
-pth_once
-pth_semaphore1
-pth_simple_mutex
-pth_simple_threads
-pth_specific
-pth_yield
-pushpopseg
*.stdout.diff
*.stderr.diff
*.stdout.out
*.stderr.out
-tls
-vgcore.pid*
-yield
--- valgrind/none/tests/x86/Makefile.am #1.1:1.2
@@ -1,3 +1,3 @@
-noinst_SCRIPTS = filter_stderr gen_insn_test.pl
+noinst_SCRIPTS = filter_cpuid filter_int filter_stderr gen_insn_test.pl
CLEANFILES = $(addsuffix .c,$(INSN_TESTS))
@@ -5,10 +5,23 @@
EXTRA_DIST = $(noinst_SCRIPTS) \
+ badseg.stderr.exp badseg.stdout.exp badseg.vgtest \
+ bt_everything.stderr.exp bt_everything.stdout.exp bt_everything.vgtest \
+ bt_literal.stderr.exp bt_literal.stdout.exp bt_literal.vgtest \
+ cpuid.stderr.exp cpuid.stdout.exp cpuid.vgtest \
+ dastest.stderr.exp dastest.stdout.exp dastest.vgtest \
+ fpu_lazy_eflags.stderr.exp fpu_lazy_eflags.stdout.exp \
+ fpu_lazy_eflags.vgtest \
+ int.stderr.exp int.stdout.exp int.vgtest \
$(addsuffix .stderr.exp,$(INSN_TESTS)) \
$(addsuffix .stdout.exp,$(INSN_TESTS)) \
$(addsuffix .vgtest,$(INSN_TESTS))
+ pushpopseg.stderr.exp pushpopseg.stdout.exp pushpopseg.vgtest \
+ rcl_assert.stderr.exp rcl_assert.vgtest \
+ seg_override.stderr.exp seg_override.stdout.exp seg_override.vgtest
check_PROGRAMS = \
- $(INSN_TESTS)
+ badseg bt_everything bt_literal cpuid dastest fpu_lazy_eflags \
+ $(INSN_TESTS) \
+ int pushpopseg rcl_assert seg_override
AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g -I$(top_srcdir)/include
@@ -16,4 +29,10 @@
# generic C ones
+badseg_SOURCES = badseg.c
+bt_everything_SOURCES = bt_everything.c
+bt_literal_SOURCES = bt_literal.c
+cpuid_SOURCES = cpuid_c.c cpuid_s.s
+dastest_SOURCES = dastest_c.c dastest_s.s
+fpu_lazy_eflags_SOURCES = fpu_lazy_eflags.c
insn_basic_SOURCES = insn_basic.def
insn_basic_LDADD = -lm
@@ -30,4 +49,8 @@
insn_sse2_SOURCES = insn_sse2.def
insn_sse2_LDADD = -lm
+int_SOURCES = int.c
+pushpopseg_SOURCES = pushpopseg.c
+rcl_assert_SOURCES = rcl_assert.S
+seg_override_SOURCES = seg_override.c
.def.c: $(srcdir)/gen_insn_test.pl
|
|
From: Tom H. <th...@cy...> - 2004-10-20 12:26:04
|
CVS commit by thughes:
When nuking threads we set their status to VgTs_Empty. This patch
ensures that any associated mutex and conditional variable pointers
are also cleared so that the thread state appears sane.
BUG: 91599
M +2 -0 vg_scheduler.c 1.192
--- valgrind/coregrind/vg_scheduler.c #1.191:1.192
@@ -1374,4 +1374,6 @@ void VG_(nuke_all_threads_except) ( Thre
VG_(proxy_delete)(tid, True);
VG_(threads)[tid].status = VgTs_Empty;
+ VG_(threads)[tid].associated_mx = NULL;
+ VG_(threads)[tid].associated_cv = NULL;
cleanup_after_thread_exited( tid, True );
}
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 11:43:09
|
CVS commit by nethercote:
Arch-abstraction:
- move remaining x86-specific Memcheck tests into an x86/ subdir.
A x86/filter_pushfpopf 1.1
A x86/filter_tronical 1.1
A x86/fpeflags.c 1.1 [no copyright]
A x86/fpeflags.stderr.exp 1.1
A x86/fpeflags.vgtest 1.1
A x86/pushfpopf.stderr.exp 1.1
A x86/pushfpopf.stdout.exp 1.1
A x86/pushfpopf.vgtest 1.1
A x86/pushfpopf_c.c 1.1 [POSSIBLY UNSAFE: printf] [no copyright]
A x86/pushfpopf_s.s 1.1
A x86/tronical.S 1.1
A x86/tronical.stderr.exp 1.1
A x86/tronical.vgtest 1.1
M +0 -3 .cvsignore 1.19
M +4 -13 Makefile.am 1.49
M +3 -0 x86/.cvsignore 1.2
M +18 -2 x86/Makefile.am 1.2
R filter_pushfpopf 1.2
R filter_tronical 1.2
R fpeflags.c 1.2
R fpeflags.stderr.exp 1.1
R fpeflags.vgtest 1.1
R pushfpopf.stderr.exp 1.7
R pushfpopf.stdout.exp 1.2
R pushfpopf.vgtest 1.4
R pushfpopf_c.c 1.2
R pushfpopf_s.s 1.2
R tronical.S 1.3
R tronical.stderr.exp 1.7
R tronical.vgtest 1.4
--- valgrind/memcheck/tests/.cvsignore #1.18:1.19
@@ -19,5 +19,4 @@
filter_leak_check_size
filter_stderr
-fpeflags
fprw
fwrite
@@ -41,5 +40,4 @@
null_socket
overlap
-pushfpopf
realloc1
realloc2
@@ -50,5 +48,4 @@
suppfree
trivialleak
-tronical
vgtest_ume
weirdioctl
--- valgrind/memcheck/tests/Makefile.am #1.48:1.49
@@ -2,6 +2,5 @@
noinst_SCRIPTS = filter_allocs filter_leak_check_size \
- filter_stderr filter_stderr_backtrace filter_pushfpopf \
- filter_tronical
+ filter_stderr filter_stderr_backtrace
EXTRA_DIST = $(noinst_SCRIPTS) \
@@ -26,5 +25,4 @@
execve.stderr.exp execve.vgtest \
execve2.stderr.exp execve2.vgtest \
- fpeflags.stderr.exp fpeflags.vgtest \
fprw.stderr.exp fprw.vgtest \
fwrite.stderr.exp fwrite.stdout.exp fwrite.vgtest \
@@ -50,5 +48,4 @@
overlap.stderr.exp overlap.stdout.exp overlap.vgtest \
pth_once.stderr.exp pth_once.stdout.exp pth_once.vgtest \
- pushfpopf.stderr.exp pushfpopf.stdout.exp pushfpopf.vgtest \
realloc1.stderr.exp realloc1.vgtest \
realloc2.stderr.exp realloc2.vgtest \
@@ -63,5 +60,4 @@
toobig-allocs.stderr.exp toobig-allocs.vgtest \
trivialleak.stderr.exp trivialleak.vgtest \
- tronical.stderr.exp tronical.vgtest \
weirdioctl.stderr.exp weirdioctl.stdout.exp weirdioctl.vgtest \
metadata.stderr.exp metadata.stdout.exp metadata.vgtest \
@@ -77,11 +73,11 @@
clientperm custom_alloc \
doublefree error_counts errs1 exitprog execve execve2 \
- fpeflags fprw fwrite hello inits inline \
+ fprw fwrite hello inits inline \
malloc1 malloc2 malloc3 manuel1 manuel2 manuel3 \
memalign_test memalign2 memcmptest mempool mmaptest \
nanoleak new_nothrow \
- null_socket overlap pushfpopf \
+ null_socket overlap \
realloc1 realloc2 realloc3 sigaltstack signal2 supp1 supp2 suppfree \
- trivialleak tronical weirdioctl \
+ trivialleak weirdioctl \
mismatches new_override metadata threadederrno \
vgtest_ume \
@@ -111,5 +107,4 @@
execve2_SOURCES = execve2.c
exitprog_SOURCES = exitprog.c
-fpeflags_SOURCES = fpeflags.c
fprw_SOURCES = fprw.c
fwrite_SOURCES = fwrite.c
@@ -130,5 +125,4 @@
null_socket_SOURCES = null_socket.c
overlap_SOURCES = overlap.c
-pushfpopf_SOURCES = pushfpopf_c.c pushfpopf_s.s
realloc1_SOURCES = realloc1.c
realloc2_SOURCES = realloc2.c
@@ -140,5 +134,4 @@
sigaltstack_SOURCES = sigaltstack.c
trivialleak_SOURCES = trivialleak.c
-tronical_SOURCES = tronical.S
weirdioctl_SOURCES = weirdioctl.c
metadata_SOURCES = metadata.c
@@ -161,4 +154,2 @@
../../coregrind/jmp_with_stack.o
-# must be built with these flags -- bug only occurred with them
-fpeflags.o: CFLAGS += -march=i686
--- valgrind/memcheck/tests/x86/.cvsignore #1.1:1.2
@@ -1,4 +1,7 @@
Makefile.in
Makefile
+fpeflags
+pushfpopf
+tronical
*.stdout.diff
*.stderr.diff*
--- valgrind/memcheck/tests/x86/Makefile.am #1.1:1.2
@@ -1,8 +1,24 @@
-noinst_SCRIPTS = filter_stderr
+noinst_SCRIPTS = filter_stderr filter_pushfpopf filter_tronical
INSN_TESTS=insn_basic insn_fpu insn_cmov insn_mmx insn_mmxext insn_sse insn_sse2
EXTRA_DIST = $(noinst_SCRIPTS) \
+ fpeflags.stderr.exp fpeflags.vgtest \
$(addsuffix .stderr.exp,$(INSN_TESTS)) \
$(addsuffix .stdout.exp,$(INSN_TESTS)) \
- $(addsuffix .vgtest,$(INSN_TESTS))
+ $(addsuffix .vgtest,$(INSN_TESTS)) \
+ pushfpopf.stderr.exp pushfpopf.stdout.exp pushfpopf.vgtest \
+ tronical.stderr.exp tronical.vgtest
+
+check_PROGRAMS = \
+ fpeflags pushfpopf tronical
+
+AM_CPPFLAGS = -I$(top_srcdir)/include
+AM_CFLAGS = $(WERROR) -Winline -Wall -Wshadow -g
+AM_CXXFLAGS = $(AM_CFLAGS)
+
+fpeflags_SOURCES = fpeflags.c
+# must be built with these flags -- bug only occurred with them
+fpeflags_CFLAGS = $(AM_CFLAGS) -march=i686
+pushfpopf_SOURCES = pushfpopf_c.c pushfpopf_s.s
+tronical_SOURCES = tronical.S
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 11:05:37
|
CVS commit by nethercote:
Arch-abstraction:
- Abstractify one remaining mention of the stack pointer.
M +1 -1 vg_main.c 1.218
--- valgrind/coregrind/vg_main.c #1.217:1.218
@@ -340,5 +340,5 @@ void VG_(unimplemented) ( Char* msg )
Addr VG_(get_stack_pointer) ( void )
{
- return VG_(baseBlock)[VGOFF_(m_esp)];
+ return VG_(baseBlock)[VGOFF_STACK_PTR];
}
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 10:58:15
|
CVS commit by nethercote:
Arch-abstraction:
- Make Helgrind totally arch-agnostic.
M +0 -3 coregrind/x86/core_arch.h 1.13
M +44 -43 helgrind/hg_main.c 1.85
M +4 -0 include/x86/tool_arch.h 1.5
--- valgrind/coregrind/x86/core_arch.h #1.12:1.13
@@ -49,7 +49,4 @@
// Accessors for the baseBlock
-#define R_STACK_PTR R_ESP
-#define R_FRAME_PTR R_EBP
-
#define R_CLREQ_RET R_EDX
#define R_PTHREQ_RET R_EDX
--- valgrind/helgrind/hg_main.c #1.84:1.85
@@ -225,17 +225,17 @@ static const shadow_word error_sword = S
changed state (if required) */
-typedef struct EC_EIP {
- union u_ec_eip {
- Addr eip;
+typedef struct EC_IP {
+ union u_ec_ip {
+ Addr ip;
ExeContext *ec;
- } uu_ec_eip;
+ } uu_ec_ip;
UInt state:STATE_BITS;
UInt tls:OTHER_BITS; /* packed TLS */
-} EC_EIP;
+} EC_IP;
-#define NULL_EC_EIP ((EC_EIP){ { 0 }, 0, 0})
+#define NULL_EC_IP ((EC_IP){ { 0 }, 0, 0})
-#define EIP(eip, prev, tls) ((EC_EIP) { (union u_ec_eip)(eip), (prev).state, packTLS(tls) })
-#define EC(ec, prev, tls) ((EC_EIP) { (union u_ec_eip)(ec), (prev).state, packTLS(tls) })
+#define IP(ip, prev, tls) ((EC_IP) { (union u_ec_ip)(ip), (prev).state, packTLS(tls) })
+#define EC(ec, prev, tls) ((EC_IP) { (union u_ec_ip)(ec), (prev).state, packTLS(tls) })
static inline UInt packEC(ExeContext *ec)
@@ -250,11 +250,11 @@ static inline ExeContext *unpackEC(UInt
}
-/* Lose 2 LSB of eip */
-static inline UInt packEIP(Addr eip)
+/* Lose 2 LSB of IP */
+static inline UInt packIP(Addr ip)
{
- return ((UInt)eip) >> STATE_BITS;
+ return ((UInt)ip) >> STATE_BITS;
}
-static inline Addr unpackEIP(UInt i)
+static inline Addr unpackIP(UInt i)
{
return (Addr)(i << STATE_BITS);
@@ -262,10 +262,10 @@ static inline Addr unpackEIP(UInt i)
typedef struct {
- EC_EIP execontext[ESEC_MAP_WORDS];
+ EC_IP execontext[ESEC_MAP_WORDS];
} ExeContextMap;
static ExeContextMap** execontext_map;
-static inline void setExeContext(Addr a, EC_EIP ec)
+static inline void setExeContext(Addr a, EC_IP ec)
{
UInt idx = (a >> 16) & 0xffff;
@@ -280,9 +280,9 @@ static inline void setExeContext(Addr a,
}
-static inline EC_EIP getExeContext(Addr a)
+static inline EC_IP getExeContext(Addr a)
{
UInt idx = (a >> 16) & 0xffff;
UInt off = (a >> 2) & 0x3fff;
- EC_EIP ec = NULL_EC_EIP;
+ EC_IP ec = NULL_EC_IP;
if (execontext_map[idx] != NULL)
@@ -563,5 +563,5 @@ void init_virgin_sword(Addr a)
{
if (clo_execontext != EC_None)
- setExeContext(a, NULL_EC_EIP);
+ setExeContext(a, NULL_EC_IP);
set_sword(a, virgin_sword);
}
@@ -2045,6 +2045,6 @@ UCodeBlock* SK_(instrument) ( UCodeBlock
/* stackref[] is used for super-simple value tracking to keep note
of which tempregs currently hold a value which is derived from
- ESP or EBP, and is therefore likely stack-relative if used as
- the address for LOAD or STORE. */
+ the stack pointer or frame pointer, and is therefore likely
+ stack-relative if used as the address for LOAD or STORE. */
ntemps = VG_(get_num_temps)(cb);
stackref = VG_(malloc)(sizeof(*stackref) * ntemps);
@@ -2080,5 +2080,6 @@ UCodeBlock* SK_(instrument) ( UCodeBlock
stackref[u_in->val2] = (u_in->size == 4 &&
- (u_in->val1 == R_ESP || u_in->val1 == R_EBP));
+ (u_in->val1 == R_STACK_PTR ||
+ u_in->val1 == R_FRAME_PTR));
VG_(copy_UInstr)(cb, u_in);
break;
@@ -2316,5 +2317,5 @@ typedef
const Char* filename;
const Char* section;
- /* True if is just-below %esp -- could be a gcc bug. */
+ /* True if is just-below the stack pointer -- could be a gcc bug. */
Bool maybe_gcc;
/* symbolic address description */
@@ -2338,5 +2339,5 @@ typedef
/* MutexErr, LockGraphErr */
Mutex *mutex;
- EC_EIP lasttouched;
+ EC_IP lasttouched;
ThreadId lasttid;
/* LockGraphErr */
@@ -2367,5 +2368,5 @@ void clear_HelgrindError ( HelgrindError
err_extra->size = 0;
err_extra->mutex = NULL;
- err_extra->lasttouched= NULL_EC_EIP;
+ err_extra->lasttouched= NULL_EC_IP;
err_extra->lasttid = VG_INVALID_THREADID;
err_extra->prev_lockset = 0;
@@ -2577,5 +2578,5 @@ static void pp_AddrInfo ( Addr a, AddrIn
if (ai->maybe_gcc) {
VG_(message)(Vg_UserMsg,
- " Address %p is just below %%esp. Possibly a bug in GCC/G++",
+ " Address %p is just below the stack pointer. Possibly a bug in GCC/G++",
a);
VG_(message)(Vg_UserMsg,
@@ -2698,8 +2699,8 @@ void SK_(pp_SkinError) ( Error* err )
if (clo_execontext == EC_Some
- && extra->lasttouched.uu_ec_eip.eip != 0) {
+ && extra->lasttouched.uu_ec_ip.ip != 0) {
Char file[100];
UInt line;
- Addr eip = extra->lasttouched.uu_ec_eip.eip;
+ Addr ip = extra->lasttouched.uu_ec_ip.ip;
VG_(message)(Vg_UserMsg, " Word at %p last changed state from %s by thread %u",
@@ -2708,20 +2709,20 @@ void SK_(pp_SkinError) ( Error* err )
unpackTLS(extra->lasttouched.tls)->tid);
- if (VG_(get_filename_linenum)(eip, file, sizeof(file), &line)) {
+ if (VG_(get_filename_linenum)(ip, file, sizeof(file), &line)) {
VG_(message)(Vg_UserMsg, " at %p: %y (%s:%u)",
- eip, eip, file, line);
- } else if (VG_(get_objname)(eip, file, sizeof(file))) {
+ ip, ip, file, line);
+ } else if (VG_(get_objname)(ip, file, sizeof(file))) {
VG_(message)(Vg_UserMsg, " at %p: %y (in %s)",
- eip, eip, file);
+ ip, ip, file);
} else {
- VG_(message)(Vg_UserMsg, " at %p: %y", eip, eip);
+ VG_(message)(Vg_UserMsg, " at %p: %y", ip, ip);
}
} else if (clo_execontext == EC_All
- && extra->lasttouched.uu_ec_eip.ec != NULL) {
+ && extra->lasttouched.uu_ec_ip.ec != NULL) {
VG_(message)(Vg_UserMsg, " Word at %p last changed state from %s in tid %u",
err_addr,
pp_state(extra->lasttouched.state),
unpackTLS(extra->lasttouched.tls)->tid);
- VG_(pp_ExeContext)(extra->lasttouched.uu_ec_eip.ec);
+ VG_(pp_ExeContext)(extra->lasttouched.uu_ec_ip.ec);
}
break;
@@ -2734,7 +2735,7 @@ void SK_(pp_SkinError) ( Error* err )
VG_(get_error_string)(err));
VG_(pp_ExeContext)( VG_(get_error_where)(err) );
- if (extra->lasttouched.uu_ec_eip.ec != NULL) {
+ if (extra->lasttouched.uu_ec_ip.ec != NULL) {
VG_(message)(Vg_UserMsg, " last touched by thread %d", extra->lasttid);
- VG_(pp_ExeContext)(extra->lasttouched.uu_ec_eip.ec);
+ VG_(pp_ExeContext)(extra->lasttouched.uu_ec_ip.ec);
}
pp_AddrInfo(VG_(get_error_address)(err), &extra->addrinfo);
@@ -3024,11 +3025,11 @@ static void eraser_mem_read_word(Addr a,
done:
if (clo_execontext != EC_None && statechange) {
- EC_EIP eceip;
+ EC_IP ecip;
if (clo_execontext == EC_Some)
- eceip = EIP(VG_(get_EIP)(tid), prevstate, tls);
+ ecip = IP(VG_(get_EIP)(tid), prevstate, tls);
else
- eceip = EC(VG_(get_ExeContext)(tid), prevstate, tls);
- setExeContext(a, eceip);
+ ecip = EC(VG_(get_ExeContext)(tid), prevstate, tls);
+ setExeContext(a, ecip);
}
}
@@ -3129,11 +3130,11 @@ static void eraser_mem_write_word(Addr a
done:
if (clo_execontext != EC_None && statechange) {
- EC_EIP eceip;
+ EC_IP ecip;
if (clo_execontext == EC_Some)
- eceip = EIP(VG_(get_EIP)(tid), prevstate, tls);
+ ecip = IP(VG_(get_EIP)(tid), prevstate, tls);
else
- eceip = EC(VG_(get_ExeContext)(tid), prevstate, tls);
- setExeContext(a, eceip);
+ ecip = EC(VG_(get_ExeContext)(tid), prevstate, tls);
+ setExeContext(a, ecip);
}
}
--- valgrind/include/x86/tool_arch.h #1.4:1.5
@@ -41,4 +41,8 @@
#define REGPARM(n) __attribute__((regparm(n)))
+// Accessors for the baseBlock
+#define R_STACK_PTR R_ESP
+#define R_FRAME_PTR R_EBP
+
#define FIRST_ARCH_REG R_EAX
#define LAST_ARCH_REG R_EDI
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-20 10:37:04
|
CVS commit by nethercote:
Arch-abstraction:
- Make Lackey talk about "machine instructions" rather than "x86 instructions".
M +25 -25 lk_main.c 1.25
--- valgrind/lackey/lk_main.c #1.24:1.25
@@ -36,5 +36,5 @@ static ULong n_dlrr_calls = 0;
static ULong n_BBs = 0;
static ULong n_UInstrs = 0;
-static ULong n_x86_instrs = 0;
+static ULong n_machine_instrs = 0;
static ULong n_Jccs = 0;
static ULong n_Jccs_untaken = 0;
@@ -45,10 +45,10 @@ static void add_one_dlrr_call(void)
}
-/* See comment above SK_(instrument) for reason why n_x86_instrs is
+/* See comment above SK_(instrument) for reason why n_machine_instrs is
incremented here. */
static void add_one_BB(void)
{
n_BBs++;
- n_x86_instrs++;
+ n_machine_instrs++;
}
@@ -58,7 +58,7 @@ static void add_one_UInstr(void)
}
-static void add_one_x86_instr(void)
+static void add_one_machine_instr(void)
{
- n_x86_instrs++;
+ n_machine_instrs++;
}
@@ -85,5 +85,5 @@ void SK_(pre_clo_init)(void)
VG_(register_compact_helper)((Addr) & add_one_dlrr_call);
VG_(register_compact_helper)((Addr) & add_one_BB);
- VG_(register_compact_helper)((Addr) & add_one_x86_instr);
+ VG_(register_compact_helper)((Addr) & add_one_machine_instr);
VG_(register_compact_helper)((Addr) & add_one_UInstr);
VG_(register_compact_helper)((Addr) & add_one_Jcc);
@@ -95,5 +95,5 @@ void SK_(post_clo_init)(void)
}
-/* Note: x86 instructions are marked by an INCEIP at the end of each one,
+/* Note: machine instructions are marked by an INCEIP at the end of each one,
except for the final one in the basic block which ends in an
unconditional JMP. Sometimes the final unconditional JMP is preceded by
@@ -107,16 +107,16 @@ void SK_(post_clo_init)(void)
JMP ... (will not be reached if Jcc succeeds)
- If we simplemindedly added calls to add_one_x86_instr() before INCEIPs
+ If we simplemindedly added calls to add_one_machine_instr() before INCEIPs
and unconditional JMPs, we'd sometimes miss the final call (when a
- preceding conditional JMP succeeds), underestimating the x86 instruction
+ preceding conditional JMP succeeds), underestimating the machine instruction
count.
<code a>
- call add_one_x86_instr()
+ call add_one_machine_instr()
INCEIP ...
<code b>
Jcc ...
- call add_one_x86_instr()
+ call add_one_machine_instr()
JMP ...
@@ -124,8 +124,8 @@ void SK_(post_clo_init)(void)
block, but not one at the end, viz:
- call add_one_x86_instr()
+ call add_one_machine_instr()
<code a>
- call add_one_x86_instr()
+ call add_one_machine_instr()
INCEIP ...
@@ -164,6 +164,6 @@ UCodeBlock* SK_(instrument)(UCodeBlock*
case INCEIP:
- /* Count x86 instr */
- VG_(call_helper_0_0)(cb, (Addr) & add_one_x86_instr);
+ /* Count machine instr */
+ VG_(call_helper_0_0)(cb, (Addr) & add_one_machine_instr);
VG_(copy_UInstr)(cb, u);
break;
@@ -200,22 +200,22 @@ void SK_(fini)(Int exitcode)
VG_(message)(Vg_UserMsg, "");
VG_(message)(Vg_UserMsg, "Executed:");
- VG_(message)(Vg_UserMsg, " BBs: %u", n_BBs);
- VG_(message)(Vg_UserMsg, " x86 instrs: %u", n_x86_instrs);
- VG_(message)(Vg_UserMsg, " UInstrs: %u", n_UInstrs);
+ VG_(message)(Vg_UserMsg, " BBs: %llu", n_BBs);
+ VG_(message)(Vg_UserMsg, " machine instrs: %llu", n_machine_instrs);
+ VG_(message)(Vg_UserMsg, " UInstrs: %llu", n_UInstrs);
VG_(message)(Vg_UserMsg, "");
VG_(message)(Vg_UserMsg, "Jccs:");
- VG_(message)(Vg_UserMsg, " total: %u", n_Jccs);
- VG_(message)(Vg_UserMsg, " %% taken: %u%%",
+ VG_(message)(Vg_UserMsg, " total: %llu", n_Jccs);
+ VG_(message)(Vg_UserMsg, " %% taken: %llu%%",
(n_Jccs - n_Jccs_untaken)*100 / n_Jccs);
VG_(message)(Vg_UserMsg, "");
VG_(message)(Vg_UserMsg, "Ratios:");
- VG_(message)(Vg_UserMsg, " x86 instrs : BB = %3u : 10",
- 10 * n_x86_instrs / n_BBs);
- VG_(message)(Vg_UserMsg, " UInstrs : BB = %3u : 10",
+ VG_(message)(Vg_UserMsg, " machine instrs : BB = %3llu : 10",
+ 10 * n_machine_instrs / n_BBs);
+ VG_(message)(Vg_UserMsg, " UInstrs : BB = %3llu : 10",
10 * n_UInstrs / n_BBs);
- VG_(message)(Vg_UserMsg, " UInstrs : x86_instr = %3u : 10",
- 10 * n_UInstrs / n_x86_instrs);
+ VG_(message)(Vg_UserMsg, " UInstrs : machine_instr = %3llu : 10",
+ 10 * n_UInstrs / n_machine_instrs);
VG_(message)(Vg_UserMsg, "");
|
|
From: Tom H. <th...@cy...> - 2004-10-20 03:12:38
|
Nightly build on standard ( Red Hat 7.2 ) started at 2004-10-20 02:00:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow munmap_exe: valgrind ./munmap_exe pth_blockedsig: valgrind ./pth_blockedsig *** pth_blockedsig failed (stdout) *** *** pth_blockedsig failed (stderr) *** pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert rcrl: valgrind ./rcrl readline1: valgrind ./readline1 resolv: valgrind ./resolv rlimit_nofile: valgrind ./rlimit_nofile seg_override: valgrind ./seg_override sem: valgrind ./sem semlimit: valgrind ./semlimit sha1_test: valgrind ./sha1_test shortpush: valgrind ./shortpush shorts: valgrind ./shorts smc1: valgrind ./smc1 susphello: valgrind ./susphello Could not read `susphello.stderr.exp' make: *** [regtest] Error 2 |
|
From: <js...@ac...> - 2004-10-20 02:55:40
|
Nightly build on phoenix ( SuSE 9.1 ) started at 2004-10-20 03:50:00 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow corecheck/tests/pth_once (stdout) corecheck/tests/pth_once (stderr) corecheck/tests/res_search (stdout) helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) memcheck/tests/pth_once (stdout) memcheck/tests/threadederrno (stdout) memcheck/tests/writev (stderr) none/tests/pth_blockedsig (stdout) none/tests/pth_blockedsig (stderr) none/tests/susphello (stdout) none/tests/susphello (stderr) none/tests/yield (stdout) none/tests/yield (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2004-10-20 02:19:49
|
Nightly build on audi ( Red Hat 9 ) started at 2004-10-20 03:15:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow insn_fpu: valgrind ./insn_fpu insn_mmx: valgrind ./insn_mmx insn_mmxext: valgrind ./insn_mmxext insn_sse: valgrind ./insn_sse insn_sse2: (cpu_test failed, skipping) -- Finished tests in none/tests/x86 ------------------------------------ yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 182 tests, 8 stderr failures, 0 stdout failures ================= corecheck/tests/fdleak_cmsg (stderr) corecheck/tests/fdleak_fcntl (stderr) corecheck/tests/fdleak_ipv4 (stderr) corecheck/tests/fdleak_socketpair (stderr) memcheck/tests/buflen_check (stderr) memcheck/tests/execve (stderr) memcheck/tests/execve2 (stderr) memcheck/tests/writev (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2004-10-20 02:13:16
|
Nightly build on ginetta ( Red Hat 8.0 ) started at 2004-10-20 03:10:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow corecheck/tests/pth_exit (stderr) corecheck/tests/pth_once (stdout) corecheck/tests/pth_once (stderr) corecheck/tests/res_search (stdout) helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) memcheck/tests/pth_once (stdout) memcheck/tests/threadederrno (stdout) none/tests/pth_blockedsig (stdout) none/tests/pth_blockedsig (stderr) none/tests/susphello (stdout) none/tests/susphello (stderr) none/tests/yield (stdout) none/tests/yield (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2004-10-20 02:08:07
|
Nightly build on alvis ( Red Hat 7.3 ) started at 2004-10-20 03:05:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) memcheck/tests/badjump (stderr) memcheck/tests/brk (stderr) memcheck/tests/brk2 (stderr) memcheck/tests/error_counts (stdout) memcheck/tests/pth_once (stdout) memcheck/tests/threadederrno (stdout) memcheck/tests/toobig-allocs (stderr) memcheck/tests/vgtest_ume (stderr) memcheck/tests/writev (stderr) none/tests/pth_blockedsig (stdout) none/tests/pth_blockedsig (stderr) none/tests/susphello (stdout) none/tests/susphello (stderr) none/tests/yield (stdout) none/tests/yield (stderr) make: *** [regtest] Error 1 |