You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
|
|
|
1
(5) |
2
(5) |
|
3
(5) |
4
(6) |
5
(6) |
6
(10) |
7
(10) |
8
(10) |
9
(10) |
|
10
(6) |
11
(6) |
12
(8) |
13
(33) |
14
(19) |
15
(6) |
16
(15) |
|
17
(8) |
18
(29) |
19
(23) |
20
(20) |
21
(8) |
22
(6) |
23
(6) |
|
24
(6) |
25
(22) |
26
(21) |
27
(9) |
28
(21) |
29
(11) |
30
(7) |
|
31
(16) |
|
|
|
|
|
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-29 13:17:46
|
CVS commit by nethercote:
whoops
M +1 -1 Makefile.am 1.50
--- valgrind/none/tests/Makefile.am #1.49:1.50
@@ -18,5 +18,5 @@
discard.stderr.exp discard.stdout.exp \
discard.vgtest \
- exec-sigmask.vgtest exec-sigmask.stdout.exp
+ exec-sigmask.vgtest exec-sigmask.stdout.exp \
exec-sigmask.stdout.exp2 exec-sigmask.stderr.exp \
execve.vgtest execve.stdout.exp execve.stderr.exp \
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-29 11:21:29
|
CVS commit by nethercote:
Fix typo that meant --signal-polltime was not being accepted.
MERGED FROM HEAD
M +1 -1 vg_main.c 1.198.2.4
--- valgrind/coregrind/vg_main.c #1.198.2.3:1.198.2.4
@@ -1723,5 +1723,5 @@ static void process_cmd_line_options( UI
else VG_NUM_CLO ("--input-fd", VG_(clo_input_fd))
else VG_NUM_CLO ("--sanity-level", VG_(clo_sanity_level))
- else VG_NUM_CLO ("--signalpolltime", VG_(clo_signal_polltime))
+ else VG_NUM_CLO ("--signal-polltime", VG_(clo_signal_polltime))
else VG_BNUM_CLO("--num-callers", VG_(clo_backtrace_size), 1,
VG_DEEPEST_BACKTRACE)
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-29 11:17:31
|
CVS commit by nethercote:
Fix typo that meant --signal-polltime was not being accepted.
MERGE TO STABLE
M +1 -1 vg_main.c 1.222
--- valgrind/coregrind/vg_main.c #1.221:1.222
@@ -1764,5 +1764,5 @@ static void process_cmd_line_options( UI
else VG_NUM_CLO ("--input-fd", VG_(clo_input_fd))
else VG_NUM_CLO ("--sanity-level", VG_(clo_sanity_level))
- else VG_NUM_CLO ("--signalpolltime", VG_(clo_signal_polltime))
+ else VG_NUM_CLO ("--signal-polltime", VG_(clo_signal_polltime))
else VG_BNUM_CLO("--num-callers", VG_(clo_backtrace_size), 1,
VG_DEEPEST_BACKTRACE)
|
|
From: Tom H. <th...@cy...> - 2004-10-29 03:06:27
|
Nightly build on standard ( Red Hat 7.2 ) started at 2004-10-29 02:00:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow map_unmap: valgrind ./map_unmap mq: valgrind ./mq mremap: valgrind ./mremap munmap_exe: valgrind ./munmap_exe pth_blockedsig: valgrind ./pth_blockedsig rcrl: valgrind ./rcrl readline1: valgrind ./readline1 resolv: valgrind ./resolv rlimit_nofile: valgrind ./rlimit_nofile sem: valgrind ./sem semlimit: valgrind ./semlimit sha1_test: valgrind ./sha1_test shortpush: valgrind ./shortpush shorts: valgrind ./shorts smc1: valgrind ./smc1 susphello: valgrind ./susphello syscall-restart1: valgrind ./syscall-restart1 syscall-restart2: valgrind ./syscall-restart2 Could not read `syscall-restart2.stderr.exp' make: *** [regtest] Error 2 |
|
From: <js...@ac...> - 2004-10-29 02:50:13
|
Nightly build on phoenix ( SuSE 9.1 ) started at 2004-10-29 03:50:00 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow Nightly build on phoenix ( SuSE 9.1 ) started at 2004-10-29 03:50:00 BST |
|
From: Tom H. <th...@cy...> - 2004-10-29 02:20:03
|
Nightly build on audi ( Red Hat 9 ) started at 2004-10-29 03:15:04 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow insn_sse2: (cpu_test failed, skipping) int: valgrind ./int pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert seg_override: valgrind ./seg_override -- Finished tests in none/tests/x86 ------------------------------------ yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 182 tests, 8 stderr failures, 0 stdout failures ================= corecheck/tests/fdleak_cmsg (stderr) corecheck/tests/fdleak_fcntl (stderr) corecheck/tests/fdleak_ipv4 (stderr) corecheck/tests/fdleak_socketpair (stderr) memcheck/tests/buflen_check (stderr) memcheck/tests/execve (stderr) memcheck/tests/execve2 (stderr) memcheck/tests/writev (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2004-10-29 02:13:30
|
Nightly build on ginetta ( Red Hat 8.0 ) started at 2004-10-29 03:10:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow insn_mmxext: valgrind ./insn_mmxext insn_sse: valgrind ./insn_sse insn_sse2: (cpu_test failed, skipping) int: valgrind ./int pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert seg_override: valgrind ./seg_override -- Finished tests in none/tests/x86 ------------------------------------ yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 182 tests, 6 stderr failures, 0 stdout failures ================= helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) make: *** [regtest] Error 1 |
|
From: Tom H. <th...@cy...> - 2004-10-29 02:08:20
|
Nightly build on alvis ( Red Hat 7.3 ) started at 2004-10-29 03:05:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 182 tests, 13 stderr failures, 1 stdout failure ================= addrcheck/tests/toobig-allocs (stderr) helgrind/tests/allok (stderr) helgrind/tests/deadlock (stderr) helgrind/tests/inherit (stderr) helgrind/tests/race (stderr) helgrind/tests/race2 (stderr) helgrind/tests/readshared (stderr) memcheck/tests/badjump (stderr) memcheck/tests/brk (stderr) memcheck/tests/brk2 (stderr) memcheck/tests/error_counts (stdout) memcheck/tests/toobig-allocs (stderr) memcheck/tests/vgtest_ume (stderr) memcheck/tests/writev (stderr) make: *** [regtest] Error 1 |
|
From: Nicholas N. <nj...@ca...> - 2004-10-28 16:54:09
|
CVS commit by nethercote:
Fix off-by-one error with VKI_GDT_TLS_MAX.
M +1 -1 coregrind/vg_ldt.c 1.16.2.1
M +1 -1 include/vg_kerneliface.h 1.23.2.1
--- valgrind/coregrind/vg_ldt.c #1.16:1.16.2.1
@@ -197,5 +197,5 @@ Addr VG_(do_useseg) ( UInt seg_selector,
VgLdtEntry* the_tls;
- vg_assert(seg_selector >= VKI_GDT_TLS_MIN && seg_selector < VKI_GDT_TLS_MAX);
+ vg_assert(seg_selector >= VKI_GDT_TLS_MIN && seg_selector <= VKI_GDT_TLS_MAX);
/* Come up with a suitable GDT entry. We look at the thread's TLS
--- valgrind/include/vg_kerneliface.h #1.23:1.23.2.1
@@ -666,5 +666,5 @@ typedef struct vki_modify_ldt_ldt_s {
#define VKI_GDT_TLS_ENTRIES 3
#define VKI_GDT_TLS_MIN 6
-#define VKI_GDT_TLS_MAX (VKI_GDT_TLS_MIN + VKI_GDT_TLS_ENTRIES)
+#define VKI_GDT_TLS_MAX (VKI_GDT_TLS_MIN + VKI_GDT_TLS_ENTRIES - 1)
/* Flags for clone() */
|
|
From: Tom H. <th...@cy...> - 2004-10-28 15:57:01
|
CVS commit by thughes:
When a thread is cancelled only abort pending system calls if
the thread is set for asynchronous cancellation and cancellation
is enabled. This fixes a long standing occasional failure in
the pth_cancel2 test.
M +5 -2 vg_scheduler.c 1.193
--- valgrind/coregrind/vg_scheduler.c #1.192:1.193
@@ -1606,6 +1606,9 @@ void do__set_cancelpend ( ThreadId tid,
VG_(threads)[cee].cancel_pend = cancelpend_hdlr;
- /* interrupt a pending syscall */
+ /* interrupt a pending syscall if asynchronous cancellation
+ is enabled for the target thread */
+ if (VG_(threads)[cee].cancel_st && !VG_(threads)[cee].cancel_ty) {
VG_(proxy_abort_syscall)(cee);
+ }
if (VG_(clo_trace_sched)) {
|
|
From: Tom H. <th...@cy...> - 2004-10-28 13:52:55
|
CVS commit by thughes: Update expected output for pth_once in memcheck tests. M +10 -10 pth_once.stdout.exp 1.3 --- valgrind/memcheck/tests/pth_once.stdout.exp #1.2:1.3 @@ -1,12 +1,12 @@ welcome: Welcome -identify_yourself: Hi, I'm thread # 0 -identify_yourself: Hi, I'm thread # 1 -identify_yourself: Hi, I'm thread # 2 -identify_yourself: Hi, I'm thread # 3 -identify_yourself: Hi, I'm thread # 4 -identify_yourself: Hi, I'm thread # 5 -identify_yourself: Hi, I'm thread # 6 -identify_yourself: Hi, I'm thread # 7 -identify_yourself: Hi, I'm thread # 8 -identify_yourself: Hi, I'm thread # 9 +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread +identify_yourself: Hi, I'm a thread main: Goodbye |
|
From: Tom H. <th...@cy...> - 2004-10-28 13:47:17
|
CVS commit by thughes:
Add -fno-omit-frame-pointer when building libpthread.so as that gets
loaded into the user's program and we want to be able to trace the
stack properly. Also add -fpic given that the code is going into a
shared library.
M +1 -0 Makefile.am 1.101
--- valgrind/coregrind/Makefile.am #1.100:1.101
@@ -130,4 +130,5 @@
${VG_PLATFORM}/syscall.S
libpthread_so_DEPENDENCIES = $(srcdir)/vg_libpthread.vs
+libpthread_so_CFLAGS = $(AM_CFLAGS) -fpic -fno-omit-frame-pointer
libpthread_so_LDFLAGS = -Werror -fno-omit-frame-pointer -UVG_LIBDIR \
-shared -ldl \
|
|
From: Tom H. <th...@cy...> - 2004-10-28 13:39:55
|
CVS commit by thughes:
Remove the thread numbers from the messages output by pth_once so that
the order the threads run in doesn't affect the output.
M +1 -2 pth_once.c 1.4 [POSSIBLY UNSAFE: printf]
M +10 -10 pth_once.stdout.exp 1.4
--- valgrind/corecheck/tests/pth_once.c #1.3:1.4
@@ -40,5 +40,4 @@ void welcome(void)
void *identify_yourself(void *arg)
{
- int *pid=(int *)arg;
int rtn;
@@ -48,5 +47,5 @@ void *identify_yourself(void *arg)
pthread_exit((void *)NULL);
}
- printf("identify_yourself: Hi, I'm thread # %d\n",*pid);
+ printf("identify_yourself: Hi, I'm a thread\n");
return(NULL);
}
--- valgrind/corecheck/tests/pth_once.stdout.exp #1.3:1.4
@@ -1,12 +1,12 @@
welcome: Welcome
-identify_yourself: Hi, I'm thread # 0
-identify_yourself: Hi, I'm thread # 1
-identify_yourself: Hi, I'm thread # 2
-identify_yourself: Hi, I'm thread # 3
-identify_yourself: Hi, I'm thread # 4
-identify_yourself: Hi, I'm thread # 5
-identify_yourself: Hi, I'm thread # 6
-identify_yourself: Hi, I'm thread # 7
-identify_yourself: Hi, I'm thread # 8
-identify_yourself: Hi, I'm thread # 9
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
+identify_yourself: Hi, I'm a thread
main: Goodbye
|
|
From: Julian S. <js...@ac...> - 2004-10-28 09:46:19
|
> > On Thu, 28 Oct 2004, Tom Hughes wrote: > >> This led to a number of subtle and hard to locate problems caused by > >> stack based arrays being overflowed by one entry when a node was > >> allocated with the maximum level. As each node only has a one in two > >> million or so chance of getting a level of SK_MAXHEIGHT this didn't > >> actually happen all that often. > > > > Urgh... well spotted. Yes .. I second that .. thanks for tracking this down. J |
|
From: Nicholas N. <nj...@ca...> - 2004-10-28 09:18:31
|
On Thu, 28 Oct 2004, Tom Hughes wrote: > Plus it usually took 5-10 minutes for the assertion to fire even when > the code was right to trigger it. I eventually worked it out late last > night and left that test running overnight to make sure I really had > got it. More reason that having unit tests, run under Memcheck, is a good idea. (Even though Memcheck probably wouldn't have spotted this, since it was a stack problem.) N |
|
From: Tom H. <th...@cy...> - 2004-10-28 08:45:59
|
In message <Pin...@he...>
Nicholas Nethercote <nj...@ca...> wrote:
> On Thu, 28 Oct 2004, Tom Hughes wrote:
>
>> This led to a number of subtle and hard to locate problems caused by
>> stack based arrays being overflowed by one entry when a node was
>> allocated with the maximum level. As each node only has a one in two
>> million or so chance of getting a level of SK_MAXHEIGHT this didn't
>> actually happen all that often.
>
> Urgh... well spotted.
It took a while to work out what was going on. I had it failing in
unmap_range but every time I changed the code to print more details
it stopped happening. That turned out to be because SkipList_Remove
was corrupting the stacked copy of ebx which unmap_range was using
to store the value of s which is used in the assertion that was
firing. Unfortunately changing unmap_range tended to mean it used
a different register and the assertion no longer triggered...
Plus it usually took 5-10 minutes for the assertion to fire even when
the code was right to trigger it. I eventually worked it out late last
night and left that test running overnight to make sure I really had
got it.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|
|
From: Nicholas N. <nj...@ca...> - 2004-10-28 08:39:59
|
On Thu, 28 Oct 2004, Tom Hughes wrote: > This led to a number of subtle and hard to locate problems caused by > stack based arrays being overflowed by one entry when a node was > allocated with the maximum level. As each node only has a one in two > million or so chance of getting a level of SK_MAXHEIGHT this didn't > actually happen all that often. Urgh... well spotted. N |
|
From: Tom H. <th...@cy...> - 2004-10-28 08:18:57
|
CVS commit by thughes:
Cope with arguments over 510 characters in length when writing the
cachegrind output file.
MERGED FROM HEAD
M +2 -2 cg_main.c 1.76.2.2
--- valgrind/cachegrind/cg_main.c #1.76.2.1:1.76.2.2
@@ -1144,6 +1144,6 @@ static void fprint_CC_table_and_calc_tot
VG_(write)(fd, (void*)buf, VG_(strlen)(buf));
for (i = 0; i < VG_(client_argc); i++) {
- VG_(sprintf)(buf, " %s", VG_(client_argv)[i]);
- VG_(write)(fd, (void*)buf, VG_(strlen)(buf));
+ VG_(write)(fd, "", 1);
+ VG_(write)(fd, VG_(client_argv)[i], VG_(strlen)(VG_(client_argv)[i]));
}
// "events:" line
|
|
From: Tom H. <th...@cy...> - 2004-10-28 08:18:02
|
CVS commit by thughes:
Don't free the interpreter structure until we've actually finished
using it... Possible fix for bug 89663 spotted by Mike Cavins.
MERGED FROM HEAD
M +1 -1 ume.c 1.20.2.1
--- valgrind/coregrind/ume.c #1.20:1.20.2.1
@@ -526,8 +526,8 @@ static int load_ELF(char *hdr, int len,
close(interp->fd);
- free(interp);
entry = baseoff + interp->e.e_entry;
info->interp_base = (ESZ(Addr))base;
+ free(interp);
} else
entry = (void *)e->e.e_entry;
|
|
From: Tom H. <th...@cy...> - 2004-10-28 08:16:42
|
CVS commit by thughes:
Yet another attempt to quash the assertions in the pthread forwarding code.
It appears that the resolution of the address is to forward to is now
working properly but that on some systems the second part of the assertion
fails because the dynamic linker resolves the name of the function being
forwarded to the glibc version rather than the version in valgrind's pthread
library.
The solution is to use dlopen to explicitly obtain a handle to valgrind's
pthread library and then lookup the symbol with dlsym when doing the
comparison in the assertion.
MERGED FROM HEAD
M +7 -1 vg_libpthread.c 1.161.2.2
--- valgrind/coregrind/vg_libpthread.c #1.161.2.1:1.161.2.2
@@ -2243,11 +2243,17 @@ void ** (*__libc_internal_tsd_address)
------------------------------------------------------------------ */
+static void *libpthread_handle;
+
#define FORWARD(name, altname, args...) \
({ \
static name##_t name##_ptr = NULL; \
+ if (libpthread_handle == NULL) { \
+ libpthread_handle = dlopen("libpthread.so.0", RTLD_LAZY); \
+ my_assert(libpthread_handle != NULL); \
+ } \
if (name##_ptr == NULL) { \
if ((name##_ptr = (name##_t)dlsym(RTLD_NEXT, #name)) == NULL) \
name##_ptr = (name##_t)dlsym(RTLD_DEFAULT, #altname); \
- my_assert(name##_ptr != NULL && name##_ptr != name); \
+ my_assert(name##_ptr != NULL && name##_ptr != dlsym(libpthread_handle, #name)); \
} \
name##_ptr(args); \
|
|
From: Tom H. <th...@cy...> - 2004-10-28 08:15:44
|
CVS commit by thughes:
The fix for bug 85811 added decoding of many extra negative type
numbers in stabs and also removed the expectation of a trailing
semicolon after the type number as gcc didn't seem to be putting
one in. It seems that older gcc's do add one however, so we now
skip one if it is there.
MERGED FROM HEAD
M +6 -0 vg_stabs.c 1.14.2.1
--- valgrind/coregrind/vg_stabs.c #1.14:1.14.2.1
@@ -676,4 +676,10 @@ static SymType *stabtype_parser(SegInfo
break;
}
+ /* Different versions of gcc seem to disagree about whether a
+ negative type is followed by a semicolon or not, and the stabs
+ spec (susch as it is) is not clear either so we will skip a
+ semicolon if there is one. */
+ if (*p == ';')
+ p++;
break;
}
|
|
From: Tom H. <th...@cy...> - 2004-10-28 08:09:56
|
CVS commit by thughes:
Fixed get_height to ensure that SK_MAXHEIGHT-1 is the maximum level we
will allocate for a skip list entry as many routines use arrays of
size SK_MAXHEIGHT to hold a set of level pointers which means that a
level of SK_MAXHEIGHT is not valid due to C arrays being zero based.
This led to a number of subtle and hard to locate problems caused by
stack based arrays being overflowed by one entry when a node was
allocated with the maximum level. As each node only has a one in two
million or so chance of getting a level of SK_MAXHEIGHT this didn't
actually happen all that often.
MERGED FROM HEAD
M +1 -1 vg_skiplist.c 1.5.2.1
--- valgrind/coregrind/vg_skiplist.c #1.5:1.5.2.1
@@ -113,5 +113,5 @@ static inline Int get_height(void)
UInt ret = 0;
- while((ret < SK_MAXHEIGHT) && (random() & 1))
+ while((ret < SK_MAXHEIGHT - 1) && (random() & 1))
ret++;
|
|
From: Tom H. <th...@cy...> - 2004-10-28 08:09:11
|
CVS commit by thughes:
Fixed get_height to ensure that SK_MAXHEIGHT-1 is the maximum level we
will allocate for a skip list entry as many routines use arrays of
size SK_MAXHEIGHT to hold a set of level pointers which means that a
level of SK_MAXHEIGHT is not valid due to C arrays being zero based.
This led to a number of subtle and hard to locate problems caused by
stack based arrays being overflowed by one entry when a node was
allocated with the maximum level. As each node only has a one in two
million or so chance of getting a level of SK_MAXHEIGHT this didn't
actually happen all that often.
BUG: 91028
M +1 -1 vg_skiplist.c 1.7
--- valgrind/coregrind/vg_skiplist.c #1.6:1.7
@@ -113,5 +113,5 @@ static inline Int get_height(void)
UInt ret = 0;
- while((ret < SK_MAXHEIGHT) && (random() & 1))
+ while((ret < SK_MAXHEIGHT - 1) && (random() & 1))
ret++;
|
|
From: Tom H. <th...@cy...> - 2004-10-28 07:56:55
|
CVS commit by thughes:
When augmenting the argument vector from the VALGRIND_OPTS environment
variable and/or the .valgrindrc files, make sure that enough space is
allocated for all the old arguments, not just those that are arguments
to valgrind itself.
MERGED FROM HEAD
M +4 -2 vg_main.c 1.198.2.3
--- valgrind/coregrind/vg_main.c #1.198.2.2:1.198.2.3
@@ -591,5 +591,7 @@ static void augment_command_line(Int* vg
char **from;
char **to;
- int env_arg_count, f1_arg_count, f2_arg_count;
+ int orig_arg_count, env_arg_count, f1_arg_count, f2_arg_count;
+
+ for ( orig_arg_count = 0; vg_argv0[orig_arg_count]; orig_arg_count++ );
env_arg_count = count_args(env_clo);
@@ -603,5 +605,5 @@ static void augment_command_line(Int* vg
/* +2: +1 for null-termination, +1 for added '--' */
from = vg_argv0;
- vg_argv0 = malloc( (vg_argc0 + env_arg_count + f1_arg_count
+ vg_argv0 = malloc( (orig_arg_count + env_arg_count + f1_arg_count
+ f2_arg_count + 2) * sizeof(char **));
vg_assert(vg_argv0);
|
|
From: Tom H. <th...@cy...> - 2004-10-28 03:19:33
|
Nightly build on standard ( Red Hat 7.2 ) started at 2004-10-28 02:00:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow badseg: valgrind ./badseg bt_everything: valgrind ./bt_everything bt_literal: valgrind ./bt_literal cpuid: valgrind ./cpuid dastest: valgrind ./dastest fpu_lazy_eflags: valgrind ./fpu_lazy_eflags insn_basic: valgrind ./insn_basic insn_cmov: valgrind ./insn_cmov insn_fpu: valgrind ./insn_fpu insn_mmx: valgrind ./insn_mmx insn_mmxext: valgrind ./insn_mmxext insn_sse: valgrind ./insn_sse insn_sse2: (cpu_test failed, skipping) int: valgrind ./int pushpopseg: valgrind ./pushpopseg rcl_assert: valgrind ./rcl_assert seg_override: valgrind ./seg_override File yield.vgtest not openable -- Finished tests in none/tests/x86 ------------------------------------ make: *** [regtest] Error 2 |