You can subscribe to this list here.
| 2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(122) |
Nov
(152) |
Dec
(69) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2003 |
Jan
(6) |
Feb
(25) |
Mar
(73) |
Apr
(82) |
May
(24) |
Jun
(25) |
Jul
(10) |
Aug
(11) |
Sep
(10) |
Oct
(54) |
Nov
(203) |
Dec
(182) |
| 2004 |
Jan
(307) |
Feb
(305) |
Mar
(430) |
Apr
(312) |
May
(187) |
Jun
(342) |
Jul
(487) |
Aug
(637) |
Sep
(336) |
Oct
(373) |
Nov
(441) |
Dec
(210) |
| 2005 |
Jan
(385) |
Feb
(480) |
Mar
(636) |
Apr
(544) |
May
(679) |
Jun
(625) |
Jul
(810) |
Aug
(838) |
Sep
(634) |
Oct
(521) |
Nov
(965) |
Dec
(543) |
| 2006 |
Jan
(494) |
Feb
(431) |
Mar
(546) |
Apr
(411) |
May
(406) |
Jun
(322) |
Jul
(256) |
Aug
(401) |
Sep
(345) |
Oct
(542) |
Nov
(308) |
Dec
(481) |
| 2007 |
Jan
(427) |
Feb
(326) |
Mar
(367) |
Apr
(255) |
May
(244) |
Jun
(204) |
Jul
(223) |
Aug
(231) |
Sep
(354) |
Oct
(374) |
Nov
(497) |
Dec
(362) |
| 2008 |
Jan
(322) |
Feb
(482) |
Mar
(658) |
Apr
(422) |
May
(476) |
Jun
(396) |
Jul
(455) |
Aug
(267) |
Sep
(280) |
Oct
(253) |
Nov
(232) |
Dec
(304) |
| 2009 |
Jan
(486) |
Feb
(470) |
Mar
(458) |
Apr
(423) |
May
(696) |
Jun
(461) |
Jul
(551) |
Aug
(575) |
Sep
(134) |
Oct
(110) |
Nov
(157) |
Dec
(102) |
| 2010 |
Jan
(226) |
Feb
(86) |
Mar
(147) |
Apr
(117) |
May
(107) |
Jun
(203) |
Jul
(193) |
Aug
(238) |
Sep
(300) |
Oct
(246) |
Nov
(23) |
Dec
(75) |
| 2011 |
Jan
(133) |
Feb
(195) |
Mar
(315) |
Apr
(200) |
May
(267) |
Jun
(293) |
Jul
(353) |
Aug
(237) |
Sep
(278) |
Oct
(611) |
Nov
(274) |
Dec
(260) |
| 2012 |
Jan
(303) |
Feb
(391) |
Mar
(417) |
Apr
(441) |
May
(488) |
Jun
(655) |
Jul
(590) |
Aug
(610) |
Sep
(526) |
Oct
(478) |
Nov
(359) |
Dec
(372) |
| 2013 |
Jan
(467) |
Feb
(226) |
Mar
(391) |
Apr
(281) |
May
(299) |
Jun
(252) |
Jul
(311) |
Aug
(352) |
Sep
(481) |
Oct
(571) |
Nov
(222) |
Dec
(231) |
| 2014 |
Jan
(185) |
Feb
(329) |
Mar
(245) |
Apr
(238) |
May
(281) |
Jun
(399) |
Jul
(382) |
Aug
(500) |
Sep
(579) |
Oct
(435) |
Nov
(487) |
Dec
(256) |
| 2015 |
Jan
(338) |
Feb
(357) |
Mar
(330) |
Apr
(294) |
May
(191) |
Jun
(108) |
Jul
(142) |
Aug
(261) |
Sep
(190) |
Oct
(54) |
Nov
(83) |
Dec
(22) |
| 2016 |
Jan
(49) |
Feb
(89) |
Mar
(33) |
Apr
(50) |
May
(27) |
Jun
(34) |
Jul
(53) |
Aug
(53) |
Sep
(98) |
Oct
(206) |
Nov
(93) |
Dec
(53) |
| 2017 |
Jan
(65) |
Feb
(82) |
Mar
(102) |
Apr
(86) |
May
(187) |
Jun
(67) |
Jul
(23) |
Aug
(93) |
Sep
(65) |
Oct
(45) |
Nov
(35) |
Dec
(17) |
| 2018 |
Jan
(26) |
Feb
(35) |
Mar
(38) |
Apr
(32) |
May
(8) |
Jun
(43) |
Jul
(27) |
Aug
(30) |
Sep
(43) |
Oct
(42) |
Nov
(38) |
Dec
(67) |
| 2019 |
Jan
(32) |
Feb
(37) |
Mar
(53) |
Apr
(64) |
May
(49) |
Jun
(18) |
Jul
(14) |
Aug
(53) |
Sep
(25) |
Oct
(30) |
Nov
(49) |
Dec
(31) |
| 2020 |
Jan
(87) |
Feb
(45) |
Mar
(37) |
Apr
(51) |
May
(99) |
Jun
(36) |
Jul
(11) |
Aug
(14) |
Sep
(20) |
Oct
(24) |
Nov
(40) |
Dec
(23) |
| 2021 |
Jan
(14) |
Feb
(53) |
Mar
(85) |
Apr
(15) |
May
(19) |
Jun
(3) |
Jul
(14) |
Aug
(1) |
Sep
(57) |
Oct
(73) |
Nov
(56) |
Dec
(22) |
| 2022 |
Jan
(3) |
Feb
(22) |
Mar
(6) |
Apr
(55) |
May
(46) |
Jun
(39) |
Jul
(15) |
Aug
(9) |
Sep
(11) |
Oct
(34) |
Nov
(20) |
Dec
(36) |
| 2023 |
Jan
(79) |
Feb
(41) |
Mar
(99) |
Apr
(169) |
May
(48) |
Jun
(16) |
Jul
(16) |
Aug
(57) |
Sep
(19) |
Oct
|
Nov
|
Dec
|
| S | M | T | W | T | F | S |
|---|---|---|---|---|---|---|
|
|
|
1
(8) |
2
(11) |
3
(21) |
4
(15) |
5
(10) |
|
6
(7) |
7
(7) |
8
(5) |
9
(7) |
10
(5) |
11
(1) |
12
(21) |
|
13
(8) |
14
(17) |
15
(6) |
16
(10) |
17
(7) |
18
(6) |
19
(15) |
|
20
(12) |
21
(16) |
22
(25) |
23
(14) |
24
(10) |
25
(7) |
26
(6) |
|
27
(34) |
28
(13) |
29
(10) |
30
(8) |
|
|
|
|
From: Tom H. <th...@cy...> - 2004-06-13 14:36:54
|
In message <Pin...@sc...>
Bob Friesenhahn <bfr...@si...> wrote:
> As of today's patch (yes, autogen.sh was run this time):
>
> if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./demangle -I../include -I./x86
> -DVG_LIBDIR="\"/usr/local/lib/valgrind"\" -Winline -Wall -Wshadow -O
> -fno-omit-frame-pointer -mpreferred-stack-boundary=2 -g -DELFSZ=32
> -MT vg_scheduler.o -MD -MP -MF ".deps/vg_scheduler.Tpo" -c -o
> vg_scheduler.o vg_scheduler.c; \
> then mv -f ".deps/vg_scheduler.Tpo" ".deps/vg_scheduler.Po"; else rm
> -f ".deps/vg_scheduler.Tpo"; exit 1; fi
> vg_scheduler.c: In function `make_thread_jump_to_cancelhdlr':
> vg_scheduler.c:1362: error: `_pthread_descr' undeclared (first use in
> this function)
> vg_scheduler.c:1362: error: (Each undeclared identifier is reported
> only once
> vg_scheduler.c:1362: error: for each function it appears in.)
> vg_scheduler.c:1362: error: syntax error before "tid"
This should be fixed now. I missed something when tweaking a patch
to apply to CVS instead of the 2.0.0 tree it was written for, and
the result only worked with linuxthread headers and not NPTL headers.
Tom
--
Tom Hughes (th...@cy...)
Software Engineer, Cyberscience Corporation
http://www.cyberscience.com/
|
|
From: Tom H. <th...@cy...> - 2004-06-13 14:35:48
|
CVS commit by thughes:
Fixed cast to work on NPTL systems.
M +1 -1 vg_scheduler.c 1.151
--- valgrind/coregrind/vg_scheduler.c #1.150:1.151
@@ -1360,5 +1360,5 @@ void make_thread_jump_to_cancelhdlr ( Th
VG_(threads)[tid].associated_cv = NULL;
VG_(threads)[tid].associated_mx = NULL;
- mx->__vg_m_owner = (_pthread_descr)tid;
+ mx->__vg_m_owner = (/*_pthread_descr*/void*)tid;
mx->__vg_m_count = 1;
/* .m_edx already holds pth_cond_wait success value (0) */
|
|
From: Bob F. <bfr...@si...> - 2004-06-13 14:28:08
|
As of today's patch (yes, autogen.sh was run this time): if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I./demangle -I../include -I./x86 -DVG_LIBDIR="\"/usr/local/lib/valgrind"\" -Winline -Wall -Wshadow -O -fno-omit-frame-pointer -mpreferred-stack-boundary=2 -g -DELFSZ=32 -MT vg_scheduler.o -MD -MP -MF ".deps/vg_scheduler.Tpo" -c -o vg_scheduler.o vg_scheduler.c; \ then mv -f ".deps/vg_scheduler.Tpo" ".deps/vg_scheduler.Po"; else rm -f ".deps/vg_scheduler.Tpo"; exit 1; fi vg_scheduler.c: In function `make_thread_jump_to_cancelhdlr': vg_scheduler.c:1362: error: `_pthread_descr' undeclared (first use in this function) vg_scheduler.c:1362: error: (Each undeclared identifier is reported only once vg_scheduler.c:1362: error: for each function it appears in.) vg_scheduler.c:1362: error: syntax error before "tid" ====================================== Bob Friesenhahn bfr...@si... http://www.simplesystems.org/users/bfriesen |
|
From: Tom H. <th...@cy...> - 2004-06-13 14:23:08
|
CVS commit by thughes:
Add support for the semtimedop system call.
Based on patch from Peter Knaggs <sed...@ya...>.
CCMAIL: 797...@bu...
A none/tests/sem.c 1.1 [no copyright]
A none/tests/sem.stderr.exp 1.1
A none/tests/sem.stdout.exp 1.1
A none/tests/sem.vgtest 1.1
M +8 -1 coregrind/vg_syscalls.c 1.97
M +3 -1 none/tests/Makefile.am 1.36
--- valgrind/coregrind/vg_syscalls.c #1.96:1.97
@@ -2584,4 +2584,11 @@ PRE(ipc)
case 3: /* IPCOP_semctl */
break;
+ case 4: /* IPCOP_semtimedop */
+ SYSCALL_TRACK( pre_mem_read, tid, "semtimedop(sops)", arg5,
+ arg3 * sizeof(struct sembuf) );
+ if (arg6 != (UInt)NULL)
+ SYSCALL_TRACK( pre_mem_read, tid, "semtimedop(timeout)", arg5,
+ sizeof(struct timespec) );
+ break;
case 11: /* IPCOP_msgsnd */
{
@@ -2711,7 +2718,7 @@ POST(ipc)
switch (arg1 /* call */) {
case 1: /* IPCOP_semop */
- break;
case 2: /* IPCOP_semget */
case 3: /* IPCOP_semctl */
+ case 4: /* IPCOP_semtimedop */
break;
case 11: /* IPCOP_msgsnd */
--- valgrind/none/tests/Makefile.am #1.35:1.36
@@ -46,4 +46,5 @@
seg_override.stderr.exp \
seg_override.stdout.exp seg_override.vgtest \
+ sem.stderr.exp sem.stdout.exp sem.vgtest \
semlimit.stderr.exp semlimit.stdout.exp semlimit.vgtest \
susphello.stdout.exp susphello.stderr.exp susphello.vgtest \
@@ -63,5 +64,5 @@
fucomip $(INSN_TESTS) \
int munmap_exe map_unmap mremap rcl_assert \
- rcrl readline1 resolv seg_override semlimit sha1_test \
+ rcrl readline1 resolv seg_override sem semlimit sha1_test \
shortpush shorts smc1 susphello pth_blockedsig pushpopseg \
syscall-restart1 syscall-restart2 system \
@@ -112,4 +113,5 @@
resolv_SOURCES = resolv.c
seg_override_SOURCES = seg_override.c
+sem_SOURCES = sem.c
semlimit_SOURCES = semlimit.c
semlimit_LDADD = -lpthread
|
|
From: Tom H. <th...@cy...> - 2004-06-13 12:07:59
|
CVS commit by thughes:
When cancelling a thread that is waiting on a condition variable we
need to relock the associated mutex before running the cancellation
handlers.
This patch ensures that the mutex is reaquired in the above case and
also makes pthread_join and pthread_cond_wait act as cancellation points
as required by the POSIX threads standard.
Based on patch from Joseph Link <jo...@jo...>.
CCMAIL: 812...@bu...
M +90 -34 vg_scheduler.c 1.150
--- valgrind/coregrind/vg_scheduler.c #1.149:1.150
@@ -1335,6 +1335,4 @@ void make_thread_jump_to_cancelhdlr ( Th
VG_(proxy_abort_syscall)(tid);
- VG_(threads)[tid].status = VgTs_Runnable;
-
/* Make sure we aren't cancelled again whilst handling this
cancellation. */
@@ -1346,4 +1344,49 @@ void make_thread_jump_to_cancelhdlr ( Th
print_sched_event(tid, msg_buf);
}
+
+ if(VG_(threads)[tid].status == VgTs_WaitCV) {
+ /* posix says we must reaquire mutex before handling cancelation */
+ vg_pthread_mutex_t* mx;
+ vg_pthread_cond_t* cond;
+
+ mx = VG_(threads)[tid].associated_mx;
+ cond = VG_(threads)[tid].associated_cv;
+ VG_TRACK( pre_mutex_lock, tid, mx );
+
+ if (mx->__vg_m_owner == VG_INVALID_THREADID) {
+ /* Currently unheld; hand it out to thread tid. */
+ vg_assert(mx->__vg_m_count == 0);
+ VG_(threads)[tid].status = VgTs_Runnable;
+ VG_(threads)[tid].associated_cv = NULL;
+ VG_(threads)[tid].associated_mx = NULL;
+ mx->__vg_m_owner = (_pthread_descr)tid;
+ mx->__vg_m_count = 1;
+ /* .m_edx already holds pth_cond_wait success value (0) */
+
+ VG_TRACK( post_mutex_lock, tid, mx );
+
+ if (VG_(clo_trace_pthread_level) >= 1) {
+ VG_(sprintf)(msg_buf, "%s cv %p: RESUME with mx %p",
+ "pthread_cancel", cond, mx );
+ print_pthread_event(tid, msg_buf);
+ }
+
+ } else {
+ /* Currently held. Make thread tid be blocked on it. */
+ vg_assert(mx->__vg_m_count > 0);
+ VG_(threads)[tid].status = VgTs_WaitMX;
+ VG_(threads)[tid].associated_cv = NULL;
+ VG_(threads)[tid].associated_mx = mx;
+ SET_PTHREQ_RETVAL(tid, 0); /* pth_cond_wait success value */
+
+ if (VG_(clo_trace_pthread_level) >= 1) {
+ VG_(sprintf)(msg_buf, "%s cv %p: BLOCK for mx %p",
+ "pthread_cancel", cond, mx );
+ print_pthread_event(tid, msg_buf);
+ }
+ }
+ } else {
+ VG_(threads)[tid].status = VgTs_Runnable;
+ }
}
@@ -1699,6 +1742,9 @@ void do__set_cancelpend ( ThreadId tid,
/* Perhaps we can nuke the cancellee right now? */
- if (!VG_(threads)[cee].cancel_ty) /* if PTHREAD_CANCEL_ASYNCHRONOUS */
+ if (!VG_(threads)[cee].cancel_ty || /* if PTHREAD_CANCEL_ASYNCHRONOUS */
+ (VG_(threads)[cee].status != VgTs_Runnable &&
+ VG_(threads)[cee].status != VgTs_WaitMX)) {
do__testcancel(cee);
+ }
}
@@ -1752,4 +1798,8 @@ void do_pthread_join ( ThreadId tid,
}
+ if(VG_(threads)[tid].cancel_pend != NULL &&
+ VG_(threads)[tid].cancel_st) {
+ make_thread_jump_to_cancelhdlr ( tid );
+ } else {
/* Mark this thread as waiting for the joinee. */
VG_(threads)[tid].status = VgTs_WaitJoinee;
@@ -1769,4 +1819,5 @@ void do_pthread_join ( ThreadId tid,
print_sched_event(tid, msg_buf);
}
+ }
}
@@ -2432,4 +2483,8 @@ void do_pthread_cond_wait ( ThreadId tid
}
+ if(VG_(threads)[tid].cancel_pend != NULL &&
+ VG_(threads)[tid].cancel_st) {
+ make_thread_jump_to_cancelhdlr ( tid );
+ } else {
/* Queue ourselves on the condition. */
VG_(threads)[tid].status = VgTs_WaitCV;
@@ -2449,4 +2504,5 @@ void do_pthread_cond_wait ( ThreadId tid
/* Release the mutex. */
release_one_thread_waiting_on_mutex ( mutex, "pthread_cond_wait " );
+ }
}
|
|
From: Tom H. <th...@cy...> - 2004-06-13 09:59:13
|
CVS commit by thughes:
Add support for separate debug files, which are just separate ELF files
containing the relevant debug sections and located using the information
in the .gnu_debuglink section of the main file along with some search
rules and checksum logic borrowed from binutils/gdb.
CCMAIL: 828...@bu...
M +199 -1 vg_symtab2.c 1.79
--- valgrind/coregrind/vg_symtab2.c #1.78:1.79
@@ -1004,4 +1004,142 @@ void read_symtab( SegInfo* si, Char* tab
}
+/*
+ * This routine for calculating the CRC for a separate debug file
+ * is GPLed code borrowed from binutils.
+ */
+static UInt
+calc_gnu_debuglink_crc32(UInt crc, const UChar *buf, Int len)
+{
+ static const UInt crc32_table[256] =
+ {
+ 0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419,
+ 0x706af48f, 0xe963a535, 0x9e6495a3, 0x0edb8832, 0x79dcb8a4,
+ 0xe0d5e91e, 0x97d2d988, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07,
+ 0x90bf1d91, 0x1db71064, 0x6ab020f2, 0xf3b97148, 0x84be41de,
+ 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7, 0x136c9856,
+ 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9,
+ 0xfa0f3d63, 0x8d080df5, 0x3b6e20c8, 0x4c69105e, 0xd56041e4,
+ 0xa2677172, 0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b,
+ 0x35b5a8fa, 0x42b2986c, 0xdbbbc9d6, 0xacbcf940, 0x32d86ce3,
+ 0x45df5c75, 0xdcd60dcf, 0xabd13d59, 0x26d930ac, 0x51de003a,
+ 0xc8d75180, 0xbfd06116, 0x21b4f4b5, 0x56b3c423, 0xcfba9599,
+ 0xb8bda50f, 0x2802b89e, 0x5f058808, 0xc60cd9b2, 0xb10be924,
+ 0x2f6f7c87, 0x58684c11, 0xc1611dab, 0xb6662d3d, 0x76dc4190,
+ 0x01db7106, 0x98d220bc, 0xefd5102a, 0x71b18589, 0x06b6b51f,
+ 0x9fbfe4a5, 0xe8b8d433, 0x7807c9a2, 0x0f00f934, 0x9609a88e,
+ 0xe10e9818, 0x7f6a0dbb, 0x086d3d2d, 0x91646c97, 0xe6635c01,
+ 0x6b6b51f4, 0x1c6c6162, 0x856530d8, 0xf262004e, 0x6c0695ed,
+ 0x1b01a57b, 0x8208f4c1, 0xf50fc457, 0x65b0d9c6, 0x12b7e950,
+ 0x8bbeb8ea, 0xfcb9887c, 0x62dd1ddf, 0x15da2d49, 0x8cd37cf3,
+ 0xfbd44c65, 0x4db26158, 0x3ab551ce, 0xa3bc0074, 0xd4bb30e2,
+ 0x4adfa541, 0x3dd895d7, 0xa4d1c46d, 0xd3d6f4fb, 0x4369e96a,
+ 0x346ed9fc, 0xad678846, 0xda60b8d0, 0x44042d73, 0x33031de5,
+ 0xaa0a4c5f, 0xdd0d7cc9, 0x5005713c, 0x270241aa, 0xbe0b1010,
+ 0xc90c2086, 0x5768b525, 0x206f85b3, 0xb966d409, 0xce61e49f,
+ 0x5edef90e, 0x29d9c998, 0xb0d09822, 0xc7d7a8b4, 0x59b33d17,
+ 0x2eb40d81, 0xb7bd5c3b, 0xc0ba6cad, 0xedb88320, 0x9abfb3b6,
+ 0x03b6e20c, 0x74b1d29a, 0xead54739, 0x9dd277af, 0x04db2615,
+ 0x73dc1683, 0xe3630b12, 0x94643b84, 0x0d6d6a3e, 0x7a6a5aa8,
+ 0xe40ecf0b, 0x9309ff9d, 0x0a00ae27, 0x7d079eb1, 0xf00f9344,
+ 0x8708a3d2, 0x1e01f268, 0x6906c2fe, 0xf762575d, 0x806567cb,
+ 0x196c3671, 0x6e6b06e7, 0xfed41b76, 0x89d32be0, 0x10da7a5a,
+ 0x67dd4acc, 0xf9b9df6f, 0x8ebeeff9, 0x17b7be43, 0x60b08ed5,
+ 0xd6d6a3e8, 0xa1d1937e, 0x38d8c2c4, 0x4fdff252, 0xd1bb67f1,
+ 0xa6bc5767, 0x3fb506dd, 0x48b2364b, 0xd80d2bda, 0xaf0a1b4c,
+ 0x36034af6, 0x41047a60, 0xdf60efc3, 0xa867df55, 0x316e8eef,
+ 0x4669be79, 0xcb61b38c, 0xbc66831a, 0x256fd2a0, 0x5268e236,
+ 0xcc0c7795, 0xbb0b4703, 0x220216b9, 0x5505262f, 0xc5ba3bbe,
+ 0xb2bd0b28, 0x2bb45a92, 0x5cb36a04, 0xc2d7ffa7, 0xb5d0cf31,
+ 0x2cd99e8b, 0x5bdeae1d, 0x9b64c2b0, 0xec63f226, 0x756aa39c,
+ 0x026d930a, 0x9c0906a9, 0xeb0e363f, 0x72076785, 0x05005713,
+ 0x95bf4a82, 0xe2b87a14, 0x7bb12bae, 0x0cb61b38, 0x92d28e9b,
+ 0xe5d5be0d, 0x7cdcefb7, 0x0bdbdf21, 0x86d3d2d4, 0xf1d4e242,
+ 0x68ddb3f8, 0x1fda836e, 0x81be16cd, 0xf6b9265b, 0x6fb077e1,
+ 0x18b74777, 0x88085ae6, 0xff0f6a70, 0x66063bca, 0x11010b5c,
+ 0x8f659eff, 0xf862ae69, 0x616bffd3, 0x166ccf45, 0xa00ae278,
+ 0xd70dd2ee, 0x4e048354, 0x3903b3c2, 0xa7672661, 0xd06016f7,
+ 0x4969474d, 0x3e6e77db, 0xaed16a4a, 0xd9d65adc, 0x40df0b66,
+ 0x37d83bf0, 0xa9bcae53, 0xdebb9ec5, 0x47b2cf7f, 0x30b5ffe9,
+ 0xbdbdf21c, 0xcabac28a, 0x53b39330, 0x24b4a3a6, 0xbad03605,
+ 0xcdd70693, 0x54de5729, 0x23d967bf, 0xb3667a2e, 0xc4614ab8,
+ 0x5d681b02, 0x2a6f2b94, 0xb40bbe37, 0xc30c8ea1, 0x5a05df1b,
+ 0x2d02ef8d
+ };
+ const UChar *end;
+
+ crc = ~crc & 0xffffffff;
+ for (end = buf + len; buf < end; ++ buf)
+ crc = crc32_table[(crc ^ *buf) & 0xff] ^ (crc >> 8);
+ return ~crc & 0xffffffff;;
+}
+
+/*
+ * Try and open a separate debug file, ignoring any where the CRC does
+ * not match the value from the main object file.
+ */
+static
+Addr open_debug_file( Char* name, UInt crc, UInt* size )
+{
+ Int fd;
+ struct vki_stat stat_buf;
+ Addr addr;
+
+ if ((fd = VG_(open)(name, VKI_O_RDONLY, 0)) < 0)
+ return 0;
+
+ if (VG_(fstat)(fd, &stat_buf) != 0) {
+ VG_(close)(fd);
+ return 0;
+ }
+
+ *size = stat_buf.st_size;
+
+ if ((addr = (Addr)VG_(mmap)(NULL, *size, VKI_PROT_READ,
+ VKI_MAP_PRIVATE|VKI_MAP_NOSYMS, fd, 0)) == (Addr)-1) {
+ VG_(close)(fd);
+ return 0;
+ }
+
+ VG_(close)(fd);
+
+ if (calc_gnu_debuglink_crc32(0, (UChar*)addr, *size) != crc) {
+ VG_(munmap)((void*)addr, *size);
+ return 0;
+ }
+
+ return addr;
+}
+
+/*
+ * Try and find a seperated debug file for a given object file.
+ */
+static
+Addr find_debug_file( Char* objpath, Char* debugname, UInt crc, UInt* size )
+{
+ Char *objdir = VG_(strdup)(objpath);
+ Char *objdirptr;
+ Char *debugpath;
+ Addr addr = 0;
+
+ if ((objdirptr = VG_(strrchr)(objdir, '/')) != NULL)
+ *objdirptr = '\0';
+
+ debugpath = VG_(malloc)(VG_(strlen)(objdir) + VG_(strlen)(debugname) + 16);
+
+ VG_(sprintf)(debugpath, "%s/%s", objdir, debugname);
+
+ if ((addr = open_debug_file(debugpath, crc, size)) == 0) {
+ VG_(sprintf)(debugpath, "%s/.debug/%s", objdir, debugname);
+ if ((addr = open_debug_file(debugpath, crc, size)) == 0) {
+ VG_(sprintf)(debugpath, "/usr/lib/debug%s/%s", objdir, debugname);
+ addr = open_debug_file(debugpath, crc, size);
+ }
+ }
+
+ VG_(free)(debugpath);
+ VG_(free)(objdir);
+
+ return addr;
+}
/* Read the symbols from the object/exe specified by the SegInfo into
@@ -1019,4 +1157,6 @@ Bool vg_read_lib_symbols ( SegInfo* si )
Addr oimage;
UInt n_oimage;
+ Addr dimage = 0;
+ UInt n_dimage = 0;
struct vki_stat stat_buf;
@@ -1200,4 +1340,5 @@ Bool vg_read_lib_symbols ( SegInfo* si )
UChar* o_dynstr = NULL; /* .dynstr */
Elf32_Sym* o_dynsym = NULL; /* .dynsym */
+ Char* debuglink = NULL; /* .gnu_debuglink */
UChar* stab = NULL; /* .stab (stabs) */
UChar* stabstr = NULL; /* .stabstr (stabs) */
@@ -1211,4 +1352,5 @@ Bool vg_read_lib_symbols ( SegInfo* si )
UInt o_dynstr_sz = 0;
UInt o_dynsym_sz = 0;
+ UInt debuglink_sz = 0;
UInt stab_sz = 0;
UInt stabstr_sz = 0;
@@ -1245,4 +1387,6 @@ Bool vg_read_lib_symbols ( SegInfo* si )
else FIND(".strtab", o_strtab, o_strtab_sz, 0, UChar*)
+ else FIND(".gnu_debuglink", debuglink, debuglink_sz, 0, Char*)
+
else FIND(".stab", stab, stab_sz, 0, UChar*)
else FIND(".stabstr", stabstr, stabstr_sz, 0, UChar*)
@@ -1269,4 +1413,57 @@ Bool vg_read_lib_symbols ( SegInfo* si )
o_dynstr, o_dynstr_sz);
+ /* Did we find a debuglink section? */
+ if (debuglink != NULL) {
+ UInt crc_offset = (VG_(strlen)(debuglink) + 4) & ~3;
+ UInt crc;
+
+ vg_assert(crc_offset + sizeof(UInt) <= debuglink_sz);
+
+ /* Extract the CRC from the debuglink section */
+ crc = *(UInt *)(debuglink + crc_offset);
+
+ /* See if we can find a matching debug file */
+ if ((dimage = find_debug_file(si->filename, debuglink, crc, &n_dimage)) != 0) {
+ ehdr = (Elf32_Ehdr*)dimage;
+
+ if (n_dimage >= sizeof(Elf32_Ehdr) && VG_(is_object_file)(ehdr))
+ {
+ shdr = (Elf32_Shdr*)(dimage + ehdr->e_shoff);
+ sh_strtab = (UChar*)(dimage + shdr[ehdr->e_shstrndx].sh_offset);
+
+ /* Find all interesting sections */
+ for (i = 0; i < ehdr->e_shnum; i++) {
+# define FIND(sec_name, sec_data, sec_size, type) \
+ if (0 == VG_(strcmp)(sec_name, sh_strtab + shdr[i].sh_name)) { \
+ if (0 != sec_data) \
+ VG_(core_panic)("repeated section!\n"); \
+ sec_data = (type)(dimage + shdr[i].sh_offset); \
+ sec_size = shdr[i].sh_size; \
+ TRACE_SYMTAB( "%18s: %p .. %p\n", \
+ sec_name, sec_data, sec_data + sec_size - 1); \
+ if ( shdr[i].sh_offset + sec_size > n_dimage ) { \
+ VG_(symerr)(" section beyond image end?!"); \
+ goto out; \
+ } \
+ }
+
+ /* Nb: must find where .got and .plt sections will be in the
+ * executable image, not in the object image transiently loaded. */
+ FIND(".stab", stab, stab_sz, UChar*)
+ else FIND(".stabstr", stabstr, stabstr_sz, UChar*)
+ else FIND(".debug_line", debug_line, debug_line_sz, UChar*)
+ else FIND(".debug", dwarf1d, dwarf1d_sz, UChar*)
+ else FIND(".line", dwarf1l, dwarf1l_sz, UChar*)
+
+# undef FIND
+
+ /* Check some sizes */
+ vg_assert((o_dynsym_sz % sizeof(Elf32_Sym)) == 0);
+ vg_assert((o_symtab_sz % sizeof(Elf32_Sym)) == 0);
+ }
+ }
+ }
+ }
+
/* Read the stabs and/or dwarf2 debug information, if any. */
if (stab != NULL && stabstr != NULL) {
@@ -1292,5 +1489,6 @@ Bool vg_read_lib_symbols ( SegInfo* si )
out:
- /* Last, but not least, heave the oimage back overboard. */
+ /* Last, but not least, heave the image(s) back overboard. */
+ if (dimage) VG_(munmap) ( (void*)dimage, n_dimage );
VG_(munmap) ( (void*)oimage, n_oimage );
return res;
|
|
From: Tom H. <th...@cy...> - 2004-06-13 09:55:31
|
CVS commit by thughes:
Add a strrchr implementation.
M +10 -0 coregrind/vg_mylibc.c 1.72
M +1 -0 include/vg_skin.h.base 1.18
--- valgrind/include/vg_skin.h.base #1.17:1.18
@@ -432,4 +432,5 @@
extern Char* VG_(strstr) ( const Char* haystack, Char* needle );
extern Char* VG_(strchr) ( const Char* s, Char c );
+extern Char* VG_(strrchr) ( const Char* s, Char c );
extern Char* VG_(strdup) ( const Char* s);
extern void* VG_(memcpy) ( void *d, const void *s, Int sz );
--- valgrind/coregrind/vg_mylibc.c #1.71:1.72
@@ -1014,4 +1014,14 @@ Char* VG_(strchr) ( const Char* s, Char
+Char* VG_(strrchr) ( const Char* s, Char c )
+{
+ Int n = VG_(strlen)(s);
+ while (--n > 0) {
+ if (s[n] == c) return (Char*)s + n;
+ }
+ return NULL;
+}
+
+
void* VG_(memcpy) ( void *dest, const void *src, Int sz )
{
|
|
From: Tom H. <to...@co...> - 2004-06-13 02:23:21
|
Nightly build on dunsmere ( Fedora Core 2 ) started at 2004-06-13 03:20:02 BST Checking out source tree ... done Configuring ... done Building ... done Running regression tests ... done Last 20 lines of log.verbose follow rcrl: valgrind ./rcrl readline1: valgrind ./readline1 resolv: valgrind ./resolv seg_override: valgrind ./seg_override semlimit: valgrind ./semlimit sha1_test: valgrind ./sha1_test shortpush: valgrind ./shortpush shorts: valgrind ./shorts smc1: valgrind ./smc1 susphello: valgrind ./susphello syscall-restart1: valgrind ./syscall-restart1 syscall-restart2: valgrind ./syscall-restart2 system: valgrind ./system yield: valgrind ./yield -- Finished tests in none/tests ---------------------------------------- == 159 tests, 0 stderr failures, 1 stdout failure ================= none/tests/exec-sigmask (stdout) make: *** [regtest] Error 1 |