Re: [Valgrind-developers] Re: Re: [Valgrind-users] error: can't find a register in class `BREG' while reloading `asm'

[Jeremy F. <je...@go...>]

On Sun, 2004-06-27 at 12:32 +0100, Tom Hughes wrote:
> I've now heard from the person who wrote that and apparently what they
> were talking about is the fact that several routines in valgrind use
> nested functions themselves, which causes gcc to mark those object as
> needing an executable stack which in turn stops things like NX support
> from kicking in.
> 
> Does anybody have any particular objections to removing the use of
> nested functions in valgrind? I haven't looked at it in any detail
> yet and I know that at least some of them make use of stack variables
> from the parent function which makes removing them non-trivial but
> it could be done.

I'd object.  It makes the code a lot cleaner in a lot of places, and in
general I think nested functions are a good idea.  NX is basically
useless, particularly for Valgrind, so I don't think there's any reason
to inconvenience ourselves over it.

	J