|
From: Julian S. <js...@ac...> - 2004-06-27 12:14:12
|
On Sunday 27 June 2004 12:39, Nicholas Nethercote wrote: > On Sun, 27 Jun 2004, Tom Hughes wrote: > > Does anybody have any particular objections to removing the use of > > nested functions in valgrind? I haven't looked at it in any detail > > yet and I know that at least some of them make use of stack variables > > from the parent function which makes removing them non-trivial but > > it could be done. [...] > > Another advantage of removing the nested functions is that the practice is > one of the things that prevents Valgrind from being compiled with the > Intel C compiler. It's the only thing, I think, that prevents building with Icc. At some point in the past I did exactly this nested fn removal, and the result works with Icc. It's an hour's work or so, not a big deal. It'll make you a Hero(tm) with the Icc people, who have asked more than once to make valgrind icc-compilable. Probably a good thing to do. Another reason is Icc uses a completely different C/C++ front end from gcc/g++ and so produces a whole different set of warnings. Ideally V should compile cleanly with both compilers. J |