|
From: Robert W. <rj...@du...> - 2004-06-18 23:04:11
|
> What were the problems that prevented you from committing it before -- was > there something to do with leak detection? I was initially concerned that the memory pools themselves weren't leak-detected - only their contents. In retrospect, that's not really an issue and might be preferable to leave that way, actually. If it ever becomes an issue, it would be relatively easy to fix. > Also, it looks like Addrcheck and Memcheck handle pools, but Massif and > Helgrind don't. The amount of code that must be written for any tool to > do malloc interception is already unfortunately high (I've tried several > times to reduce it, but have never got anywhere) and it looks like > supporting mempools requires a decent amount of pretty boilerplate-ish > code to be added (viz that in mac_malloc_wrappers.c)... hmm. Hmm. I hadn't really paid much attention to anything other than Addrcheck and Memcheck, I have to admit. The mempool stuff should not effect them negatively if it's not handled in there, so that's something else that could be added in later, too, if needed. For the moment, I'd just like to get the current mempool implementation in place, so that: 1) other people can play with it and suggest improvements; 2) someone else might get to finish off the missing bits for the other skins... ;-) Regards, Robert. |