Re: [Valgrind-developers] valgrind

[Nicholas N. <nj...@ca...>]

On Thu, 3 Jun 2004, Jeremy Fitzhardinge wrote:

> CVS commit by fitzhardinge:
>
> Partial fix for bug 76869.  This fixes the problem with returning from
> a signal handler when VDSOs are turned off in FC2.  Note that we don't
> (yet) support VDSOs being on (use "echo 0 > /proc/sys/kernel/vdso").

Next time, can you run the regression tests before committing?

I just did, and went from no errors (pre-check in) to this:

  == 153 tests, 5 stderr failures, 1 stdout failure =================
  corecheck/tests/sigkill                  (stderr)
  none/tests/coolo_sigaction               (stdout)
  none/tests/coolo_sigaction               (stderr)
  none/tests/syscall-restart1              (stderr)
  none/tests/syscall-restart2              (stderr)
  none/tests/system                        (stderr)

All of them died with this error:

valgrind: vg_signals.c:444 (vgPlain_handle_SCSS_change): Assertion
`ksa_old.ksa_restorer == ((void *)0)' failed.
   at 0xB802A535: vgPlain_skin_assert_fail (vg_mylibc.c:1211)
   by 0xB802A534: assert_fail (vg_mylibc.c:1207)
   by 0xB802A572: vgPlain_core_assert_fail (vg_mylibc.c:1218)
   by 0xB802E0C3: vgPlain_handle_SCSS_change (vg_signals.c:447)

sched status:

Thread 1: status = Runnable, associated_mx = 0x0, associated_cv = 0x0
   at 0xABFFF042: ???
   by 0x4202780D: sigaction (in /lib/tls/libc-2.3.2.so)
   by 0x4203FA94: do_system (in /lib/tls/libc-2.3.2.so)
   by 0x8048344: main (system.c:8)

N