[Valgrind-developers] valgrind/coregrind

[Nicholas N. <nj...@ca...>]

CVS commit by nethercote: 

Fix bug in helper_{IN,OUT} -- they weren't preserving %eflags as they should.


  M +6 -0      vg_helpers.S   1.32


--- valgrind/coregrind/vg_helpers.S  #1.31:1.32
@@ -133,4 +133,6 @@
         movl    16(%esp), %eax
         movl    12(%esp), %edx
+
+        pushfl
         cmpl    $4, %eax
         je      in_dword
@@ -146,4 +148,5 @@
         inl     (%dx),%eax
 in_done:
+        popfl
         movl    %eax,12(%esp)
         popl    %edx
@@ -165,4 +168,6 @@
         movl    16(%esp), %edx
         movl    12(%esp), %eax
+
+        pushfl
         cmpl    $4, 20(%esp)
         je      out_dword
@@ -178,4 +183,5 @@
         outl    %eax,(%dx)
 out_done:
+        popfl
         popl    %edx
         popl    %eax