Re: [Valgrind-developers] valgrind/coregrind

[Nicholas N. <nj...@ca...>]

On Thu, 22 Apr 2004, Tom Hughes wrote:

> Cope with AT_xCACHEBSIZE not being defined, which they aren't on systems
> with 2.2 kernels and, it seems, on some systems with 2.4 kernels.
>
> --- valgrind/coregrind/vg_main.c  #1.150:1.151
> @@ -51,4 +51,16 @@
>  #include <unistd.h>
>
> +#ifndef AT_DCACHEBSIZE
> +#define AT_DCACHEBSIZE          19
> +#endif /* AT_DCACHEBSIZE */
> +
> +#ifndef AT_ICACHEBSIZE
> +#define AT_ICACHEBSIZE          20
> +#endif /* AT_ICACHEBSIZE */
> +
> +#ifndef AT_UCACHEBSIZE
> +#define AT_UCACHEBSIZE          21
> +#endif /* AT_UCACHEBSIZE */
> +
>  #ifndef AT_SYSINFO
>  #define AT_SYSINFO              32

Would it be better to conditionally include the cases that use these?  Ie.
mention them if they are defined, rather than defining them if they are
not?

Sorry for the pickiness.

N