|
From: Nicholas N. <nj...@ca...> - 2004-04-13 10:25:51
|
On Sun, 11 Apr 2004, Robert Walsh wrote: > I think I finally have a working patch for bug 73655. I've tested it on > RedHat 9 and everything appears to be working just fine. I'd really like > it if someone could test on something else (Fedora, say) just so I'm not > borking any of the other builds. If someone could volunteer for this, I'd > really appreciate it. I tried it; that test case works on my, er, RH 9 box too. What about the memcheck/tests/new_override.cpp test? The expected output in the .exp file is that Valgrind's 'new' takes precedence, which is actually wrong here. With your patch, I'm still getting V's new taking precedence. Also, you're now generating vg_intercept.c and vg_replace_malloc.c, from files with .vgi extensions... we already have similar files with .base extensions (vg_skin.h.base)... should be consistent here. Finally, how does your patch actually work? What did you change? thanks N |