|
From: Nicholas N. <nj...@ca...> - 2004-02-05 09:51:30
|
On Thu, 5 Feb 2004, Felix von Leitner wrote: > I just found valgrind 2.1 and saw that my 2.0 epoll diff no longer > applies cleanly, so I mad a new one: > > http://www.fefe.de/diffs/valgrind-2.1-epoll.diff.bz2 I took your old version and made a few changes, it's currently bouncing its way around the valgrind-developers list, and will hopefully be committed soon. I attach it for your perusal. There are a few differences to your patch, namely: - I have a POST(epoll_create), because it creates an fd which needs to be tracked for --track-fds=yes - I introduced "struct vki_epoll_event" into vg_kerneliface.h so that the size arg in epoll_ctl's SYSCALL_TRACK isn't done in terms of 32-bit words, which makes it more in line with the other syscall wrappers, and also to avoid #including <sys/epoll.h> which is a 2.6-only header file. - In POST(epoll_wait), I check if the result is > 0 before doing the SYSCALL_TRACK, and the size argument relies on the result, rather than arg3. Let me know if you think any of these changes are wrong. N |