[Valgrind-developers] valgrind/coregrind

[Jeremy F. <je...@go...>]

CVS commit by fitzhardinge: 

Be a bit clearer about core-dumping messages (don't say we are if we're not)


  M +13 -7     vg_signals.c   1.62


--- valgrind/coregrind/vg_signals.c  #1.61:1.62
@@ -1717,4 +1717,16 @@ static void vg_default_action(const vki_
 
    if (terminate) {
+      if (core) {
+         /* If they set the core-size limit to zero, don't generate a
+            core file */
+         static struct vki_rlimit zero = { 0, 0 };
+         struct vki_rlimit corelim;
+         
+         VG_(getrlimit)(VKI_RLIMIT_CORE, &corelim);
+
+         if (corelim.rlim_cur == 0)
+            core = False;
+      }
+
       if (VG_(clo_verbosity) != 0 && (core || VG_(clo_verbosity) > 1)) {
          VG_(message)(Vg_UserMsg, "");
@@ -1785,10 +1797,4 @@ static void vg_default_action(const vki_
 
       if (core) {
-         static struct vki_rlimit zero = { 0, 0 };
-         struct vki_rlimit corelim;
-
-         VG_(getrlimit)(VKI_RLIMIT_CORE, &corelim);
-
-         if (corelim.rlim_cur > 0)
             make_coredump(tid, info, corelim.rlim_cur);